News for hackers. Stuff that matters.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by bastawhiz on Thursday June 01, 2023 @11:13AM (#36152253)
Maybe this has been obvious or well known, but this was a revelation to me:

> It took six hours for my order to complete, and the accounts look legit; each has a profile picture, different companies that they work for, a couple of repositories, and a contribution to one or more open-source projects, next to being a GitHub member for over a year.

This is the motivation for garbage AI-generated PRs or insubstantial docs changes that "people" make. It doesn't matter if they're good. They only exist to add surface level legitimacy to fake accounts so that services like this one can exist.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by CapmCrackaWaka on Thursday June 01, 2023 @11:21AM (#36152399)
Exactly. I’ve denied so many PR’s which only fixed a typo in comments or some other trivial thing. I know what they’re doing.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jackdh on Thursday June 01, 2023 @11:30AM (#36152562)
You deny PR's just for typo's? I've done a few of those in the past all in good faith, perhaps I'm the bot?
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by CapmCrackaWaka on Thursday June 01, 2023 @11:32AM (#36152593)
No I have denied PRs that _only_ fixed a typo. Edited to be more clear.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by superchink on Thursday June 01, 2023 @11:41AM (#36152734)
I had the same thought. Is fixing typos not contributing? Should I not be submitting PRs to help with documentation/polish/etc? I never even thought that trying to help would be viewed as malicious.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by hu3 on Thursday June 01, 2023 @11:39AM (#36152712)
I probably submitted more than 10 PRs that only fixed a single word in projects I like.

I do that when I see typos in documentation.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by myko on Thursday June 01, 2023 @01:48PM (#36154742)
Same, and I appreciate similar contributions to my own projects
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jawiggins on Thursday June 01, 2023 @11:39AM (#36152710)
So you’ve just left the typo in the project? I’ve opened PRs just to fix one or two misplaced characters before. Just trying to do my part to help
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jorvi on Thursday June 01, 2023 @11:55AM (#36152959)
Could just fix the typo yourself and reference the PR in your commit then close the PR without pulling.

I imagine contributors won’t exactly be happy with that though.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by hammyhavoc on Friday June 02, 2023 @01:39PM (#36168300)
Honestly, who cares if the end result is the same? Their forked repo with the patch on still exists, the patch was incorporated in whatever way made sense to the original repo owner.

OK, a credit, but really, who cares? People can see what an accepted pull request consisted of, so I'm not sure they're kidding anybody in terms of boosting their reputation with credits for fixing typos.

All the same, I'm just glad to see people improve their presentation, especially typos.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by badrequest on Thursday June 01, 2023 @11:45AM (#36152782)
I issued a PR to correct a typo in a popular ML library just two weeks ago, I am not a bot, this strategy seems flawed.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jacquesm on Thursday June 01, 2023 @11:48AM (#36152831)
Any mechanism to combat abuse will have false positives as well.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by irrational on Thursday June 01, 2023 @11:57AM (#36153002)
What proof do you have that you are not a bot?
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by dhosek on Thursday June 01, 2023 @12:21PM (#36153421)
He passed the Voight-Kampff test.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by Tepix on Thursday June 01, 2023 @12:13PM (#36153289)
Well, i submitted such a PR today. It hasn't been rejected (just yet).
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by pcthrowaway on Thursday June 01, 2023 @12:37PM (#36153668)
I think the people responding are missing the point.

I've also submitted PRs that just fixed typos, and I've considered that a legit contribution.

But if I maintained a high-profile project right now, I'd at least take pause in thinking some of these accounts could be spam reputation-boosting accounts that only make comments/PRs to lend legitimacy to the account when it ultimately stars some artificially boosted repo.

And making it harder to detect star manipulation erodes the signals of trust which have been used on Github, and ultimately can be a security concern (historically I've looked at numbers of contributors, stars, downloads, and issues open/closed as a rough idea of how secure some npm dependency might be.. basically the idea that "more eyeballs" can mean slightly less chance of a massive security issue, especially in security-critical code like oauth libraries)

I don't know what the solution is here. Maybe requiring people sign a CLA like some corporate open source projects do is at least enough of a barrier

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by stronglikedan on Thursday June 01, 2023 @02:08PM (#36155025)
Denying that PR and fixing it yourself is taking credit for others' work, and leaving it in is no good either. I don't see any upside to rejecting them. I'd be ashamed of myself for that.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by hammyhavoc on Friday June 02, 2023 @01:36PM (#36168247)
Project maintainers frequently hold themselves back with amateur presentation, and that includes typos. It's hard to take some things seriously if they are failing at English, let alone their programming language of choice. It's sad because there's plenty of amazing open source out there, but the presentation is terribad.

IMO, the solution is simple: allow project maintainers to disable pointless metrics that would incentivize the GitHub equivocal to karma farming.

I also think the quality of comment on HN suffers for the fact that the karma score is visible metric to the end-user. Reddit particularly. The view count on tweets too.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by admtal on Thursday June 01, 2023 @11:47AM (#36152806)
Someone submitted a PR to me yesterday on my open source repo fixing a typo — did not occur to me it was part of this strange con
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by somsak2 on Thursday June 01, 2023 @12:24PM (#36153462)
how is it a con if it's a useful contribution? it's not my job to filter bot accounts used for starring repos. if a PR improves my project I'll accept it.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by lazide on Thursday June 01, 2023 @03:32PM (#36156199)
If it’s useful (actually), it’s not a con on you of course! It does pollute the overall ecosystem though, since it is used to prop up fake stars and the like.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by freedomben on Thursday June 01, 2023 @01:29PM (#36154481)
It probably was legitimate. There are tons of people (myself included) that send PRs to fix typos and such. I also accept PRs like that to my own projects.

A lot more people will read the docs than the code, and typos are annoying and for some people highly distracting (OCD)

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by maksimur on Thursday June 01, 2023 @02:21PM (#36155180)
It's reassuring to know that I'm not the only one with this issue. Typos can be extremely disruptive, often compelling me to re-read the entire sentence.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by foobiekr on Thursday June 01, 2023 @02:41PM (#36155480)
It probably was not legitimate. There are wonderful people like you but they are dwarfed by the thousands of scam accounts using this method to try and engineer legitimacy.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by number6 on Thursday June 01, 2023 @05:43PM (#36157777)
I did it too and now I hope people don't think I tried to scam them by being nice...
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by kaliqt on Thursday June 01, 2023 @05:51PM (#36157867)
I doubt it. I too submit small fixes.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by Breza on Friday June 02, 2023 @09:14AM (#36164606)
Same here. Typos bother me. Rather than complaining, I just submit a PR to fix particularly egregious ones.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jcparkyn on Thursday June 01, 2023 @08:36PM (#36159354)
[Citation needed]
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by tompt on Thursday June 01, 2023 @11:49AM (#36152853)
Do you then fix the typo with no attribution to the original reporter? Or do you just choose not to fix a known error because you question the motives of the reporter?
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by arp242 on Thursday June 01, 2023 @08:46PM (#36159412)
Usually this is stuff like fixing "// TODO: this fails reguarly in the CI" (real example from the last such PR). It's the kind of thing I'll fix if I see it, but not really worth going out of my way fixing something like that: it's just a comment in some test code (not user-facing) and the few people that will ever see that comment understand "reguarly" as well. It's a non-issue and basically just spam IMHO.

These are always either bots or people looking to bolster their CV by bragging they "contributed" n PRs to n repos. I signed up to collaboratively make some (hopefully nice) software, not to deal with a stream of PRs like this.

Typos in README or publicly facing docs are different; I usually merge those (and those are almost always good faith too, because usually a real human picks up on them before the bots/script kiddies do).

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by ilrwbwrkhv on Thursday June 01, 2023 @12:03PM (#36153106)
Lol so you didn't accept PRs to "own the bots"? Your horse might be a bit too high you know.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by xtreme on Thursday June 01, 2023 @12:07PM (#36153170)
Relevant xkcd: https://xkcd.com/810/
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by Tepix on Thursday June 01, 2023 @12:15PM (#36153304)
Thus, we win once the bots submit useful PRs.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by throwaway675309 on Thursday June 01, 2023 @06:35PM (#36158367)
Same. There ought to be a way to submit inconsequential things like typos through a separate system that don't get counted as pull requests. That way the people who are genuinely claiming good faith shouldn't really care if it doesn't count as part of your "PR score".
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by Solvency on Thursday June 01, 2023 @11:52AM (#36152909)
What sort of "AI" model drives bots like this? Is it really AI? Or is it more like automated scrapers that run some basic deterministic functions (like spellchecks)?

Or are people actually deploying LLMs to inspect code and produce usable optimizations?

Because that would be an interesting beneficial side effect to an otherwise "nefarious" marketing hustle.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by bastawhiz on Thursday June 01, 2023 @12:13PM (#36153285)
I expect it's a combination of scripting, some manual effort, and AI.

For what it's worth, I've seen lots of examples of this, and "usable optimizations" is entirely false. The PRs are often not working code. It's scattershot. The point isn't to make a PR that benefits the project in any way, it's to fill in the green square on the profile so it looks like there's a human doing things.

Anyone giving this stuff more than a cursory glance would see that it's all bullshit. But the point isn't to stand up to scrutiny. It's to defeat abuse protection measures with legitimate-looking activity. And in the case of stars, to make it look to anyone who's just glancing at the star-ers that there are real people starring the repos.

It's deviously clever and absolutely terrible.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by paddw on Thursday June 01, 2023 @11:54AM (#36152944)
Depending on where the scam is run, I wouldn't consider it out of the question that it would be economical to do manually.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by ilc on Thursday June 01, 2023 @11:55AM (#36152946)
Yes, botspam is bad. But if a change is good. A change is good, merge it and get on with your life.

If someone wants to write "check_spelling_bot" and get a ton of github karma, I have 0 issue with it. In fact, I encourage GitHub to do it :).

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by bastawhiz on Thursday June 01, 2023 @12:16PM (#36153340)
I've never seen "good" changes from these bots. The code they propose often isn't even working, it's just a change that looks like it might do something. Some of the spellcheck changes might be beneficial, but there's an ethical question about whether accepting those PRs (versus making the change in a new commit directly) is a net-negative to the community overall.

If you got spam, but the spam was useful to you personally, not marking it as spam prevents your email provider from flagging the account as spam to the wider world.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by vikramkr on Thursday June 01, 2023 @12:50PM (#36153889)
But if it's useful I'd argue it's deifinitionally not spam for you. And if most people don't mark it as spam so it doesn't get flagged, that means it just isn't spam. Bots send emails too, and not all bot sent emails are spam.

Relevant xkcd: https://xkcd.com/810/

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by shkkmo on Thursday June 01, 2023 @02:55PM (#36155689)
> But if it's useful I'd argue it's deifinitionally not spam for you.

That is absolutely false. Spam is not defined based on it's utility, but based on whether a message is solicited.

If the author of a repo hasn't signed their repo up for an automated PR bot, that bot sending out PRs is absolutely spam.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by vikramkr on Thursday June 01, 2023 @03:41PM (#36156321)
Most definitions for it include whether the message is irrelevant or unwanted. Trying to define it purely as unsolicited gets into weird cases where you'd say that an emergency tornado alert is spam because it's unsolicited. Maybe there's a definition if spam where that's the case but if the residents of an area find that alert useful it seems unlikely that they would describe it as spam, even though they didn't solicit the warning
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by shkkmo on Thursday June 01, 2023 @05:32PM (#36157650)
I don't see any definition that address "irrelevancy" but many do mention "unwanted", which is effectively the same thing as saying "unsolicited".

Edit: Emergency alerts are solicited by owning a phone in a country that mandates that cell carriers send those messages.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by vikramkr on Thursday June 01, 2023 @06:31PM (#36158324)
For me googling spam definition brings up google definition in which irrelevant is the first word.

Before getting sidetracked on definitions of other words, I would be deeply surprised if asking a bunch of people on the street "If you received a message you didn't ask for and didn't expect, but it turns out you are very glad you received it and it provided you value, is that spam?" resulted in a broad consensus around "yes"

Unwanted and unsolicited are definitely not the same thing, whether or not you solcit something has nothing to do with if you want it, I'm not sure how those are synonymous. And if being mandated to recieve a message by someone else counts as you soliciting the message, where solicit in its most common definition means to ask for, then I guess that means that everything is solicited?

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by shkkmo on Tuesday June 06, 2023 @10:03AM (#36212935)
Since you failed to post the "google definition", here's the one I get at the top when googling "spam definition"

> Unsolicited e-mail, often of a commercial nature, sent indiscriminately to multiple mailing lists, individuals, or newsgroups; junk e-mail.

Note, "unsolicited" is the first word and "irrelevant" does not appear anywhere and there is no discussion of the utility of the message to the recipient.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by guitarbill on Friday June 02, 2023 @09:45AM (#36164970)
> Edit: Emergency alerts are solicited by owning a phone in a country that mandates that cell carriers send those messages.

That's so pedantic, I'm inclined to disagree - if it's even correct. Not everything that's unsolicited is spam. An unsolicited thank you note isn't spam.

More components of spam are traditionally a large, indiscriminate number of receivers, and low quality messaging. Irrelevancy does partially capture both of these.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by shkkmo on Tuesday June 06, 2023 @10:08AM (#36213021)
You may view it as "pedantic" but it is how language works.

There is a complex set of social expectations around when a thank you note is unsolicited. I could start trying to describe them, but then you'd probably call me pedantic again.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by bombcar on Thursday June 01, 2023 @12:36PM (#36153652)
PR spam is annoying, you end up with “oxford-comma-bots” fighting “no-oxford-commas” forever to get credibility.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by somsak2 on Thursday June 01, 2023 @12:22PM (#36153428)
this is valuing a humans time of filtering through good and not good changes at 0. Imagine if you had to receive all email and judge each individual one for spam / not spam.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jimmyl02 on Thursday June 01, 2023 @12:11PM (#36153242)
I've noticed this on producthunt too; there are lots of accounts which just summarize the post and you can tell they don't really know what the product is / have tried it. But other than that they seem completely legitimate.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by sshine on Thursday June 01, 2023 @02:27PM (#36155261)
And there are bots on Reddit and on Hacker News that will provide automatic links to paywall-skippers and such.

Not all bots have bad intent. Some compensate for a lack of a protocol/platform-native feature. Which makes all bots occasionally annoying, because human time is spent.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by hammyhavoc on Friday June 02, 2023 @01:33PM (#36168197)
Intent is a matter of perspective.

I'm sure that from the perspective of a publication that paywalls, those bots are not a good thing.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by erhaetherth on Friday June 02, 2023 @03:34AM (#36162213)
I occasionally ponder if I should send many small changes at the company I work for. Not because I'm not a real boy but because every so often my manager will be impressed by my commit count. Not that I'm trying to inflate it (I just try really hard to avoid meetings so I can write code which I actually enjoy), but...sure seems like it encourages the wrong behavior.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by KMnO4 on Friday June 02, 2023 @10:43AM (#36165767)
Oh wow, thanks for pointing it out. It’s now clicking for me.

A few months back, I noticed that there were some accounts posting issues on open source repositories, but their issues were a direct copy/paste of mine. I couldn’t figure out why they would copy/paste my issue so I dismissed it.

Now it makes sense!