Re:So, I went down the rabbit hole of buying GitHub Stars, s...
by jawiggins on Thursday June 01, 2023 @11:39AM
(#36152710)
So you’ve just left the typo in the project? I’ve opened PRs just to fix one or two misplaced characters before. Just trying to do my part to help
[ Parent
| on HN ]
Re:So, I went down the rabbit hole of buying GitHub Stars, s...
by jorvi on Thursday June 01, 2023 @11:55AM
(#36152959)
Could just fix the typo yourself and reference the PR in your commit then close the PR without pulling.
I imagine contributors won’t exactly be happy with that though.
Re:So, I went down the rabbit hole of buying GitHub Stars, s...
by hammyhavoc on Friday June 02, 2023 @01:39PM
(#36168300)
Honestly, who cares if the end result is the same? Their forked repo with the patch on still exists, the patch was incorporated in whatever way made sense to the original repo owner.
OK, a credit, but really, who cares? People can see what an accepted pull request consisted of, so I'm not sure they're kidding anybody in terms of boosting their reputation with credits for fixing typos.
All the same, I'm just glad to see people improve their presentation, especially typos.