News for hackers. Stuff that matters.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by CapmCrackaWaka on Thursday June 01, 2023 @11:21AM (#36152399)
Exactly. I’ve denied so many PR’s which only fixed a typo in comments or some other trivial thing. I know what they’re doing.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jackdh on Thursday June 01, 2023 @11:30AM (#36152562)
You deny PR's just for typo's? I've done a few of those in the past all in good faith, perhaps I'm the bot?
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by CapmCrackaWaka on Thursday June 01, 2023 @11:32AM (#36152593)
No I have denied PRs that _only_ fixed a typo. Edited to be more clear.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by superchink on Thursday June 01, 2023 @11:41AM (#36152734)
I had the same thought. Is fixing typos not contributing? Should I not be submitting PRs to help with documentation/polish/etc? I never even thought that trying to help would be viewed as malicious.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by hu3 on Thursday June 01, 2023 @11:39AM (#36152712)
I probably submitted more than 10 PRs that only fixed a single word in projects I like.

I do that when I see typos in documentation.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by myko on Thursday June 01, 2023 @01:48PM (#36154742)
Same, and I appreciate similar contributions to my own projects
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jawiggins on Thursday June 01, 2023 @11:39AM (#36152710)
So you’ve just left the typo in the project? I’ve opened PRs just to fix one or two misplaced characters before. Just trying to do my part to help
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jorvi on Thursday June 01, 2023 @11:55AM (#36152959)
Could just fix the typo yourself and reference the PR in your commit then close the PR without pulling.

I imagine contributors won’t exactly be happy with that though.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by hammyhavoc on Friday June 02, 2023 @01:39PM (#36168300)
Honestly, who cares if the end result is the same? Their forked repo with the patch on still exists, the patch was incorporated in whatever way made sense to the original repo owner.

OK, a credit, but really, who cares? People can see what an accepted pull request consisted of, so I'm not sure they're kidding anybody in terms of boosting their reputation with credits for fixing typos.

All the same, I'm just glad to see people improve their presentation, especially typos.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by badrequest on Thursday June 01, 2023 @11:45AM (#36152782)
I issued a PR to correct a typo in a popular ML library just two weeks ago, I am not a bot, this strategy seems flawed.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jacquesm on Thursday June 01, 2023 @11:48AM (#36152831)
Any mechanism to combat abuse will have false positives as well.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by irrational on Thursday June 01, 2023 @11:57AM (#36153002)
What proof do you have that you are not a bot?
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by dhosek on Thursday June 01, 2023 @12:21PM (#36153421)
He passed the Voight-Kampff test.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by Tepix on Thursday June 01, 2023 @12:13PM (#36153289)
Well, i submitted such a PR today. It hasn't been rejected (just yet).
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by pcthrowaway on Thursday June 01, 2023 @12:37PM (#36153668)
I think the people responding are missing the point.

I've also submitted PRs that just fixed typos, and I've considered that a legit contribution.

But if I maintained a high-profile project right now, I'd at least take pause in thinking some of these accounts could be spam reputation-boosting accounts that only make comments/PRs to lend legitimacy to the account when it ultimately stars some artificially boosted repo.

And making it harder to detect star manipulation erodes the signals of trust which have been used on Github, and ultimately can be a security concern (historically I've looked at numbers of contributors, stars, downloads, and issues open/closed as a rough idea of how secure some npm dependency might be.. basically the idea that "more eyeballs" can mean slightly less chance of a massive security issue, especially in security-critical code like oauth libraries)

I don't know what the solution is here. Maybe requiring people sign a CLA like some corporate open source projects do is at least enough of a barrier

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by stronglikedan on Thursday June 01, 2023 @02:08PM (#36155025)
Denying that PR and fixing it yourself is taking credit for others' work, and leaving it in is no good either. I don't see any upside to rejecting them. I'd be ashamed of myself for that.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by hammyhavoc on Friday June 02, 2023 @01:36PM (#36168247)
Project maintainers frequently hold themselves back with amateur presentation, and that includes typos. It's hard to take some things seriously if they are failing at English, let alone their programming language of choice. It's sad because there's plenty of amazing open source out there, but the presentation is terribad.

IMO, the solution is simple: allow project maintainers to disable pointless metrics that would incentivize the GitHub equivocal to karma farming.

I also think the quality of comment on HN suffers for the fact that the karma score is visible metric to the end-user. Reddit particularly. The view count on tweets too.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by admtal on Thursday June 01, 2023 @11:47AM (#36152806)
Someone submitted a PR to me yesterday on my open source repo fixing a typo — did not occur to me it was part of this strange con
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by somsak2 on Thursday June 01, 2023 @12:24PM (#36153462)
how is it a con if it's a useful contribution? it's not my job to filter bot accounts used for starring repos. if a PR improves my project I'll accept it.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by lazide on Thursday June 01, 2023 @03:32PM (#36156199)
If it’s useful (actually), it’s not a con on you of course! It does pollute the overall ecosystem though, since it is used to prop up fake stars and the like.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by freedomben on Thursday June 01, 2023 @01:29PM (#36154481)
It probably was legitimate. There are tons of people (myself included) that send PRs to fix typos and such. I also accept PRs like that to my own projects.

A lot more people will read the docs than the code, and typos are annoying and for some people highly distracting (OCD)

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by maksimur on Thursday June 01, 2023 @02:21PM (#36155180)
It's reassuring to know that I'm not the only one with this issue. Typos can be extremely disruptive, often compelling me to re-read the entire sentence.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by foobiekr on Thursday June 01, 2023 @02:41PM (#36155480)
It probably was not legitimate. There are wonderful people like you but they are dwarfed by the thousands of scam accounts using this method to try and engineer legitimacy.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by number6 on Thursday June 01, 2023 @05:43PM (#36157777)
I did it too and now I hope people don't think I tried to scam them by being nice...
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by kaliqt on Thursday June 01, 2023 @05:51PM (#36157867)
I doubt it. I too submit small fixes.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by Breza on Friday June 02, 2023 @09:14AM (#36164606)
Same here. Typos bother me. Rather than complaining, I just submit a PR to fix particularly egregious ones.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jcparkyn on Thursday June 01, 2023 @08:36PM (#36159354)
[Citation needed]
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by tompt on Thursday June 01, 2023 @11:49AM (#36152853)
Do you then fix the typo with no attribution to the original reporter? Or do you just choose not to fix a known error because you question the motives of the reporter?
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by arp242 on Thursday June 01, 2023 @08:46PM (#36159412)
Usually this is stuff like fixing "// TODO: this fails reguarly in the CI" (real example from the last such PR). It's the kind of thing I'll fix if I see it, but not really worth going out of my way fixing something like that: it's just a comment in some test code (not user-facing) and the few people that will ever see that comment understand "reguarly" as well. It's a non-issue and basically just spam IMHO.

These are always either bots or people looking to bolster their CV by bragging they "contributed" n PRs to n repos. I signed up to collaboratively make some (hopefully nice) software, not to deal with a stream of PRs like this.

Typos in README or publicly facing docs are different; I usually merge those (and those are almost always good faith too, because usually a real human picks up on them before the bots/script kiddies do).

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by ilrwbwrkhv on Thursday June 01, 2023 @12:03PM (#36153106)
Lol so you didn't accept PRs to "own the bots"? Your horse might be a bit too high you know.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by xtreme on Thursday June 01, 2023 @12:07PM (#36153170)
Relevant xkcd: https://xkcd.com/810/
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by Tepix on Thursday June 01, 2023 @12:15PM (#36153304)
Thus, we win once the bots submit useful PRs.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by throwaway675309 on Thursday June 01, 2023 @06:35PM (#36158367)
Same. There ought to be a way to submit inconsequential things like typos through a separate system that don't get counted as pull requests. That way the people who are genuinely claiming good faith shouldn't really care if it doesn't count as part of your "PR score".