News for hackers. Stuff that matters.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jackdh on Thursday June 01, 2023 @11:30AM (#36152562)
You deny PR's just for typo's? I've done a few of those in the past all in good faith, perhaps I'm the bot?
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by CapmCrackaWaka on Thursday June 01, 2023 @11:32AM (#36152593)
No I have denied PRs that _only_ fixed a typo. Edited to be more clear.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by superchink on Thursday June 01, 2023 @11:41AM (#36152734)
I had the same thought. Is fixing typos not contributing? Should I not be submitting PRs to help with documentation/polish/etc? I never even thought that trying to help would be viewed as malicious.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by hu3 on Thursday June 01, 2023 @11:39AM (#36152712)
I probably submitted more than 10 PRs that only fixed a single word in projects I like.

I do that when I see typos in documentation.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by myko on Thursday June 01, 2023 @01:48PM (#36154742)
Same, and I appreciate similar contributions to my own projects
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jawiggins on Thursday June 01, 2023 @11:39AM (#36152710)
So you’ve just left the typo in the project? I’ve opened PRs just to fix one or two misplaced characters before. Just trying to do my part to help
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jorvi on Thursday June 01, 2023 @11:55AM (#36152959)
Could just fix the typo yourself and reference the PR in your commit then close the PR without pulling.

I imagine contributors won’t exactly be happy with that though.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by hammyhavoc on Friday June 02, 2023 @01:39PM (#36168300)
Honestly, who cares if the end result is the same? Their forked repo with the patch on still exists, the patch was incorporated in whatever way made sense to the original repo owner.

OK, a credit, but really, who cares? People can see what an accepted pull request consisted of, so I'm not sure they're kidding anybody in terms of boosting their reputation with credits for fixing typos.

All the same, I'm just glad to see people improve their presentation, especially typos.

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by badrequest on Thursday June 01, 2023 @11:45AM (#36152782)
I issued a PR to correct a typo in a popular ML library just two weeks ago, I am not a bot, this strategy seems flawed.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by jacquesm on Thursday June 01, 2023 @11:48AM (#36152831)
Any mechanism to combat abuse will have false positives as well.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by irrational on Thursday June 01, 2023 @11:57AM (#36153002)
What proof do you have that you are not a bot?
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by dhosek on Thursday June 01, 2023 @12:21PM (#36153421)
He passed the Voight-Kampff test.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by Tepix on Thursday June 01, 2023 @12:13PM (#36153289)
Well, i submitted such a PR today. It hasn't been rejected (just yet).
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by pcthrowaway on Thursday June 01, 2023 @12:37PM (#36153668)
I think the people responding are missing the point.

I've also submitted PRs that just fixed typos, and I've considered that a legit contribution.

But if I maintained a high-profile project right now, I'd at least take pause in thinking some of these accounts could be spam reputation-boosting accounts that only make comments/PRs to lend legitimacy to the account when it ultimately stars some artificially boosted repo.

And making it harder to detect star manipulation erodes the signals of trust which have been used on Github, and ultimately can be a security concern (historically I've looked at numbers of contributors, stars, downloads, and issues open/closed as a rough idea of how secure some npm dependency might be.. basically the idea that "more eyeballs" can mean slightly less chance of a massive security issue, especially in security-critical code like oauth libraries)

I don't know what the solution is here. Maybe requiring people sign a CLA like some corporate open source projects do is at least enough of a barrier

Re:So, I went down the rabbit hole of buying GitHub Stars, s... by stronglikedan on Thursday June 01, 2023 @02:08PM (#36155025)
Denying that PR and fixing it yourself is taking credit for others' work, and leaving it in is no good either. I don't see any upside to rejecting them. I'd be ashamed of myself for that.
Re:So, I went down the rabbit hole of buying GitHub Stars, s... by hammyhavoc on Friday June 02, 2023 @01:36PM (#36168247)
Project maintainers frequently hold themselves back with amateur presentation, and that includes typos. It's hard to take some things seriously if they are failing at English, let alone their programming language of choice. It's sad because there's plenty of amazing open source out there, but the presentation is terribad.

IMO, the solution is simple: allow project maintainers to disable pointless metrics that would incentivize the GitHub equivocal to karma farming.

I also think the quality of comment on HN suffers for the fact that the karma score is visible metric to the end-user. Reddit particularly. The view count on tweets too.