News for hackers. Stuff that matters.
Re:Show HN: A pure C89 implementation of Go channels, with b... by eqvinox on Wednesday December 13, 2023 @03:04PM (#38633438)
It's 2023 - even MSVC has supported C11 and C17 for a while now. C89 is no longer a feature to advertise, it's an unhelpful constraint forcing poorer quality code. A good example is that CspChan_closed should use the bool type added in C99.

There's nonstandard nomenclature in "_dispose"; if the constructing function is called _create, the common pattern is to pair it with _destroy.

typedefs ending with _t are reserved for standards extensions, though these days people ignore this a lot because it feels like general practice to add _t.

There's no way to pass in a custom allocator, or logging callback, or set some debug logging flags. Maybe something to tackle later.

Both _select functions fall short in that they do not allow select'ing on channels + other file descriptors simultaneously. General library design practice is to have the library return a file descriptor that can be used in whatever event loop the application already uses. (The fd can be a dummy pipe or eventfd.)

All of these things are in the header, so they matter the most as they set ABI and API for any user. Unfortunately getting them right as early as possible is important to avoid breaks; yet very hard to do since often API aspects only become clear after a library has non-trivial users.

[edited to tone down a bit]

Re:Show HN: A pure C89 implementation of Go channels, with b... by dang on Wednesday December 13, 2023 @03:10PM (#38633504)
I realize your intention is to provide good feedback and you obviously know a lot, but if you could shift the pH slightly away from acidic, that would be better. Keep in mind that criticisms like this have a tendency to land 10x harder than you intended.

https://news.ycombinator.com/showhn.html

Re:Show HN: A pure C89 implementation of Go channels, with b... by drewg123 on Wednesday December 13, 2023 @04:00PM (#38634065)
This has to be the best comment from a moderator that I've ever seen. This is why I love HN.
Re:Show HN: A pure C89 implementation of Go channels, with b... by lnxg33k1 on Wednesday December 13, 2023 @04:21PM (#38634291)
I almost never agree with mods here, but despite that I’ve got to admit that the way the expose their opinions is one of the best Ive experienced
Re:Show HN: A pure C89 implementation of Go channels, with b... by hn_throwaway_99 on Friday December 15, 2023 @05:45PM (#38659777)
Just a note, because this is a common misconception that many folks bring from Reddit:

There are no "mods" on HN. There is one singular admin, dang, who pretty incredibly manages both the tech and the community.

In terms of people who have the power to downvote comments or flag stories, these are just regular HN users. There is a karma threshold at which downvote and flag links appear, but there is otherwise nothing special about this ability.

Some folks may think I'm splitting hairs, but I think it's important to clarify, as I often see comments blaming the "mods" for e.g. a post that was downvoted or flagged, as if the mods are some shadowy cabal (which can be the case when referring to Reddit mods). If posts are downvoted are flagged, it's because the community at large didn't like what you had to say.

Re:Show HN: A pure C89 implementation of Go channels, with b... by eqvinox on Wednesday December 13, 2023 @03:17PM (#38633601)
Sigh. Yes. Valid. I'll go edit it a bit.
Re:Show HN: A pure C89 implementation of Go channels, with b... by dang on Wednesday December 13, 2023 @03:29PM (#38633734)
Appreciated!
[dead]
Re:Show HN: A pure C89 implementation of Go channels, with b... by IAmLiterallyAB on Wednesday December 13, 2023 @07:20PM (#38636180)
If that was sarcasm, I don't think it landed. If not, well, let's not discourage people from admitting when they are wrong. It's a healthy thing to do.
Re:Show HN: A pure C89 implementation of Go channels, with b... by da39a3ee on Wednesday December 13, 2023 @11:47PM (#38637887)
And what we're looking at now is the non-acid version? You seem to have completely missed that the person was implementing something interesting. Here's something for you to do: think about whether, at work, you're good at giving credit to other people publicly. How do you think people feel on reading your code review comments? More junior employees? Are you happy with this?
Re:Show HN: A pure C89 implementation of Go channels, with b... by dang on Thursday December 14, 2023 @12:33AM (#38638165)
The edit moved in a good direction and that's worth reinforcing. It's not worth it to pile on further—it risks shaming, which would produce a backlash, which wouldn't benefit anyone.
Re:Show HN: A pure C89 implementation of Go channels, with b... by faiD9Eet on Thursday December 14, 2023 @04:33AM (#38639495)
Thank you dang very much for that explanation. It is a good example of social interaction and of second order effects. You are setting a good role model.
Re:Show HN: A pure C89 implementation of Go channels, with b... by jpc0 on Thursday December 14, 2023 @04:49AM (#38639597)
Don't want to start a thread and agree with what dang has said but I do want to give some perspective from my side.

I didn't see the original comment and I may take this better since it isn't my code but I don't ser this comment as negative.

If gives clear criticism which I can easily brush off as the way I want my library to work, but that when I read it I can agree with.

One if my major gripes with many libraries doing asynchronous work is that they just blindly assume I will be using their blessed event loop when in reality I already have an event loop. Which means I now need to put their code in a new thread, regenerate events and pass that to my event loop, that tends to add complexity.

Re:Show HN: A pure C89 implementation of Go channels, with b... by eqvinox on Thursday December 14, 2023 @05:24AM (#38639797)
Comment moved to https://pastebin.com/NgJ7VHSU due to length and off-topic-ness.
Re:Show HN: A pure C89 implementation of Go channels, with b... by swingingFlyFish on Thursday December 14, 2023 @10:12AM (#38642190)
The other reason to love this place is OPs take rebuke with grace. Kudos to you sir.
Re:Show HN: A pure C89 implementation of Go channels, with b... by helsinki on Wednesday December 13, 2023 @10:03PM (#38637292)
How much do you get paid to be mod?
Re:Show HN: A pure C89 implementation of Go channels, with b... by defrost on Wednesday December 13, 2023 @10:10PM (#38637336)
Undisclosed: https://www.newyorker.com/news/letter-from-silicon-valley/th...

.. but likely more than either of us get paid to comment.

Re:Show HN: A pure C89 implementation of Go channels, with b... by dang on Thursday December 14, 2023 @12:34AM (#38638172)
Enough to keep doing it.
Re:Show HN: A pure C89 implementation of Go channels, with b... by kazinator on Wednesday December 13, 2023 @03:14PM (#38633552)
> should really be a bool

bool is actually #define bool _Bool. You have to include <stdbool.h> to get it. That's ugly enough not to want to use it.

I'm looking at the April 2023 draft of ISO C. Under "Relational Expressions" I see that the result of an expression like x < y isn't bool, but ... int.

Here is the exact wording, minus a footnote reference:

Each of the operators < (less than), > (greater than), <= (less than or equal to), and >= (greater than or equal to) shall yield 1 if the specified relation is true and 0 if it is false. The result has type int.

int is still the Boolean type in C, and null pointers and zeros are still falsy, relational expressions yield 0 or 1 of type int, and #define bool is just a sham for anal retentives.

> typedefs ending with _t are reserved for standards extensions

That is inaccurate. It's POSIX that reserves this namespace. Even if you're targeting POSIX, the reservation has next to no practical meaning, and can safely be ignored.

Here is why. What POSIX says is that when new type names will be introduced in the future in POSIX, they will have _t as a suffix. Well, so what? New type names in ISO C will also have _t suffixes, yet ISO C doesn't say anything about that being "reserved".

When a new identifier is introduced, it has to start and end in something.

Whenever POSIX introduces a new public identifier in the future, that identifier will either start with "a", or else with "b", or with "c" ... does that mean that we should stop using all identifiers in order not to tread on a reserved space?

When you have a language without namespaces/packages, you just live with the threat of a clash and deal with it when it happens.

Name clashes are not just with standards like ISO C and POSIX but vendor extensions and third-party code.

The mole is only a problem when it rears its head, and that's when you whack it.

Re:Show HN: A pure C89 implementation of Go channels, with b... by eqvinox on Wednesday December 13, 2023 @03:46PM (#38633893)
> bool is actually #define bool _Bool. You have to include <stdbool.h> to get it. That's ugly enough not to want to use it.

Sure, which is why it got changed to a keyword in C23. I'll agree this should have happened earlier.

The return type of comparison operators is entirely irrelevant; you don't build APIs by reference to the return type of a comparison operator. It makes a difference to the reader whether your source code says "int" or "bool", that alone is all the reason anyone should need.

> That is inaccurate. It's POSIX that reserves this namespace.

You got me there. However, the question is, why would you add the _t? It serves no purpose. Typedefs have their own namespace anyway, you're not working around some possible collision by adding the _t.

That said I've already noted this is a commonly ignored aspect. I suppose it "feels" better/correct to some readers. I will happily agree this is the weakest point of my feedback either way, yet I still rather point it out and have people learn more details about this.

Re:Show HN: A pure C89 implementation of Go channels, with b... by kazinator on Wednesday December 13, 2023 @04:31PM (#38634413)
> The return type of comparison operators is entirely irrelevant

It is entirely relevant. The boolean type of the language is whatever is the type of (0 < 1).

> Typedefs have their own namespace anyway

Typedefs positively do not have their own namespace.

If you write

  #undef getc
  {
     typedef char getc;

  }
you cannot call the getc function in that scope; it is now the typedef.
Re:Show HN: A pure C89 implementation of Go channels, with b... by codys on Wednesday December 13, 2023 @08:13PM (#38636578)
When folks talk about namespaces, structs, & typedefs in C, it's to call out that `struct X` and `typedef int X;` can both exist at the same time. In other words, nothing prevents one from doing a `typedef struct X { int f; } X;` or similar, using `X` as the name in both places.

It is true that it's more correct to say "struct names have their own namespace", though I think we can infer what's actually meant here fairly easily.

Re:Show HN: A pure C89 implementation of Go channels, with b... by kazinator on Wednesday December 13, 2023 @08:41PM (#38636775)
> more correct to say "struct names have their own namespace"

That is false. If we declare an "enum foo", which is not a struct, then we cannot have a "struct foo" in that scope.

Re:Show HN: A pure C89 implementation of Go channels, with b... by codys on Wednesday December 13, 2023 @09:02PM (#38636913)
Sure, you're right, it's just not really relevant here.
Re:Show HN: A pure C89 implementation of Go channels, with b... by kazinator on Wednesday December 13, 2023 @09:12PM (#38636984)
Well, your two comments set a standard for relevance that is not easily attained by others.
Re:Show HN: A pure C89 implementation of Go channels, with b... by Xeamek on Wednesday December 13, 2023 @06:17PM (#38635598)
What about size of stored bool variable? Just using int will take 4 bytes (Or something else, but still bigger then 1), while stdbool will only use 1 byte, no?
Re:Show HN: A pure C89 implementation of Go channels, with b... by kazinator on Wednesday December 13, 2023 @06:37PM (#38635785)
In arrays, you can use char. In structs, there are also bitfields like unsigned flag : 1.
Re:Show HN: A pure C89 implementation of Go channels, with b... by __d on Thursday December 14, 2023 @12:17AM (#38638069)
> int is still the Boolean type in C, and null pointers and zeros are still > falsy, relational expressions yield 0 or 1 of type int, and #define bool > is just a sham for anal retentives.

Alternatively, and especially in a library API, using bool is a clear specification of semantics.

An int parameter could have many meanings. An int return value similarly. In both cases, using "bool" makes the usage instantly more clear, without the need for comments, or man pages, or Doxygen, or super_long_parameter_names, or whatever.

I think it's useful.

Re:Show HN: A pure C89 implementation of Go channels, with b... by oconnor663 on Wednesday December 13, 2023 @03:12PM (#38633528)
> that's just the header

You're providing a ton of code style feedback. That's fair, code style is important, I'm not saying you shouldn't. But surely when providing style feedback in public you could take a friendlier tone :(

Re:Show HN: A pure C89 implementation of Go channels, with b... by wiseowise on Wednesday December 13, 2023 @05:25PM (#38635077)
What's unfriendly in their tone?
Re:Show HN: A pure C89 implementation of Go channels, with b... by IAmLiterallyAB on Wednesday December 13, 2023 @07:16PM (#38636140)
They edited their original comment before you saw it, apparently the original tone was a bit harsh
Re:Show HN: A pure C89 implementation of Go channels, with b... by eqvinox on Thursday December 14, 2023 @04:33AM (#38639494)
btw, just to note, both your and dang's comment were very appropriate in calling me out for the very poor form of the original comment. Either of your comments would've reminded me that I don't normally do that, and I would've gone back and edited it. I replied to dang's comment (the "Sigh. Yes. Valid.") because I saw that first, but I also appreciate your pointing out the same thing, and in particular that you did so without reacting to my bile with more bile yet.

Thanks!

Re:Show HN: A pure C89 implementation of Go channels, with b... by oconnor663 on Saturday December 16, 2023 @03:00AM (#38662621)
No worries!
Re:Show HN: A pure C89 implementation of Go channels, with b... by tomcam on Wednesday December 13, 2023 @04:16PM (#38634230)
> It's 2023 - even MSVC has supported C11 and C17 for a while now. C89 is no longer a feature to advertise

There are plenty of constrained environments where this is indeed a feature to advertise, namely older machines and embedded systems.

Re:Show HN: A pure C89 implementation of Go channels, with b... by 38 on Wednesday December 13, 2023 @05:24PM (#38635065)
> older machines

Anything from the 80s/90s isn't really worth supporting. We gotta draw the line somewhere.

Re:Show HN: A pure C89 implementation of Go channels, with b... by fweimer on Wednesday December 13, 2023 @05:51PM (#38635329)
But it's not actually written in C89. It uses POSIX threads, flexible array members, anonymous unions, bitfield members that are not int, declarations intermixed with statements. And that's just what “gcc -std=c89 -pedantic-errors” reports.
Re:Show HN: A pure C89 implementation of Go channels, with b... by MrRadar on Wednesday December 13, 2023 @04:07PM (#38634141)
Also, as someone who wrote code that had to support C89-only compilers as recently as 5 years ago, I noticed immediately that this code mixes code and variable declarations which strictly C89 compatible compilers will barf on. That said, this code also uses pthreads which is not exactly as portable as "pure C89" implies either.
Re:Show HN: A pure C89 implementation of Go channels, with b... by coumbaya on Wednesday December 13, 2023 @03:09PM (#38633481)
Not dismissing anything you said but bool isn't C89 right ? Back ~6 years ago when I worked in embedded C89, bool was just a #define true (1==1), #define false (0==1) so I guess it makes sense it isn't in the lib ?
Re:Show HN: A pure C89 implementation of Go channels, with b... by eqvinox on Wednesday December 13, 2023 @03:14PM (#38633553)
Indeed, bool (or _Bool) was added in C99, hence my pointing out it not being used… it's not in C89.

It matters because the return value sense is different; an "int" return for a status-ish thing in a modern library generally means 0 for success, nonzero for error codes. "bool" is the other way around, 0 for failure-y. In this case it's a status retrieval function so it's pretty clear that it's intended as a boolean but it'd still be better to actually make it bool.

Re:Show HN: A pure C89 implementation of Go channels, with b... by coumbaya on Wednesday December 13, 2023 @03:50PM (#38633954)
Ah, I get it now, thx.
Re:Show HN: A pure C89 implementation of Go channels, with b... by sylware on Wednesday December 13, 2023 @04:01PM (#38634083)
Even C has already a syntax way too rich and complex (and C11 and C17 tantrums are making things worse).

Integer promotion should go, like implicit cast for anything except void* and literals, but we are missing a dynamic/static casts syntax explicit split. Only one loop keyword, loop {}, no switch, no anonymous block, no "a?b:c" operator. typedef has to go, (and typeof,generic,etc), the variable arguments of preprocessor function should be defined once and for all. __thread must go as tls should be managed dynamically and explicitely with the system interface, never statically and hidden by the runtime. Only sized primitive types (u8/s8...). That said, anonymous union/struct are very nice for complex memory layout.

And all the things I am forgetting right now.

With the pre-processor and coding discipline you can get close to that already, but I was told that what I am describing is basically the simplicity of rust syntax, true? Namely it is easier to write a naive rust compiler than a C compiler?

Re:Show HN: A pure C89 implementation of Go channels, with b... by IlliOnato on Wednesday December 13, 2023 @04:26PM (#38634354)
What's wrong with ternary operator ("a?b:c") ? It seems many people hate it but I've never seen a reason for it.

This operator is very useful and uncontroversial in Perl, it's normal (and quite readable) in selecting a value for assignment. One is expected to use good practices with it, but it is nice.

Is the problem the fact that in C you can use it instead of if, selecting not values but actions, like (a > b) ? printf("A") : printf("B");

Re:Show HN: A pure C89 implementation of Go channels, with b... by speed_spread on Wednesday December 13, 2023 @08:19PM (#38636618)
I like the ternary too but to pretend that it's ok because it's useful in perl is more of a counter argument...
Re:Show HN: A pure C89 implementation of Go channels, with b... by IlliOnato on Thursday December 14, 2023 @07:22AM (#38640598)
A was not using Perl as an argument, I am just much more familiar with Perl than C, so I wondered if the ternary operator works differently in C than in Perl, making it more problematic/less useful.
Re:Show HN: A pure C89 implementation of Go channels, with b... by dgfitz on Wednesday December 13, 2023 @05:58PM (#38635409)
I don’t like them because they’re easy to write and a pain to deal with later. My biggest irritation comes when I’d like to break inside the if or else clause of a ternary and can’t. There is also more mental overhead to parse and keep in the mental stack.

I have also seen them used cleanly and beautifully, but that is a rare occurrence.

Re:Show HN: A pure C89 implementation of Go channels, with b... by sylware on Thursday December 14, 2023 @07:15AM (#38640541)
Something which is significantly "controversial", or has no significant and pertinent impact, should not increase the compiler technical cost. Syntax sugar is the enemy of compiler technical costs.

For instance, a "feature" of significant and pertinent impact missing, in the list I provided, load and store from unaligned memory address should have their own keywords as this is really important, even though modern hardware micro-archs tolerate that at a cost. Anybody using that abomination of "struct packing" C extensions should think again: C has been meant for aligned access by default, namely unaligned access should be at a syntax cost, and should pop up from the syntax and be HARDCORE explicit. I don't even think rust syntax is that clean, am I wrong? (hopefully)

For instance in linux printf, I did run in a beautiful (irony) "aligned" attribute on a stack variable. I was reading the code and I though there was a bug since I did not read the variable declaration as I was very mistaken that the variable name was enough... Yeah, should be banned from the kernel (hopefully, rust is careful to avoid that abomination in its syntax).

When I have "packed" data structures, I am, usually, careful at having everything "byte" defined and use explicit macros for Xword loads and stores.

"Letting the compiler do that for you" is dual edge sword. And I don't even start on the _Generic abomination, which creates so much type indirection you don't know what you are dealing with unless you read a ton more code.

Re:Show HN: A pure C89 implementation of Go channels, with b... by IlliOnato on Thursday December 14, 2023 @07:19AM (#38640575)
What you mean by "breaking inside"? You cannot nest ternaries, but you can chain them (see my other comment above).
Re:Show HN: A pure C89 implementation of Go channels, with b... by zogrodea on Wednesday December 13, 2023 @04:51PM (#38634661)
I (a different person replying to your post) don't mind ternary operators, but I do prefer if-expressions which convey the same thing semantically but can be nicer to read (and also way better when chaining else-if ladders - nested ternaries can be a nightmare to read). https://stackoverflow.com/a/46843369
Re:Show HN: A pure C89 implementation of Go channels, with b... by 8372049 on Wednesday December 13, 2023 @09:13PM (#38636986)
To me personally, the use case for ?: is selecting a value for a const:

    const value = cond ? a : b;
Using an if instead would mean you can't make it const, and is usually more convoluted to read.

For pretty much all other use cases, I agree that ifs are better.

Re:Show HN: A pure C89 implementation of Go channels, with b... by kevindamm on Thursday December 14, 2023 @03:15AM (#38639021)
In that case you can have the result of a function call be assigned to the const, and the function be the if/else for the value. With a well-named function it can even be more readable than the ternary.
Re:Show HN: A pure C89 implementation of Go channels, with b... by IlliOnato on Thursday December 14, 2023 @08:15AM (#38640978)
Having to create a function where a simple expression would suffice is "typing in mittens" programming...
Re:Show HN: A pure C89 implementation of Go channels, with b... by kevindamm on Thursday December 14, 2023 @09:28AM (#38641677)
Fair enough.. I actually use ternary sometimes, especially in brief return statements, and especially when both results are simple values. I only really avoid it when the result expressions are multiline. I just felt like pointing out the obvious when I saw GP's comment.
Re:Show HN: A pure C89 implementation of Go channels, with b... by zogrodea on Thursday December 14, 2023 @05:31AM (#38639842)
I was confused by your reply when I first read it (didn't quite understand it), but I think it comes from a miscommunication when I had intended if-expressions (if statements that return a value) while you had if-statements in mind.

For example, the following F# code (you can run `dotnet fsi` in a terminal to try it out, if you have dotnet installed) is equivalent to a ternary expression:

// the value of x is "is_not_lower" after evaluation (x is a constant/immutable value, just like a 'const' value in JS) let x = if 0 > 1 then "is_lower" else "is_not_lower"

Which is equivalent to the following (in JS): const x = 0 > 1 ? "is_lower" : "is_not_lower"

In F# (and also Kotlin which I linked before), you can have clean code with if-elif-else ladders while the equivalent (using nested ternaries) would be hard to read. For example:

// the constant/immutable variable "comparison" is either "HIGHER", "LOWER" or "EQUAL" depending on the branch taken let comparison = if a > b then "HIGHER" elif a < b then "LOWER" else "EQUAL"

In JS land (and also most common programming languages which have plain if-statements), I agree a ternary would often be preferrable as long as it's not nested.

Re:Show HN: A pure C89 implementation of Go channels, with b... by IlliOnato on Thursday December 14, 2023 @07:14AM (#38640535)
I would say that languages where "if" can be used as expression provide a different (perhaps better) syntax for the same ternary operator.

    a = if x then y else z
is just a more verbose version of

     a = x ? y : z;
Raku uses yet another form of the same operator:

     a = x ?? y :: z;
Syntactic sugar :-)
Re:Show HN: A pure C89 implementation of Go channels, with b... by lizmat on Thursday December 14, 2023 @07:53AM (#38640785)
It's actually

    a = x ?? y !! z
And that's because a single : is used for many other semantics in the Raku Programming Language. And ?? and !! standout better in code.

https://docs.raku.org/language/operators#infix_??_!!

Re:Show HN: A pure C89 implementation of Go channels, with b... by IlliOnato on Thursday December 14, 2023 @08:11AM (#38640933)
You are right, of course. Sorry! "Colon belongs to Larry" :-)

I think I made this mistake because :: was used in one of the drafts for Perl 6, but the final specification uses !!

Re:Show HN: A pure C89 implementation of Go channels, with b... by 8372049 on Thursday December 14, 2023 @09:28AM (#38641680)
Sorry for the confusion, but you did indeed decipher my meaning (if-statements)! I agree that if-expressions are far more readable in languages that support them (Python and Haskell come to mind for me), even though they're arguably just syntactic sugar for the ternary operator.
Re:Show HN: A pure C89 implementation of Go channels, with b... by IlliOnato on Thursday December 14, 2023 @07:00AM (#38640442)
Chained ternaries are quite readable when formatted as tables...

    a = (x < 5 ) ? 'LESS'
      : (x > 5 ) ? 'MORE'
      :            'SAME';
Re:Show HN: A pure C89 implementation of Go channels, with b... by lelanthran on Thursday December 14, 2023 @01:16AM (#38638388)
> Namely it is easier to write a naive rust compiler than a C compiler?

You must be joking.

Re:Show HN: A pure C89 implementation of Go channels, with b... by sylware on Thursday December 14, 2023 @05:07AM (#38639692)
That's a question.

You know the answer?

Re:Show HN: A pure C89 implementation of Go channels, with b... by vacuity on Thursday December 14, 2023 @05:55PM (#38648538)
Writing a Rust lexer/parser, maybe. The entire compiler? Dubious.
Re:Show HN: A pure C89 implementation of Go channels, with b... by sylware on Friday December 15, 2023 @06:31AM (#38653100)
"maybe", then you don't know if it is easier to write a rust naive compiler than a C naive compiler (look at tinycc, cproc/qbe, simple-cc/qbe, etc).
Re:Show HN: A pure C89 implementation of Go channels, with b... by vacuity on Friday December 15, 2023 @03:39PM (#38658522)
You don't seem to be asking a question anymore. That's not what I said maybe to, anyways. If both languages have grammars that are on the same level, I don't see why someone experienced in writing a lexer/parser would have more difficulty with one. I think Rust only needs lookahead for raw strings and there are some quirks with C's grammar, but I'm not knowledgeable about that.
Re:Show HN: A pure C89 implementation of Go channels, with b... by cellularmitosis on Thursday December 14, 2023 @01:46AM (#38638526)
Easier to write a rust compiler than a C compiler? I must be somehow misinterpreting this.
Re:Show HN: A pure C89 implementation of Go channels, with b... by sylware on Thursday December 14, 2023 @05:08AM (#38639695)
It is a question.
Re:Show HN: A pure C89 implementation of Go channels, with b... by pengaru on Wednesday December 13, 2023 @04:26PM (#38634351)
The standards extensions reservation of _t is such a non-issue I don't understand why people even bother mentioning it anymore.

It's become such a common practice to suffix your typedefs with _t it's practically a de facto standard at this point.

Since everyone's already namespacing types with some kind of prefix, I don't see the problem nor have I ever experienced a negative consequence after decades of writing C this way.

Re:Show HN: A pure C89 implementation of Go channels, with b... by neverartful on Wednesday December 13, 2023 @04:26PM (#38634353)
No good deed goes unpunished.
Re:Show HN: A pure C89 implementation of Go channels, with b... by Rochus on Thursday December 14, 2023 @01:05PM (#38644719)
Amen.
Re:Show HN: A pure C89 implementation of Go channels, with b... by Galanwe on Wednesday December 13, 2023 @05:08PM (#38634882)
> It's 2023 - even MSVC has supported C11 and C17 for a while now. C89 is no longer a feature to advertise, it's an unhelpful constraint forcing poorer quality code.

Oh come on, let's not play the language police... You are entitled to your language likings, others are not. C89 is simple, straightforward, no bells and whistles, and some people like that (I do).

> There's nonstandard nomenclature in "_dispose"; if the constructing function is called _create, the common pattern is to pair it with _destroy.

"Nonstandard" says who?

In my 20 years of C I've seen all possible combinations of _init/_create/_new/_alloc _free/_deinit/_release/_delete/_destroy/_dispose. As long as it's consistent across the codebase, it's fine.

> typedefs ending with _t are reserved for standards extensions, though these days people ignore this a lot because it feels like general practice to add _t.

Not really. The usual convention for _t is to differentiate between raw struct names and typedef structs, such that you know whether you have to prefix "struct" during declaration. i.e. `struct foo {}`/`typedef struct {} foo_t`

> Both _select functions fall short in that they do not allow select'ing on channels + other file descriptors simultaneously.

Good point

Re:Show HN: A pure C89 implementation of Go channels, with b... by dekhn on Wednesday December 13, 2023 @05:12PM (#38634923)
I feel like this comment could be best structured in the form of a series of commits sent as a combined Merge Request.

First, a commit to change the docs to say it's a pure C99 (or C11 or C17) implementation.

Second, for each of your points, a single commit fixing each style issue (_dispose -> _destroy, typedefs).

Seperately, another MR with the commit for _select improvements.

Or maybe just send the C99 one first, and if that gets rejected, don't bother with the rest.

Re:Show HN: A pure C89 implementation of Go channels, with b... by jansommer on Wednesday December 13, 2023 @05:52PM (#38635339)
MSVC lacks some C99 features like variable length arrays and complex numbers. There's always a work around, but wouldn't want to use that compiler for C unless I had to.

Going for C89 for a truly portable project is probably fine.

Re:Show HN: A pure C89 implementation of Go channels, with b... by arp242 on Wednesday December 13, 2023 @09:55PM (#38637242)
MSVC added that a few years ago. It took them a (very) long time, but it should now be fully C99-compliant, even C17 I think (either fully or mostly).
Re:Show HN: A pure C89 implementation of Go channels, with b... by jansommer on Thursday December 14, 2023 @04:18AM (#38639422)
No. That syntax is not supported. Try a VLA and see how it goes. Then try a complex number or read the docs: "The compiler doesn't directly support a complex or _Complex keyword" - https://learn.microsoft.com/en-us/cpp/c-runtime-library/comp...
Re:Show HN: A pure C89 implementation of Go channels, with b... by pjmlp on Thursday December 14, 2023 @07:33AM (#38640664)
Supporting C11 and C17 by definition doesn't require supporting C99 features made optional in C11.
Re:Show HN: A pure C89 implementation of Go channels, with b... by Conscat on Wednesday December 13, 2023 @06:17PM (#38635600)
I would note that Tiny C Compiler is used a fair amount in the wild today, even beyond its stated use cases on the landing page, and C89 is the only standard that it fully supports.
Re:Show HN: A pure C89 implementation of Go channels, with b... by jamal-kumar on Wednesday December 13, 2023 @07:28PM (#38636243)
Out of curiosity where is tinycc still being used?
Re:Show HN: A pure C89 implementation of Go channels, with b... by defrost on Wednesday December 13, 2023 @07:36PM (#38636291)
Fun stuff like running OS's in your browser:

https://bellard.org/jslinux/

and by a dedicated few to this day: https://lists.gnu.org/archive/html/tinycc-devel/

It's not much but it's not dead.

Re:Show HN: A pure C89 implementation of Go channels, with b... by Conscat on Wednesday December 13, 2023 @10:02PM (#38637285)
Languages that transpile to C code like it because, if the C is generated by another compiler, then the C language's expressiveness doesn't really matter, and TCC builds machine code pretty fast.
Re:Show HN: A pure C89 implementation of Go channels, with b... by rurban on Thursday December 14, 2023 @02:26AM (#38638723)
With big code bases, to get fast feedback. For me it's 200ms vs 3min
Re:Show HN: A pure C89 implementation of Go channels, with b... by arp242 on Wednesday December 13, 2023 @09:53PM (#38637237)
According to the README it supports most of C99, and even some things beyond that. It's not clearly defined what's meant with "most" or what's not supported, but since I've never had any problems with any C99 code I've written I suspect it's mostly fairly little used stuff (complex numbers?), and it seems that for all practical purposes tcc supports C99 for almost all codebases.
Re:Show HN: A pure C89 implementation of Go channels, with b... by Rochus on Wednesday December 13, 2023 @06:44PM (#38635851)
> edited to tone down a bit

How generous. The comment reminds me of this passage in C. Northcote Parkinson's famous 1957 book:

"The man who is denied the opportunity of taking decisions of importance begins to regard as important the decisions he is allowed to take. He becomes fussy about filing, keen on seeing that pencils are sharpened, eager to ensure that the windows are open (or shut), and apt to use two or three different-colored inks."

How can it be that in HN a comment like this, which is all about trivialities and the personal sensitivities of the commentator, and which contributes nothing relevant to the matter at hand, receives the most upvotes? Is this comment somehow pinned to the top instead?

Many here seem just disparaging about Reddit, but if you want to see an actually useful and intelligent comment from someone who actually knows something about the subject, take a look here: https://old.reddit.com/r/C_Programming/comments/18fzr1a/a_pu.... I'd expect at least that level from comments on HN.

Re:Show HN: A pure C89 implementation of Go channels, with b... by kovac on Wednesday December 13, 2023 @08:14PM (#38636580)
What's the name of the book?
Re:Show HN: A pure C89 implementation of Go channels, with b... by Rochus on Wednesday December 13, 2023 @08:21PM (#38636632)
"Parkinson's Law And Other Studies in Administration" - a very enlightening book that has lost none of its relevance.
Re:Show HN: A pure C89 implementation of Go channels, with b... by sevagh on Wednesday December 13, 2023 @08:04PM (#38636511)
>How can it be that in HN a comment like this, which is all about trivialities and the personal sensitivities of the commentator, and which contributes nothing relevant to the matter at hand, receives the most upvotes? Is this comment somehow pinned to the top instead?

I feel like purposely emphasizing C89 in your project name is meant to highlight some sort of greybeard or serious hacker aspect to it. Presumably the poster was thinking along the lines of "if you're trying to show how proficient you are with a sharp knife, here's a list of all the ways you cut yourself with it."

Re:Show HN: A pure C89 implementation of Go channels, with b... by anitil on Wednesday December 13, 2023 @09:59PM (#38637264)
For me C89 means 'will build anywhere' whereas C99+ means 'may or may not build anywhere', rather than a value judgement about the author. But my background was in firmware where sometimes you were using custom compilers or very old compilers.
Re:Show HN: A pure C89 implementation of Go channels, with b... by cellularmitosis on Thursday December 14, 2023 @12:22AM (#38638096)
As someone whose idea of fun is trying to compile open source software on OS X / PowerPC, portability has a special place in my heart. While I view open source software as a "gift to the world", C89 + MIT is at the far end of the spectrum of how generous that gift is.

https://imgflip.com/i/89b05r

Re:Show HN: A pure C89 implementation of Go channels, with b... by Rochus on Wednesday December 13, 2023 @10:01PM (#38637277)
It's a library, one of the goals of which is compatibility with the many C89 compilers still in use today, so how else should I name it? And why is it bad or provoking to have a gray beard (which sounds a lot like age discrimination to me) or to highlight a "serious hacker aspect"?
Re:Show HN: A pure C89 implementation of Go channels, with b... by eqvinox on Thursday December 14, 2023 @05:50AM (#38639968)
> It's a library […] C89 […] how else should I name it?

It's unfortunate that you pose this as a rhetorical question, it has an actual answer: replace "pure C89" with "C89 compatible", wrap it in braces, and move it to the end of the title.

The message you're communicating by putting "pure C89" right front is very different from having a "(C89 compatible)" at the end: the former sounds like C89 is somehow an unequivocally good thing ("pure") while the latter makes clear that it is to address an unfortunate reality of engineering life. It would also distance you from C style and quality focused comments.

> which is all about trivialities and the personal sensitivities of the commentator, and which contributes nothing relevant to the matter at hand

The select API concern seems relevant and actionable.

Re:Show HN: A pure C89 implementation of Go channels, with b... by Rochus on Thursday December 14, 2023 @06:47AM (#38640352)
> replace "pure C89" with "C89 compatible"

Not even English has the "purity" that you subliminally presuppose in your (entirely unnecessary) assertions. See e.g. https://www.merriam-webster.com/dictionary/pure?utm_campaign.... And not a single one of your arguments had to do with "language purity"; instead you nit-picked about naming and features you miss; so what? But hey, it's open source: impress the world with your own version of the library.

Re:Show HN: A pure C89 implementation of Go channels, with b... by sevagh on Thursday December 14, 2023 @12:42PM (#38644347)
These aren't really my judgements, I'm just guessing why you got some criticisms.

I didn't consider the aspect of which modern toolchains are still attached to C89, but using a language spec that's 35 years old has some relationship to the grayness of one's beard. But in any case I used the term greybeard to evoke the aesthetic of "fuck modernity, embrace terse C, suckless software" etc.

Re:Show HN: A pure C89 implementation of Go channels, with b... by justin66 on Thursday December 14, 2023 @12:13AM (#38638053)
> I feel like purposely emphasizing C89 in your project name is meant to highlight some sort of greybeard or serious hacker aspect to it.

Or indicating that it will work if you want to fold the code into a C89 project, which is not exactly a rare concern.

Re:Show HN: A pure C89 implementation of Go channels, with b... by RangerScience on Wednesday December 13, 2023 @09:33PM (#38637095)
Oh shit it me. Thank you! Time for me to reflect on this for a bit…
Re:Show HN: A pure C89 implementation of Go channels, with b... by jjgreen on Wednesday December 13, 2023 @07:28PM (#38636241)
IIRC, reservation of _t in typedefs is for the POSIX rather than C standards.
Re:Show HN: A pure C89 implementation of Go channels, with b... by accelbred on Wednesday December 13, 2023 @07:52PM (#38636408)
C89 is a requirement where I work still, so C89 libraries are useful here. We support vendor C toolchains that don't always have C99 features.
Re:Show HN: A pure C89 implementation of Go channels, with b... by Brian_K_White on Wednesday December 13, 2023 @07:54PM (#38636433)
It's 2023, and I love this. There is no reason to criticize the mere fact that someone took the effort to make something that portable.

Even if you think they wasted their time, they didn't waste your time, and I value the existence of things like this, which means even if you don't, at least some others do.

Re:Show HN: A pure C89 implementation of Go channels, with b... by kevin_thibedeau on Wednesday December 13, 2023 @08:41PM (#38636773)
C89 sometimes actually means gnu89 which is decidedly non-portable to modern standards in subtle ways. It's time to put that horse to pasture and consider at least using a 24 year old standard instead.
Re:Show HN: A pure C89 implementation of Go channels, with b... by Brian_K_White on Wednesday December 13, 2023 @09:49PM (#38637212)
If gnu89 is not a perfect c89, so what? c11 is also not a perfect c89. ruby is also not a perfect c89. Swift is more convenient than c89 for ios. c89 doesn't have tons of features that c# has. We could say true yet irrelevant things all day long. You don't like c89 flavor ice cream, got it. So what?
Re:Show HN: A pure C89 implementation of Go channels, with b... by epcoa on Thursday December 14, 2023 @11:11AM (#38642913)
The only thing that matters here rather than the nonsense hypotheticals is that they are right, the library isn’t C89 as pointed out by others. This isn’t about not liking C89 flavor ice cream, but calling it C89 when it isn’t. Like, of all things why mislead about that? Very bizarre behavior from the OP and these comments.

The more reasonable discussion then becomes: fix the non C89 issues so the statement becomes accurate, disclose that it uses extensions, or as some have constructively suggested consider just targeting C99 rather than GNU89. Not sure why you think criticism of something not being what it claims is inappropriate.

Re:Show HN: A pure C89 implementation of Go channels, with b... by __d on Thursday December 14, 2023 @12:25AM (#38638103)
Ok, I agree that these points might have been made more constructively, but ...

They're mostly legitimate, good-quality feedback for a new C library.

_create/_destroy -- yes; custom allocator, logger, debug level setting -- yes; returning a file descriptor -- yes; the implied suggestion to move stuff out of the header -- yes.

This is important feedback. These things will require a breaking change down the line unless you tackle them before 1.0.

I encourage the author to take this onboard: it'll make your own life easier and your library a better C citizen.

Re:Show HN: A pure C89 implementation of Go channels, with b... by buildartefact on Thursday December 14, 2023 @12:30AM (#38638139)
Do you know of a good style guide that encapsulates common conventions like create/destroy?
Re:Show HN: A pure C89 implementation of Go channels, with b... by 1vuio0pswjnm7 on Thursday December 14, 2023 @03:13AM (#38639003)
Perhaps I'm readint it wrong bu this comment is crticising someone for not using added language features. Maybe the author does not need them. "YAGNI". IMO, it should be the author's choice whether or not to utilise certain features. As someone else noted in another comment, C89 is more portable than C11 or C17. To me, C89 is like Bourne shell. An author can choose to write scripts in Bash but they will not be as portable as ones written in Dash, nor as fast. The only constraint I have run into with C89, when compiling lex.yy.c, is that it has a limit of 32767 lines.