News for hackers. Stuff that matters.
Re:Signal on Android: Images sent to wrong contacts by greysonp on Sunday July 25, 2021 @02:38PM (#27951708)
Hi there, Signal-Android developer here. I updated the issue to reflect this, but this bug has been fixed. I was tracking it on a separate issue, and had forgotten to close this one.

We do, in fact, take issues like this very seriously. This bug was extraordinarily rare, and because we have no metrics/remote log collection, there was an initial period where we had to spend time adding logging and collecting user-submitted logs to try to track it down. As soon as we were able to pick up a scent, it was all we worked on, and we were able to get a fix out very quickly.

Re:Signal on Android: Images sent to wrong contacts by andrewguenther on Sunday July 25, 2021 @02:52PM (#27951824)
> This bug was extraordinarily rare, and because we have no metrics/remote log collection, there was an initial period where we had to spend time adding logging and collecting user-submitted logs to try to track it down.

Without telemetry, can you actually back up the claim that this issue was extremely rare?

Re:Signal on Android: Images sent to wrong contacts by hnarn on Sunday July 25, 2021 @02:59PM (#27951881)
Some details on how this assumption was made would be nice, but I think it's pretty obvious that any developer involved in a project can make a reasonable assumption of how rare a bug is depending on the technical details on what is required for the bug to happen. For example, if we say for the sake of argument that a hypothetical bug requires you to have more than ten contacts of the exact same name and these also need to share the same country and area code, one can make the assumption this use case is very rare without knowing the exact number of users that this applies to, just based on common sense regarding how the application is normally used.

edit: The linked github issue says:

> The TL;DR is that if someone had conversation trimming on, it could create a rare situation where a database ID was re-used in a way that could result in this behavior. It was very difficult to track down, with earlier phases involving getting additional logging into builds. Once we had some more information, it did in fact become our top priority, a fix was made, and we got it out as quickly and as safely as possible. The fix itself should make it so that database issues like the one that caused this bug can't happen again.

Re:Signal on Android: Images sent to wrong contacts by WesolyKubeczek on Sunday July 25, 2021 @04:02PM (#27952424)
> a hypothetical bug requires you to have more than ten contacts of the exact same name and these also need to share the same country and area code

Sounds like the village a part of my family tree comes from.

Re:Signal on Android: Images sent to wrong contacts by Griffinsauce on Sunday July 25, 2021 @05:26PM (#27953067)
> just based on common sense regarding how the application is normally used

Just based on assumptions of how the application is used.

"falsehoods programmers believe" comes to mind. The uniqueness of names in your example could be false in some (or many? No idea) cultures.

Re:Signal on Android: Images sent to wrong contacts by z3t4 on Sunday July 25, 2021 @03:35PM (#27952219)
> The fix itself should make it so that database issues like the one that caused this bug can't happen again.

I've said that a few times, and been wrong about it. :D

I don't know what they mean by "where a database ID was re-used", but I guess it had to do with caching, and cache invalidation is one of the hardest part in computer programming.

Re:Signal on Android: Images sent to wrong contacts by dane-pgp on Sunday July 25, 2021 @10:06PM (#27954774)
> cache invalidation is one of the hardest part in computer programming.

Yes, famously it is one of the two hardest parts of computer programming, the other being naming things, and off-by-one errors.

Re:Signal on Android: Images sent to wrong contacts by varispeed on Sunday July 25, 2021 @04:28PM (#27952639)
Why would anyone think that re-use of ID was a good idea?
Re:Signal on Android: Images sent to wrong contacts by hnarn on Sunday July 25, 2021 @04:32PM (#27952665)
I'm not defending the practice of re-using a database ID, but it's absolutely something that can happen (or change) as an oversight rather than an active choice from the developer.
Re:Signal on Android: Images sent to wrong contacts by doctor_eval on Sunday July 25, 2021 @06:44PM (#27953640)
Perhaps that’s why it was a bug?
Re:Signal on Android: Images sent to wrong contacts by jakequade on Monday July 26, 2021 @12:26AM (#27955661)
> it's pretty obvious that any developer involved in a project can make a reasonable assumption of how rare a bug is

... is it? The fact that a bug exists means there's a logic gap. You can try and patch it with theory, but that's just adding assumption to a scenario created from broken assumptions. Also, the job of telemetry in incident reporting isn't to be vague - its to add precision.

Re:Signal on Android: Images sent to wrong contacts by lmeyerov on Monday July 26, 2021 @01:04AM (#27955893)
There's probably a ratio of bug-report-to-occurrences that they're used to for difference kinds of bugs. Ex: If user-visible security bugs have good report rates, say 100-1000 leaks per 1 report, and 10 reports, then 1K-10K incidents. This is harder in b2b, but in b2c, PM's should have a feel for it..
Re:Signal on Android: Images sent to wrong contacts by conradev on Monday July 26, 2021 @01:37AM (#27956044)
You’d be surprised how difficult it is to estimate the frequency that someone sees a bug. The only way to have a “feel for it” is to base it on… other data.

Say there is a bug that happens in the photo taking flow – you’d need to know how often people take photos in Signal. You’d think you could spitball something for that, but it is actually really hard. But if you log how often photos are taken, then that is a great starting point.

But further, lower level logic errors like this, especially ones involving race conditions, are even harder to pin down. That is why on iOS you can log “faults” which are non-fatal but very not-expected events:

https://developer.apple.com/documentation/os/logger/3551617-...

They generate reports with stack traces that you can use to a) judge the prevalence of an issue and b) see where it originated

Re:Signal on Android: Images sent to wrong contacts by NullPrefix on Sunday July 25, 2021 @03:15PM (#27952037)
>for the sake of argument that a hypothetical bug requires you to have more than ten contacts of the exact same name and these also need to share the same country and area code

This is only rare if you have a small social circle. My circle has multiple first name-collisions of at least 5 participants, but my circle is not very big and the area code is also quite small.

Some countries do not use area codes for mobile phone numbers, which are used for Signal, meaning country code is the only area limiting factor.

Re:Signal on Android: Images sent to wrong contacts by hutrdvnj on Sunday July 25, 2021 @03:34PM (#27952208)
Well he just wanted to make an example. One could also construct an example, where the bug only occurs for people with a rare sequence of unicode symbols (e.g. U+2600 U+2601 U+2602) in their username and have a specific date (e.g. 05.04.1920) as their birthday.
Re:Signal on Android: Images sent to wrong contacts by NullPrefix on Sunday July 25, 2021 @04:06PM (#27952455)
Your argument depends on Signal implementing username support, because we do not support unicode in phone numbers.
Re:Signal on Android: Images sent to wrong contacts by hutrdvnj on Sunday July 25, 2021 @04:11PM (#27952499)
My argument depends on an alternate universe in which signal supports it, everything else being equal, because why not.
Re:Signal on Android: Images sent to wrong contacts by NullPrefix on Sunday July 25, 2021 @04:20PM (#27952571)
Does that alternate universe support phone numbers with unicode characters too?
Re:Signal on Android: Images sent to wrong contacts by ChrisKnott on Sunday July 25, 2021 @04:49PM (#27952794)
You are arguing against a hypothetical situation of your opponent's creation. This is like when Ross tried to beat Chandler at Cups
Re:Signal on Android: Images sent to wrong contacts by hutrdvnj on Sunday July 25, 2021 @04:57PM (#27952846)
I go to bed now and dream of a universe in which NullPrefix is Ross and continues to argue endlessly.
Re:Signal on Android: Images sent to wrong contacts by NullPrefix on Sunday July 25, 2021 @06:19PM (#27953470)
I'll argue with anyone about anything. For free.
Re:Signal on Android: Images sent to wrong contacts by webmaven on Monday July 26, 2021 @04:54AM (#27957192)
> I'll argue with anyone about anything. For free.

No, you won't.

Re:Signal on Android: Images sent to wrong contacts by NullPrefix on Monday July 26, 2021 @07:04AM (#27957998)
Obviously that was a hyperbolic statement.
Re:Signal on Android: Images sent to wrong contacts by webmaven on Monday August 02, 2021 @08:51AM (#28035839)
Don't argue with me!
Re:Signal on Android: Images sent to wrong contacts by NullPrefix on Sunday July 25, 2021 @06:30PM (#27953560)
I am curious how different that alternative universe needs to be for my argument to be invalid.
Re:Signal on Android: Images sent to wrong contacts by desine on Sunday July 25, 2021 @07:09PM (#27953789)
It's not that your argument was incorrect. It's that it is tangential to the parent comment. hnarn was not making the point of something being rare, they were demonstrating that a developer can estimate the rarity based on the conditions that trigger it. The rarity itself is no matter.

Arguing over small semantic or circumstantial differences is often considered impolite

Re:Signal on Android: Images sent to wrong contacts by johnisgood on Sunday July 25, 2021 @05:54PM (#27953284)
It is a hypothetical scenario for the purpose of an example. It could have been literally anything, the point is for it to be rare.
Re:Signal on Android: Images sent to wrong contacts by NullPrefix on Sunday July 25, 2021 @06:20PM (#27953478)
Yes, but the fact that scenario is hypothetical doesn't counter my argument that whatever the developer thinks is rare is actually rare.
Re:Signal on Android: Images sent to wrong contacts by johnisgood on Monday July 26, 2021 @07:31PM (#27966812)
I do not know why I keep replying to this... but regardless, here it comes: your counter-argument is irrelevant! It does not require any counter-argument, because it is hypothetical! He could have said anything else that is rare, something that you think is rare, too. Just assume he said something that you think is rare as well. It is a hypothetical scenario, so you can do that; in fact: you should have done that, because all that is important is that it is rare, whatever that is. Again, argument over what he said is rare or not is not needed. Just assume it is rare, or assume he said something you think is rare.

I hope this gets the point across. Yes, maybe what he said is not rare, but that is besides the point.

Re:Signal on Android: Images sent to wrong contacts by desine on Sunday July 25, 2021 @03:26PM (#27952129)
>for the sake of argument
Re:Signal on Android: Images sent to wrong contacts by NullPrefix on Sunday July 25, 2021 @04:03PM (#27952435)
Yes.

And for the sake of the same argument I made a counter argument, stating that some initially believed to be rare circumstances are actually not that rare.

Re:Signal on Android: Images sent to wrong contacts by hnarn on Sunday July 25, 2021 @04:22PM (#27952583)
"For the sake of argument" does not mean "I invite you to debate this", it means the exact opposite: "let's assume this is correct/we agree/etc. for a while and debate what comes after". So in this case you are doing the exact opposite of what the phrase "for the sake of argument" is requesting.

https://idioms.thefreedictionary.com/for+the+sake+of+argumen...

> I know you want to go to Stanford, but just for the sake of argument, let's talk about what some of the other schools you got into have to offer.

This does not mean "I invite you to make a counter-argument as to why no other schools than Stanford are worth going to".

Re:Signal on Android: Images sent to wrong contacts by qu4z-2 on Sunday July 25, 2021 @04:58PM (#27952853)
It sounds to me like NullPrefix accepted the hypothetical bug, for the sake of the argument, and then addressed the rarity assumptions made about that bug. "For the sake of argument" doesn't mean "No debating" it means "Let's assume some thing x is taken as a given and go from there."
Re:Signal on Android: Images sent to wrong contacts by hnarn on Sunday July 25, 2021 @05:02PM (#27952885)
The whole point was that "given this assumed rare bug, one can know it's pretty rare". Whether the example is actually rare enough is completely beside the point. If it's not rare enough for you, replace it. The argument comes next: given a rare bug, a developer can make an assumption of how rare it is. Debating the example of rareness is splitting hairs.
[dead]
Re:Signal on Android: Images sent to wrong contacts by hnarn on Sunday July 25, 2021 @04:47PM (#27952784)
English is my second language.
Re:Signal on Android: Images sent to wrong contacts by johnisgood on Sunday July 25, 2021 @05:57PM (#27953298)
There is no argument, and it did not require a counter-argument, because that is not the point. He could have used literally anything else, it just has to be rare.
Re:Signal on Android: Images sent to wrong contacts by CoryAlexMartin on Sunday July 25, 2021 @03:06PM (#27951947)
If you know the reproduction steps and you can look at the code, you should be able to make an estimate of rarity.
Re:Signal on Android: Images sent to wrong contacts by saagarjha on Sunday July 25, 2021 @03:08PM (#27951967)
Even with telemetry, would you be able to back up the claim that that the issue was rare? All too often, people add telemetry to something in an attempt to try to find things like this, but they end up leaking things elsewhere and not accounting for them. Bad statistics are more dangerous than no statistics, and all that.
Re:Signal on Android: Images sent to wrong contacts by gsich on Sunday July 25, 2021 @03:31PM (#27952185)
If this is the first instance of this bug being reported, then yes it's rare.
Re:Signal on Android: Images sent to wrong contacts by johnisgood on Sunday July 25, 2021 @05:58PM (#27953310)
The rarity of a bug is independent from reports of it.
Re:Signal on Android: Images sent to wrong contacts by barsonme on Sunday July 25, 2021 @06:12PM (#27953412)
That also depends on the severity of the bug. :)
Re:Signal on Android: Images sent to wrong contacts by gsich on Sunday July 25, 2021 @06:26PM (#27953529)
No, those are directly correlated.
Re:Signal on Android: Images sent to wrong contacts by johnisgood on Monday July 26, 2021 @06:33AM (#27957808)
I would like to think so. I used a program that is full of bugs, yet those are not reported[1], nor have they been fixed. :(

Edit:

[1] I did report one (or two?, it has been some time ago) after some time (could have been months, because I could do without it as a compromise for that time being). They did not respond nor did they fix it (so I did not report any other bugs I have found). I recently re-installed it to give it another go, and the easy-to-fix bug still occurs. They just do not give a damn. Their website has been rebranded and everything, but this bug has not been fixed for over a year.

Edit #2:

Wow, I was way off with the "over a year". I checked the bug report of the one I remember reporting. It does seem like some other people have reported it too. Well, it is a bug from 2018, after all. Still open, no word from a developer. :D It is a bug of a crucial feature.

In any case, if for some reason I had to use this software again, I would never report any bugs because it is pretty much futile. They do not answer, they do not categorize bugs, they do not seem to check the bug reports at all. It would be a waste of time.

Re:Signal on Android: Images sent to wrong contacts by gsich on Monday July 26, 2021 @07:06AM (#27958008)
Then why not report them?
Re:Signal on Android: Images sent to wrong contacts by zimpenfish on Monday July 26, 2021 @08:15AM (#27958472)
Because the bug happens when you're trying to get something done and you don't have 5 spare minutes to interrupt your flow in order to file a bug. You might make a mental note to report it later and then forget. Or, if the bug is annoying enough, you might just never use that program again and you don't care if it gets fixed. Or your wifi glitched at the same time the bug happened and you've no idea if it is a bug or the glitchy wifi. Or you don't know it's a bug until later and by that time you've no idea what you were doing to trigger it.

There's a million and one valid reasons people don't report bugs.

Re:Signal on Android: Images sent to wrong contacts by desine on Sunday July 25, 2021 @07:46PM (#27954022)
The reports of it are correlated to the rarity, except in instances where reports are not generated, such as apps that do not collect error telemetry.
Re:Signal on Android: Images sent to wrong contacts by agucova on Monday July 26, 2021 @04:25AM (#27957028)
Users can make reports manually, and you would even expect them to do so at a high rate in bugs like this. This implies a high correlation between bug reports and rarity.
Re:Signal on Android: Images sent to wrong contacts by gsich on Monday July 26, 2021 @05:57AM (#27957569)
Telemetry does not matter in this case. If a bug occures often, then either the issue ticker will get this bug often, or there might even be a "known bugs" section.
Re:Signal on Android: Images sent to wrong contacts by gsich on Sunday July 25, 2021 @06:25PM (#27953521)
Even with, what telemetry would allow you to determine how many pictures (and presumably content) you sent to whom?
Re:Signal on Android: Images sent to wrong contacts by andrewguenther on Monday July 26, 2021 @12:33PM (#27961509)
You can fix the bug but emit a metric on the original code path to estimate the impact after the fix is made. It wouldn't tell you who sent what to who, but would give you a better idea of impact for an incident report or postmortem.
Re:Signal on Android: Images sent to wrong contacts by kaba0 on Sunday July 25, 2021 @09:40PM (#27954615)
I read it as bugs of this severity are extremely rare. Which claim doesn’t require telemetry.
Re:Signal on Android: Images sent to wrong contacts by TekMol on Sunday July 25, 2021 @02:42PM (#27951746)
Can you provide a link to the commit that fixes it?

Shouldn't there have been an announcement to inform users what has been leaked and under which circumstances?

How can user A send an image to user B that neither of them took? Isn't everything end-2-end encrypted? Then how can unencrypted data from user C end up on the device of user B?

Re:Signal on Android: Images sent to wrong contacts by tomudding on Sunday July 25, 2021 @03:12PM (#27952013)
> Can you provide a link to the commit that fixes it?

If I understand the issue [0] correctly, these two commits should be the fix:

https://github.com/signalapp/Signal-Android/commit/e90fa05d6...

https://github.com/signalapp/Signal-Android/commit/b9657208f...

The former updates how recipients (or really threads, I suppose) are merged (the issue occurred when trimming threads) and the latter changes the way how thread ids are generated (now automatically incremented). Together they should prevent unrelated recipients (threads) from being merged.

[0]: https://github.com/signalapp/Signal-Android/issues/10247#iss...

Re:Signal on Android: Images sent to wrong contacts by hackinthebochs on Sunday July 25, 2021 @06:47PM (#27953659)
Using incrementing ids as your source of ownership is just asking for trouble. This just means a programming error can have a high probability of ids lining up and leaking resources. Guids make this practically impossible.
Re:Signal on Android: Images sent to wrong contacts by fulafel on Monday July 26, 2021 @02:17AM (#27956253)
I wonder if there's any widely implemented programming pattern that would catch this better, eg consisting of concatenated type code and id. Using GUIDs here would still hide the bug, not flag an error.
Re:Signal on Android: Images sent to wrong contacts by ultrarunner on Monday July 26, 2021 @11:40AM (#27960805)
I don’t know if it’s widely implemented, but the way Stripe IDs resources comes to mind.
Re:Signal on Android: Images sent to wrong contacts by rattray on Sunday July 25, 2021 @09:25PM (#27954532)
Interesting, I hadn't thought of that advantage of uuids/guids before.
Re:Signal on Android: Images sent to wrong contacts by winrid on Sunday July 25, 2021 @05:30PM (#27953099)
I love the terrible commit name. "Updating recipient merging."
Re:Signal on Android: Images sent to wrong contacts by Popegaf on Sunday July 25, 2021 @03:15PM (#27952040)
From the explanation [0], this looks like the commit [1].

I do have to say though, the commit messages are very barren and barely any reference an issue directly. My guess is that they develop on private branches with an internal issue tracker and decide not to reference issues as that would be confusing. It would help a bunch if they referenced the public issues and made it clear which issues they're working on. They don't seem to use Github Projects [2].

All in all, the communication / transparency of the project is lacking - even though I'm glad they're providing something usable. Hopefully Matrix will be able to provide something as easily usable as well.

[0]: https://github.com/signalapp/Signal-Android/issues/10247#iss...

[1]: https://github.com/signalapp/Signal-Android/commit/83086a5a2...

[2]: https://github.com/signalapp/Signal-Android/projects

Re:Signal on Android: Images sent to wrong contacts by konschubert on Sunday July 25, 2021 @04:59PM (#27952866)
If it’s a client bug that just switches out recipients, then the messages will just get encrypted for the wrong recipient.
Re:Signal on Android: Images sent to wrong contacts by agilob on Sunday July 25, 2021 @03:00PM (#27951894)
No PR with name that would suggest the fix in the client https://github.com/signalapp/Signal-Android/pulls?q=is%3Apr+...

and no PR from OP in the opensource part of the server https://github.com/signalapp/Signal-Server/pulls?q=is%3Apr+i...

Re:Signal on Android: Images sent to wrong contacts by seg_lol on Sunday July 25, 2021 @03:40PM (#27952260)
*edit, I think this issue was specific to the Android client, the desktop client has a totally different sqlite schema.

The child comment to your comment is deleted, but I think autoincrement IDs shouldn't be used under an ambient authority context.

It would make more sense to have IDs based on an LSF or Feistel sequence, perhaps split into a master ID and a conversation sequence.

Autoincrement on this field makes it easy for off by one errors. Even just moving to guids and maintaining a proper parent child relationship would have prevented this.

Or maybe there should be a database per conversation (set of all parties).

https://github.com/signalapp/Signal-Android/commit/83086a5a2...

https://github.com/signalapp/Signal-Android/commit/b9657208f...

Row IDs shouldn't have so much power.

Re:Signal on Android: Images sent to wrong contacts by WesolyKubeczek on Sunday July 25, 2021 @04:11PM (#27952497)
The good thing about autoincrementing unsigned 64-bit integers is that 1) it's insanely fast, 2) SQLite is doing it automatically, 3) seriously, why don't they have it on all tables yet? SQLite guarantees no collisions within a table.

Doing homegrown ID generation is how such bugs are being introduced in the first place. Your application level trigger got bypassed, oops. Your check was experimentally disabled and left like that for a year until people started noticing, oops.

If you make an SQLite-backed application and it has a bug like this, I can safely bet $500 it's not going to be SQLite that has the bug.

Just don't expose the numeric IDs in links, and generate your UUIDs in tables where you need to point to rows in an outside-accessible link. This is database 101, for crying out loud.

Re:Signal on Android: Images sent to wrong contacts by lwhi on Sunday July 25, 2021 @02:43PM (#27951759)
I appreciate that this was a difficult and rare bug, but for an app that sells itself as 'secure', it feels like this isn't acceptable.

How can users be assured that this type of issue won't occur again?

Re:Signal on Android: Images sent to wrong contacts by asdfasgasdgasdg on Sunday July 25, 2021 @04:48PM (#27952787)
What does it mean for it to "not be acceptable?" Accepting or not accepting the bug is not an option on the table. It happened. The options you have open to you are to use or not use the freely provided software, or donate or not donate to the foundation providing it. Users cannot be assured that future bugs will not occur. That is an assurance that is not available with most consumer software, and certainly not with software delivered for free by a not-for-profit.
Re:Signal on Android: Images sent to wrong contacts by lwhi on Monday July 26, 2021 @03:06AM (#27956535)
If you are unclear, perhaps it would be useful to ask yourself what you would personally need from a product to consider it 'secure'.
Re:Signal on Android: Images sent to wrong contacts by stathibus on Sunday July 25, 2021 @11:25PM (#27955254)
Yes, Signal is a messaging app whose whole reason for existing is privacy, but it does not actually guarantee any privacy features; it just tries its best. Despite this "who cares if it works" premise, they have raised tens of millions of dollars.

I dream of a world where commercial software is held to the same standards as even the lowest quality commercial hardware.

Re:Signal on Android: Images sent to wrong contacts by asdfasgasdgasdg on Sunday July 25, 2021 @11:47PM (#27955408)
Concretely, what would you like to see done? Should the foundation be hit with a fine or a lawsuit for this bug? Would that improve the overall security stance of the public at large?
Re:Signal on Android: Images sent to wrong contacts by stathibus on Monday July 26, 2021 @06:12AM (#27957678)
I would like to see the foundation put their enormous investment into making a product that works correctly.

If that's too much to ask, then they really ought to be more public and forthcoming about the fact that Signal is not actually private or secure.

Re:Signal on Android: Images sent to wrong contacts by tablespoon on Sunday July 25, 2021 @03:36PM (#27952222)
> How can users be assured that this type of issue won't occur again?

By not using software.

And I mean software in general, not this software in particular. You're basically asking for assurance that they won't have any more bugs, but no one can actually provide such an assurance in the real world.

Re:Signal on Android: Images sent to wrong contacts by stathibus on Sunday July 25, 2021 @11:27PM (#27955268)
Yes, they can.
Re:Signal on Android: Images sent to wrong contacts by tablespoon on Monday July 26, 2021 @12:36AM (#27955717)
> Yes, they can.

If they do, they're either incompetent, lying, or building something enormously expensive yet completely impractical for most if not all real world uses.

Re:Signal on Android: Images sent to wrong contacts by stathibus on Monday July 26, 2021 @06:09AM (#27957649)
I don't understand this attitude. Where did we go wrong as a discipline where making products that actually work is such an outlandish proposition? No other consumer product industry would talk like this.
Re:Signal on Android: Images sent to wrong contacts by aeturnum on Monday July 26, 2021 @12:06PM (#27961151)
It comes from the halting problem. People can be more careful writing code, but it is impossible to be certain about all the things code will or won't do. Even very simple programs can have flaws that get found and fixed years later. It happens all the time.

We need to be open and honest about the possibility that our code may act in ways we don't foresee.

Re:Signal on Android: Images sent to wrong contacts by stathibus on Monday July 26, 2021 @12:51PM (#27961750)
If this was actually true, we wouldn't have safety critical software systems that have been running for decades without fatal bugs.
Re:Signal on Android: Images sent to wrong contacts by tablespoon on Monday July 26, 2021 @03:40PM (#27964358)
> If this was actually true, we wouldn't have safety critical software systems that have been running for decades without fatal bugs.

Not hitting a bug is not the same as not having a bug. I'd bet money that whatever system you're talking about has bugs. Plus, the system may be far simpler than you assume.

Re:Signal on Android: Images sent to wrong contacts by tablespoon on Monday July 26, 2021 @10:48AM (#27960061)
> I don't understand this attitude. Where did we go wrong as a discipline where making products that actually work is such an outlandish proposition? No other consumer product industry would talk like this.

Part of it is cost/benefit ratio for the extra effort, part of it is market demands, part of it is lack of technology, part of it is unavoidable stuff like the halting problem.

It's also worth remembering that Signal is developed by a non-profit with a total of 36 staff members (if Wikipedia is correct). That means they have fewer developers, and even fewer Android developers.

Re:Signal on Android: Images sent to wrong contacts by stathibus on Monday July 26, 2021 @12:50PM (#27961733)
This is a messaging app we're talking about here. There's nothing outrageously difficult or complex that hasn't already been done 25 years ago. If 36 people and $100 million in funding is not enough to make a messaging app that doesn't suck, what _is_ required and why is it more than that?
Re:Signal on Android: Images sent to wrong contacts by tablespoon on Monday July 26, 2021 @03:31PM (#27964221)
> This is a messaging app we're talking about here. There's nothing outrageously difficult or complex that hasn't already been done 25 years ago.

If you think it's so easy, be your own change and do it, and then we can judge the results.

> If 36 people and $100 million in funding is not enough to make a messaging app that doesn't suck, what _is_ required and why is it more than that?

You're assuming there's a solution of a certain form to get you what you want, but maybe it's your assumption that's wrong.

I mean, there are formally verified systems that might be like what you're asking, but they're both 1) very expensive, 2) extremely feature poor.

Re:Signal on Android: Images sent to wrong contacts by stathibus on Monday July 26, 2021 @08:55PM (#27967401)
I'm busy, but tell you what, I'll do it for only $75 million. Maybe I should launch a Kickstarter.
Re:Signal on Android: Images sent to wrong contacts by lwhi on Sunday July 25, 2021 @04:27PM (#27952631)
I disagree. If that really is the choice, they should drop the secure moniker without further debate.

--

If you produce a product that claims to be secure, the onus is on you to back up those claims.

Off the top my my head there are many ways to implement measures that can help to encourage security going forward.

One of the benefits of coding in the open, and ascribing to opens standards and protocols is transparency and the ability for all to interrogate the code.

Can that work? It's obviously partly also down to the culture of the product team. As another poster in this thread has highlighted, the commit messages are terse and not as helpful as they could be. Perhaps more openness re. intention would help.

Also, why are we finding out about this bug over 7 months after it was reported? Transparency regarding vulnerabilities needs to be at the forefront of the products communications if the team really are serious about security.

In terms of isolating bugs; what kind of testing is in place. TDD, functional testing, beta testing?

There are so many avenues which _could_ be discussed in relation to my initial question.

Your response, is unfortunately not providing anything helpful.

Re:Signal on Android: Images sent to wrong contacts by asdfasgasdgasdg on Sunday July 25, 2021 @04:50PM (#27952798)
> One of the benefits of coding in the open, and ascribing to opens standards and protocols is transparency and the ability for all to interrogate the code.

They already do all of those things. https://github.com/signalapp/Signal-Android

Re:Signal on Android: Images sent to wrong contacts by hellcow on Sunday July 25, 2021 @05:47PM (#27953222)
In word but not in spirit. They stopped updating their repo for an entire year while integrating a crypto shitcoin in secret.

These actions betray trust, and trust is Signal's entire reason for being.

Re:Signal on Android: Images sent to wrong contacts by lwhi on Sunday July 25, 2021 @06:52PM (#27953697)
You need to reread my post.

The situation is far more complicated than your link to the GitHub repo would indicate.

Re:Signal on Android: Images sent to wrong contacts by hnarn on Sunday July 25, 2021 @05:10PM (#27952949)
Users are not entitled to a guarantee that this will never happen again, because Signal is free and open source software provided free of charge and without warranty.

The Android app is GPL licensed. The license clearly states:

> For the developers' and authors' protection, the GPL clearly explains that there is no warranty for this free software.

If you feel let down by open source software, you have many options available to you to make that software more reliable.

Re:Signal on Android: Images sent to wrong contacts by ghoward on Sunday July 25, 2021 @05:53PM (#27953278)
Moxie Marlinspike is famously belligerent against Signal forks, so no, the license does not really help here.
Re:Signal on Android: Images sent to wrong contacts by sneak on Sunday July 25, 2021 @05:57PM (#27953302)
It does. You are allowed to fork or reimplement the Signal client, and even distribute it, with the official Signal servers configured, so long as you do not infringe the Signal trademark.

They don't like forks using their servers, but it's the users who connect to their servers, not the fork publisher. Those users are permitted to connect via the TOS, which is independent from the GPL.

Re:Signal on Android: Images sent to wrong contacts by lwhi on Sunday July 25, 2021 @06:58PM (#27953729)
They also refuse to open source their server software.

This is the problem in my mind. Open source in words, but not spirit.

Re:Signal on Android: Images sent to wrong contacts by sneak on Sunday July 25, 2021 @07:13PM (#27953823)
Not only is it false as has already been pointed out, it doesn't matter at all. There is nothing stopping them from silently running a fork.
Re:Signal on Android: Images sent to wrong contacts by lwhi on Sunday July 25, 2021 @07:27PM (#27953895)
As far as I'm aware, I have to use the official server if I wish to communicate via the platform.

If this isn't true, I'd be very interested to learn more.

Re:Signal on Android: Images sent to wrong contacts by h_anna_h on Sunday July 25, 2021 @07:07PM (#27953783)
Re:Signal on Android: Images sent to wrong contacts by lwhi on Sunday July 25, 2021 @07:26PM (#27953890)
So are you telling me I can run my signal server and use it to communicate with others on the signal network?
Re:Signal on Android: Images sent to wrong contacts by growse on Monday July 26, 2021 @04:20AM (#27956999)
You can run your signal server and use it to communicate with others on your signal network.

The openness or otherwise of the code has literally nothing to do with the terms of use of any service being run.

Re:Signal on Android: Images sent to wrong contacts by lwhi on Monday July 26, 2021 @07:05PM (#27966583)
No.

The product _is_ the network. By restricting access to the network, access to the product is also curtailed.

Re:Signal on Android: Images sent to wrong contacts by growse on Tuesday July 27, 2021 @05:01AM (#27970238)
You originally asked about running your signal server. Now you're talking about the network that's hosted through Signal Inc's servers.

So what's your point? Do you think everyone should have a right to connect to their servers however they like, and the service operator can't exert any control over that?

Re:Signal on Android: Images sent to wrong contacts by h_anna_h on Sunday July 25, 2021 @07:28PM (#27953897)
I am telling you that "They also refuse to open source their server software." is false.
Re:Signal on Android: Images sent to wrong contacts by chithanh on Sunday July 25, 2021 @07:52PM (#27954048)
Signal typically delay releasing the server source code, so the latest version of the server is not open source. In one case it took them almost a year (no public commits between 20 April 2020 and 6 April 2021).

https://github.com/signalapp/Signal-Android/issues/11101#iss...

Among the official reasons given was staying ahead of spammers. In this instance it was also speculated that the payment function which they were building into the server was to remain secret.

https://github.com/signalapp/Signal-Android/issues/11101#iss...

[dead]
Re:Signal on Android: Images sent to wrong contacts by h_anna_h on Monday July 26, 2021 @03:39PM (#27964344)
Are you trying to subtly accuse chithanh of something? If so I would request that you do it explicitly instead of in a passive-agressive way.

Regardless, their post contained only factual statements relevant to the discussion. I noticed no entitlement.

Re:Signal on Android: Images sent to wrong contacts by chithanh on Sunday July 25, 2021 @10:43PM (#27954990)
If you call it a "whim" if I point out that the latest version of the Signal server is proprietary software most of the time then so be it.

Or maybe you are referring to the other commenters who were entitled to expect that the one critical task of a crypto messenger is ensuring the confidentiality of communication, which has been broken by this bug (and at least one similar bug before it, https://github.com/signalapp/Signal-Android/issues/7909 ).

You can both be grateful that Signal is free and at the same time call out shenanigans of its owners. Just saying.

[dead]
Re:Signal on Android: Images sent to wrong contacts by remirk on Monday July 26, 2021 @01:32AM (#27956015)
What a buzz kill. If I understand you correctly we shouldn't have expectations or constructive criticism on stuff we don't directly pay money for. I think that's nonsense. Does this only apply to certain opinions?

You are not paying money for Signal. But by using it, and getting others to use it, you are definitely improving their position on the market by helping them become a monopoly. Money isn't everything.

Re:Signal on Android: Images sent to wrong contacts by tablespoon on Monday July 26, 2021 @03:39AM (#27956729)
> What a buzz kill. If I understand you correctly we shouldn't have expectations or constructive criticism on stuff we don't directly pay money for. I think that's nonsense. Does this only apply to certain opinions?

You can have constructive criticisms, but they have to actually be reasonable and constructive. It's not reasonable or constructive to expect their software to never have bugs (i.e. be outraged when they have one); to rag on them because they didn't fix some bug more quickly than they may have been able to; to throw around labels like "proprietary" just because they don't release something on your schedule; to be bitter that their vision is not your vision (e.g. they won't implement some client or server feature you want), etc. All of that is in this thread.

Signal, for whatever reason, seems to attract a lot of entitled complaints like the ones I enumerated. I don't know exactly why, but it probably involves some combination of contrarianism, being in popular software category, and people who want to feel better for having picked a different team.

Signal isn't perfect software for me: I really wish they had an unencrypted message export feature, for instance. But I understand that doesn't fit into their vision, and instead of bitching about it, I just have it on my todo list to write my own (and have done some preliminary work on it).

> You are not paying money for Signal. But by using it, and getting others to use it, you are definitely improving their position on the market by helping them become a monopoly. Money isn't everything.

What now? Signal is nowhere near being monopoly, and even if they were, they're a non-profit, which makes the idea far less threatening.

Re:Signal on Android: Images sent to wrong contacts by chithanh on Monday July 26, 2021 @10:12AM (#27959565)
> It's not reasonable or constructive to expect their software to never have bugs

I think nobody demanded anything of that sort, that is just a strawman. What was actually demanded is that priority of such bugs be raised, and perhaps users be adequately warned about known defects that may compromise the confidentiality of their messages.

That Signal developers didn't have an idea what was going on for 6 months? And then it turned out to be similar to that other stale/invalid database bug where messages were sent to unintended recipients? Back then fixing only the bug at hand but not taking steps to ensure that the type of bug (wrongly matching expired message IDs to existing messages) won't happen again? Doesn't paint them in the best light.

> to throw around labels like "proprietary" just because they don't release something on your schedule

I throw around the label "proprietary" because software which doesn't come with source code is in fact, proprietary. If Signal pushes new server code to production and keep its source to themselves, calling that still "open source" requires serious mental gymnastics.

> Signal, for whatever reason, seems to attract a lot of entitled complaints like the ones I enumerated.

No, besides your strawman the other commenters were all reasonable and constructive.

Re:Signal on Android: Images sent to wrong contacts by tablespoon on Monday July 26, 2021 @11:05AM (#27960296)
> I throw around the label "proprietary" because software which doesn't come with source code is in fact, proprietary. If Signal pushes new server code to production and keep its source to themselves, calling that still "open source" requires serious mental gymnastics.

It comes with source code, just not on your time-frame. That's still open source.

And if that's unacceptable to you, just use something else.

>> Signal, for whatever reason, seems to attract a lot of entitled complaints like the ones I enumerated.

> No, besides your strawman the other commenters were all reasonable and constructive.

We're going to have to agree to disagree there.

But if you want to (for instance) implement a plan so we can be "assured that this type of issue won't occur again" in Signal (https://news.ycombinator.com/item?id=27951759), be my guest. Or maybe you could develop a fork of it and show us your vision for it (including a source release schedule that's satisfying to you, a federated protocol, and all the the other demands in ITT).

Re:Signal on Android: Images sent to wrong contacts by chithanh on Tuesday July 27, 2021 @02:43PM (#27975975)
> We're going to have to agree to disagree there.

Everyone can of course have their own opinions. But they cannot have their own facts, a discussion does not work that way.

Whether one considers some statement as entitled, that is an opinion and we can disagree about this.

But whether a program is open source or not is a fact. It doesn't matter if the source code is going to be released a day or a year after the Signal server has been pushed into production, at that very moment the program is not open source. Your comment about my time-frame is irrelevant. In the github issue 11101 link I posted above is Moxie admitting to running versions of the server that are ahead of the public git repository. These are factually closed source, and you continuing to argue against that fact doesn't reflect well on you, nor the ability to have serious discussions with you.

Re:Signal on Android: Images sent to wrong contacts by h_anna_h on Wednesday July 28, 2021 @12:21AM (#27980221)
To be pedantic, only the ones that posses the binary need the source code for something to be open source. Since they did not publish the binary and since they have the source code we could say that it is actually open source software.
Re:Signal on Android: Images sent to wrong contacts by lwhi on Monday July 26, 2021 @03:13AM (#27956579)
No, you are utterly incorrect.

If you produce a product that people depend on — and through which, you either intentionally or inadvertently cause damage to your user base — they have every reason to be upset.

If the product is open source, the user base luckily has the option to fix the problem.

This isn't true with Signal's model.

Re:Signal on Android: Images sent to wrong contacts by sneak on Monday July 26, 2021 @09:50AM (#27959322)
You seem to be confusing open source for a federated protocol.

Signal is not federated, as an explicit design decision.

The source code for the server and the client are both free software.

Re:Signal on Android: Images sent to wrong contacts by nerbert on Sunday July 25, 2021 @02:50PM (#27951816)
‘Many forms of secure messaging systems have been tried, and will be tried in this world of sin and woe. No one pretends that Signal is perfect or all-wise. Indeed it has been said that Signal is the worst messaging except for all those other forms that have been developed from time to time…’

Winston S Churchill, 11 November 1947

Re:Signal on Android: Images sent to wrong contacts by geofft on Sunday July 25, 2021 @03:41PM (#27952265)
Sure, but there's a small theoretical difference with democracy. You have to live under some system of government. You don't have to use a secure messenger. You can choose to have sensitive conversations in person or not have them at all.

I agree that in practice, a lot of people are going to use their phones for relatively sensitive conversations, and in practice, Signal remains the best choice for doing so. But there are a few real threat models where the options aren't Signal vs. SMS / Google Chat / Discord / etc., the options are Signal vs. nothing. For instance, you could be a journalist deciding whether to ask clarifying questions to a government whistleblower via Signal or meet up with them in a park. You could be an activist/demonstrator under a repressive regime deciding whether to coordinate some action this weekend via Signal or hold off on it entirely and tactically preserve your freedom. And so forth.

For those people, if (and to be clear this is a big "if," while this issue is one serious piece of evidence it is nonetheless inconclusive) Signal isn't trustworthy, it doesn't matter if Signal is the least-bad of the options.

(Also, it's not like Signal is the only e2e messenger around. There's iMessage/FaceTime, for instance. Churchill's claim was that the abstract idea of democracy was good, not that any concrete implementation like the British government was good.)

Re:Signal on Android: Images sent to wrong contacts by godelski on Sunday July 25, 2021 @04:44PM (#27952765)
> You can choose to have sensitive conversations in person or not have them at all.

I don't think this is fair. Most of the solution to this is "not having them at all." That's not a good solution and still doesn't solve your problem since you can still be listened to.

> There's iMessage/FaceTime, for instance.

Which also has gotten in trouble recently with Pegasus as there was a 0-click exploit in iMessage. Honestly, that is a far more serious issue than the one here. That being said, I still trust iMessage and that the devs are doing the best that they can. I just recognize that security is difficult and will always be a cat and mouse game. There is no such thing as perfect security.

Re:Signal on Android: Images sent to wrong contacts by geofft on Sunday July 25, 2021 @05:00PM (#27952871)
I think what I'm trying to get at is that incorrectly believing you have access to a secure messenger can be worse than acting as if you don't, if those are your options. The whistleblower might choose not to make contact, but if the alternative is making contact and immediately going to prison (because someone else on your contact list saw a classified screenshot from you and told the authorities), maybe that's better. The activists might choose not to protest, but if the alternative is being caught before they even start their protest (because your group was forwarding a little advertisement image or annotated map around among trusted people, and someone untrusted got it), maybe that's better.

Take Reality Winner, for instance (the mechanics of that case were entirely unrelated to secure messengers, but it makes a relevant example overall). The effect on the world of her whistleblowing seems to have been minimal, and the cost to her was significant. Was it worthwhile? If she had been told the risks of the government identifying her were higher and decided not to leak anything, wouldn't that have been a better outcome?

I'm not saying there's perfect security. Vulnerable users absolutely need to be making risk assessments and deciding what they're comfortable with, and we should be clear nothing is risk-free. I'm just saying my sense of Signal's risk, in absolute terms, is higher than it was before I learned about this, and that matters to vulnerable users, not just the fact that it probably remains the lowest-risk messenger of the various options.

I agree with you overall, and the Pegasus exploit does reflect badly on Apple (and probably should reflect more badly on them than seems to be happening).

Re:Signal on Android: Images sent to wrong contacts by godelski on Sunday July 25, 2021 @05:20PM (#27953029)
> I think what I'm trying to get at is that incorrectly believing you have access to a secure messenger can be worse than acting as if you don't, if those are your options.

For the average person, I do not believe this is true. For the non-average person, I believe you are correct but most of these people are aware and should be constantly trained.

I'm not saying you're wrong, I'm saying that there are two different conversations to be had and we need to know which one we're having. To me it looks like Signal is about as good as you get without loads of complication and for what it is meant to do.

> he Pegasus exploit does reflect badly on Apple

And same with this on Signal. I do believe we should hold these companies to high standards. But the point I'm trying to make is that these also aren't reasons to abandon the platforms completely (as many users are suggesting here). That's throwing the baby out with the bathwater.

Re:Signal on Android: Images sent to wrong contacts by geofft on Sunday July 25, 2021 @05:42PM (#27953175)
Yeah, to be clear, I only mean this from the point of view of non-average Signal users.

It's a little weird that Signal is both the "baseline security that everyone should have" product (a la HTTPS or WPA2) and the "you are literally hiding from the government" product. Of course, the target market for the latter, when you are not another government yourself, is by definition mostly illegal activity (whether or not the laws are justifiable), so it makes sense that there isn't a good product just for that.

In this particular case, it also complicates things that people who are literally hiding from the government also have normal ordinary conversations with lots of people, and it helps things for those ordinary conversations to happen on Signal, but this bug is particularly bad if you do that.

(I'm also not really sure where, say, people buying recreational drugs fit on the "average"/"non-average" axis. Is it a reasonable precaution to not text incriminating information to your drug dealer over Signal? It feels like it shouldn't be necessary, but I can see the argument for it.)

Re:Signal on Android: Images sent to wrong contacts by helmholtz on Sunday July 25, 2021 @03:58PM (#27952391)
You make some fair points. But even from the eyes of those people, what is the alternative? Is iMessage guaranteed to not have any hidden exploits out there? And on the flip side, what do they lose out on by only having those conversations in person? Well, I'd argue that their world becomes a lot smaller, and there sources are instantly at a higher risk.
Re:Signal on Android: Images sent to wrong contacts by geofft on Sunday July 25, 2021 @04:11PM (#27952509)
If iMessage were sending photos to the wrong people (even with extremely low probability) for over half a year, there would be serious negative publicity to Apple for it, even if they had never implemented end-to-end encryption. Apple also has more software testers and more willingness to use telemetry. So while there are no 100% guarantees, I think the incentives are aligned with iMessage at least as well as they are with Signal.

Apple suffered negative publicity from the 2014 iCloud photo leaks, even though those were "just" phishing and not a vulnerability/bug in the strict sense. Tim Cook had to give statements to the media, and in fact Apple stepped up its phishing protection by pushing two-factor authentication and notifying users about additional iCloud logins.

Re:Signal on Android: Images sent to wrong contacts by okdjnfweonfe on Sunday July 25, 2021 @02:55PM (#27951843)
Probably by installing some hardened memory on your phone to prevent cosmic bitflips or the such.

Unless you are going to go to NASA lengths of hardware reliability, you can't really hope much for the software that has to deal with the issues of... how many different android phones are there?

Re:Signal on Android: Images sent to wrong contacts by geofft on Sunday July 25, 2021 @03:34PM (#27952211)
The available evidence indicates that this was due to a logic error, not to cosmic rays and/or Android ecosystem diversity.
Re:Signal on Android: Images sent to wrong contacts by chithanh on Sunday July 25, 2021 @08:01PM (#27954086)
> How can users be assured that this type of issue won't occur again?

Actually, this very type of issue (sending messages to wrong recipients due to stale/invalid database entries) has occured previously.

https://github.com/signalapp/Signal-Android/issues/7909

Re:Signal on Android: Images sent to wrong contacts by goodpoint on Sunday July 25, 2021 @04:19PM (#27952569)
> How can users be assured that this type of issue won't occur again?

By writing code defensively. Despite the other comments, it's possible.

The key is to be redundant: for example, off-by-one errors are very common when accessing an set of indexed items by number.

Yet you can split the set (e.g. an array) in multiple ones to make it more unlikely that you pick the wrong item (e.g. picture vs users).

You can also "tag" the outgoing image with some attributes, e.g. the recipient and a sent/not-sent flag.

You can cross-check and stop if something is inconsistent. Many other things are possible e.g. to protect from RAM bit flips.

It's not a matter of language or tooling, it's a matter of mindset.

Re:Signal on Android: Images sent to wrong contacts by eganist on Sunday July 25, 2021 @04:25PM (#27952613)
> By writing code defensively. Despite the other comments, it's possible.

I'm going to tack onto this and suggest that signal drastically slow down the pace of feature development. They don't have the same profit motivations other companies have. The messaging market, at least in its current state, is largely known. These both give Signal an advantage in that they can slow down and harden the product while baking security into their DevOps practices as a first class citizen.

Tl;dr: signal needs to slow down.

Re:Signal on Android: Images sent to wrong contacts by renewiltord on Sunday July 25, 2021 @03:48PM (#27952322)
The answer is that you can’t be assured. Act as you will with that info.
Re:Signal on Android: Images sent to wrong contacts by rattray on Sunday July 25, 2021 @09:27PM (#27954540)
They could choose to use a less transparent company's software, so that they never become aware of rare issues like this in the first place?
Re:Signal on Android: Images sent to wrong contacts by reinforcedpaper on Sunday July 25, 2021 @03:33PM (#27952204)
From the explanation of the bug on github it seems to me like this is a client-side database issue and nothing was actually leaked. Database ids were reused so random images that were previously received were displayed in newly received messages.

Is this correct? If it is then it's probably worth mentioning.

Re:Signal on Android: Images sent to wrong contacts by tgsovlerkhgsel on Sunday July 25, 2021 @04:31PM (#27952658)
My understanding is that the database issue caused your client to send pictures A, B and C to person X, when you were trying to send picture C to person X (where A and B are pictures that were previously sent to someone else).
Re:Signal on Android: Images sent to wrong contacts by reinforcedpaper on Sunday July 25, 2021 @04:43PM (#27952756)
The person reporting the issue specifically said that they couldn't find those pictures on their phone and don't remember ever sending them to anyone.

The recipient also wouldn't be able to find those images anywhere else because they have chat trimming enabled. The result is that because a newly received message happened to share the id of an old deleted message, the new message is now displaying pictures from the old message.

This does require the recipient to have received those pictures and also not remember them but I believe it is easier to forget a random picture you received than one you sent.

Again, this is me speculating with very limited knowledge of client internals but it makes sense to me. I would like to see a developer confirm this.

Re:Signal on Android: Images sent to wrong contacts by nathan_phoenix on Sunday July 25, 2021 @03:23PM (#27952106)
> we were able to get a fix out very quickly.

I'm not sure if 8 months can be categorized as fast... The issue was posted on Dec 4, 2020, and the fix (5.17) was released on July 21.

Also, sounds like quite a big issue considering that Signal is all about privacy...

Re:Signal on Android: Images sent to wrong contacts by hutzlibu on Sunday July 25, 2021 @04:07PM (#27952471)
Selective quoting?

"As soon as we were able to pick up a scent, it was all we worked on, and we were able to get a fix out very quickly."

Re:Signal on Android: Images sent to wrong contacts by nathan_phoenix on Sunday July 25, 2021 @04:27PM (#27952626)
Oh sorry, I interpreted it differently. Tho it still doesn't change anything, they prolonged investigating this issue for months and only put mayor work behind it when they "pick[ed] up a scent on it". Although they knew about it from day one (one Signal staff replied on the same day the issue was posted).
Re:Signal on Android: Images sent to wrong contacts by hutzlibu on Sunday July 25, 2021 @05:06PM (#27952921)
Yeah but he explained, that they could not track down the bug, without having the luxory of default user tracking and metrics. So what can you do, when you have a non reproducible bug, but limited ressources(and other problems around)? You wait for the bug to show up again and then have more data to work with.
Re:Signal on Android: Images sent to wrong contacts by saurik on Sunday July 25, 2021 @08:04PM (#27954113)
What you do is you tell everyone about the issue so they can take the appropriate steps to protect themselves, whatever that might be (don't send sensitive photos, don't use Signal to do it, only use Signal on iOS, etc.); they did not seem to do that.
Re:Signal on Android: Images sent to wrong contacts by hutzlibu on Monday July 26, 2021 @04:12AM (#27956933)
Yes, this is a valid point.

I only referred to the actual bug fixing.

Re:Signal on Android: Images sent to wrong contacts by eganist on Sunday July 25, 2021 @03:47PM (#27952315)
Question: do you guys have a software or product security team? I suggested the roles to workwithus @ Signal on 5/18/2018 and have never seen a public follow-up in the form of career postings.

Asking because such a team may be best equipped to serve as both the support and internal accountability function for such while minimizing business conflicts when engineering is facing challenges integrating security into DevOps natively.

At this point, it's probably warranted; the last time I asked was when Signal was seeing its spree of XSS defects in the desktop app. If Signal has one, a simple "yes" will suffice, but without a reply, I have to assume not.

Re:Signal on Android: Images sent to wrong contacts by azornathogron on Sunday July 25, 2021 @05:10PM (#27952947)
Given Signal's raison d'être, I would think nearly their entire team is the "security team".

I'm not being entirely facetious either - security is the USP of the product, I really would expect security knowledge and a feeling of responsibility for the product's security to be pervasive throughout the whole team.

Re:Signal on Android: Images sent to wrong contacts by tylermenezes on Sunday July 25, 2021 @03:51PM (#27952349)
> we were able to get a fix out very quickly.

Is 6 months really what Signal considers quick for a bug that leaks private data?

Re:Signal on Android: Images sent to wrong contacts by hutzlibu on Sunday July 25, 2021 @04:07PM (#27952467)
Selective quoting?

"As soon as we were able to pick up a scent, it was all we worked on, and we were able to get a fix out very quickly."

Re:Signal on Android: Images sent to wrong contacts by tylermenezes on Sunday July 25, 2021 @05:08PM (#27952938)
It's not at all selective. This should have been "all they worked on" from the moment they got several confirmations, not from the moment people beat them over the head with data. If they couldn't fix it they should have pulled the app.

This is a company that aggressively markets itself to people needing privacy, and mistakes can ruin lives. And before you say it, they have tens of millions of dollars in funding.

Re:Signal on Android: Images sent to wrong contacts by hutzlibu on Sunday July 25, 2021 @05:17PM (#27953001)
Well yes, maybe they should have put more people on it, from day one. But even though they have solid funding, doesn't mean they can throw it out the window.

And non reproducible bugs can be hard, even when you throw money at them.

But your quote was almost a textbook example of selective quoting, because you said, that they said they did a quick fix, when it really took over 6 months. But they did not say this - they said "once they pick up the scent" they delivered a quick fix. This is something very different.

Re:Signal on Android: Images sent to wrong contacts by tylermenezes on Sunday July 25, 2021 @07:00PM (#27953736)
"But even though they have solid funding, doesn't mean they can throw it out the window."

This is a product which is advertised as private, marketed extensively toward people requiring privacy. Knowing they're accidentally sending images to the wrong people is a HUGE, priority 1 problem.

Re:Signal on Android: Images sent to wrong contacts by hutzlibu on Monday July 26, 2021 @05:14AM (#27957325)
"Knowing they're accidentally sending images to the wrong people is a HUGE, priority 1 problem."

It is. But I have no insight in all the other problems and bugs they have. Do you? There is never a guarantee of total safety. So focusing all the ressources on one problem that happens extremeley rarely and miss out a bigger problem, that affects millions? But I don't know if this was the case here. Might also be neglect or not wanting to spread the image of Signal as being non-secure, while in a path of growth.

Re:Signal on Android: Images sent to wrong contacts by nathan_phoenix on Sunday July 25, 2021 @04:28PM (#27952642)
Does it change anything tho? They prolonged investigating this issue for months and only put mayor work behind it when they "pick[ed] up a scent on it". Although they knew about it from day one (one Signal staff replied on the same day the issue was posted).
Re:Signal on Android: Images sent to wrong contacts by miken123 on Sunday July 25, 2021 @03:31PM (#27952183)
I find this quite concerning and am really wondering if there are any privacy advantages to Signal if these things happen.

Could you say something on:

1. Have any defend in depth measures been applied in the Android and other clients to make sure this issue does not happen again? E.g., an additional check when sending/encrypting a message to make sure it is absolutely meant for the person it is being send to? 2. Why did it take 8 months to fix this if some users could reproduce it consistently?

Re:Signal on Android: Images sent to wrong contacts by GekkePrutser on Sunday July 25, 2021 @06:48PM (#27953674)
One thing I wonder is: how could this happen at all? Considering the E2E Encryption in place, I would expect the incorrect recipient simply wouldn't be able to decode the image considering they never have exchanged keys with the sender?
Re:Signal on Android: Images sent to wrong contacts by runarberg on Sunday July 25, 2021 @06:55PM (#27953713)
Not a signal developer, but I would imagine it would be fairly simple that the same bug also encrypted the message with the eventual receiver’s key (as opposed to the intended receiver’s key). Resulting in a message which the eventual receiver could decrypt but not the intended receiver.
Re:Signal on Android: Images sent to wrong contacts by alfiedotwtf on Sunday July 25, 2021 @07:00PM (#27953744)
"How could this happen at all"

> I remember before Jellybean Android, sending SMS would break up my message and send it to multiple people, and the Android alarm clock would drift by hours.

So how could this happen? Because software is hard.

Re:Signal on Android: Images sent to wrong contacts by stathibus on Sunday July 25, 2021 @11:29PM (#27955284)
Its not hard - its bad. Do better.
Re:Signal on Android: Images sent to wrong contacts by spicybright on Sunday July 25, 2021 @03:22PM (#27952094)
Just wanted to say, thank you so much for your contributions. Signal is an amazing product, and things like these happen to the best of projects.
Re:Signal on Android: Images sent to wrong contacts by saurik on Sunday July 25, 2021 @08:03PM (#27954101)
Not mentioning in this comment when the issue was fixed--two weeks ago in the code and days ago in production--is extremely dishonest. I have been contacted by literally everyone I have sent this to saying something akin to "dude says it was fixed quickly but they just didn't close the issue" despite my message with the link saying (exactly) "<- issue opened on december 3rd and only fixed last week", making me have to again point out "closed today, but only fixed in production last week" (fixed in the code two weeks ago, but that doesn't matter much)... at which point they are forced to do a double take and suddenly care.

I have worked on high-impact open source software--the iOS jailbreak ecosystem, writing some of the most core software for it, such as the mechanisms which support runtime code modification and which install the userland--with a much smaller team than Signal, and when you run into serious issues you need to disclose them, and you need to be super honest about the post-mortem. You shouldn't just kind of sweep the issue under the rug in the hope you can fix it before someone notices or it affects enough people to become a PR problem.

(On what is maybe a side note of my thesis here for a moment, but for completeness on the related issue of why I am so dissatisfied with these PR-like responses: you say it is "extremely rare", but not so rare that tons of people aren't reporting the issue happening at least to people they know; this is being used here as an excuse for why it was hard to find and fix, but is then being taken by some as "oh it was also unimportant": issues have to be additionally weighted by their impact, and this bug was clearly critical.)

The equivalent of this sort of thing I have run into is "there is like a one in a hundred thousand chance that you will experience catastrophic data loss from using my software", and I took those issues very seriously, as when you have tens of millions of users that's still a non-negligible number of people in the absolute: I considered every single person who would lose something like their camera roll on their phone to be a crushing defeat that I should internalize and take super personally, as I know the feeling of loss of important information and have enough empathy to assign it to my users.

(Hell: one time I actually hired someone to spend a bunch of time going back and building a tool that would take videos recorded by Cycorder (my video recorder for the original iPhone) that had been damaged by a bug I found in one version of the app that had led to some videos being misrecorded and lost--in a way that I think was even more random than "merely" if the power ran out while recording?--and repair them, to send to the almost no people who had taken videos of their family they realized only after an event weren't playable. This is different, of course, as this was after the fact, but a demonstration of the empathy I feel developers should have for their users: if I can do it with the tiny resources I had... anyone can do it.)

When you find reports of such an issue, you carefully track every single one of them down... but you also have a small time box, past which you need to disclose the issue to everyone: you put a large message on the download link of the product or update the homepage of the app to explain your status finding the issue and asking for help with leads, as it is important that people know that if this could affect them they can mitigate... maybe they don't send photos to anyone they couldn't afford sending to someone wrong, they use a different tool, or they switch to running Signal on iOS.

This doesn't seem to have happened? Hell: if anything, this issue seems to have been sufficiently boring to you that you didn't even close it the second you fixed it or keep people abreast in the issue on GitHub of when they could expect the fix you committed to roll into production. This is both an unacceptable communication style and level of empathy for a product trying to be as important as Signal (though sadly not terribly surprising on either count... it is this same lack of empathy that springs up when Signal has database corruption issues or lacks export tooling or spends its time undermining the wrong opponents or throws in a cryptocurrency--which I should want to celebrate as I am in that space!!--built on DRM tooling and without any warning or thought as to what it means for the one open source secure messenger... sigh).

Re:Signal on Android: Images sent to wrong contacts by bradbeattie on Monday July 26, 2021 @11:24AM (#27960561)
> I was tracking it on a separate issue

Do you mind linking to that issue? Thanks!

[dead]
Re:Signal on Android: Images sent to wrong contacts by jraph on Sunday July 25, 2021 @04:59PM (#27952868)
> Edit: Anyone downvoting this also simply doesn't understand how serious this privacy leak really is. Shame on you too.

Wouldn't showing a warning suggesting not to post sensitive images while the bug is being investigated be better than straight up shutting down the service while solving the privacy issue?

Wouldn't closing the service have made people leave for other (probably worse) services, the one relying on privacy, privacy-minded people and "regular users" alike, and have worse consequences for privacy than this bug?

(not currently a Signal user, and I did not downvote your comment)

Re:Signal on Android: Images sent to wrong contacts by NavinF on Sunday July 25, 2021 @06:18PM (#27953462)
It's pretty much impossible to distinguish rare bugs from user error if you don't have logging/telemetry.