News for hackers. Stuff that matters.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by emerongi on Friday July 10, 2020 @10:30AM (#23791785)
The most popular apps on one of the most popular operating systems just plainly don't even open.

What has this industry become? How are we so goddamn inept at writing software? This is an industry where we can automate testing - not many other industries have this capability - and we still don't have a simple test regime of "check if the app opens" for any of those apps. Somehow, at the most valuable software companies of the world, nobody has set up a system that makes sure that you can't introduce a change that renders these apps unusable?

WHAT THE FUCK.

I have always been afraid of software engineering becoming a trade similar to medicine or law or (regular) engineering where significant barriers will be put up before you can enter the industry, but this sort of shit makes me feel like it could be for the better. I will have to go and get a degree, but that's the price I have to pay I guess.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by dang on Friday July 10, 2020 @05:14PM (#23796542)
> WHAT THE FUCK

Please don't use uppercase for emphasis. If you want to emphasize a word or phrase, put asterisks around it and it will get italicized.

https://news.ycombinator.com/newsguidelines.html.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by rachelbythebay on Friday July 10, 2020 @10:35AM (#23791844)
Years ago, I had one of the employee builds on my company phone, and it picked up an update and would "instacrash" - tap the icon, and it'd die immediately. Crash. Crash. Crash.

A couple of days later I caught up with the people allegedly responsible for this stuff in the bigger review meeting. "Shouldn't you open a SEV because you are shipping stuff that can't possibly work and aren't catching it pre-release?" The response was a lot of hand-waving and stupid manager-speak that boiled down to "no, go away".

I basically wrote them off at that point. If they could act that way and get away with it by way of implicit acceptance from upper management, that's just the way it was going to be.

I see the quality is as high as always.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by fsociety on Friday July 10, 2020 @11:13AM (#23792309)
Yep at such a large company there is such huge variance in quality. Wish you and many others were still here to help fight against this mindset. There is lots of high quality work done here, but it doesn’t matter if we end up with issues like this.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by exikyut on Friday July 10, 2020 @10:57AM (#23792117)
Curiously, this type of handwavy response reveals a not-quite-1:1 mapping between the sort of assertive, pro-admission, fail-forward balance that "move fast, break things" implies for me, and the apparent reality which seems closer to "haha crowdsourced QC go brrrrt"

:(

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by yreg on Friday July 10, 2020 @10:36AM (#23791853)
The apps are broken serverside by Facebook. No amount of testing (automated or not) on the side of the app developers would have prevented this.

Facebook's own apps did not break since they are on the latest version of FBSDK.

What Facebook needs to do is to test whether their changes don't break other people's apps.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by emerongi on Friday July 10, 2020 @10:46AM (#23791967)
1. Server-side APIs can be versioned. If an old version is somehow changed, I would call it plain malpractice and in some other industries your license to practice could be stripped.

2. Client-side SDKs can be designed in a way that even if the server-side changes (which it shouldn't), it does not cause the whole application to crash. This can of course be hard depending at which level the SDK operates and how integrated it is into the app.

3. Are there no contracts between Google/Spotify/etc and Facebook? If I were FB and there were contracts on the line, I would make sure that there is no way something like this can slip through (automated testing).

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by rv-de on Friday July 10, 2020 @11:07AM (#23792233)
> What Facebook needs to do is to test whether their changes don't break other people's apps.

I'd argue this is at the very core of why you test. I mean this problem is as simple as (n+1).m vs n.(m+1) in terms of versioning vs revisioning.

If that is not being tested then I'd say Facebook isn't actually testing at all - at least not in a practically relevant sense ...

... despite the shit-load of YouTube videos from FB devs lecturing about CI/CD and what not.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by jayd16 on Friday July 10, 2020 @12:22PM (#23793118)
Sounds like you have it backwards. They use other people's apps to test whether their changes break Facebook.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by mrtksn on Friday July 10, 2020 @10:50AM (#23792016)
It is not acceptable to have your client crash due to server-side stuff going on. When the server is faulty the client must handle that gracefully, like disabling the functionality or displaying a message about what is wrong if no further use is possible due to the error.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by linux2647 on Friday July 10, 2020 @10:43AM (#23791930)
I disagree. While, yes, Facebook needs to test their SDK, app developers need to build resiliency into their apps to ensure third party dependencies don’t break their app. The developer adopted it into their app; it’s their responsibility to do the proper checks in cases like these where Facebook broke things on their end.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by monocularvision on Friday July 10, 2020 @10:48AM (#23791991)
This is a native SDK that is crashing the process. There is nothing an app developer can responsibly do to prevent or recover from this crash.

Other than remove the SDK, of course.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by hyko on Friday July 10, 2020 @11:39AM (#23792643)
Yes there is: a remote kill switch that prevents the third party SDK from loading. That puts you back in control of the software you’re shipping.

Fool me once, and all that.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by saagarjha on Friday July 10, 2020 @12:01PM (#23792882)
You have to be technically competent enough to know how to dynamically load a framework, though.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by liuliu on Friday July 10, 2020 @01:52PM (#23794256)
And most SDKs are provided as static frameworks. You have to be technically competent to know how to wrap a static framework as dynamic, and then use dlopen to load them properly with a rather high one-time runtime cost. A mess.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by bognition on Friday July 10, 2020 @12:29PM (#23793201)
For a tech company with a multi-billion dollar valuation this shouldn't be insurmountable
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by saagarjha on Friday July 10, 2020 @01:00PM (#23793590)
Facebook knows how dynamic loading works. (At least, I think so…) However, their many clients may not, as a lot are not multi-billion dollar companies.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by XCSme on Friday July 10, 2020 @10:56AM (#23792099)
So there is no way to try {} catch {} it, right?
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by Sephiroth87 on Friday July 10, 2020 @11:00AM (#23792156)
Not in this case, as it's not code explicitly called by the client, but automatically loaded on app launch...
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by saagarjha on Friday July 10, 2020 @12:02PM (#23792892)
Yes, but 1. it’s hard to inject that as the crash happens very early at launch and 2. Objective-C exceptions of this type are not intended to be caught.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by robterrell on Friday July 10, 2020 @12:54PM (#23793516)
That's not strictly true, and anyway it's different for the app developer versus a library provider. If you're making a 3rd party SDK that can throw, you need to make it can catch those throws.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by saagarjha on Friday July 10, 2020 @01:05PM (#23793659)
NSInvalidArgumentException is not intended to be caught. You can, of course, but receiving one indicates a serious run-time error.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by valuearb on Friday July 10, 2020 @11:59AM (#23792865)
If it's an objective C exception, you can catch those with an objective c wrapper function. Ive done that before in my Swift projects.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by ryandrake on Friday July 10, 2020 @05:15PM (#23796560)
> Other than remove the SDK, of course.

Bingo! App developer voluntarily pulled in a dependency which they didn't fully understand. When you bring in a dependency, it's not still someone else's code/problem, it becomes your problem.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by corndoge on Friday July 10, 2020 @10:46AM (#23791959)
Ah yes.

If hacker news goes down while you are writing this comment, it is your responsibility to ensure you can still post your comment despite the service breakage.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by slipheen on Friday July 10, 2020 @10:59AM (#23792138)
Unless your app is designed for browsing Facebook, there's no reason that anything on Facebook's servers should affect if your app works.

Many of the apps crashing are using Facebook for a portion of their app, such as one login option.

Letting that take down the whole app is insufficiently defensive coding, whether in the app, sdk, or glue between them.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by frenchy on Friday July 10, 2020 @11:24AM (#23792435)
> there's no reason that anything on Facebook's servers should affect if your app works.

Absolutely, but the problem is that in order for you to use these features, you're supposed to use the official Facebook SDK. The additional problem, is that Facebook has no interest in defensive coding, because if you're not interacting with Facebook in an app, there's no benefit to Facebook for you using that app at all.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by corndoge on Friday July 10, 2020 @11:19AM (#23792373)
How do you defend against abort() in library code?
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by Nextgrid on Friday July 10, 2020 @11:35AM (#23792577)
Don't include libraries which contain such code?
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by saagarjha on Friday July 10, 2020 @12:03PM (#23792905)
No abort here, the crash is coming from the runtime, which you’re not opting out of if you want your app to work.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by slipheen on Friday July 10, 2020 @06:23PM (#23797273)
Then we can agree the FB sdk should have been better written to avoid this, right?
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by corndoge on Friday July 10, 2020 @06:49PM (#23797490)
Obviously, and now we agree!
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by yreg on Friday July 10, 2020 @10:48AM (#23791980)
So how could the app developers have prevented this, other then not using the SDK? (I'm not advocating for using the SDK.)
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by mattgreenrocks on Friday July 10, 2020 @10:50AM (#23792009)
Would disabling SDK autoinit have fixed this? That was a suggestion raised back in March. Seems like a net win to avoid static initializers in the first place.

(Am not a mobile dev, but it wasn't exactly hard to find that, either).

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by Sephiroth87 on Friday July 10, 2020 @11:03AM (#23792178)
Maybe (although some people report that not working), but not necessarily, as "autoinit" is just an if case checked in the same auto executed code in the Facebook SDK, which could still crash before the flag is checked.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by akerro on Friday July 10, 2020 @05:12PM (#23796519)
Are you telling me that Facebook Inc. has no capacity or ability to test their own, one of the most popular SDKs in the world, in the wild? Like have a single phone connected by USB and open spotify app and simply login after they make a backend change?
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by yreg on Saturday July 11, 2020 @11:58AM (#23803112)
By app developers I mean the consumers of FBSDK, not Facebook.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by liuliu on Friday July 10, 2020 @01:47PM (#23794207)
The truth is, 1st-party apps are well-supported but 3rd-party SDKs provided by these companies, especially the ones don't generate revenues (Facebook SDK, and many others) are simply not well-supported within the organization. They are not dogfooded, they don't develop with the latest and greatest tools available for 1st-party apps, some of them have very spotty CI, and often their release schedule is not as rigorous (many 1st party apps adopted weekly release schedule).
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by nathanyz on Friday July 10, 2020 @03:29PM (#23795365)
I would disagree that the 3rd-party SDKs don't make revenue for Facebook. They likely provide additional targeting and behavioral data that feeds into their giant ad machine and lookalike audiences.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by liuliu on Sunday July 12, 2020 @12:37AM (#23808859)
That is a long chain. Internal promo doesn't work that way. That's why it is easier to get promoted when you work directly on ads.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by tpmx on Friday July 10, 2020 @12:08PM (#23792959)
Maybe don't include the Facebook SDK (Facebook Spyware Development Kit) in your tier-1 app?
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by vsareto on Friday July 10, 2020 @11:32AM (#23792536)
1. Mock dependency

2. Throw exceptions

Don't tell me "No amount of testing" just because you aren't responsible for your own dependencies.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by mschuster91 on Friday July 10, 2020 @11:49AM (#23792754)
You can't mock it, that is the entire point. Simply loading the shared library of the SDK will execute the broken code.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by adamparsons on Friday July 10, 2020 @12:57PM (#23793555)
90% of people in this thread think “native code” is a react plugin
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by vsareto on Friday July 10, 2020 @01:01PM (#23793598)
I don't, but I'm fairly sure there is a solution and others just don't want to try hard enough
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by kerbs on Friday July 10, 2020 @11:29PM (#23799217)
Can validate, no reasonable way.

Removed the SDK myself from a top 100 App Store app.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by vsareto on Friday July 10, 2020 @12:14PM (#23793023)
So an app (which you control), is told to load a shared library, and there's no way to handle that? Even by delaying the loading to only when it'll be used?
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by mschuster91 on Friday July 10, 2020 @01:18PM (#23793840)
It's not "is told", it is "it is writen in the binary itself that the kernel/libc runtime should load the shared library".
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by saagarjha on Friday July 10, 2020 @01:48PM (#23794210)
To be fair, you don't have to do it that way. (Library loading is done by dyld, FWIW.)
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by jasonv on Friday July 10, 2020 @12:14PM (#23793024)
This is the second time.

Recently tested an enterprise marketing app with an SDK ... and we tested if the endpoint wasn't available. Nothing happened -- it worked just fine. Failed quietly and gracefully -- the user would never notice.

"We" know how to do this.

Facebook hasn't done anything to fix this problem since it happened a few weeks ago.

But it's Facebook -- I hope they keep it up. Can't wait for them to AOL themselves.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by layoutIfNeeded on Friday July 10, 2020 @06:56PM (#23797560)
The problem is not that the endpoint is not available, rather that the endpoint is returning garbage on which the parser chokes. Of course you should always write parsing to be 100% resilient against any kind of garbage input (even malicious), but my point is that your marketing SDK could still be a ticking timebomb.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by jasonv on Friday July 10, 2020 @07:19PM (#23797742)
True, yes. But this is for a financial services mobile app... one of the first concerns was the user experience. The org is well versed in the other back-end security and data issues that also have to be looked at.

But if you're Facebook, and you're pushing your SDK as a great solution and it's embedded in high profile apps and you are letting this happen a couple of times, I get to make fun of you. (a dollop of sarcasm, to be sure..)

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by marcinzm on Friday July 10, 2020 @08:08PM (#23798111)
>I have always been afraid of software engineering becoming a trade similar to medicine or law or (regular) engineering where significant barriers will be put up before you can enter the industry, but this sort of shit makes me feel like it could be for the better. I will have to go and get a degree, but that's the price I have to pay I guess.

I can almost guarantee that the programmer who wrote this had a degree and passed a very rigorous testing process to get their job at Facebook. Doesn't mean anything when the company tells them to cut corners to iterate faster.

Stop blaming engineers for the mistakes of management.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by stjohnswarts on Friday July 10, 2020 @08:13PM (#23798131)
Yeah it's not like most programmers wouldn't prefer to be writing good software but the "let the user test it" cycle of quick turnaround sprint culture is always going to have this issue.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by babesh on Friday July 10, 2020 @11:31AM (#23792524)
There is more complexity in this.

Proximate Issues

The app makers cannot easily prevent the crash since it is happening in Facebook provided code. Perhaps the only thing they could do is to code in kill switches. Another possibility would be to modify the Facebook code. That introduces maintainability issues.

The crash happened because of a server side change that triggered roughly the Objective-C equivalent of a null pointer exception.

Objective-C is an old unsafe language.

Ultimate Issues

Client-side libraries have a poor history in the industry. They are often written by server engineers who aren’t expert on the platform.

For instance, if it was really a static load method that called the server, then this was a poor design decision.

Furthermore, weaker server engineers are notorious for breaking backward compatibility. They don’t design nor build in tests to ensure backward compatibility. The backward compatibility must include backward data compatibility.

The above issues are indicative of organizational issues.

Facebook is a little bit of an outlier. It was notorious for badly written client libraries stretching back to the Facebook platform days. The joke was that their libraries may have been written by interns even though so many companies were dependent on them.

The Facebook libraries and the ilk are used for sign on through Facebook and ad attribution. The trade off an app maker needs to make it a whether to run ads on Facebook and whether to support sign in.

Facebook is not the only big company with these issues. Google’s equivalent also crashed albeit at a much lower rate due to a much more convoluted issue.

Apple introduced the Swift programming language to address the deficiencies in Objective-C. That these companies are running into these issues makes me wonder if they never transitioned to Swift. They are certainly way behind the latest version of the libraries.

To summarize, it is a cascade of issues some technical and some organizational rather than a single coding error. These issues span companies.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by saagarjha on Friday July 10, 2020 @12:00PM (#23792873)
> The crash happened because of a server side change that triggered roughly the Objective-C equivalent of a null pointer exception.

> Objective-C is an old unsafe language.

This was a safe crash, not an unsafe one. Swift can and would crash the same way.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by babesh on Friday July 10, 2020 @08:23PM (#23798191)
You can’t safely call a method on a nil value in Swift. You need to explicitly force that in your code with an exclamation point to assume that the variable is not nil.

Looks like the server passed empty value in JSON which got converted to NSNull in Objective-C. It's a common mistake to assume null is returned instead of NSNull.

The Swift equivalent of the JSON library should return nil which you then need to explicitly check for non nilness before using unless you use the unsafe exclamation pint.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by saagarjha on Friday July 10, 2020 @09:04PM (#23798450)

  $ swift
  Welcome to Apple Swift version 5.3 (swiftlang-1200.0.16.15 clang-1200.0.22.41).
  Type :help for assistance.
    1> import Foundation
    2> // IIRC this used to throw an exception.
    3> // Now a respondsToSelector: check is silently inserted and we get a surprise nil.
    4> (Int?.none as AnyObject).count + "call Swift's bluff".count
  Fatal error: Unexpectedly found nil while unwrapping an Optional value: file repl.swift, line 4
  2020-07-10 18:03:43.815959-0700 repl_swift[73029:930570] Fatal error: Unexpectedly found nil while unwrapping an Optional value: file repl.swift, line 4
  Execution interrupted. Enter code to recover and continue.
  Enter LLDB commands to investigate (type :help for assistance.)
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by babesh on Friday July 10, 2020 @09:11PM (#23798487)
You need to call Swift's bluff with AnyObject. That's unsafe and was only necessary to bridge to Objective-C where you can call any method on any object.

I think we are in general agreement?

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by saagarjha on Friday July 10, 2020 @09:20PM (#23798541)
When you write an iOS app you're constantly interacting with Objective-C. The moment you're using JSONSerialization–and unless you're shipping your own JSON parser, you're not avoiding it–you're getting back a nice Any that you are almost certainly going to work with, possibly implicitly, using AnyObject. My point was that switching the SDK to use Swift would not help fix this issue, and I think I've shown that you'd run into similar issues even without the use of the force unwrap operator as you implied previously.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by babesh on Friday July 10, 2020 @09:30PM (#23798600)
Fair enough.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by kobalsky on Friday July 10, 2020 @12:36PM (#23793278)
Google has recently pushed a payload that crashed any app using Google Maps SDK https://issuetracker.google.com/issues/154855417

This one was a good one because the app cache was poisoned so the only solution was to ask customers to reinstall the app (after Google deployed their fix, which took a while) or upload an update that nuked the SDK cache on startup.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by kobalsky on Friday July 10, 2020 @12:31PM (#23793226)
>>> I have always been afraid of software engineering becoming a trade similar to medicine or law or (regular) engineering where significant barriers will be put up before you can enter the industry, but this sort of shit makes me feel like it could be for the better. I will have to go and get a degree, but that's the price I have to pay I guess.

This would still happen because A) the programmers that made this mistake probably have the knowledge to pass any certification exam you can throw at them, B) most of the time we are not just building something that has exploded 1000 times before, we are creating new stuff.

The engineering process was the issue here, and sadly the only way to prevent this is not to make personal barriers of entry higher but to slow down the process with more QA, testing or whatever you can throw at it. In other words, make software more expensive. And keep in mind that this would only give better numbers but it would not solve the issue either (see Boeing 737 MAX).

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by jfkebwjsbx on Friday July 10, 2020 @12:40PM (#23793337)
> A) the programmers that made this mistake probably have the knowledge to pass any certification exam you can throw at them

Very unlikely. You probably don't realize how tough some professional exams are in some fields. We are talking dedicated months of study here.

> B) most of the time we are not just building something that has exploded 1000 times before, we are creating new stuff

Most software out there is just CRUD stuff, not really new stuff...

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by vsareto on Friday July 10, 2020 @11:09AM (#23792249)
>How are we so goddamn inept at writing software?

Wow who would have thought no standards, free access to learning, fake-ass meritocracy, and exorbitant profits and market control would have led to such a thing

Pick a standard, whether it's a degree program, a cert, or apprenticeships. Hurry up! Just give us a solid target to aim for.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by ljm on Friday July 10, 2020 @12:08PM (#23792957)
The fact that so many popular apps have to pull in a full-blown SDK from Facebook to get support for even a subset of its functionality is insane to me, too. That 'log in with Facebook' button on your app comes with an entire suite of stuff that Facebook can use to slurp up any data it wants.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by brink on Friday July 10, 2020 @01:00PM (#23793584)
> I have always been afraid of software engineering becoming a trade similar to medicine or law or (regular) engineering where significant barriers will be put up before you can enter the industry, but this sort of shit makes me feel like it could be for the better.

There's a good chance that the one who wrote this bug had a degree.

Surgeries in medicine still get botched despite all of their degrees and barriers. Degrees don't produce good code, good developers produce good code.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by mushbino on Friday July 10, 2020 @01:19PM (#23793857)
There's no standardized process for producing a "good developer". Every company has a different process and different standards. I think that's a part of the problem and I agree that it's not one academia can solve, but I wonder if there could potentially be another way.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by notJim on Friday July 10, 2020 @12:09PM (#23792963)
These histrionics are ridiculous. There has never been an era in software engineering where people didn't write bugs. There has never been an era where people didn't miss bugs. You can scream and moan at the top of your lungs all you want, but shaming and calling people incompetent does not contribute anything.

> I will have to go and get a degree

Was not aware that having a degree made you immune to writing bugs.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by StreamBright on Friday July 10, 2020 @01:14PM (#23793783)
I try to avoid software in general as much as possible.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by blantonl on Friday July 10, 2020 @10:52AM (#23792043)
Bugs happen. Tests miss edge cases. Shit happens.

This will be a fart in the wind and lessons will be learned.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by emerongi on Friday July 10, 2020 @11:01AM (#23792162)
Maybe lessons will be learned, maybe not.

The industry seems to have very low standards. Let's let these mistakes happen over and over and let's just patch them as we go. No long-term thinking.

Someone should collect all these horrible incidents and start a university course on just plainly what NOT to do.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by Dirlewanger on Saturday July 11, 2020 @10:16AM (#23802369)
Industry has low standards because the users have low standards. If the application doesn't start, they are mildly annoyed and go do something else. Eventually the bug will get fixed and they use it again. This has been the case for like 95% of software written in the past decade.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by blantonl on Friday July 10, 2020 @11:06AM (#23792222)
Some of the very brightest software engineers in the world work at Facebook. As much as I would love to rip on Facebook, I also understand that integrated software development is hard, and I guarantee you that Facebook is "doing it better" than most.

Don't sit in an ivory tower and throw stones in glass houses. Can you guarantee that your own SDLC house is in order? Because it might be, right up until a sneaky edge case nips you in the butt, and then suddenly it isn't.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by emerongi on Friday July 10, 2020 @11:26AM (#23792455)
If an industry leader with "the brightest software engineers in the world" is unable to write their software to a higher than average standard, then I think I am in the very reasonable position to point it out and raise discussion about it. Don't place me in an ivory tower for that.

Why should we just sweep this under the rug and call it a day? There is something very important that can be learned from this. Apparently, FB themselves have not learned, because this is not the first time this has happened. Why was this allowed to happen more than once? Did Apple, Google, Spotify, Facebook etc not take any actions?

"Shit happens" is one way to look at it. Another way is to question whether we as software engineers are really doing our job properly.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by mrep on Friday July 10, 2020 @10:07PM (#23798845)
Why are you so angry about Facebook, Apple, Google, and Spotify having a tiny outage? They are not life saving services and only cause a mild inconvenience when they fail which practically never happens for most people especially compared to "average software".

> FB themselves have not learned, because this is not the first time this has happened.

They have tens of thousands of engineers likely split into hundreds of different teams/microservices focussing on different parts of their software stack. A ton of them are new to it and nobody knows every part of the stack so shit can happen.

What is the biggest engineering organization size you have worked for and what was your uptime?

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by filleduchaos on Saturday July 11, 2020 @09:43AM (#23802148)
> Why are you so angry about Facebook, Apple, Google, and Spotify having a tiny outage?

The linked issue makes it very clear that the "tiny outage" affects literally every app that has the Facebook SDK merely linked, for a frankly dumb reason (static initialization) that they should have learned from the last time it happened.

It's not a SaaS. "Uptime" for a linked library is stupid.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by mattgreenrocks on Friday July 10, 2020 @11:20AM (#23792391)
Let's avoid lionizing/denigrating here.

They're using static initialization and it bit them in the ass again. They should stop using it because it is prone to things like this which result in apps not launching at all. I'd like to see them commit to stop using this method to initialize themselves, and take responsibility for the crashes. Then, IMO, we'd be good.

In a scenario like this, I'd hope they'd want to make this bug's recurrence impossible.

Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by tdrp on Friday July 10, 2020 @06:26PM (#23797303)
It was horrifying to see how many config changes you have to do to basically beg facebook not to send back data to their server. Most of these were hidden in various corners of the documentation and I still suspect there's crap being sent back without permission. I would love nothing more than to disable the SDK entirely but we have a few hundred thousand users logged into our app via Facebook.

Here is our Android config in case anyone's interested:

<meta-data android:name="com.facebook.sdk.AutoLogAppEventsEnabled" android:value="false"/>

        <meta-data android:name="com.facebook.sdk.AdvertiserIDCollectionEnabled"
                android:value="false"/>

        <meta-data android:name="com.facebook.sdk.AutoInitEnabled"
                android:value="false"/>
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by valuearb on Friday July 10, 2020 @12:01PM (#23792886)
Isn't Facebook the place that forces engineers to write code in a open bullpen environment? How can high quality code be written in a madhouse?
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by saagarjha on Friday July 10, 2020 @12:04PM (#23792920)
Bright engineers sometimes do some very stupid, arrogant things.
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by damnyou on Friday July 10, 2020 @12:12PM (#23793001)
The brightness at places like FB tends to be diverted towards making money, not ensuring software quality. (This is also true at places like Apple, just differently so.)
Re:App suddenly crashing on startup due to FBSDKRestrictiveD... by jfkebwjsbx on Friday July 10, 2020 @12:48PM (#23793438)
> Some of the very brightest software engineers in the world work at Facebook

Like they work in many other companies.

In any case, this is not about being bright but about being diligent.