Re:LGTM is a simple pull request approval system for GitHub
by ninjakeyboard on Tuesday July 05, 2016 @11:14AM
(#12036980)
Not talking about the project, but is the term 'LGTM' (looks good to me) used often in tech? I've heard it from Googlers but otherwise haven't really seen the term in tech.
[ Parent
| on HN ]
Re:LGTM is a simple pull request approval system for GitHub
by loeg on Tuesday July 05, 2016 @11:50AM
(#12037221)
Looks Good to Me is commonly used in code review at my employer (not Google).
Re:LGTM is a simple pull request approval system for GitHub
by Kunlun on Tuesday July 05, 2016 @12:00PM
(#12037318)
Same here we are using it for most of our commits. When someone is done with their changes, they issue a PR which is reviewed by one or two team members before being rejected or merged by saying LGTM.
Re:LGTM is a simple pull request approval system for GitHub
by colbyaley on Tuesday July 05, 2016 @12:18PM
(#12037515)
It's been used at companies I've worked at (not Google).
I had a coworker who didn't know what it meant, and somehow assumed it was "Let's Get That Money". So now I think of that every time :)
Re:LGTM is a simple pull request approval system for GitHub
by realityking on Tuesday July 05, 2016 @03:23PM
(#12038852)
For a long time, I actually thought it means "Let's Get That Moving". Still works.
Re:LGTM is a simple pull request approval system for GitHub
by throwanem on Tuesday July 05, 2016 @01:13PM
(#12037953)
Same here, for the same reason. Apparently that's a 50 Cent track - go fig!
Re:LGTM is a simple pull request approval system for GitHub
by etjossem on Tuesday July 05, 2016 @12:55PM
(#12037813)
Depends on the company, but at SendGrid it's standard practice in the code review stage to wait for Looks Good To Me - no more changes needed - before merging.
Much like this submission, our continuous integration system (opsbot) doesn't let you continue through the workflow until you have a "LGTM" comment from another developer. This prevents lone-developer cowboy merges with no review. :)
Re:LGTM is a simple pull request approval system for GitHub
by Larrikin on Tuesday July 05, 2016 @01:26PM
(#12038043)
I had assumed it was very common. The small start up I worked at used it. One of the developers was really fond of using this plugin for all his LGTM comments
https://chrome.google.com/webstore/detail/lgtm/oeacdmeoegfag...
Re:LGTM is a simple pull request approval system for GitHub
by llamataboot on Tuesday July 05, 2016 @11:21AM
(#12037017)
I've always had it as "Looks Good To Merge" -- we use it every day...
Re:LGTM is a simple pull request approval system for GitHub
by ninjakeyboard on Tuesday July 05, 2016 @11:30AM
(#12037088)
it's used more generally than in code. eg design doc review you'd say "LGTM" to say that there are no suggestions.
Re:LGTM is a simple pull request approval system for GitHub
by percept on Tuesday July 05, 2016 @11:34AM
(#12037122)
Let's Get The Manual
Re:LGTM is a simple pull request approval system for GitHub
by mdk754 on Tuesday July 05, 2016 @01:03PM
(#12037866)
Let's get this merged!
Re:LGTM is a simple pull request approval system for GitHub
by agnivade on Wednesday July 06, 2016 @01:57PM
(#12044768)
Yup, its used often. Atleast in my company(not Google), LGTM and SGTM are used pretty commonly.
Re:LGTM is a simple pull request approval system for GitHub
by joshschreuder on Tuesday July 05, 2016 @07:09PM
(#12040171)
I think I picked it up from looking at Angular PRs but have spread it to my team so now we all use it.
Re:LGTM is a simple pull request approval system for GitHub
by krzyk on Tuesday July 05, 2016 @03:27PM
(#12038875)
I also heard Google uses it, in none of my previous employees I've seen it (corporations).
Re:LGTM is a simple pull request approval system for GitHub
by reubenbond on Wednesday July 06, 2016 @10:41AM
(#12043348)
It's common at Microsoft to sign off on a code review with "LGTM".