Re:LGTM is a simple pull request approval system for GitHub
by etjossem on Tuesday July 05, 2016 @12:55PM
(#12037813)
Depends on the company, but at SendGrid it's standard practice in the code review stage to wait for Looks Good To Me - no more changes needed - before merging.
Much like this submission, our continuous integration system (opsbot) doesn't let you continue through the workflow until you have a "LGTM" comment from another developer. This prevents lone-developer cowboy merges with no review. :)
Much like this submission, our continuous integration system (opsbot) doesn't let you continue through the workflow until you have a "LGTM" comment from another developer. This prevents lone-developer cowboy merges with no review. :)