News for hackers. Stuff that matters.
Re:GitHub Copilot X: The AI-powered developer experience by w-m on Wednesday March 22, 2023 @10:26AM (#35261530)
I tried getting myself on the CLI waitlist (https://githubnext.com/projects/copilot-cli/). That they use ffmpeg as the example hits a huge pain point for me. But:

"Next Waitlist by GitHub Next would like permission to: Act on your behalf

Not owned or operated by GitHub"

Why does signing up for a waitlist require me to give permissions to an app to act in my account? An app that isn't even officially from GitHub?

This sets a bad example for permission requests, getting people to just click through the dialog, which requests too much access, and from the wrong domain.

Re:GitHub Copilot X: The AI-powered developer experience by Bedon292 on Wednesday March 22, 2023 @10:32AM (#35261612)
I was wondering the same thing. It seems like it is labeled weirdly since it is part of GitHub, but definitely was triple checking what was going on with that.
Re:GitHub Copilot X: The AI-powered developer experience by envy2 on Wednesday March 22, 2023 @10:34AM (#35261669)
I think this is just a standard API access prompt. The GitHub Next page clearly indicates it is (C) GitHub Inc and the blog post makes GitHub's control clear.
Re:GitHub Copilot X: The AI-powered developer experience by retrocryptid on Wednesday March 22, 2023 @10:43AM (#35261795)
Well. That's what the AI wants you to believe.
Re:GitHub Copilot X: The AI-powered developer experience by madeofpalk on Wednesday March 22, 2023 @11:59AM (#35263084)
> The GitHub Next page clearly indicates it is (C) GitHub Inc and the blog post makes GitHub's control clear.

This is not clear at all. Phishing websites always say (C) Bank of America. That doesn't make it legit.

Re:GitHub Copilot X: The AI-powered developer experience by macNchz on Wednesday March 22, 2023 @10:44AM (#35261807)
It's interesting because the Copilot for PRs preview uses an app that does say "Owned and Operated by GitHub". Probably just an oversight, but I'm pretty sensitive about what access GitHub apps have, especially given the list of major attacks that have happened in recent years that were initiated by someone sneaking malicious payloads in somewhere along the development pipeline.

Curious why they'd use a totally different domain in the first place–how much access do you think you could get to private repos just by cloning that page onto githubfuture.com (available) and spearphishing interesting targets?

Re:GitHub Copilot X: The AI-powered developer experience by w-m on Wednesday March 22, 2023 @10:50AM (#35261912)
Signing up for the technical preview of Copilot Chat also worked as expected, it was just a checkmark and a button on github.com, not even an oauth dialog.
Re:GitHub Copilot X: The AI-powered developer experience by joshmanders on Wednesday March 22, 2023 @10:46AM (#35261847)
> Why does signing up for a waitlist require me to give permissions to an app to act in my account? An app that isn't even officially from GitHub?

Because it uses GitHub's oauth flow, all applications who use this flow show the same stuff.

Re:GitHub Copilot X: The AI-powered developer experience by justin_oaks on Wednesday March 22, 2023 @11:26AM (#35262513)
OAuth allows the use of different scopes for different levels of access. So just because it uses OAuth doesn't mean it has to require major account access.

I assume the problem is that GitHub doesn't have sufficiently granular permissions (OAuth scopes), or that the requesting app doesn't use the correct scopes.

Re:GitHub Copilot X: The AI-powered developer experience by ilaksh on Wednesday March 22, 2023 @10:49AM (#35261887)
There are several CLI programs like this. I built mine before ChatGPT came out so it uses text-davinci-003. It https://github.com/runvnc/askleo If you google for ChatGPT CLI I assume some will come up and those are probably better because they are cheaper and faster.
Re:GitHub Copilot X: The AI-powered developer experience by filmgirlcw on Wednesday March 22, 2023 @10:50AM (#35261909)
It’s officially from GitHub. There is some weird language (that I’ll absolutely pass feedback on to the team), I think because GitHub Next is a different organization from GitHub proper, but I can assure you, this is an official GitHub app.

But I totally agree that this isn’t a great/clear message about where this is from.

Re:GitHub Copilot X: The AI-powered developer experience by madeofpalk on Wednesday March 22, 2023 @11:37AM (#35262727)
I raised this concern before about how unclear this is and the concern was pretty much dismissed https://news.ycombinator.com/item?id=33539150

"Techies" often lament about how silly users are about falling for phishing tricks, but then they also routinely make it so difficult to determine what's legit from what's fake.

Re:GitHub Copilot X: The AI-powered developer experience by BubbleRings on Wednesday March 22, 2023 @11:41AM (#35262789)
This becoming the top thread here might get their attention. You have a very good point.
Re:GitHub Copilot X: The AI-powered developer experience by basch on Wednesday March 22, 2023 @11:55AM (#35263028)
>routinely make it so difficult to determine what's legit from what's fake.

Like the amount of times on my phone where I get prompted for a username and password different from the app im in (to make some kind of connection) but then suppress the url from visibility. An astoundingly poor design choice that has proliferated into every single variant of that user design flow.

Re:GitHub Copilot X: The AI-powered developer experience by cyrusatjam on Wednesday March 22, 2023 @12:20PM (#35263403)
Not to mention, the app you're in can inject JS into the page it renders. Best practice is to open in your default browser and then allow the deeplink in the callback_uri to return you back to the original app
Re:GitHub Copilot X: The AI-powered developer experience by filmgirlcw on Wednesday March 22, 2023 @12:00PM (#35263104)
Totally agree. I did the same double-take with some stuff at Universe and I work here. As Idan said back then, there are lots of reasons that we want Next to be separate from GitHub proper. But you’re absolutely correct that we should make it more clear that anything from Next is not a rogue org and also part of GitHub.

Thanks for the feedback.

Re:GitHub Copilot X: The AI-powered developer experience by xp84 on Wednesday March 22, 2023 @07:40PM (#35268600)
> make it so difficult to determine what's legit from what's fake.

So true. I still think the DNS was one of the only chances to grant, and teach, the ability to confidently make trust decisions in the general population. IDN attacks notwithstanding, it's hard to beat an inspectable string that contains its own trust chain, compared to "app names" that can often be set to the hacker's own choice. Sadly, antipatterns seem more common than useful patterns.

(Antipatterns like using a domain like "talktotacobell . com" (don't visit that) as the site to complete a receipt survey. Or every public school district or even school having a random .com or .org.)

People decided that end users would find an address like xhs.xsd.ed.ca.gov too complicated, yet people found 10-digit completely meaningless telephone numbers perfectly fine for decades.

Re:GitHub Copilot X: The AI-powered developer experience by RulerOf on Wednesday March 22, 2023 @11:06AM (#35262175)
The domain name on that authorization prompt was more than enough to get me to decline.

I wouldn't have hesitated at all if it were at next.github.com.

Re:GitHub Copilot X: The AI-powered developer experience by filmgirlcw on Wednesday March 22, 2023 @11:07AM (#35262191)
Totally get it.

I’ve passed feedback on to the team so (hopefully) the CLI app will be be clearly from GitHub soon (we need to transfer it to the regular GitHub org and then there hopefully won’t be any confusion). GitHub Next exists in a different org from GitHub proper for lots of reasons, but we should definitely make it more clear that those experiments are still from GitHub.

Re:GitHub Copilot X: The AI-powered developer experience by vlovich123 on Wednesday March 22, 2023 @11:22AM (#35262443)
Doing it under a liberated domain under GitHub.com sounds like it would work (still a separate org but it’s a signal that this is from main GitHub)
Re:GitHub Copilot X: The AI-powered developer experience by RulerOf on Wednesday March 22, 2023 @11:54AM (#35263010)
FYI, after digging down a few links from there and winding up at the GitHub Next org page[1], seeing the verified email [email protected] and the official site link to https://githubnext.com was enough validation for me.

Can't wait for Voice Copilot :)

1: https://github.com/githubnext

Re:GitHub Copilot X: The AI-powered developer experience by rjzzleep on Wednesday March 22, 2023 @11:55AM (#35263034)
To me the auth flow looks wrong. The CLI oauth would get act on your behalf, but the website to apply for access should not under any circumstance do that.

Maybe it's just copy and pasted from somewhere, but it looks wrong to me regardless.

Re:GitHub Copilot X: The AI-powered developer experience by Kye on Wednesday March 22, 2023 @12:36PM (#35263611)
It seems like one organization being able to specify a relationship with another, possibly with the ability to set a list of approved permissions, would solve this.
Re:GitHub Copilot X: The AI-powered developer experience by eitland on Wednesday March 22, 2023 @11:35AM (#35262689)
The amount of companies, including serious banks, that doesn't understand this is mind blowing.

Just the other day I had to verify with a Norwegian bank that the KYC (nonsense as usual) that they linked to was actually them and not someone who had gained access to sneak in a link. Because the domain was something completely different.

Re:GitHub Copilot X: The AI-powered developer experience by dheera on Wednesday March 22, 2023 @11:44AM (#35262857)
Time to register a rogue Github Pages site at next.github.com?
Re:GitHub Copilot X: The AI-powered developer experience by filmgirlcw on Wednesday March 22, 2023 @12:24PM (#35263446)
Next.GitHub.com redirects to GitHubnext.com fwiw.
Re:GitHub Copilot X: The AI-powered developer experience by tcbyrd on Wednesday March 22, 2023 @02:45PM (#35265443)
Re:GitHub Copilot X: The AI-powered developer experience by idan on Wednesday March 22, 2023 @12:39PM (#35263653)
Correct! We know this is a terribly confusing thing. Hopefully by the next big launch we can work out a way to have GitHub Next things not bear the "not owned or operated" thing.
Re:GitHub Copilot X: The AI-powered developer experience by Borgz on Wednesday March 22, 2023 @02:52PM (#35265545)
Unfortunately, I think this is another indication of a lack of understanding by GitHub of how their OAuth/GitHub App systems are expected to function by end users.

I'm reminded of this incident [1] from a few months ago. Allegedly, a malicious actor abused GitHub's poorly designed OAuth permissions to obtain up to 500 stars from developers without their consent, all thanks to a "sign in with GitHub" button and a flawed consent screen that did not communicate what the victims were consenting to. Even worse, GitHub allegedly decided to suspend at least one victim's account.

We're left with a number of questions:

1. Why does GitHub give third-party apps permission to star repos when it is apparently against the terms of service to automate such an action?

2. Why does GitHub lump this permission in with public_repo, a scope that grants read and write access to all public repositories? [2]

3. Why does the consent UI for this scope display simply as

    Repositories
    Public repositories
and not even mention that this grants write access unless the user clicks on it? [3] (it also doesn't mention that it gives permission to star repos)

4. Why does GitHub punish victims with account suspension for being tricked into giving consent to malicious apps?

It is good that GitHub is taking some steps to improve account security, such as fine-grained personal access tokens and mandatory 2FA. But these improvements do not seem to be extending to the OAuth system. The GitHub App system, while better in that it has granular permissions, is also flawed with its mysterious "act on your behalf" consent UI. [4] [5]

[1]: https://news.ycombinator.com/item?id=33917962

[2]: https://docs.github.com/en/developers/apps/building-oauth-ap...

[3]: https://news.ycombinator.com/item?id=33919481

[4]: https://github.com/community/community/discussions/37117

[5]: https://github.com/cirruslabs/cirrus-ci-docs/issues/751

Re:GitHub Copilot X: The AI-powered developer experience by localhost on Wednesday March 22, 2023 @10:55AM (#35262010)
While I don't remember to use it (too much AI in too many tools!) Warp has this feature as well "Warp AI". This is what it told me for the demo scenario:

  ffmpeg -i input.mp4 -i watermark.png -filter_complex "overlay=10:10" output.mp4
Bunch of descriptive words too.
Re:GitHub Copilot X: The AI-powered developer experience by darepublic on Wednesday March 22, 2023 @11:17AM (#35262337)
+1 for copilot is good for ffmpeg. Recently did a project involving complicated ffmpeg filters, it could handle them on it's own quite well.
Re:GitHub Copilot X: The AI-powered developer experience by pastor_bob on Wednesday March 22, 2023 @11:18AM (#35262351)
Interesting, how does this know what executables are available on your PATH?
Re:GitHub Copilot X: The AI-powered developer experience by nicky0 on Wednesday March 22, 2023 @11:25AM (#35262501)
I guess since it runs does a shell executable, it can simply examine the path.
Re:GitHub Copilot X: The AI-powered developer experience by Loeffelmann on Thursday March 23, 2023 @06:57AM (#35272776)
It's pretty simple to write your own script in the meantime. I wrote this sometime ago: https://gist.github.com/Loeffeldude/41f3a71570f4bad1aff2749b...