Peacekeeping is not popular in the army, for good reason. They are there to fight wars, not deliver social programs, build nations, or referee conflicts.
If using language like "warfighter" can get the politicians to lay off on using the army for things other than fighting wars, then the clumsiness of the phrase is worth it.
I suspect, though, that this is just more corporate-speak infiltrating the military bureaucracy.
Warfighter makes me think of someone who is empowered. A warrior willingly testing themselves in the harshest conditions imaginable. Fighting against adversity. Not submitting to it.
Your post reminded me of all the videos I watched on this subject. The ridiculousness of it all. A group of marines in Afghanistan who in the process of trying to deliver security to a village end up outside of it on a vantage point, ordering artillery shelling of the same village they are tasked with protecting because tabliban started firing mortars at them from within the village walls.[0]
I can imagine there are a lot of people who might be interested in that, but not in the war fighting. Today those people either don't enlist, or enlist and hate that aspect.
Edit: Ok maybe not what it's for, but the State Department is a better fit. Nobody is ever going to trust a foreign military to do anything good in their country.
Technically, only the Army has soldiers. The non-exclusionary term used to be “men and women in uniform,” but that got tired, so I guess we get “warfighters” now.
In common parlance, a 'soldier' is anybody who is part of a military and an 'army' is any and all military. But I would not expect the Pentagon to be so casual with their use of terms relating directly to their affairs.
The people who serve on ships can become soldiers by consensus.
See, eg: https://foreignpolicy.com/2021/04/19/united-states-afghanist...
Edit: As others have noted, "soldier" is traditionally a term reserved for members of an army. So for anything that cuts across the entire armed forces, you end up with soldiers, sailors, marines, airmen, coast guardsmen, and (of course) guardians (which is, I'm sad to say, the actual term for members of the Space Force). That's unworkably long (and it gets worse if you want to try and find gender neutral phrasing for "airmen" and "coast guardmen"; "airmen, airwomen, coast guardsmen, coast guardwomen" is even more ridiculously unworkable, and "airperson" is just too dumb to contemplate). I think the only reasonable answer is "serviceperson" or "servicemen and servicewomen", but I can't fault people for disliking those. But "warrior", as the article notes, already has incompatible meanings, and "warfighter" isn't much better.
Maybe the real answer is just to adopt the Space Force term for the entire armed forces, and call everyone guardians. (And it kills me that this is, actually, one the better ideas I've heard.)
Soldier to warfighter seems unnecessary.
EDIT: It seems possibly using "warfighter" is more accurate as marines and pilots aren't soldiers?
It's meant to be a blanket term to satisfy categorization from rifle carrying traditional soldiers to drone pilots in an Idaho parking lot.