News for hackers. Stuff that matters.
Re:How to do a code review by aledalgrande on Thursday September 05, 2019 @07:02PM (#20891432)
In the "What Is Not An Emergency?" section:

> It is the end of the day on a Friday and it would just be great to get this CL in before the developer leaves for the weekend.

I laughed out loud because it reminded me of so many times I have seen it happen and then someone had to fix in the weekend.

Who shares the same experience?

Re:How to do a code review by bt848 on Thursday September 05, 2019 @08:43PM (#20892011)
They didn't give the two examples that are most common inside Google: Google I/O is coming up, or annual performance reviews are coming up.

Strangely they also list as "not an emergency" rollbacks of clearly broken code, but that's an exception to review rules inside Google. Anyone can do a pure rollback of a change without getting the approval of the owners of the code, and there are automated tools that will roll back changes that appear to have broken at least 1000 tests, without human review.

Edit: There's even a button right in the code review web UI to roll back a committed change.

Re:How to do a code review by NoodleIncident on Thursday September 05, 2019 @09:18PM (#20892168)
> Google I/O is coming up, or annual performance reviews are coming up.

As long as everyone admits it, sounds like those are actual emergencies :)

Re:How to do a code review by cameronbrown on Thursday September 05, 2019 @09:02PM (#20892094)
> at least 1000 tests

The threshold for this seems at least a little too high, doesn't it?

Re:How to do a code review by bt848 on Thursday September 05, 2019 @09:07PM (#20892115)
They have a lot of tests :-) Abseil-cpp alone has 2400 tests, at least in the open-source tree.

https://github.com/abseil/abseil-cpp/tree/master/absl/base

Re:How to do a code review by sanderjd on Thursday September 05, 2019 @10:10PM (#20892435)
I was thinking low :)
Re:How to do a code review by AnimalMuppet on Thursday September 05, 2019 @08:57PM (#20892078)
Worse: The developer wants to get this checked in before they go on vacation.

And they really want to, because they don't want to have to do a bunch of merges when they come back...

Re:How to do a code review by Glyptodon on Thursday September 05, 2019 @07:22PM (#20891532)
Some places I've worked explicitly won't push/deploy/similar on Friday.
Re:How to do a code review by Gibbon1 on Thursday September 05, 2019 @07:32PM (#20891592)
I've mostly worked for small industrial light manufacturers. First job I worked at they were always late with shipping stuff. And always taking stuff down to the UPS office after hours. After watching this for a few years I got the shop manager to adopt a rule. If it's not ready to be boxed up before lunch, it's not shipping today.

After they started enforcing that they got a lot more productive and started shipping on time much more often. Turns out the mad rush to meet an arbitrary deadline absolutely kills productivity.

Re:How to do a code review by winrid on Thursday September 05, 2019 @11:31PM (#20892787)
Forgive me, I don't understand your last sentence. It sounds contradictory vs "they got a lot more productive".
Re:How to do a code review by Gibbon1 on Friday September 06, 2019 @02:13AM (#20893472)
What would happen is the shop would start thrashing with people switching from one task to another trying to hurry one unit through production. You eat the setup time for each production task for exactly one unit.
Re:How to do a code review by winrid on Friday September 06, 2019 @03:20AM (#20893711)
Yeah, I misread your comment as saying they rushed units in before lunch :D :D
Re:How to do a code review by LanceH on Friday September 06, 2019 @12:23AM (#20893043)
They got fewer returns/defects when they stopped rushing.
Re:How to do a code review by winrid on Friday September 06, 2019 @03:20AM (#20893705)
I realize that now. I initially read it as they rushed to get things done before lunch everyday. Oops!
Re:How to do a code review by Sammi on Saturday September 07, 2019 @06:10AM (#20902874)
Your choices are often between these two:

1. Higher throughput, higer latency and correctness on one side.

2. Lower throughput, lower latency and some risk of faults on the other side.

It's like the difference between tcp and udp.

The question is: Where do you need to be? What are your requirements?

Re:How to do a code review by joefkelley on Thursday September 05, 2019 @07:33PM (#20891604)
I worked at one (horrible) place where we explicitly only deployed on Friday afternoon.

The logic was we have fewer users over the weekend, so if something goes wrong, fewer people will notice.

Re:How to do a code review by devnulloverflow on Sunday September 08, 2019 @07:59PM (#20914148)
It depends on what company you are.

Some who administers some SAP thing for a huge supermarket chain tells me they do all of their upgrades on weekends because their users aren't at work.

Makes sense for them, but it would be a crazy thing to do the consumer-focused interweb company that I work for.

Re:How to do a code review by fma on Thursday September 05, 2019 @07:40PM (#20891637)
I rewrote an app that used to only deploy on weekends because we do a lot of processing on weekday afternoons and nights. I changed the deployd to the mornings.

I justified as saying if something breaks we have everyone there to fix it. Plus I'm not going to spend my weekend working if I don't have to.

My app has global traffic. Sometimes stuff breaks Sunday night and Asia is the first to find out.

Re:How to do a code review by Cthulhu_ on Friday September 06, 2019 @03:51AM (#20893831)
Ugh, I know the feeling - one client I worked for would only do deploys a few times a year if that, and only at night. I mean we'd get extra pay or free time for doing night shifts, but really, it's not good practice.
Re:How to do a code review by UK-Al05 on Friday September 06, 2019 @01:17AM (#20893272)
This implies they don't have very good automated deploy, monitoring and automated rollback solution.

The test of a good cd is that your ok with releasing on Friday at end of the day.

Re:How to do a code review by Glyptodon on Sunday September 08, 2019 @11:41PM (#20915052)
I agree I've never worked anywhere with really heavy duty CI, as in I've never worked somewhere that automated rollbacks were either trusted in all cases or business acceptable after something was production live. (Which is to say I haven't worked at places that had really significant scale.) And CI is only as good as your test coverage, which is to say if something esoteric is overlooked in your test suite...
Re:How to do a code review by aledalgrande on Friday September 06, 2019 @09:55AM (#20895644)
You are assuming that monitoring and rollback solutions are bug free, always on and have 100% knowledge of what's going on. That is never true.
Re:How to do a code review by twothamendment on Thursday September 05, 2019 @09:15PM (#20892151)
We had no-deploy Friday which made support & product people feel happy and devs dread the pileup on Monday. It has evolved into "don't deploy higher impact things on Friday" and "try not to deploy at all Friday afternoon". That gives us a half day to hear about issues and fix them before the weekend.
Re:How to do a code review by aledalgrande on Thursday September 05, 2019 @07:24PM (#20891544)
That's a good policy. We currently don't deploy on Friday afternoons.
Re:How to do a code review by atdt on Thursday September 05, 2019 @07:25PM (#20891553)
But it's such a trivial change...! What could go wrong?
Re:How to do a code review by dymk on Thursday September 05, 2019 @08:25PM (#20891910)
But then Thursday just becomes Friday...
Re:How to do a code review by luminiferous on Thursday September 05, 2019 @08:59PM (#20892083)
That's fine, because when something breaks the day after you've pushed, it's Friday and everyone's in the office. People are still going to rush the deadline, but putting the deadline earlier means you have time to deal with stuff that breaks after the deadline.
Re:How to do a code review by furyofantares on Thursday September 05, 2019 @08:37PM (#20891976)
We call it a chuck-in.