News for hackers. Stuff that matters.
Re:How to do a code review by bt848 on Thursday September 05, 2019 @08:43PM (#20892011)
They didn't give the two examples that are most common inside Google: Google I/O is coming up, or annual performance reviews are coming up.

Strangely they also list as "not an emergency" rollbacks of clearly broken code, but that's an exception to review rules inside Google. Anyone can do a pure rollback of a change without getting the approval of the owners of the code, and there are automated tools that will roll back changes that appear to have broken at least 1000 tests, without human review.

Edit: There's even a button right in the code review web UI to roll back a committed change.

Re:How to do a code review by NoodleIncident on Thursday September 05, 2019 @09:18PM (#20892168)
> Google I/O is coming up, or annual performance reviews are coming up.

As long as everyone admits it, sounds like those are actual emergencies :)

Re:How to do a code review by cameronbrown on Thursday September 05, 2019 @09:02PM (#20892094)
> at least 1000 tests

The threshold for this seems at least a little too high, doesn't it?

Re:How to do a code review by bt848 on Thursday September 05, 2019 @09:07PM (#20892115)
They have a lot of tests :-) Abseil-cpp alone has 2400 tests, at least in the open-source tree.

https://github.com/abseil/abseil-cpp/tree/master/absl/base

Re:How to do a code review by sanderjd on Thursday September 05, 2019 @10:10PM (#20892435)
I was thinking low :)