Re:How to do a code review
by NoodleIncident on Thursday September 05, 2019 @09:18PM
(#20892168)
> Google I/O is coming up, or annual performance reviews are coming up.
As long as everyone admits it, sounds like those are actual emergencies :)
Re:How to do a code review
by cameronbrown on Thursday September 05, 2019 @09:02PM
(#20892094)
> at least 1000 tests
The threshold for this seems at least a little too high, doesn't it?
They have a lot of tests :-) Abseil-cpp alone has 2400 tests, at least in the open-source tree.
Strangely they also list as "not an emergency" rollbacks of clearly broken code, but that's an exception to review rules inside Google. Anyone can do a pure rollback of a change without getting the approval of the owners of the code, and there are automated tools that will roll back changes that appear to have broken at least 1000 tests, without human review.
Edit: There's even a button right in the code review web UI to roll back a committed change.