News for hackers. Stuff that matters.
Re:SSH client in Google Chrome by jwr on Thursday January 17, 2013 @04:29AM (#5071759)
This is exactly what I've been waiting for!

The ability to take my critical secret information into a huge, buggy, extensible, unaudited, complex and constantly changing browser environment! Who could resist?

This will also inspire innovators world-wide. Look at it this way: we can now find novel ways to steal passwords, secret keys, log sessions, access servers, sneak in trojans.

Count me in.

Re:SSH client in Google Chrome by eliben on Thursday January 17, 2013 @08:50AM (#5072600)
I'm saddened by the recent shift of HN discussions to Reddit-isms. For Reddit, we have Reddit. Please, stop wasting others' time.
Re:SSH client in Google Chrome by hosay123 on Thursday January 17, 2013 @12:07PM (#5073669)
It is unfair to label this poor quality, the author clearly describes a problem with moving a security tool like SSH into the browser.

Despite Chrome being speedily updated when known security problems are discovered, the attack surface compared to a dedicated client is huge: the 2-decade-old /usr/bin/ssh + /usr/bin/xterm combo has no concept of a DOM, does not share computing interfaces available to untrusted users (e.g. shared web workers), cannot receive messages from untrusted frames (postMessage()), cannot even be addressed by untrusted content (chrome://path/to/trusted/script), does not almost transparently expose ring0 drivers (OpenGL), does not have thousands of LOC on subsystems with little battle testing (WebRTC) and so on.

Of course these features are thought to be secure, until they are discovered in the midst of a Stuxnet type scenario and suddenly everyone is patching like crazy. Wasn't Java considered invulnerable only 2 weeks ago? Look at what changed - somebody noticed it wasn't long after tens of thousands of infections already occurred, and today it is on every browser's plug-in blacklist. I can't recall the last I read about xterm in the Pwn2Own contest, or any 0-day in the past decade, nor can Google accidentally DoS my xterm because their sync service is down (happened last month).

Following from the truism that the fastest, most bug-free code is code that doesn't exist, the easiest way to reduce exposure to unknown attacks is to minimize the amount of code running. Security design 101. Using something with the complexity of a web browser to render an 80x25 vector used to administer potentially hundreds of thousands of machines is almost the antithesis of good protocol.

Re:SSH client in Google Chrome by VikingCoder on Thursday January 17, 2013 @12:13PM (#5073711)
Do most people run ssh and xterm on a bare-bones OS, or are they running on a full OS stack?

An OS that they may or may not update frequently.

An OS that they may or may not be logged into as an admin.

An OS that may have a keylogger running on it.

I think running SSH (or Chrome Remote Desktop) from a Chromebox is a pretty good way to have that minimal OS that is updated frequently, without admin privileges, with a lower risk of a keylogger. That I have to use two-factor to log into, even if my device is stolen.

Re:SSH client in Google Chrome by ramayac on Thursday January 17, 2013 @04:53PM (#5075473)
What do you think about using a js-keylogger via a malicious Chrome extension, could that be a plausible scenario?
Re:SSH client in Google Chrome by VikingCoder on Thursday January 17, 2013 @05:12PM (#5075561)
Sure, absolutely.

If you don't want the risk, don't install extensions you don't fully trust. Just like any applications or services on your desktop.

Re:SSH client in Google Chrome by brianto2010 on Thursday January 17, 2013 @03:46PM (#5075098)
"It is unfair to label this poor quality, the author clearly describes a problem with moving a security tool like SSH into the browser."

Yes, I agree. The grandparent does point out a valid problem. However I believe the parent was referring to the sarcastic tone and negativity, which I also believe should be out of place here on Hacker News.

Re:SSH client in Google Chrome by gcr on Thursday January 17, 2013 @08:40PM (#5076559)
Just a quick note, but implicitly asserting that xterm is a very secure program will weaken your argument. From http://st.suckless.org/ :

xterm is bloated and unmaintainable. Here’s an excerpt from the README:

                Abandon All Hope, Ye Who Enter Here


    This is undoubtedly the most ugly program in the distribution.  It was one of
    the first "serious" programs ported, and still has a lot of historical baggage.
    Ideally, there would be a general tty widget and then vt102 and tek4014
    subwidgets so that they could be used in other programs.  We are trying to
    clean things up as we go, but there is still a lot of work to do.
Needless to say things have not changed, it’s still ugly. It has over 65K lines of code and emulates obscure and obsolete terminals you will never need. The popular alternative, rxvt has only 32K lines of code. This is just too much for something as simple as a terminal emulator; it’s yet another example of code complexity.
Re:SSH client in Google Chrome by tripzilch on Thursday January 17, 2013 @09:43AM (#5072854)
And I am saddened by the not-so-recent yet constant Reddit-bashing over aspects of discussion that appear on HN and not necessarily at all on most programming-related subreddits. Those, in my experience, have a level of discussion quite comparable to HN[0].

[0] in a technical sense, the startup focus is quite unique to HN. or maybe I don't subscribe to startup-related subreddits (since startup news is not really the reason I read HN either)

Re:SSH client in Google Chrome by detst on Thursday January 17, 2013 @11:03AM (#5073330)
I love HN for discussions like this when a security expert familiar with the Chrome architecture will jump in and break things down (good or bad).

Increasingly I expect a contrarian at the top stating nothing but the obvious fact that there are security implications. Can we stop this now?

Re:SSH client in Google Chrome by recycleme on Thursday January 17, 2013 @09:55AM (#5072923)
You will find many sarcastic comments in HN. This has nothing to do with Reddit. However, I do appreciate when HNers add in a "/s" or something alike to make it clear that sarcasm was used.

You can find quality conversations in Reddit but, more than likely, not in the default subreddits.

Re:SSH client in Google Chrome by cnlwsu on Thursday January 17, 2013 @11:51AM (#5073573)
These comments always remind me of this http://xkcd.com/603/

People have been complaining that Reddit was taking over years ago and will continue to. Strangely while people posting cat pictures is downvoted for not being productive conversation comments like this get upvoted when it contributes just as much. Heck its even in the guideline:

If your account is less than a year old, please don't submit comments saying that HN is turning into Reddit. (It's a common semi-noob illusion.)

Although I know you have been around for more then a year.

Re:SSH client in Google Chrome by acchow on Thursday January 17, 2013 @01:48PM (#5074341)
To be fair, 90% of the Google SWE interns last summer were given chromebooks (instead of MBP) as their laptops (to supplement their workstations). They were extremely disliked.
Re:SSH client in Google Chrome by Evbn on Thursday January 17, 2013 @11:53PM (#5077189)
Come now. The interns weren't given nice computers, but they were still liked. And FWIW, the only real problem with Chromebook as corporate dumb terminal is the tiny screen resolution.
Re:SSH client in Google Chrome by acchow on Friday January 18, 2013 @01:02PM (#5080004)
"ctrl+w" is normally used to move between split panes in vim. It closes the SSH tab on a Chromebook. Googlers were not happy.
Re:SSH client in Google Chrome by jwr on Thursday January 17, 2013 @03:20PM (#5074947)
My answer was sarcastic, but there were real issues behind. Call it "informed sarcasm". Having used ssh since 1995 (on systems like SunOS 4.2 and UNICOS) I felt entitled to a bit of sarcasm.

I thought it would be obvious to most readers how a tty environment is easier to control than a browser (really, just consider the number and pace of updates to your kernel/windowing system/terminal and your web browser), so I did not bother with lengthy explanations.

Re:SSH client in Google Chrome by FooBarWidget on Thursday January 17, 2013 @05:22AM (#5071903)
Yeah, browser-based technology is so unsecure and dubious, it will never catch on for anything security critical such as banking. </sarcasm>
Re:SSH client in Google Chrome by patio11 on Thursday January 17, 2013 @06:34AM (#5072097)
Critically, there are in fact much worse things you can do to many someones than stealing their online banking session.
Re:SSH client in Google Chrome by skeletonjelly on Thursday January 17, 2013 @06:16AM (#5072035)
What banking extensions do you use? The one I installed for my bank is a Chrome "app" but really it's just a link.
Re:SSH client in Google Chrome by Torgo on Thursday January 17, 2013 @11:44AM (#5073532)
Even that has some security utility because it can enable SSL certificate pinning and prevent phishing. I don't know if they're using it that way, but it makes it possible.
Re:SSH client in Google Chrome by taligent on Thursday January 17, 2013 @07:30AM (#5072258)
Online banking isn't security critical.

The banks operate on the assumption that their user's machines will be compromised and have undertaken plenty of steps to manage their risk e.g. two factor auth, transfer limits etc.

Re:SSH client in Google Chrome by chimeracoder on Thursday January 17, 2013 @10:55AM (#5073284)
> The banks operate on the assumption that their user's machines will be compromised and have undertaken plenty of steps to manage their risk e.g. two factor auth, transfer limits etc.

I've written about this before at length, but I'll say it again here: the security practices of most major banks in the US are laughable. This applies to both online and offline banking.

Re:SSH client in Google Chrome by snowwrestler on Friday January 18, 2013 @01:24PM (#5080124)
In addition to, and IMO more important than, the technical efforts that banks dedicate to online security, there are the business practices that they dedicate to security. These include tracking and predicting loss, budgeting to cover and recover from those losses, purchasing adequate insurance to cover their risk, detailed record-keeping internally, and detailed communication with their customers.

Let's say your online banking browser session was hijacked and the bad guys transfered $100,000 out of your account. First of all the bank is likely to flag that transaction for closer review since it is probably a big departure from your usual behavior. Second, they are going to confirm its accuracy with you, at the very least in a printed or emailed statement to you that it occurred. If they are good, they will call to make sure you meant to do it. Third, they are going to keep records of what happened--the IP address that was connected when the transfer was requested, the time of day, where the money was transferred to, etc.

If it becomes clear that the transfer was a theft, then the bank will cover it as loss and you will get your money back. This is why online banking is not security-critical. Because there are numerous online and offline processes that mitigate the risks associated with online banking.

Now compare to managing your own webserver. The webserver is a dumb machine, not an intelligent counterparty like a bank. If your access to your webserver is hijacked, the webserver will not do a thing to detect, protect, or recover from whatever the bad guys do. Or more specifically, it will do only what you have specifically set it up to do.

By analogy, the lock on the front door of your house is "more important" than the lock on the front door of the police station--because there's no one behind your front door but you, while the police station has dozens of armed and trained officers behind their front door.

Re:SSH client in Google Chrome by martinced on Thursday January 17, 2013 @12:17PM (#5073732)
You know what the transfer limit is at my bank?

125 000 Euros per transaction (approx. $166 000 at today's rate)

I'd say that I agree with you: they've undertaken plenty of steps to manage their risk like by putting transfer limits.

Re:SSH client in Google Chrome by zobzu on Thursday January 17, 2013 @01:52PM (#5074386)
Thats not exactly the standard.
Re:SSH client in Google Chrome by toomuchtodo on Thursday January 17, 2013 @06:26PM (#5075962)
My brokerage account (Fidelity) has limits in the tens of thousands, and can be accessed by any browser or mobile smartphone.

I'm fairly certain all online brokerages are the same in the limits regard. And yes, tens of thousands of dollars is a huge amount to lose.

I'm just fine with SSH in a browser.

Re:SSH client in Google Chrome by Evbn on Thursday January 17, 2013 @11:56PM (#5077196)
Transfers are only permitted to destinations that are externally verified, though. Except penny stocks pump dump scam purchases.
Re:SSH client in Google Chrome by patrickaljord on Thursday January 17, 2013 @06:41AM (#5072119)
Chromium is open source, the extension is open source and it runs on nativeclient which itself is open source and was designed and audited to be secure and sandboxed. Making it secure and sandboxed was part of the initial goal of both Chromium and nativeclient, and again, they and the extension are all open source and audited daily by Google engineers and tons of security companies.
Re:SSH client in Google Chrome by dsr_ on Thursday January 17, 2013 @07:11AM (#5072208)
Chromium is open source. Chrome is not.

It is perfectly possible that Google is doing all sorts of Evil Stuff (TM) in the binaries that they ship out. I don't think it's likely, because a fair few people will be examining the packets it sends -- but it is possible.

Re:SSH client in Google Chrome by EricBurnett on Thursday January 17, 2013 @08:08AM (#5072376)
The same could be said for any binary releases, from open source code or not (e.g. Firefox). If you don't trust Google's binary releases then build your own Chromium from audited sources.
Re:SSH client in Google Chrome by mcpherrinm on Thursday January 17, 2013 @08:48AM (#5072582)
Yes, trusting binaries is a little scary. But for open source projects like Firefox, you should be able to compile a bit-identical release to what Mozilla provides.

With Chrome, that isn't possible. It is based on Chromium, but includes non-open source code, and so you cannot immediately build it.

However, in the end, they're just executables. Looking at assembly isn't quite the same as looking at source code, but we could examine the additional components and try to identify any malicious parts. At least in theory -- the work involved would be quite big.

Re:SSH client in Google Chrome by DannyBee on Thursday January 17, 2013 @10:38AM (#5073179)
All non-open source code in chrome should be in plugins (or otherwise separate DLL's), not chrome's main binary. If you know of a case where this isn't true, please let me know.

You wouldn't be able to compile bit-identical releases due to FDO, but otherwise ...

Re:SSH client in Google Chrome by tonfa on Thursday January 17, 2013 @09:51AM (#5072903)
> But for open source projects like Firefox, you should be able to compile a bit-identical release to what Mozilla provides.

Pretty sure it's actually very hard, I'd assume they use FDO in their builds.

Re:SSH client in Google Chrome by mcpherrinm on Thursday January 17, 2013 @10:13AM (#5073018)
That's true. I know profile-guided-optimization is used for Windows builds; unsure on other platforms.

Actually, this sounds like a fairly interesting project to me: Given a tool chain and a source code base, can we prove this was a possible compilation? In the case of deterministic compilers this is trivial, but as you highlight, not all optimizers are.

Re:SSH client in Google Chrome by LukeShu on Thursday January 17, 2013 @10:46AM (#5073231)
I'm fairly certain that PGO is used for all of the official binaries. I do know that Arch Linux's package (which is from source, not official binaries) is compiled with PGO, so the support is definitely there.
Re:SSH client in Google Chrome by Hello71 on Thursday January 17, 2013 @11:05AM (#5073344)
The scripts used to automate PGO are in the official repository.
Re:SSH client in Google Chrome by groby_b on Thursday January 17, 2013 @05:20PM (#5075611)
Theoretically, you should be able to compile a bit-identical release. Practically, you won't. (Or at least, I'd be very surprised)

Re-creating bit-identical copies is hard when you _try_ to make it happen for your project, and I can't see any active efforts for that in most OSS projects.

Timestamps in .o/.lib files, use of system libraries, optimization heuristics, exact versions of the entire toolchain, and many more "fun" issues prevent that from happening, usually.

Re:SSH client in Google Chrome by taligent on Thursday January 17, 2013 @07:35AM (#5072274)
Do you really think open source and security audits actually means much ? You only to have to look at Java and Windows to know that security exploits can exist for years sometimes decades without anyone noticing them.
Re:SSH client in Google Chrome by BitMastro on Thursday January 17, 2013 @08:35AM (#5072499)
>You only to have to look at Java and Windows to know that security exploits can exist for years sometimes decades without anyone noticing them.

Yes, and your point is? Security audits do mean much, that's why they are done. Open source means a lot as well, it means that if I don't trust a software, I can check it if I want to, rather than accepting what a company is telling me.

There's a reason why cryptographic stuff is almost exclusively open source, it's because security through obscurity doesn't work.

That said, the amount of exploits for open and closed source software is more of less equivalent, but the time to fix is usually shorter for open source code.

Re:SSH client in Google Chrome by alxv on Thursday January 17, 2013 @08:09AM (#5072383)
Oh right... because putting your critical secret information into a huge, buggy, extensible, unaudited, complex, and constantly changing operating system is so much better!
Re:SSH client in Google Chrome by moe on Thursday January 17, 2013 @10:01AM (#5072945)
When running OpenSSH on top of Linux you will be affected by any security bug in Linux or OpenSSH.

When running OpenSSH inside Chrome on top of Linux you will be affected by any security bug in Linux, OpenSSH or Chrome.

It's not that hard to understand, really.

Re:SSH client in Google Chrome by BitMastro on Thursday January 17, 2013 @11:41AM (#5073528)
Or, from another point of view, an attacker has to bypass Linux and OpenSSH security in one case or bypass Linux, OpenSSH and Chrome security mechanisms in the other case..

It's an oversimplification

Re:SSH client in Google Chrome by moe on Thursday January 17, 2013 @02:01PM (#5074445)
No.

When you load your SSH-Keys into Chrome and the Chrome sandbox is compromised then there is no further layer between the attacker and your keys.

This is a new attack vector in addition to those that may exist in SSH itself and your operating system.

Re:SSH client in Google Chrome by BitMastro on Thursday January 17, 2013 @02:19PM (#5074577)
I understand what you mean, but I'm saying that compromising the sandbox can be looked as well as an additional step to achieve. And more so if, for example, address space randomization is offered by the OS. In this case the security model is reinforced, rather than weakened.
Re:SSH client in Google Chrome by moe on Thursday January 17, 2013 @04:04PM (#5075196)
but I'm saying that compromising the sandbox can be looked as well as an additional step to achieve

You're making no sense. The previous attack vectors don't go away when you put your keys into Chrome. Chrome becomes an additional option for the attacker, not an additional "step".

A house with two doors is less secure than the same house with one door.

Re:SSH client in Google Chrome by tmzt on Thursday January 17, 2013 @10:22PM (#5076893)
There is also no reason that private keys have to be loaded in the same process (or even the sandbox) when an ssh agent is used.
Re:SSH client in Google Chrome by moe on Thursday January 17, 2013 @10:43PM (#5076967)
I'm a bit baffled to what degree some people here try to deny the obvious.

Yes, you can use ssh-agent with chrome (if they have that implemented, I don't know). Yet you are still in trouble when the chrome sandbox gets compromised, because all your keystrokes are passing through it.

Re:SSH client in Google Chrome by BitMastro on Friday January 18, 2013 @06:55AM (#5078218)
From what I know they don't impement ssh-agent. Do you consider ssh-agent as another attack vector or additional security?

If the sandbox is compromised to have file system access, a process can read your keys from ~/.ssh as well as chrome storage files. Otherwise a webpage has to escape its own sandbox, bypass the native client's sandbox (in a different process) composed of the inner and outer sandbox and then access the native client.

I'm not saying that it's impossible, I'm saying that using a simple analogy as "a house with two doors" might not be the best.

Re:SSH client in Google Chrome by moe on Friday January 18, 2013 @08:48AM (#5078550)
Otherwise a webpage has to escape its own sandbox, bypass the native client's sandbox (in a different process) composed of the inner and outer sandbox and then access the native client.

Or there could be just some really dumb bug that somehow enables cross-process access. With javascript. You know, one of these silly brown-paper-bag bugs that are not supposed to happen.

Either way, this is the second door. It may be a shiny steel door, but it's an additional door.

Re:SSH client in Google Chrome by BitMastro on Friday January 18, 2013 @09:48AM (#5078820)
The other process might as well be ssh itself at this point. Anyway, we are just speculating, also the wall is another door if you smash through it. Just don't use it then.
Re:SSH client in Google Chrome by olalonde on Thursday January 17, 2013 @05:06AM (#5071856)
"Middlebrow dismissal" comes to mind...
Re:SSH client in Google Chrome by patio11 on Thursday January 17, 2013 @06:00AM (#5071999)
Can I phrase the same objection in a more HN-y manner?

SSH terminals are high-sensitivity software. We frequently use them, with very sensitive credentials, to log into secured servers. There are two zones of trust involved: we trust that our local machine is not rooted, and we trust that the server is not rooted. The magic of SSL means that no matter how foul everything is between those two zones of trust, we can't get compromised.

If we embed the SSH terminal in the browser, we now have four zones of trust: our local machine, the browser, the SSH terminal extension, and the server we connect to.

This is a very scary broadening of our attack surface. While the terminal app siting on your machine is decades old and has been tested extensively, the browser extension almost certainly has not. The browser extension, in addition to possibly having vulnerabilities itself, is executing in the context of the browser. The browser is a very scary place to be, because its whole mission in life is connecting to the untrusted, infected cesspool of the Internet and then doing what the Internet tells it to. By grace of God and Google engineers, we generally assume that our browsers aren't going to crack out of the sandbox surrounding the sandbox surrounding the sandbox that all that evil Internet stuff is executing in, but we expect that, in the normal course of operation, those inner sandboxes are going to fall into the hands of the enemy, repeatedly.

It therefore seems to be an exceptionally bad idea to take our holiest-of-holy credentials and move them inside the sandbox, closer to the attackers.

This is particularly true in terms of a risk/benefit analysis, since the risks are incredible and the only benefit is "Saves you from having to do a single key chord to pop open an additional terminal on your machine."

This is moot if you have total confidence in the Chrome and Native Client teams to never have a mistake which lets someone, e.g., read arbitrary process memory. That's happened before -- Mark Dowd et al found it. That would be pretty sucky if it happened on a browser you logged into your bank, because the attacker can probably grab your cookie and banking session. It would be much worse, though, if it happened on a machine used by a bank sysadmin who unwisely decided to use a terminal within his browser, because why steal one session when you can just steal the bank? (n.b. Note how this is possible without causing Chrome to execute arbitrary code or defeating the OS's protections against Chrome doing stuff outside the Chrome-box.)

Re:SSH client in Google Chrome by patio11 on Thursday January 17, 2013 @07:05AM (#5072194)
Interestingly, Google appears to be largely thinking of the opposite threat model:

http://git.chromium.org/gitweb/?p=chromiumos/platform/assets...

Additionally, the Secure Shell application follows a strict Content SecurityPolicy that does not allow access to the JavaScript 'eval' function. This helps lower the risk that a terminal exploit could run arbitrary JavaScript.

Translation: Don't worry, if the bad guys already own your server/local machine, it's less likely they'll be able to go from owning your server/local machine to owning your browser, because we make them have to jump through a few hoops to execute arbitrary Javascript.

I'm having one of those rare, weird moments where I disagree with someone I enormously respect in a field, on that field, and think -- even after reflecting -- that even with the "They're so smart about this they're probably seeing something you aren't" modifier the words that are coming out of their mouth are, in fact, not right.

Edit to add: I previously used the language "batshit crazy", but on reflection you could envision an attack like "Attacker gets arbitrary content written into a web server log; if we cat this in the JS context, we turn totally harmless text that wasn't executing on the server or the local terminal into executable Javascript." But I still really think that is less likely and less severe than bootstrapping a browser, NativeClient, or extension bug into "Root all the boxes."

Re:SSH client in Google Chrome by JoachimSchipper on Thursday January 17, 2013 @08:27AM (#5072458)
It is possible to use this sensibly - e.g. I don't really see the problem with using this to play a MUD/roguelike/etc. In that context, their security worries make complete sense.

On the other hand, for certain environments, browser access is game over anyway. I'd expect that snarfing your customers' credit card info out of your admin consoles would get an attacker 99% of the value (s)he'd get from completely rooting you - just how careful are you about separating the internet and your admin consoles? Just how careful is the average HN user? (Note that your admin consoles would need a custom attack, though, while "open a reverse shell when logging in" would be considerably more general.)

But yes, for many, many people, this is really scary.

Re:SSH client in Google Chrome by Spooky23 on Thursday January 17, 2013 @12:00PM (#5073622)
I tend to agree with you, as most folks would. But perhaps this approach is being driven by the "Chrome as Operating System" approach and the Chromebook.

Google is a big enough company that the thought process is being driven the by internal needs and wants, not necessarily by what the rest of the universe is doing.

Re:SSH client in Google Chrome by taligent on Thursday January 17, 2013 @07:38AM (#5072278)
We have all seen these browser sandboxes before. And guess what:

Java and Flash are two of the most widely compromised pieces of software in history.

Re:SSH client in Google Chrome by justinschuh on Thursday January 17, 2013 @10:08AM (#5072983)
It hurts my head to see people refer to a "sandbox" as if the term means anything in isolation. Sandboxing is a strategy that covers a broad spectrum of implementation quality. Take Java's "sandbox," which is just its VM layer employing a complicated stack inspection based permission model. In practice it's very porous, and has a very poor security history at various levels.

You also mentioned Flash, which has a VM "sandbox" for Actionscript, with a simpler, mostly origin-based security model. Depending on the platform there's also an outer Flash sandbox using OS-based security primitives to various degrees. Since Adobe built their own NPAPI sandbox on Windows (mostly for Firefox), it's a good one to point to. It prevents write-level access to most objects, and relies on a broker process to manage those actions. Most objects are readable from inside the sandbox, and various low-privilege objects can be directly controlled as well. Historically, Flash has a better security track record than Java, but has still had its share of issues.

Then there's the Chrome sandbox. Once again, there's a VM level "sandbox" for JavaScript and one for NaCl nexes, both using a strict origin-based security model. Then there's an outer sandbox using the OS-based primitives that deny access to all objects, requiring all resource access to be routed through a broker process. Chrome is generally considered to be very good on the security front, and has yet to be hit with an exploit in the wild.

I could actually into very deep detail on how these differ, and the effectiveness of each sandbox implementation, but I think the broad descriptions convey my point.

Re:SSH client in Google Chrome by BitMastro on Thursday January 17, 2013 @09:18AM (#5072730)
And guess what, they're also two of the most widely installed software.

The truth is that sandboxes are effective in mitigating the attacks, because they add another level of security. Even safari added a sandbox a couple years ago.

Re:SSH client in Google Chrome by justinschuh on Thursday January 17, 2013 @09:24AM (#5072758)
Building an SSH client as a Chrome app doesn't introduce attack surface from web content. The SSH client and web content run in different sandboxed processes and don't share resources. For the web content (or another Chrome app) to break into the SSH client, it would need arbitrary unsandboxed code execution, which means it could manipulate any process running in the user's context. So, the threat model doesn't change from a standalone SSH client.

The bugs Mark found in NaCl several years ago don't alter the threat model for a standalone SSH client either. And for context, Mark's work was done while NaCl was in alpha development, years before it shipped in Chrome; were performed as part of a Google sponsored contest and later a Google paid audit; and applied to the NaCl validator sandbox, not the outer process isolation sandbox. So, even the more nebulous threat you're implying is grossly misstated.

Re:SSH client in Google Chrome by patio11 on Thursday January 17, 2013 @10:40AM (#5073196)
For the web content (or another Chrome app) to break into the SSH client, it would need arbitrary unsandboxed code execution

Respectfully, I think you might be limiting the attack space here in a fashion that attackers are not restricted to doing. For example, there appear to me to be opportunities for side channel attacks which do not require the bad guys to totally break your sandbox model for them to be able to guess at what another Chrome process is doing. Given that they'll have a local vantage point to do the timing measurements, and consequently very high precision, it's at least possible that they can guess things about the operation of the SSH process. If the guess the right things, they don't need to cause the SSH process to execute any code at all. (If memory serves me, that's previously been used to time OpenSSL's encryption/decryption itself, but there's probably other vectors if that isn't an option these days, like timing I/O operations with sufficient precision to guess what they were.)

There's an interesting question on whether moving the SSH into a Chrome process makes it more vulnerable vis-a-vis other Chrome processes to timing attacks than it would be just by being on the same box with a Chrome process. I would not trust myself to say "That is definitely more of a risk" with the level of research I've done, but I think it is highly unlikely that it gets less risky.

Re:SSH client in Google Chrome by justinschuh on Friday January 18, 2013 @12:40AM (#5077326)
I don't mean to be rude, but you seem fundamentally confused. The argument you've strung together here isn't in any way specific to an SSH client built as a Chrome app--and is a just a nebulous claim that applies to any execution contexts sharing the same system.
Re:SSH client in Google Chrome by comex on Thursday January 17, 2013 @04:10PM (#5075239)
What if the attacker compromised the GPU process without compromising the entire sandbox? If hardware compositing is on, they could snoop on the SSH window contents. (Then again, they might be able to do that even with a separate application...)
Re:SSH client in Google Chrome by justinschuh on Friday January 18, 2013 @12:20AM (#5077270)
Yeah, the GPU process can do this regardless due to the way Windows forces any accellerated GPU app to work. I'm not sure if you dug into this before, but the GPU does run as low-integrity for UIPI purposes on the interactive desktop (lower for other object access). Unfortunately, the desktop window, screen, and display state are still exposed at that level. We're digging into AppContainers to see if tighter restrictions are possible on Win8, but usage is still so low that it's not a priority.
Re:SSH client in Google Chrome by justinschuh on Friday January 18, 2013 @10:16AM (#5078999)
Sorry I focused solely on Windows, but to my knowledge all platforms we support have similar architectural niggles in terms of the GPU process being able to read anything that's displayed.
Re:SSH client in Google Chrome by jkn on Thursday January 17, 2013 @07:13AM (#5072212)
What about the traditional SSH client as a zone of trust? It's unfair to ignore the client in the traditional case but count the browser and extension as two additional zones of trust in the Chrome case.

Client-side exploits in SSH clients have happened before[1]. The scope of such exploits is arguably reduced when running a sand-boxed application in a browser compared to a regular application on the local machine.

That being said, I agree with your general point that using a browser as an SSH terminal dramatically increases the attack surface, compared to a small dedicated client.

[1] http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2005-0467

Multiple integer overflows in the (1) sftp_pkt_getstring and (2) fxp_readdir_recv functions in the PSFTP and PSCP clients for PuTTY 0.56, and possibly earlier versions, allow remote malicious web sites to execute arbitrary code via SFTP responses that corrupt the heap after insufficient memory has been allocated.

Re:SSH client in Google Chrome by patio11 on Thursday January 17, 2013 @07:15AM (#5072222)
They call out to your existing SSH client, so if it's vulnerable, wrapping it in NativeClient means it is still vulnerable. By comparison, my SSH client doesn't go to Chrome and say "Hey guys, apropos of nothing, please hang onto these SSH keys so we have something to give anyone who successfully is able to read memory from any one of fivish subsystems in your under-constant-attack product."

[Edit: On re-reading, I think I misunderstood this, and the comment beneath this one is substantially correct regarding them bundling OpenSSH. I still think this is substantially more attack surface than however you're consuming OpenSSH code currently.]

Re:SSH client in Google Chrome by jkn on Thursday January 17, 2013 @07:25AM (#5072250)
As I read it the whole SSH client is an OpenSSH port running in the NativeClient sandbox, which does make it safer in terms of SSH client exploits, in the sense that the exploit doesn't give you immediate control of the local machine.

Secure Shell is a Chrome Application that combines the "ssh" command (see http://openssh.org/ for details) ported to NativeClient with the "hterm" terminal emulator to provide a secure shell client for the Chrome browser.

http://git.chromium.org/gitweb/?p=chromiumos/platform/assets...

I'm not familiar enough with the multiple sandboxing levels of Chrome to judge the risks of one malicious website accessing the memory of the Secure Shell extension. I guess you have a point, although I would expect the "each tab in a separate process" model to mitigate this concern?

Re:SSH client in Google Chrome by icebraining on Thursday January 17, 2013 @08:33AM (#5072482)
we generally assume that our browsers aren't going to crack out of the sandbox surrounding the sandbox surrounding the sandbox that all that evil Internet stuff is executing in, but we expect that, in the normal course of operation, those inner sandboxes are going to fall into the hands of the enemy, repeatedly.

Why? The whole model of Chrome is that there's a multi-process conglomerate with clearly defined interfaces between them and OS enforced boundaries otherwise.

Why would it be easier for a malicious JS payload running on Process A to attack the Chrome SSH extension running on Process B than to attack the terminal or openssh processes?

Re:SSH client in Google Chrome by MatthewPhillips on Thursday January 17, 2013 @08:08AM (#5072378)
> While the terminal app siting on your machine is decades old and has been tested extensively, the browser extension almost certainly has not.

This is running OpenSSH code.

Re:SSH client in Google Chrome by j_s on Thursday January 17, 2013 @10:53AM (#5073273)
Hard to suppress my smile reading this; this post would also have been appropriate when businesses were transitioning their LOB data-entry apps from VB6 to being web-based. Just for your sake I hope an issue is found so you can point back to your prescience, in all its chicken-little-style glory.

Thanks for the reminder that new software is less secure than old, and that new technologies often widen attack surfaces. There is little doubt in my mind that this is just the beginning of Chrome native apps, and they have to start somewhere.

Re:SSH client in Google Chrome by FooBarWidget on Thursday January 17, 2013 @07:16AM (#5072224)
What's a middlebrow dismissal? A google search only gave HN results.
Re:SSH client in Google Chrome by patio11 on Thursday January 17, 2013 @07:22AM (#5072243)
It's a word coined by pg that's sort of a term-of-art for the depressing tendency of the top HN comment to be something which pooh-poohs the company/topic/idea in the submission, doesn't add anything to the discussion, but (crucially) is worded convincingly enough to not just end up on the bottom of the thread.

e.g. "Lol that suckz because Google can steal ur passwerdz!" would not end up at the top of the thread. We wouldn't be terribly worried if someone actually said "Wait, I just audited NativeClient and it turns out you can achieve arbitrary code execution. Maybe you should avoid this software." The danger zone is comments which sound like the second but, on reflection, only tell you about as much as the first.

Re:SSH client in Google Chrome by snowwrestler on Friday January 18, 2013 @01:31PM (#5080156)
Ironically the concept of a "middlebrow dismissal" seems to me to enable what it condemns--e.g. HN'ers can now just post "hey that's a middlebrow dismissal" instead of a detailed statement of why a particular response falls short.

Basically I think pg made it worse by giving it a catchy name.

Re:SSH client in Google Chrome by jessaustin on Thursday January 17, 2013 @08:25AM (#5072448)
This makes sense, but it makes me think that (in the interest of having a good top post) you should have top-leveled your in-depth comment rather than responding to olalonde's as you did. Your comment then could have (and probably would have) been voted up to the top.
Re:SSH client in Google Chrome by meaty on Thursday January 17, 2013 @04:54AM (#5071828)
You are the first person to articulate exactly what I think about such things perfectly!

Give me PuTTY or SSH on a terminal any day over this.

Re:SSH client in Google Chrome by salmanapk on Thursday January 17, 2013 @04:38AM (#5071781)
It might not be very safe at the moment, but this _is_ the future no matter how much you troll.