News for hackers. Stuff that matters.
Re:PR Process Is Killing Morale and Productivity by lijok on Friday November 29, 2024 @01:47PM (#42276032)
Speaks volumes to the maturity of our work that a 3000 LOC PR is seen not only as acceptable, but expected.

Raising a planning change equivalent to a 3000 LOC PR in a civil engineering firm would get your assignment swiftly handed over to someone more competent.

Re:PR Process Is Killing Morale and Productivity by loa_in_ on Friday November 29, 2024 @04:55PM (#42277454)
LOC is a bad measure of literally anything. It's not related to productivity, efficiency, bug count, readability, etc. What it's most related to is the choice of language and libraries. For me, shunning big contributions just for being big just stifles my drive to contribute. If the solution does what it's supposed to, is valid, efficient and there's no obvious unnecessary duplication of codethen who cares if it's big. All valid contributions push the project forward.
Re:PR Process Is Killing Morale and Productivity by sundbry on Saturday November 30, 2024 @12:37AM (#42279803)
It is actually directly related to the time and complexity of code review. Just because LOC is an imperfect metric for productivity etc., does not mean it's a poor metric for risk, complexity, poor sequencing of changes, or other attributes.
Re:PR Process Is Killing Morale and Productivity by DontchaKnowit on Saturday November 30, 2024 @11:20AM (#42282342)
How are you supposed to write new code without hitting a 3k loc pr?
Re:PR Process Is Killing Morale and Productivity by Aeolun on Saturday November 30, 2024 @03:13PM (#42283741)
Merge before you’ve written 3000 lines of code?
Re:PR Process Is Killing Morale and Productivity by Olreich on Monday December 02, 2024 @11:22PM (#42303046)
But the planning change to add a new wing to the building? That can’t be made smaller. What about if a new regulation is put in effect requiring every fire door to have a corresponding fire window next to it? That’s either 3000 little changes that need reviewing or one big change. One big change is often the correct choice. Knowing when it’s appropriate and when it’s not is the job of the engineer, the team, and the lead.