News for hackers. Stuff that matters.
Re:How we engineer feedback at Figma with eng crits by f1gm3nt on Monday March 11, 2024 @01:29PM (#39671016)
Still fighting with the CTO on letting people other than him do code reviews. We don't do retrospectives and code reviews also take months. I also have to fill out a change request form (CRF) that has the git hash, list of files modified, and many other useless and redundant fields that are required.
Re:How we engineer feedback at Figma with eng crits by njovin on Monday March 11, 2024 @01:52PM (#39671276)
I don't think I know a single engineer that would tolerate working in this environment.
Re:How we engineer feedback at Figma with eng crits by brianwawok on Monday March 11, 2024 @01:39PM (#39671117)
> code reviews also take months

Wow. I don't think I would have lasted even the first month there.

Sounds not healthy.

Re:How we engineer feedback at Figma with eng crits by f1gm3nt on Monday March 11, 2024 @01:58PM (#39671343)
It's rough, I'm looking =)
Re:How we engineer feedback at Figma with eng crits by 65 on Monday March 11, 2024 @03:46PM (#39672478)
> code reviews also take months

Seems wildly counter-productive, as I'm guessing there will be a ton of merge conflicts.

Re:How we engineer feedback at Figma with eng crits by pm90 on Monday March 11, 2024 @01:32PM (#39671054)
This sounds like the worst version of SOC controls.
Re:How we engineer feedback at Figma with eng crits by f1gm3nt on Monday March 11, 2024 @01:35PM (#39671092)
It's all for "PCI Compliance" lol
Re:How we engineer feedback at Figma with eng crits by Brystephor on Monday March 11, 2024 @01:56PM (#39671326)
How is it for PCI compliance? Which of the PCI DSS requirements outlines this?
Re:How we engineer feedback at Figma with eng crits by f1gm3nt on Monday March 11, 2024 @01:59PM (#39671368)
Got me, first time I've ever had to fill out something like this
Re:How we engineer feedback at Figma with eng crits by kjs3 on Monday March 11, 2024 @07:31PM (#39674403)
Section 6.5: "Changes to all system components are managed securely."

6.5.1 is probably where the CRF form came from.

Re:How we engineer feedback at Figma with eng crits by Aeolun on Monday March 11, 2024 @09:01PM (#39674958)
There’s a lot you can do with ‘separation of responsibilities’.
Re:How we engineer feedback at Figma with eng crits by beAbU on Monday March 11, 2024 @01:40PM (#39671127)
Can't you have normal peer review with the rest of the team in lower level branches? Have everything work out as "normal" with PRs and whatnot, then when you want to merge develop into master or whatever, then do the CRF and CTO review?

Everybody then gets what they want.

Re:How we engineer feedback at Figma with eng crits by f1gm3nt on Monday March 11, 2024 @01:55PM (#39671310)
It's a mix of ego and people not knowing what they are doing. I had to fight my first month just to get code into BitBucket. Before that, it was a server in rackspace you pushed to as the root user.

Because the CTO only does the code reviews, people create the PR and the CRF. Issue is because it takes so long, the CTO wants merge conflicts resolved before it's reviewed. Problem with that is, no one remembers the context a month (or longer later).

I have A LOT of spare time so I will often help out with doing reviews but because I'm not allowed to merge or deploy code, it's more of helping junior engineers write better code.

Re:How we engineer feedback at Figma with eng crits by seattle_spring on Monday March 11, 2024 @02:11PM (#39671525)
Wait, based on the article and your name, are you talking about Figma?
Re:How we engineer feedback at Figma with eng crits by sunnybeetroot on Monday March 11, 2024 @03:02PM (#39672087)
No chance this is Figma
Re:How we engineer feedback at Figma with eng crits by bornfreddy on Monday March 11, 2024 @03:37PM (#39672399)
Why not? It seems plausible to me.

The article came off as if the company is run by designers, not engineers. While the engineers I know generally appreciate some feedback, they don't need much of it on engineering questions. UX and design, however - bring it on! So "eng crits" sound like... learning exercises for juniors? If it works for them, that's good, but I don't see myself sending my CV over, at least not based on this article.

Re:How we engineer feedback at Figma with eng crits by sunnybeetroot on Monday March 11, 2024 @03:42PM (#39672442)
There is another post that mentions PCI compliance, but I don’t see how all of Figma falls under needing PCI compliance.
Re:How we engineer feedback at Figma with eng crits by bornfreddy on Monday March 11, 2024 @03:48PM (#39672496)
Good point!
Re:How we engineer feedback at Figma with eng crits by Solvency on Monday March 11, 2024 @02:40PM (#39671846)
why is this being downvoted? I was wondering the exact same thing.
Re:How we engineer feedback at Figma with eng crits by ramon156 on Monday March 11, 2024 @02:59PM (#39672045)
Never knew you could download comments! (sorry)
Re:How we engineer feedback at Figma with eng crits by f1gm3nt on Tuesday March 12, 2024 @09:28AM (#39679233)
No, I do not work at Figma lol
Re:How we engineer feedback at Figma with eng crits by sibeliuss on Monday March 11, 2024 @01:40PM (#39671136)
Yikes! How is this tolerated?
Re:How we engineer feedback at Figma with eng crits by danielvaughn on Monday March 11, 2024 @04:54PM (#39673126)
If the job market was better I'd tell you to quit. That sounds awful, and wildly irresponsible behavior from a CTO.
Re:How we engineer feedback at Figma with eng crits by Aeolun on Monday March 11, 2024 @09:00PM (#39674951)
Who knows, maybe the product is stable and wildly successful.
Re:How we engineer feedback at Figma with eng crits by f1gm3nt on Tuesday March 12, 2024 @09:27AM (#39679219)
It's not...