News for hackers. Stuff that matters.
Re:Secret scanning is now available for free on public repos... by flatiron on Thursday December 15, 2022 @07:36PM (#34007889)
Good on them. GitHub secrets cause a lot of problems. They will always create a better idiot but this idiot trap is long past due.

I also can’t wait until people base64 their creds to get past this. Explaining to some that base64 isn’t encryption tends to be hard so I imagine people will feel safe just base64 and checking it in.

Re:Secret scanning is now available for free on public repos... by CSSer on Thursday December 15, 2022 @07:46PM (#34007994)
Or md5. I wouldn’t be surprised to see that from some in PHP land.
Re:Secret scanning is now available for free on public repos... by Godel_unicode on Thursday December 15, 2022 @08:01PM (#34008105)
With md5 hashes, the actual password isn’t there whereas base64 encoding is merely another way of representing the same bits. Yes md5 is weak, but it’s Fort Knox compared to base64.
Re:Secret scanning is now available for free on public repos... by CSSer on Thursday December 15, 2022 @08:39PM (#34008455)
I’m very much aware of the differences in format and effort. The idea was only tangentially related :/

Also, at the risk of being pedantic, yes, some semblance of the password is definitely there. Someone can happily go off and try to brute force it.

Re:Secret scanning is now available for free on public repos... by Godel_unicode on Thursday December 15, 2022 @08:54PM (#34008593)
As long as we’re being pedantic, no they can’t (well, I guess they can try with no hope of succeeding?). You can find a sequence of bytes which will have the same md5, but you have no way of knowing that it’s the same string of bytes which someone else used to arrive at that md5. As I alluded to in my post, that information is gone.
Re:Secret scanning is now available for free on public repos... by tkanarsky on Thursday December 15, 2022 @08:00PM (#34008095)
Hah, provide the hash and have the backend crack it whenever it needs to call the api.
Re:Secret scanning is now available for free on public repos... by eloff on Thursday December 15, 2022 @08:07PM (#34008160)
You're not going to crack a hash for an API key. Not even with MD5. Long random strings are the worst case scenario for trying to reverse a hash.
Re:Secret scanning is now available for free on public repos... by CSSer on Thursday December 15, 2022 @08:36PM (#34008424)
I forget the exact details, but if I recall correctly you can crack md5 with a for loop in PHP because you can just iterate through the full character set. Maybe it would take awhile but having seen it in action for shorter examples I doubt that’s going to stop someone sufficiently motivated. Then again, at that point I guess they’d just opt for a tool like hashcat.
Re:Secret scanning is now available for free on public repos... by mwint on Thursday December 15, 2022 @08:41PM (#34008470)
The full character set for an AWS key is super ridiculously huge, like heat death of the universe huge.
Re:Secret scanning is now available for free on public repos... by CSSer on Thursday December 15, 2022 @08:47PM (#34008531)
Hm, could you provide one as an example? I’m kidding. That’s fair. I was just thinking of ASCII. How many services live up to AWS’ standards?
Re:Secret scanning is now available for free on public repos... by eloff on Thursday December 15, 2022 @09:22PM (#34008843)
AWS keys are ascii, but they have so much entropy you could never guess it to reverse the hash.
Re:Secret scanning is now available for free on public repos... by jamesfinlayson on Thursday December 15, 2022 @11:02PM (#34009975)
One I can see now is 40 characters of... not sure - I see uppercase, lowercase, digits and special characters. Maybe it's printable ASCII?
Re:Secret scanning is now available for free on public repos... by bombcar on Thursday December 15, 2022 @11:24PM (#34010187)
Your access keys consist of an access key ID (for example, AKIAIOSFODNN7EXAMPLE) and a secret access key (for example, wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY).
Re:Secret scanning is now available for free on public repos... by selcuka on Thursday December 15, 2022 @08:58PM (#34008620)
You can find a collision, but you can't (unless you are very lucky) reverse the hash. The bits are not there.
Re:Secret scanning is now available for free on public repos... by CSSer on Thursday December 15, 2022 @10:00PM (#34009298)
Of course not. I’m referring to brute force. The idea that you can’t reverse a hash seemed so obvious to me that I didn’t feel it necessary to disclaim. You can increment characters in php like numbers[0]. It has some funny quirks. It doesn’t loop back around right away. If you write a for loop for that and pass it into the builtin for md5, you can just go until your hashes match. Of course this would take a long time for big hashes and there are other tools that can do this better if you’re motivated anyway. But hey, you can make a fun hash cracker in a few lines if you’re feeling it. My whole point was just that MD5 is fairly weak. Lots of people don’t or at least didn’t use to consider this because it was also (too) convenient.

[0]: https://stackoverflow.com/a/3567245

Re:Secret scanning is now available for free on public repos... by selcuka on Thursday December 15, 2022 @10:27PM (#34009610)
> I’m referring to brute force. The idea that you can’t reverse a hash seemed so obvious to me that I didn’t feel it necessary to disclaim.

You are confusing hashing with encryption. There is no general way to reverse a hash, be it brute force or an algorithmic method. There are an infinite number of strings that will generate the same MD5 hash. My point is, your for loop may eventually find a string, but it won't be the original AWS secret, so it won't work.

Re:Secret scanning is now available for free on public repos... by CSSer on Thursday December 15, 2022 @11:17PM (#34010122)
I wasn’t particularly in touch with the concept of hash collisions, no. Now that I’ve learned something I can revel in the fact that it only cost me a silly amount or imaginary internet points to do so. Thanks!
Re:Secret scanning is now available for free on public repos... by eloff on Friday December 16, 2022 @09:06AM (#34014567)
That’s a better deal than college :)
Re:Secret scanning is now available for free on public repos... by depereo on Thursday December 15, 2022 @08:12PM (#34008213)
Base64: if this format wasn't secure why are kubernetes 'secrets' stored in it huh?

;)

Re:Secret scanning is now available for free on public repos... by banana_giraffe on Thursday December 15, 2022 @08:27PM (#34008334)
base64 is far too much work. A new dev turned '"AKIAIOSFODNN7EXAMPLE"' into '"AK" + "IAIOSFODNN7EXAMPLE"' to make the security alert go away.

Thankfully, the alert was sent to enough people it was caught by someone else, and the key was destroyed before someone outside could have fun with it.

Re:Secret scanning is now available for free on public repos... by mbildner on Thursday December 15, 2022 @08:40PM (#34008463)
I remember reading in jshint’s docs that they purposely did not chase this kind of lint since at that point the user is clearly fighting the library.
Re:Secret scanning is now available for free on public repos... by reilly3000 on Thursday December 15, 2022 @10:02PM (#34009319)
Given the fact that nobody really does that, I think it was a creative and low risk hack.

1. If you are worried about the people who have access to your codebase abusing a secret, you have a serious people problem that needs to be solved immediately and unambiguously. A motivated internal attacker can do almost anything. Organizations live or die on trust. One doesn’t need to scour for keys break in when they have a badge (or their mate’s) and they built the lock.

2. If you are concerned the secret will be discovered by a generic threat, it won’t, not with this string concatenation. It’s so rare. Should this become a common practice this would be over, retroactively even. We all saw this unfold with with m y e m a I l at y dot com obscurity, until the fine folks who worked on ScrapeBox turned up the right regex to start scraping those too.

3. Nothing else. You are right and responded right. Don’t put keys in code kids. Nobody likes having to erase history in their codebase, especially because of a careless mistake or a deliberate workaround.

I’m just saying… of all the dumb shortcuts that can break stuff, this one is one the mostly harmless end of the spectrum.

Re:Secret scanning is now available for free on public repos... by lolinder on Thursday December 15, 2022 @10:19PM (#34009521)
I take it from your response that you don't lock your door at night, because a motivated external attacker could just bring a ladder and break a window?
Re:Secret scanning is now available for free on public repos... by bombcar on Thursday December 15, 2022 @11:20PM (#34010155)
It's actually quite rare to lock doors at night in substantial parts of the world.
Re:Secret scanning is now available for free on public repos... by reilly3000 on Friday December 16, 2022 @12:02AM (#34010537)
Exactly. Pragmatism has a place in this world. Not everywhere, not everywhen, but more than you might think.

Most of the people in my area don’t lock their doors. A decade ago in a very different neighborhood we had locks, alarm systems, and hyper-vigilance, and still lost thousands via property theft and damage. 5 miles away.

It would be maladaptive of me to bring the same level of vigilance to a different setting. It wastes resources and clouds one’s ability to trust. It slows you down every day.

I don’t know how I could have been more clear that I don’t endorse committing secrets to code, in fact I’ve been a champion for code hygiene and security everywhere I work. I just recognize and think others should as well that there are diminishing returns for precautions where they aren’t used. The returns can diminish so low that they go negative.

Even in the safe neighborhood, one might lock up when they leave for a trip, or make other reasonable preparations to increase security and obscurity.

Yes, I said everywhen, and yes I am asserting that I just coined it and that it’s brimming with greatness :P

Re:Secret scanning is now available for free on public repos... by matkoniecz on Friday December 16, 2022 @12:07AM (#34010602)
Are you also doing with secret (not anymore) data in public repositories on GitHub? Note context of your comment, in thread about secret scanning for public repositories on GitHub.
Re:Secret scanning is now available for free on public repos... by reilly3000 on Friday December 16, 2022 @11:24AM (#34016426)
I do most of my work on private codebases so I went that direction. I had intended to add a qualifier for that but I missed my window to edit.

Agreed there are many ways that working with public repos makes everything dramatically more difficult. I’m pleased to see GHAS secret scanning become free. I’m not clear if that would include the pre-push secret scanning feature. If so you have a really decent toolset for prevention and detection. Remediation should be as easy as key rotation. Except keys get reused and rotation affects all users... if the keys can’t be rotated it’s a big chore for private repos owners, but de facto impossible with public codebases. There is no way of knowing who has cloned it (without paying for enterprise audit logs).

Re:Secret scanning is now available for free on public repos... by bryanrasmussen on Friday December 16, 2022 @01:24AM (#34011191)
Re:Secret scanning is now available for free on public repos... by reilly3000 on Friday December 16, 2022 @11:26AM (#34016451)
TIL and thank you for it. I officially retract my meaningless claim of being its originator.
Re:Secret scanning is now available for free on public repos... by bombcar on Friday December 16, 2022 @11:42AM (#34016683)
"Everywhy" is available so you can originate that.
Re:Secret scanning is now available for free on public repos... by bryanrasmussen on Friday December 16, 2022 @12:24PM (#34017337)
everywhom and their grandwhom has claimed to originate everywhy at least once.
Re:Secret scanning is now available for free on public repos... by matkoniecz on Friday December 16, 2022 @12:06AM (#34010582)
> low risk hack

That seems to be quite high risk hack to rely on such security through obscurity.

Re:Secret scanning is now available for free on public repos... by bagels on Friday December 16, 2022 @04:46AM (#34012687)
Why was that change made? I would assume malice or incompetence?
Re:Secret scanning is now available for free on public repos... by lozenge on Friday December 16, 2022 @04:57AM (#34012744)
I think we need a new phrase for this: "malicious incompetence"

A similar story from my work: "I didn't read the contents of the red warning screen because I knew I wanted to release my code".

Re:Secret scanning is now available for free on public repos... by banana_giraffe on Friday December 16, 2022 @10:48AM (#34015879)
In this case, it was an alarm that ran during build (I think, it's been a while), and used git blame to send a message like "@person: You checked in a secret! Fix this!".

So, they fixed it.

Re:Secret scanning is now available for free on public repos... by woutr_be on Thursday December 15, 2022 @10:02PM (#34009315)
I legitimately recently had to argue with a PM and his developers, that a base64 encoded user ID isn’t considered security best practices for API authentication. Even when I showed them how I can produce the “secret” myself, they kept arguing that I was wrong.
Re:Secret scanning is now available for free on public repos... by bryanrasmussen on Friday December 16, 2022 @01:27AM (#34011222)
Ok I've been around for a long time and I don't think I would have met anyone who would have argued that since around 2009, although I guess I can remember secrets and keys going into repos as late as 2018 at places I've seen.
Re:Secret scanning is now available for free on public repos... by woutr_be on Sunday December 18, 2022 @12:41AM (#34035347)
In fairness, the PM was the kind of guy who has no technical experience, but was arrogant enough to pretend like he did, and most of the devs were pretty junior.

It was the first time for me having to even argue about this.