You don't need to be a part of any particular domain to effectively audit code.
Clearly it gets rockets into the sky, but something similar is true for all code that hasn’t failed catastrophically yet.
This also leads to interesting practices at times like favouring repeating code over writing separate functions to ensure the flow of reading doesn't jump around and instead always moves forward.
They put the flight software through a lot of hardware in the loop tests, simulating launch. That's probably the main novel thing.
You're still missing the point. It isn't about knowing how rockets work or anything in particular. It's about being able to search for and recognize issues.
I don't know why you think someone would have to know about Twitter's specific implementation of distributed systems in order to inspect those systems for non-twitter-specfifc issues.
Sorry, what was it about my comment you vehemently disagree with?
Such as those which do not meet the standards defined for the particular audit.
Do we know what is or isn't being reviewed? Do we know how much effort is being applied in this process or if there's a defined upper and/or lower bound?
Still, the issues you'll likely encounter inside a car are very very different from the ones you'll see inside a historically grown distributed system serving millions of web, app and API requests. Auditing code is more than analyzing runtime/memory complexity.
Thats not to say it's impossible for Tesla engineers to audit. But I'd imagine it would take quite a bit of time to gather meaningful insight into the landscape and would hardly be an efficient use of the time of senior Tesla engineers.
There are many systems involved in those cars, there's also many people working for those kind of companies who do not solely "work on cars."
>Auditing code is more than analyzing runtime/memory complexity.
I agree.
>Thats not to say it's impossible for Tesla engineers to audit. But I'd imagine it would take quite a bit of time to gather meaningful insight into the landscape and would hardly be an efficient use of the time of senior Tesla engineers.
Take longer than if the team were comprised of Twitter staff or who are already familiar with Twitter's infrastructure and code base? Sure. But that's the case with just about any audit conducted by an outside entity.
In short, experience matters.
Also remember that Telsa runs their own distributed systems to support the connected features of their cars. Certainly that's not the same as Twitter, but it's definitely in the same ballpark.
>In short, experience matters.
Is this based off real experience in the field of auditing?
That isn't at all what I said nor implied.
Fooled? No.
>Perhaps consider that your reactionary post was not quite as "rational" as you'd like to believe, or at least that you haven't yet said what you mean.
What part of any of my comments are reactionary? What have I said that I don't mean? I genuinely don't understand.
Did you graduate with an engineering degree or do you just like calling yourself a "web engineer"?
It can be difficult to critique choices, specially in system architecture, when domain requirements are presented or falsely asserted as 'dictating the choice', but this can be addressed by directing conversations with stakeholders to nail down the conceptual model that has been implemented in architecture style x, and then the conversation is on more equal footing.
Auditing language usage, libraries, development process, etc. are much less domain specific.
They wouldn't have to understand any of it, just be able to identify where and when changes occurred, for later review for any last minute shenanigans.
I'm not personally convinced this whole incident even happened, but if it did, this is what I think would make sense.
-- hn_throwaway_99 https://news.ycombinator.com/item?id=33389128
Here I was responding to a comment "What hubris to think that your system is so complex that other engineers couldn't understand it." Which is still a bullshit assessment of the argument (which the original comment was about) that you need expertise in specific domains to be able to evaluate code, which I agree with.
My comment you quoted above is that I think that there would be a subset of Tesla engineers (just not the ones that, for example, solely focus on driver systems) that would overlap with Twitter's domain.
It takes a long time to onboard to a big mature infrastructure that is serving hundreds of millions of users for people moving from a similar company, even longer if your day job is whatever Tesla engineers are doing.
And that's onboarding, not pretending to be an expert which seems to be the role they're taking on.
Would it?
Would it not?
Facebook has a years-old bug with their ML classifier used to flag spam/abuse content in Facebook Groups. Its exact behavior has morphed over time as they flailingly attempt to fix it, but for several straight months that behavior was "posting to a Group via the Graph API fails with 'unknown error' if it includes a dollar sign". This in an API used by tens of thousands of apps and many millions of users, at one of the richest (in both money and programmers) companies on the planet.
ML is often a black box "computer says no" scenario with little meaningful ability to debug.
Who is thinking that?
If you spend $44 billion dollars on something, you're going to want to look it over extremely well.
Even just having access to code while someone talks I can prove with much higher value questions on what they are saying… because even if I’m asking something dumb it prompts a deeper explanation.
Your video player somehow managed to be worse than Reddit, the perennial joke of web dev.
Not to mention “something went wrong” again and again, maybe by the 4th reload would a linked tweet actually show up for me.
I’m on 25 gig symmetrical fiber with <10ms to my local AWS hub, FWIW
That seems like a purpose-built feature to punish non-Twitter users to induce them to sign up for Twitter and/or use the Twitter app instead of the web UI. It's not a bug but a misfeature.
Any competent engineer can come to understand most any part of the system, but it's going to take minimum several weeks to understand what's really going on in a little 0.01% corner of the engineering shop.