News for hackers. Stuff that matters.
Re:Tesla engineers were on-site to evaluate the Twitter staf... by Nicksil on Saturday October 29, 2022 @07:52PM (#33389173)
>Bullshit. I'm a web engineer, and I wouldn't be competent to audit code that runs Space X's rockets, nor would anyone I know in my career space.

You're still missing the point. It isn't about knowing how rockets work or anything in particular. It's about being able to search for and recognize issues.

Re:Tesla engineers were on-site to evaluate the Twitter staf... by inerte on Saturday October 29, 2022 @07:59PM (#33389212)
At Twitter's scale the issues are far less about "this code smells funny" but how dozens of systems interact together. Ain't nobody gonna figure out problems by simply checking out a handful of repositories, and specially in a few hours / days.
Re:Tesla engineers were on-site to evaluate the Twitter staf... by Nicksil on Saturday October 29, 2022 @08:02PM (#33389245)
>At Twitter's scale the issues are far less about "this code smells funny" but how dozens of systems interact together. Ain't nobody gonna figure out problems by simply checking out a repository, and specially in a few hours / days.

I don't know why you think someone would have to know about Twitter's specific implementation of distributed systems in order to inspect those systems for non-twitter-specfifc issues.

Re:Tesla engineers were on-site to evaluate the Twitter staf... by inerte on Saturday October 29, 2022 @08:08PM (#33389300)
Ack, and thanks for your comment. I am choosing to disengage from this conversation, have fun!
Re:Tesla engineers were on-site to evaluate the Twitter staf... by Nicksil on Saturday October 29, 2022 @08:22PM (#33389422)
>Ack, and thanks for your comment. I am choosing to disengage from this conversation, have fun!

Sorry, what was it about my comment you vehemently disagree with?

Re:Tesla engineers were on-site to evaluate the Twitter staf... by saagarjha on Saturday October 29, 2022 @08:28PM (#33389466)
Issues such as what?
Re:Tesla engineers were on-site to evaluate the Twitter staf... by Nicksil on Saturday October 29, 2022 @08:32PM (#33389503)
>Issues such as what?

Such as those which do not meet the standards defined for the particular audit.

Re:Tesla engineers were on-site to evaluate the Twitter staf... by saagarjha on Saturday October 29, 2022 @08:43PM (#33389607)
I mean, you can do a very general audit of things like “is there CI” or “do they use horribly unsafe serialization everywhere” but I don’t see anything beyond this without a huge amount of effort.
Re:Tesla engineers were on-site to evaluate the Twitter staf... by Nicksil on Saturday October 29, 2022 @08:51PM (#33389679)
>I mean, you can do a very general audit of things like “is there CI” or “do they use horribly unsafe serialization everywhere” but I don’t see anything beyond this without a huge amount of effort.

Do we know what is or isn't being reviewed? Do we know how much effort is being applied in this process or if there's a defined upper and/or lower bound?

Re:Tesla engineers were on-site to evaluate the Twitter staf... by saagarjha on Sunday October 30, 2022 @06:08PM (#33399352)
The upper limit is the point where it makes sense to bring in experts rather than random Tesla engineers.
Re:Tesla engineers were on-site to evaluate the Twitter staf... by moooo99 on Saturday October 29, 2022 @08:04PM (#33389265)
> You're still missing the point. It isn't about knowing how rockets work or anything in particular. It's about being able to search for and recognize issues.

Still, the issues you'll likely encounter inside a car are very very different from the ones you'll see inside a historically grown distributed system serving millions of web, app and API requests. Auditing code is more than analyzing runtime/memory complexity.

Thats not to say it's impossible for Tesla engineers to audit. But I'd imagine it would take quite a bit of time to gather meaningful insight into the landscape and would hardly be an efficient use of the time of senior Tesla engineers.

Re:Tesla engineers were on-site to evaluate the Twitter staf... by Nicksil on Saturday October 29, 2022 @08:11PM (#33389323)
>Still, the issues you'll likely encounter inside a car are very very different from the ones you'll see inside [...]

There are many systems involved in those cars, there's also many people working for those kind of companies who do not solely "work on cars."

>Auditing code is more than analyzing runtime/memory complexity.

I agree.

>Thats not to say it's impossible for Tesla engineers to audit. But I'd imagine it would take quite a bit of time to gather meaningful insight into the landscape and would hardly be an efficient use of the time of senior Tesla engineers.

Take longer than if the team were comprised of Twitter staff or who are already familiar with Twitter's infrastructure and code base? Sure. But that's the case with just about any audit conducted by an outside entity.

Re:Tesla engineers were on-site to evaluate the Twitter staf... by hn_throwaway_99 on Saturday October 29, 2022 @08:00PM (#33389227)
I'm not missing the point. "Searching for and recognizing issues" is not somehow completely independent from the domain of the code in question. More importantly, different domains often have completely different primary concerns. E.g. web app engineering is often concerned with reducing cycle time because the technology means that you can instantly release updates. That's obviously very different from the concerns of launching a rocket, and I would expect them to have very different engineering practices.

In short, experience matters.

Re:Tesla engineers were on-site to evaluate the Twitter staf... by kelnos on Saturday October 29, 2022 @08:37PM (#33389564)
I don't think Musk is looking for an itemized bug list. He's probably more interested in overall code quality, estimates on the level of technical debt, and a qualitative feel about the state of things. While a distributed systems person would have an easier go of that, I think most decently-well-rounded software developers would provide value there.

Also remember that Telsa runs their own distributed systems to support the connected features of their cars. Certainly that's not the same as Twitter, but it's definitely in the same ballpark.

Re:Tesla engineers were on-site to evaluate the Twitter staf... by Nicksil on Saturday October 29, 2022 @08:05PM (#33389276)
>I'm not missing the point. "Searching for and recognizing issues" is not somehow completely independent from the domain of the code in question. More importantly, different domains often have completely different primary concerns. E.g. web app engineering is often concerned with reducing cycle time because the technology means that you can instantly release updates. That's obviously very different from the concerns of launching a rocket, and I would expect them to have very different engineering practices.

>In short, experience matters.

Is this based off real experience in the field of auditing?

Re:Tesla engineers were on-site to evaluate the Twitter staf... by uoaei on Saturday October 29, 2022 @07:58PM (#33389201)
I implore you to consider that auditing code is more than just big-O analyses.
Re:Tesla engineers were on-site to evaluate the Twitter staf... by Nicksil on Saturday October 29, 2022 @07:59PM (#33389210)
>I implore you to consider that auditing code is more than just big-O analyses.

That isn't at all what I said nor implied.

Re:Tesla engineers were on-site to evaluate the Twitter staf... by uoaei on Saturday October 29, 2022 @08:11PM (#33389324)
You seem to have fooled literally every person replying to your post, then. Perhaps consider that your reactionary post was not quite as "rational" as you'd like to believe, or at least that you haven't yet said what you mean.
Re:Tesla engineers were on-site to evaluate the Twitter staf... by Nicksil on Saturday October 29, 2022 @08:25PM (#33389439)
>You seem to have fooled literally every person replying to your post, then.

Fooled? No.

>Perhaps consider that your reactionary post was not quite as "rational" as you'd like to believe, or at least that you haven't yet said what you mean.

What part of any of my comments are reactionary? What have I said that I don't mean? I genuinely don't understand.