News for hackers. Stuff that matters.
Re:LGTM – A simple pull request approval system by partido3619463 on Wednesday June 01, 2022 @12:31AM (#31578097)
“ Pull requests are locked and cannot be merged until the minimum number of approvals are received. Project maintainers can indicate their approval by commenting on the pull request and including LGTM (looks good to me) in their approval text.”

Isn’t this how protected branches and github review functionality works anyways? What does this module add?

Re:LGTM – A simple pull request approval system by Deukhoofd on Wednesday June 01, 2022 @03:42AM (#31579193)
Possibly it was not so 6 years ago when the repository was initially made? Of course considering that this is the Gitea fork, their goal might not be the use for Github.
Re:LGTM – A simple pull request approval system by treve on Wednesday June 01, 2022 @01:04AM (#31578312)
Yes, and it has a number of other features, but it's behind a paywall. So perhaps this is for those that want some of those features but don't want to pay.
Re:LGTM – A simple pull request approval system by codsane on Wednesday June 01, 2022 @05:03PM (#31588078)
The README says it uses GitHub protected branches, so I'm not sure if it does get around the paywall. That would be great though!
Re:LGTM – A simple pull request approval system by rektide on Wednesday June 01, 2022 @12:28AM (#31578079)
Ok nice but why would gitea org make a github based capability... the road to bootstrapping is long & weird.
Re:LGTM – A simple pull request approval system by kodah on Wednesday June 01, 2022 @01:05AM (#31578324)
Gitea's API's are GitHub compatible.
Re:LGTM – A simple pull request approval system by 0des on Tuesday May 31, 2022 @11:56PM (#31577890)
"LGTM is a simple pull request approval system using GitHub protected branches and maintainers files or maintainers groups. Pull requests are locked and cannot be merged until the minimum number of approvals are received. Project maintainers can indicate their approval by commenting on the pull request and including LGTM (looks good to me) in their approval text."
Re:LGTM – A simple pull request approval system by cercatrova on Wednesday June 01, 2022 @12:35AM (#31578124)
I always thought LGTM meant "Let's Get This Money!" and not "Looks Good To Me!" but I suppose either interpretation works in most cases.
Re:LGTM – A simple pull request approval system by CameronNemo on Wednesday June 01, 2022 @01:01AM (#31578296)
I thought it was "Let's Get This Merged" and commented it on my own PR once.
Re:LGTM – A simple pull request approval system by rob74 on Wednesday June 01, 2022 @02:54AM (#31578941)
Well, I assume you wouldn't submit a PR if it didn't look good to you, so the acronym is appropriate...
Re:LGTM – A simple pull request approval system by dathinab on Wednesday June 01, 2022 @05:02AM (#31579600)
you have no idea (1) what some people do when some external force tires to make them contribute to opensource ...

1: ok, you probably do know as most people on HN probably do know

Re:LGTM – A simple pull request approval system by steinuil on Wednesday June 01, 2022 @05:54AM (#31579835)
I thought it meant "Let's Get This Merge" like it was a play on "let's get this bread". I know it stands for "Looks Good To Me" now but I still prefer my reading :)
Re:LGTM – A simple pull request approval system by david_van_loon on Wednesday June 01, 2022 @01:14AM (#31578370)
It's an ambiguous acronym. I've used it both ways.
Re:LGTM – A simple pull request approval system by Thorrez on Wednesday June 01, 2022 @03:26AM (#31579096)
All the front page Google results appear to say Looks Good To Me

https://www.dictionary.com/e/acronyms/lgtm/

https://www.urbandictionary.com/define.php?term=LGTM

https://www.freecodecamp.org/news/what-do-cryptic-github-com...

https://knowyourmeme.com/memes/lgtm

https://www.cyberdefinitions.com/definitions/LGTM.html

Urban Dictionary does have Let's Get This Merged as its second definition, but it's at a net of -121 points, whereas Looks Good To Me is at net 941, and was added 10 years earlier. That doesn't seem ambiguous to me.

Re:LGTM – A simple pull request approval system by darkwater on Wednesday June 01, 2022 @03:46AM (#31579223)
First time I hear "Let's Get This Money!" is a thing.
Re:LGTM – A simple pull request approval system by Jach on Wednesday June 01, 2022 @03:22AM (#31579074)
I once briefly thought it was "Let's GoToMeeting" -- like they want to schedule a call over it.
Re:LGTM – A simple pull request approval system by bl0rg on Wednesday June 01, 2022 @06:19AM (#31579960)
huh, I always thought it meant "Lets greet the man"