Re:LGTM – A simple pull request approval system
by CameronNemo on Wednesday June 01, 2022 @01:01AM
(#31578296)
I thought it was "Let's Get This Merged" and commented it on my own PR once.
[ Parent
| on HN ]
Re:LGTM – A simple pull request approval system
by rob74 on Wednesday June 01, 2022 @02:54AM
(#31578941)
Well, I assume you wouldn't submit a PR if it didn't look good to you, so the acronym is appropriate...
Re:LGTM – A simple pull request approval system
by dathinab on Wednesday June 01, 2022 @05:02AM
(#31579600)
you have no idea (1) what some people do when some external force tires to make them contribute to opensource ...
1: ok, you probably do know as most people on HN probably do know
Re:LGTM – A simple pull request approval system
by steinuil on Wednesday June 01, 2022 @05:54AM
(#31579835)
I thought it meant "Let's Get This Merge" like it was a play on "let's get this bread". I know it stands for "Looks Good To Me" now but I still prefer my reading :)
Re:LGTM – A simple pull request approval system
by david_van_loon on Wednesday June 01, 2022 @01:14AM
(#31578370)
It's an ambiguous acronym. I've used it both ways.
Re:LGTM – A simple pull request approval system
by Thorrez on Wednesday June 01, 2022 @03:26AM
(#31579096)
All the front page Google results appear to say Looks Good To Me
https://www.dictionary.com/e/acronyms/lgtm/
https://www.urbandictionary.com/define.php?term=LGTM
https://www.freecodecamp.org/news/what-do-cryptic-github-com...
https://knowyourmeme.com/memes/lgtm
https://www.cyberdefinitions.com/definitions/LGTM.html
Urban Dictionary does have Let's Get This Merged as its second definition, but it's at a net of -121 points, whereas Looks Good To Me is at net 941, and was added 10 years earlier. That doesn't seem ambiguous to me.