News for hackers. Stuff that matters.

A comment on LGTM – A simple pull request approval system.

Re:LGTM – A simple pull request approval system by partido3619463 on Wednesday June 01, 2022 @12:31AM (#31578097)
“ Pull requests are locked and cannot be merged until the minimum number of approvals are received. Project maintainers can indicate their approval by commenting on the pull request and including LGTM (looks good to me) in their approval text.”

Isn’t this how protected branches and github review functionality works anyways? What does this module add?

[ Parent | on HN ]
Re:LGTM – A simple pull request approval system by Deukhoofd on Wednesday June 01, 2022 @03:42AM (#31579193)
Possibly it was not so 6 years ago when the repository was initially made? Of course considering that this is the Gitea fork, their goal might not be the use for Github.
[ Parent | on HN ]
Re:LGTM – A simple pull request approval system by treve on Wednesday June 01, 2022 @01:04AM (#31578312)
Yes, and it has a number of other features, but it's behind a paywall. So perhaps this is for those that want some of those features but don't want to pay.
[ Parent | on HN ]
Re:LGTM – A simple pull request approval system by codsane on Wednesday June 01, 2022 @05:03PM (#31588078)
The README says it uses GitHub protected branches, so I'm not sure if it does get around the paywall. That would be great though!
[ Parent | on HN ]