News for hackers. Stuff that matters.
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by CameronNemo on Sunday January 02, 2022 @10:45PM (#29777102)
I can't stop laughing at the idea of GitLab struggling to render 100k lines of changes.

Please actually attempt the ideas you are suggesting before suggesting them.

This set of changes (and other large ones like it) is partially why the kernel needs to use email instead of <insert bloated Ruby application here>.

Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by nyanpasu64 on Monday January 03, 2022 @12:47AM (#29777757)
GitLab is awful and slow at rendering large changes. Sometimes when folding and unfolding files, the scroll position will jump around (though I'm unsure if that's a browser extension). And when viewing standalone files, KDE's Invent GitLab server is slow and can take 5-10 seconds to render a few thousand lines and send it to the client as JSON with syntax highlighting, before the file contents show up.
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by masklinn on Monday January 03, 2022 @03:13AM (#29778468)
> GitLab is awful and slow at rendering large changes

So’s github, anything of a non-trivial size it just won’t show by default and you need to re-request every time.

It starts struggling around the kloc scale, and the browser itself soon follows as the dom is not the neatest and you start getting tab memory above half a gig, which I assume also makes the JS start killing itself or something.

Good times.

Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by merb on Monday January 03, 2022 @06:46PM (#29788752)
gitlab can't render this changeset. gitlab has a limit what it can render.
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by xyzzy_plugh on Sunday January 02, 2022 @11:13PM (#29777260)
> why the kernel needs to use email instead of

This sort of implies that the Kernel would use something centralized if it worked well, which I don't believe to be true. Using email is very much an intentional choice and a desirable solution.

Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by charcircuit on Monday January 03, 2022 @01:14AM (#29777888)
>This sort of implies that the Kernel would use something centralized if it worked well, which I don't believe to be true.

The mailing list that they use now is centralized. It works by everyone sending a message to a single email address. The owner of that address then sends the email out to all of the subscrbers of the mailing list.

Having everyone who wants to upstream their patch directly to the kernel submit their work to a single website is not much different than them sending it to a single email.

Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by hnaccount_rng on Monday January 03, 2022 @04:54AM (#29779053)
But that isn't how it works right? You send your pull requests to the relevant maintainer, CC people that you think should be aware _and_ send it to the mailing list (probably also "only" via CC).

This here for example is sent to Linus directly and that part does _not_ depend on the mailing list. The mailing list is just a convenience feature for people that _want_ to be aware but may be looked over/forgotten by the submitter (which still happens, and people regularly say stuff like "also CC'ing additional relevant people").

Yes you could, at least in principle, also do that via GitHub/GitLab/whatever. But a) you wouldn't gain anything (the kernel already has all the tooling it needs and it's large enough to just create missing tools, heck git was literally written for it), b) you would introduce a massive single point of failure that either i) is _not_ under control of the kernel.org team or ii) needs a massive amount of resources to host (see the fun people poke at displaying 2k commits in GitLab). Neither seems like a good use of the kernel development resources. And if you want to contribute to the kernel... using a mailing list is an absolutely trivial problem.

Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by CameronNemo on Monday January 03, 2022 @12:16AM (#29777589)
Yeah which is why I put the word "partially" in front of that out of context quote.
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by ncann on Sunday January 02, 2022 @11:30PM (#29777346)
It's not like you would render and display the diffs in 2k emails at the same time either.
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by hamburglar on Monday January 03, 2022 @03:57AM (#29778725)
There’s no reason you couldn’t. And part of the beauty of patch emails containing full diffs is that you can take them and use whatever tool you want to render them and not be beholden to some dumb web UI’s opinion of what’s “too big.”
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by CameronNemo on Monday January 03, 2022 @12:18AM (#29777605)
The difference is in one case a centralized server is expending a lot of resources to show something to the user, and in the other case it all happens locally and has no effect on the kernel.org infrastructure.
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by encryptluks2 on Monday January 03, 2022 @04:31AM (#29778922)
I don't think the issue is with the centralized server, but the browser and the JS components they use. I prefer local anyhow.
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by wtallis on Sunday January 02, 2022 @11:34PM (#29777364)
Didn't git do exactly that in preparing those emails to be sent? I wonder how long it took for that command to run.
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by db48x on Monday January 03, 2022 @01:28AM (#29777978)
Probably very, very quickly. git-format-patch is very fast; all it has to do is diff the files involved in each commit, which is already heavily optimized. No syntax highlighting (your email program can do that if you want it), or line numbering (ditto).
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by db48x on Monday January 03, 2022 @05:24AM (#29779255)
61.65 seconds to create all 2,298 emails on my computer, with the repository on spinning rust. That’s about one fortieth of a second each on average.
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by bonzini on Monday January 03, 2022 @02:24AM (#29778248)
Don't discount the heaviness of rendering the HTML on the client, too!
Re:“Fast Kernel Headers” Tree -v1: Eliminate the Linux Kerne... by charcircuit on Sunday January 02, 2022 @11:07PM (#29777231)
I'm sure it could handle you viewing each commit one at a time just how with email you would look at each commit one at a time.