There's a lot that the guy could have done differently to demonstrate what a legitimate pull request looks like. Because this wasn't it.
Now, updating “copyright 2018-2019” to “2020” isn’t.
Unfortunately, in many cases now, copyright is based on the year the author died, rather than the year the work was created, which means it is much harder to work out if something has entered the public domain.
Changing the date without changing the code significantly is arguably fraudulent.
if you create some content in 2018 and I rip it off in 2019 and then you update your copyright to 2020, what's to stop me from saying I came up with it first?
In some countries the publishing date is what counts, and they define publishing for websites as when the site was viewed.
No, the publishing date is relevant (not the first publishing date).
I regularly have to shop around for libraries. Seeing a copyright 2017 doesn't bode well for the documentation or the project being maintained.
Check out this PR: https://github.com/OscarZhou/CSharpTraining/pull/1/commits/8...
How would you like to receive dozens of PRs like that? You would absolutely consider that blatant spam.
The problem a lot of the hacktober fest PR don't do any of that.
E.g. on the rust repo some one added a bunch of PRs which add "### The best" to some readmes.
That is the thing with spam in general - you can tell it from legitimate mail easily, but is it still annoying and requires you to deal with it.
Of course, if a company started offering free t-shirts for mailing list submissions and some foolish (but well-meaning) youtuber would publish a tutorial on how to subscribe and post to a mailing list, I have no doubts that there would be a deluge regardless of this higher bar. :)
As someone who has been contributing to Linux for a few years now, which uses mailing lists exclusively for all development (and not only do they use Git, they wrote it) I've found that mail-based workflows are in some ways better to GitHub/GitLab/etc:
1. You can review individual patches, you cannot do this in GitHub at all (commenting at the bottom of a commit doesn't count because it's not tied to the PR and the comment is lost to ether on force-push). GitHub also defaults to you reviewing the full diff and make reviewing individual commits kind of frustrating (you're just dropped into the commit history view rather than a proper review view).
2. All code reviews end up being line-based because the patch is the main body of the email. Design discussion happens as replies to the cover letter of the patch set, meaning you can easily tell which kind of discussion is happening. You can also directly comment on the git commit message, which the kernel community values a lot more than most projects.
3. You can far more easily be notified on patches sent to sections of the tree (though this is slightly tied to Linux's development workflow with subsystem maintainers). GitHub only lets you watch a repository and get the firehouse of events -- which is about as useful as subscribing to the main LKML and trying to keep up with the notifications.
As for difficulty, honestly the bar to entry to send a patch to a mailing list if you're using Git is just:
$ git send-email --to ... --cc ... origin/master
I would suggest doing "git format-patch" with --cover-letter and then checking the patch contents first, but you can do it one command for simple patches. Git was designed to make this mailing list approach work, so it shouldn't be surprising that it's actually pretty simple to use.> feedback that can be given right there on the line of code it pertains to
Done easily with a mailing list, and you can be sure that the comment won't just magically disappear because GitHub decided it was fixed even when it wasn't.
> excruciatingly painful if they don't even use a modern DVCS like git.
As far as local development is concerned, there's no reason you can't use all the git tools to manage your changes.
Comments about a patch are fleeting and should be gone after the patch lands — and should be treated as such. Any relevant comments will be in the source code.
GitLab (and several others) can be self-hosted for free; and the walled garden (GitHub?) is tolerable enough. And as long as you keep your software development practices sensible (centred around git, not GitHub), there hardly is a wall really.
> As far as local development is concerned, there's no reason you can't use all the git tools to manage your changes.
Certainly possible, but I didn't manage to get git-svn working the last time I wanted to contribute to a SVN repo. In the end I just created a local git repo in-place and generated the patch with git format-patch.
I'm sure my first ever PR was adding an example to the docs for something, and if that had been closed with no response and labelled spam I doubt I'd have stayed around to contribute again.
There are software projects out there, even highly used ones, that only use Github to mirror their SVN repository (or some other yesteryear source code system). For those maintainers these PRs do take up more time than they contribute though.
I can limit interactions to non-new users.
I can limit interactions to users that have contributed before.
I can limit interactions to users that I have manually whitelisted in my repo.
Unfortunately, only one of these can be active at a time, but the options do exist now.
Go to your repo -> Settings -> Moderation Settings -> Interaction Limits
A lot of projects have simply no easy guide to get from a git pull to a working build for someone not familiar with the language or build system used.
Generally speaking, (T-shirt farming aside), if you find a genuine typo, or small way to improve documentation, then that PR will be very much appreciated. README-typos are quite visible, yet easy for maintainers to overlook.
If you are new to GitHub, please do not be discouraged, and as with editing Wikipedia- be bold.
(In the large scheme of things, its really positive that so many people worked out how to make a PR, and were then motivated to do so- lets not shame them too hard. Although occasionally neccessary, we must be mindful about gatekeeping, especially with the young and inexperienced)