News for hackers. Stuff that matters.
Re:Code Health: Respectful Reviews == Useful Reviews by PragmaticPulp on Thursday November 07, 2019 @12:37PM (#21475258)
I agree with the premise. Workplaces are much more enjoyable when everyone is respectful, professional, and courteous to their peers.

Most of these guidelines are reasonable enough. I think it's important to keep the DOs and DON'Ts list to the minimum, though. These interaction guidelines become counter-productive when they try to be all-encompassing definitions of good and bad interpersonal behavior.

I worked with one team who had an ever-expanding code of conduct. Each time they had a conflict, they tried to add rules to the CoC that they thought would prevent the conflict. Good intentions, but counter-productive execution. Three things happened:

1) New hires had to learn to navigate a minefield of obscure code of conduct rules. They tended to shutdown and socially isolate themselves for fear of accidentally triggering another obscure CoC issue, like including emojis in code reviews. The safest thing to do is only interact with close allies within the company, and minimize unnecessary interaction with anyone else. Silos.

2) The CoC became a tool for power plays. For a few bad apples, the CoC became a list of gotchas that they could use as a power play against others. At one point we had someone reading every Slack conversation and code review just to call out possible CoC violations (remember, this includes things like using emojis in code review) so they could call other people out on their violations. Substantiative conversations moved to private messages or in-person conversations. Not healthy. Partially solved by adding a CoC rule about minding your own business and explaining healthy ways to share the CoC with others.

3) Human interactions started to feel robotic, almost scripted. This one is harder to describe, but each interaction with someone in public or outside your close friend group started to feel like everyone was following a mental script for how our conversations could proceed. Conversations felt like a mental checklist of what was an acceptable way to discuss a differing opinion or answer a question without the possibility of stepping on anyone's toes. It became draining in ways that I haven't experienced since. It was a huge relief when I moved to another company where people were allowed to talk freely to each other, like professional adults.

Re:Code Health: Respectful Reviews == Useful Reviews by threwawasy1228 on Thursday November 07, 2019 @01:46PM (#21476040)
This is really interesting, I think this is how the general population views social justice and other activist issues actually. It seems to be a similarly structured setup where we implement a byzantine list of things that people of privilege are supposed to keep track up, starting out as a list of good intentions that then spirals out of control. Afterwards nobody is real with anyone anymore and we are simply left with a system where most social interaction feels like a robotic scripted attempt to follow the rules of privilege.
Re:Code Health: Respectful Reviews == Useful Reviews by matheusmoreira on Thursday November 07, 2019 @03:25PM (#21476929)
The problem is they come up with all these rules for others to follow. They don't seem to realize the rules also apply to them. It's perfectly fine to call for the exclusion of a man because of a controversial tweet but when protected groups do the same thing and people try to hold them accountable they get laughed at as if it was absurd and wrong to even try.
Re:Code Health: Respectful Reviews == Useful Reviews by erikpukinskis on Thursday November 07, 2019 @09:41PM (#21479562)
I think you’ve fallen prey to propaganda that paints proponents of social justice in a certain way.

The social justice warriors I know _are_ part of the general population, and mind their business, and work hard every day to help people in need.

I am always disappointed when I see people write off the entire cause of social justice as pointless meddling. You’ve been duped if you think that’s all that’s going on.

The “general population” you aligned yourself with is chock full of SJWs who you have had only positive interactions with. But you would never know it...

Like trans people who pass... how would you ever realize they exist? And yet there they are.

Re:Code Health: Respectful Reviews == Useful Reviews by porknubbins on Thursday November 07, 2019 @10:43PM (#21479802)
While I’m in agreement with a lot of their causes, I have to say all SJW types I’ve met have been an very particular slice of the population, almost all educated, urban dwelling millennial age people. As a contract worker I see lots of job environments and I kind of enjoy the less upscale more down to earth (ironically more racially diverse) jobs where you don’t have to remember whose pronouns are “they” this week. I can’t even remember what pronouns are supposed to be modified so I messed up last time saying mine were “he/his”.
Re:Code Health: Respectful Reviews == Useful Reviews by fcarraldo on Thursday November 07, 2019 @11:34PM (#21479996)
After saying your preferred pronouns are “he/him/his”, would you feel offended if people intentionally ignored that and instead referred to you as “her”?

Dismissing an entire class of people with pithy comments about “they/their” pronouns might seem fine to you, but it sure as hell doesn’t feel good when you’re on the other side of it. Be respectful to all people and not just the ones that don’t inconvenience you.

Re:Code Health: Respectful Reviews == Useful Reviews by matheusmoreira on Friday November 08, 2019 @03:44AM (#21480775)
> Be respectful to all people and not just the ones that don’t inconvenience you.

This is a good ideal to strive for. However, people should not be getting fired, banned, excluded, ostracized or otherwise sanctioned over this. For example:

https://github.com/joyent/libuv/pull/1015

https://www.joyent.com/blog/the-power-of-a-pronoun

What happened in that pull request is completely disproportionate. These reactions and punishments will cause chilling effects. People are watching.

Re:Code Health: Respectful Reviews == Useful Reviews by fcarraldo on Friday November 08, 2019 @09:52AM (#21482676)
If anything is disproportionate in your examples, it’s the reactions of those against merging the pull request. Using “he/him” in technical documentation is as tone-deaf as using “she/hers” when writing recipes. Men, women and non-binary engineers exist and we should not hold principles that prevent entirely innocuous changes like changing “him” to “their” in a readme, period. The only reason that GitHub PR thread and the Joyent blog post escalated as they did was the strong reaction by the individuals who were against the change. If the PR was just merged, there would’ve been no controversy.
Re:Code Health: Respectful Reviews == Useful Reviews by matheusmoreira on Friday November 08, 2019 @12:13PM (#21484296)
There were valid reasons to reject the change:

> Us maintainers tend to reject tiny doc changes because they're often more trouble than they're worth.

> You have to collect and check the CLA, it makes git blame less effective, etc.

Even if you don't agree, nothing in there even comes close to justifying the abuse leveled against the developer. A small documentation change led to the departure of a core developer. Was it worth it?

Re:Code Health: Respectful Reviews == Useful Reviews by fcarraldo on Friday November 08, 2019 @02:45PM (#21485972)
It led to Ben's departure because he abjectly refused to listen to the user community, encouraged a tremendous amount of public debate over his personal decision to go against the community's wishes, then single-handedly reverted Isaac Childers' commit accepting the change with the following pithy comment[0]:

> Revert "doc: Removed use of gendered pronouns"

> @isaacs may have his commit bit but that does not mean he is at liberty

> to land patches at will. All patches have to be signed off by either

> me or Bert. Isaac, consider yourself chided.

Do you feel that this is acceptable behavior that should be encouraged? Ben was fully in the wrong here, and if this was instead about Tabs vs Spaces instead of something political in nature, we wouldn't be having this debate. Ben acted childishly, was called out on it, and then _decided to leave of his own volition_ because he felt he was unwanted, which was true given his behavior.

Was it worth it? I don't know, ask Ben.

[0]https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482d...

Re:Code Health: Respectful Reviews == Useful Reviews by matheusmoreira on Friday November 08, 2019 @06:43PM (#21488161)
> encouraged a tremendous amount of public debate

I don't think "debate" is the right word for what happened in that thread.

> then single-handedly reverted Isaac Childers' commit

A perfectly good reason for reverting the commit was provided in the message itself: "All patches have to be signed off by either me or Bert." It looks like the patch didn't meet that criteria. He also cited other valid reasons for rejecting it: "have to collect and check the CLA, it makes git blame less effective, etc."

Is this change so overwhelmingly important and urgent that it overrides the aforementioned policy and concerns? I don't know.

Does the fact he rejected the patch excuse the way people reacted to his decision? No.

Re:Code Health: Respectful Reviews == Useful Reviews by porknubbins on Tuesday November 12, 2019 @09:39PM (#21520740)
I agree with respecting everyone and would never, for example, intentionally call a trans woman “he” because I can see by looking what to say. My issue is with people who are asking to have all of us remap language to remember a special exception for them (ie she looks female but feels nonbinary so wants to be called they) and gets offended if you don’t remember. It just feels like a highly politicized exercise, and though I try to comply it feels awkward.
Re:Code Health: Respectful Reviews == Useful Reviews by threwawasy1228 on Friday November 08, 2019 @12:47AM (#21480221)
I absolutely disagree, you are making a major incorrect assumption about why I have the opinions I do. I readily engaged with SJW activists and helped organize/participated in numerous events and protests. I know EXACTLY what they are like, and it isn't propaganda that causes me to think of them in this light, it was being around them and trying to work together with them in common cause that caused me to have this attitude.

Normal people can hold social justice opinions and go about their business normally like you say, but these people are not at all what I'm talking about in this discussion. And yes I would say that the general population is NOT chock full of the type of SJWs I hung out with in college. I would know.

Cite me a statistic if you want to convince me otherwise.

Re:Code Health: Respectful Reviews == Useful Reviews by erikpukinskis on Friday November 08, 2019 @12:54PM (#21484846)
I am not trying to discount your experience. I have met people like that too.

I’m just saying, that’s not the entirety, or even the majority of people who are fighting for social justice.

And there are powerful media campaigns working hard to get you to think that they are.

What you’re saying is a little like sating “I’ve been to every Taco place in Chicago, I am speaking from experience, tacos are trash.”

And I’m saying, there are a lot of other tacos out there.

Re:Code Health: Respectful Reviews == Useful Reviews by mercer on Friday November 08, 2019 @02:54PM (#21486062)
> What you’re saying is a little like sating “I’ve been to every Taco place in Chicago, I am speaking from experience, tacos are trash.”

It's more like saying "I've been to every Taco Warrior place in Chicago...".

While I think the term SJW is often used too broadly to include "reasonable people who care about social justice", I also think the term SJW quite often is specific enough to be used as a label for people who take the issue of social justice a little too seriously, often to the point of making it a (seemingly) core part of their identity.

Personally I'd say let's be reasonable and stop using the overloaded term 'SJW', but at the same time I do agree that there are certain people for which it would be nice to have a label, where SJW (emphasis on 'warrior') is kind of the right one.

Re:Code Health: Respectful Reviews == Useful Reviews by erikpukinskis on Friday November 08, 2019 @09:00PM (#21489039)
I guess I would ask you: why do you want a special term for the shitty version of this specific category of people?

Do you have other terms for the shitty people within other specific groups? Do you have a term you use specifically for the shitty business people? Do you have a term you use specifically for shitty athletes? For shitty politicians? For shitty women?

We have a word for the shitty version of a gay person. We also have a word for the shitty version of a black person. Worth noting. Louis CK says he has nothing against gay people, but he wants to use the F-word to connote a special kind of shitty gender nonconforming man.

Have you thought about where this SJW label came from and why it exists in the first place?

Re:Code Health: Respectful Reviews == Useful Reviews by hogFeast on Thursday November 07, 2019 @07:18PM (#21478919)
This should only apply for large companies. Only in large companies do you end up employing large numbers of idiots. And only then do you need the rules that a minority go crazy with.

In my experience, the cure is usually worse than the disease. Give someone a rulebook that they can use to justify the awful inclinations of their personality, and they will spend 99% of their energy doing this.

Small companies manage this better in my experience - outside of the guy who came from LARGE TECH COMPANY and spends all day writing lists and telling people how they do things at LARGE TECH COMPANY - because they will get rid of someone who is being disruptive rather than try to move them somewhere else. HR in large companies tends to be far softer.

Btw, my point is that all this applies to social activism too. We need rules because eventually someone will do something dumb. The rules will get taken too far. And that small minority ends up making almost everyone else unhappy.

Incidentally: there is a probably a parallel with this forum. Of any internet forum, this place is probably the most humourless and exacting when it comes to people quoting rules (often by number) to each other. The monkeys will take over the zoo 100% of the time in these cases.

I have actually even had interviews like this. I remember one particularly funny one was for a front-end role where I was witness to a lecture from a "senior dev" on the topic of: why X technology/pattern is "wrong"?

Re:Code Health: Respectful Reviews == Useful Reviews by munchbunny on Thursday November 07, 2019 @01:37PM (#21475945)
> 2) The CoC became a tool for power plays. For a few bad apples, the CoC became a list of gotchas that they could use as a power play against others. At one point we had someone reading every Slack conversation and code review just to call out possible CoC violations (remember, this includes things like using emojis in code review) so they could call other people out on their violations. Substantiative conversations moved to private messages or in-person conversations. Not healthy. Partially solved by adding a CoC rule about minding your own business and explaining healthy ways to share the CoC with others.

I've seen this happen too. Not for code reviews, but for process rules in general. IMO the key issue is that rules can't be used as a substitute for good judgement, and bad judgement needs to be an explicitly fire-able performance metric.

Unfortunately, it's really hard to make sure "good judgement" is educated and constantly re-evaluated, and not just whatever baggage the person carries (misconceptions at best, outright ageism/sexism/racism at worst). From the perspective of leadership, this is a tough but solvable problem: read about people management and sociology diversely and avidly, establish actually anonymous lines of feedback for ground level employees to upper management, and set a precedent for firing jerks promptly. From the perspective of an employee facing bad management, good luck fixing that. It's probably easier to just find a new job.

Re:Code Health: Respectful Reviews == Useful Reviews by SkyBelow on Thursday November 07, 2019 @04:16PM (#21477349)
But that sounds like an inconsistently enforced rule which means selectively applied, eventually done so on factors that would be considered unacceptable if written down.

If a rule is written down, I'm prefer it be fully enforced other than being used as a club to selectively bludgeon certain individuals. Yes, at first it will be used against those who 'deserve' it based on some social metric. But how long before it is used against unattractive people more than attractive people (see Halo effect) or used against people with less social skills more than those with greater charisma?

I've seen it happen one too many times to think the new rule won't end up with the same abuses.

Re:Code Health: Respectful Reviews == Useful Reviews by munchbunny on Thursday November 07, 2019 @06:45PM (#21478647)
> But that sounds like an inconsistently enforced rule which means selectively applied, eventually done so on factors that would be considered unacceptable if written down.

You're going to have to pick a position on the spectrum between always-enforced rules and purely honor codes (and social pressure). We know the former fails because hard and fast rules can be and are gamed. We know honor codes and social pressure only keep honest people honest. So in practice, where on this spectrum do you stand?

If it's your company, or team, or club, or whatever other gathering of humans, you have to make a choice on this question.

Re:Code Health: Respectful Reviews == Useful Reviews by SkyBelow on Friday November 08, 2019 @10:29AM (#21483055)
It's something I have spent a lot of time thinking about, and while I have yet to reach a conclusion, I believe in a function that approaches always enforced rules as penalty for breaking the rules increases. When the penalty is high, the harm the average player feels from someone gaming the rules is preferable to the harm they feel from having the rules selectively applied to them.

I also strongly encourage pointing out the 'real rules' that the written rules are enforced by when they are selectively enforced. Many times they are much harder to tolerate once called out.

Re:Code Health: Respectful Reviews == Useful Reviews by munchbunny on Friday November 08, 2019 @03:56PM (#21486651)
What you're talking about here is creating a robust mechanism for monitoring, investigating, and revising the rule system, which I think we both agree about. My point is that if you are a leader, there is a general approach to make sure your organization has that. Not so much as a peon.

To bring it back to your original point, you expressed a clear preference for a letter-of-the-law approach, and for rules that are always applied and always enforced. You place the burden of fairness on the creator of the rule instead of the enforcer. That's an understandable approach. I don't agree now, but I did at one time, so let's run with it.

How would you define guidelines/rules for code reviews specifically, or engineering culture in general? Would you? How would you remediate brilliant jerks? How would you measure and incentivize working well with the rest of the team/company?

Re:Code Health: Respectful Reviews == Useful Reviews by SkyBelow on Monday November 11, 2019 @09:30AM (#21505077)
Code cop. Naming standards would very consistent. If it is SSN, Ssn, or SocialSecurityNumber, it will be that way all across all databases of the same system. Rules would differ per system, because there are different best practices per system, which is what I would start with as there is far more expertise into those best practices than what I have. Rules would be equally enforced, but anyone would have the ability to request change.

Overall, where possible I rather not have a rule and only create them as needed. Once needed it is created and enforced consistently.

>How would you remediate brilliant jerks? How would you measure and incentivize working well with the rest of the team/company?

These are areas I'm not proficient in and thus I would first need more study.

One thing is that I don't really think there is a choice between two options, but that both options are the same. The only difference from social pressure is that the rule system is much more complex and not written down because people cannot tolerate facing the rule system once written. Imagine a law that says attractive people get less time in prison, would that stand? That women get less prison time? That whites get less prison time? Yet this is what happens when judges are free to given sentences and prosecutors are free to pick what charges to bring.

What I advocate is any rule must be written down, and thus any unfairness like the above must be faced and either codified and thus open for challenge or be done away with by removing the subjective application of a rule.

Re:Code Health: Respectful Reviews == Useful Reviews by chapium on Thursday November 07, 2019 @06:04PM (#21478239)
The pattern I see is the person spearheading code of conduct is quarantined in their own office so the rest of the team doesn't have to put up with them. Not necessarily managers.
Re:Code Health: Respectful Reviews == Useful Reviews by SoftwareMaven on Thursday November 07, 2019 @06:13PM (#21478332)
One of the most important things I've learned over the years I've managed people is that processes and policies of any sort are two-edged swords. It's easy to add a policy, and to convince oneself of the advantage the policy will confer. What is very often ignored is the cost of a policy.

Every policy comes with an associated cost, and those costs can add up quickly. People always ask "what will this policy make better", but, just as important, is to ask, "what will this policy make worse".

Re:Code Health: Respectful Reviews == Useful Reviews by BurningFrog on Thursday November 07, 2019 @07:35PM (#21479009)
I've come to believe that ignoring one side of the cost/benefit calculus is the root cause of an enormous number of mistakes.

To spell the two errors out:

A: "This has a benefit, so we should do it!"

B: "This has a cost, so we should not do it!"

Re:Code Health: Respectful Reviews == Useful Reviews by ljm on Thursday November 07, 2019 @08:31PM (#21479277)
I like to talk about trade-offs a lot, and opportunity cost is also a good way to look at it. But yeah, it’s not often I see that happen.

Even better, make that a function of time so your cost/benefit analysis looks further beyond your initial preference. Spending more to save more is a highly effective choice in the right circumstances, and equally so, a perceived rapid gain can cost a fortune a bit later on.

It’s never so easy as saying always do D, prefer Y, avoid Z. They’re prescriptive and reactionary.

Re:Code Health: Respectful Reviews == Useful Reviews by chrisco255 on Thursday November 07, 2019 @01:16PM (#21475710)
Conflict isn't necessarily bad and it's often very, very healthy as long as it doesn't descend into name calling or something toxic.
Re:Code Health: Respectful Reviews == Useful Reviews by BeetleB on Thursday November 07, 2019 @08:22PM (#21479229)
Agreed, but I consider this kind of a non-statement.

Conflict isn't bad. It's misunderstandings that are bad and lead to name calling or worse. In my experience, the majority of bad behavior at work is due to a misinterpretation of good/neutral intentions.

Conflict avoidance is pretty bad, in my opinion. However, it is a mistake to look at codes of conduct purely from an avoidance angle. This blog post is likely not about avoiding conflicts.

Re:Code Health: Respectful Reviews == Useful Reviews by benologist on Thursday November 07, 2019 @01:51PM (#21476079)
I think what makes HN so high-quality overall is the constant policing for personal attacks and toxicity. Some sites have 'rules' that are barely or not enforced at all that you must be respectful but this is the only site that consistently and objectively enforces good conduct.
Re:Code Health: Respectful Reviews == Useful Reviews by blub on Thursday November 07, 2019 @02:53PM (#21476687)
One weakness is that users can gang on politically incorrect comments or threads and flag them.

Last I've seen this was a thread about the professor which was claiming that women aren't disadvantaged in physics. It was a totally harmless thing, about how a journal decided to publish his views.

Re:Code Health: Respectful Reviews == Useful Reviews by wwright on Thursday November 07, 2019 @08:15PM (#21479196)
ime, what is called “political correctness” is often interpreted as “respecting others” by different people.

You can disagree with what expectations they have for interpersonal respect, but I think that’s how the other side sees it.

Re:Code Health: Respectful Reviews == Useful Reviews by Jamwinner on Friday November 08, 2019 @01:56PM (#21485461)
Downvoting without offering counterargument is disrespectful and counter productive.
Re:Code Health: Respectful Reviews == Useful Reviews by raxxorrax on Friday November 08, 2019 @01:03AM (#21480272)
But this is enforced by the users themselves to 99%. This is a very fundamental difference.
Re:Code Health: Respectful Reviews == Useful Reviews by esotericn on Thursday November 07, 2019 @02:42PM (#21476573)
I find this really interesting. I'm wondering if this is a cultural thing.

I didn't interpret the list as being a set of instructions at all. More of an expression of an opinion on what people should do. You read it, learn, incorporate it into your working life.

It happens to be that I pretty much agree with it all, but if I didn't, I wouldn't find myself consulting the list to decide whether I should or shouldn't say something.

If someone 'called me out' on a 'violation' of this document, I'm not sure how I'd respond. Probably with laughter? I honestly don't know, perhaps I'm just in a bubble.

We can discuss as adults, if there's a problem with my communication I want to know. I don't want to be pointed at the rule book, this isn't primary school.

Re:Code Health: Respectful Reviews == Useful Reviews by munchbunny on Thursday November 07, 2019 @03:35PM (#21476997)
> If someone 'called me out' on a 'violation' of this document, I'm not sure how I'd respond. Probably with laughter? I honestly don't know, perhaps I'm just in a bubble.

Let's say, hypothetically, because this is neither you nor me, that I wrote something like "Were you paying attention in CS100?" to a dumb mistake in your pull request. We all slip sometimes, so generally these shouldn't be big deals. Quick fix and move on.

You said to me: "Hey, in your last code review you openly insulted my competence by saying '______'. Please don't do that."

I responded: "No, you deserved that for the type of mistake you made."

I know 1-2 developers personally who would genuinely believe that. I've encountered far more here and on Reddit that would as well.

I think the real versions of us would both agree that the hypothetical me is being a jerk. Having a guideline that says "Don't criticize the person" gives you a way to take this up your managerial chain with a specific problem, as opposed to a general statement of "munchbunny was being a jerk."

While you might not need this in order to manage the situation, I know of several fresh college grads who have not yet learned the communication and political skills to manage this, and so having a document spelling it out is helpful for both teaching and enforcement, even if the line items are not explicitly rules.

Re:Code Health: Respectful Reviews == Useful Reviews by bonoboTP on Thursday November 07, 2019 @04:35PM (#21477551)
So managers are supposed to be part time kindergarten nannies now? Is this really something that happens to an extent where educated adults cannot resolve such issues among themselves?

This is again a situation that's just hard for me to imagine, from both sides.

Re:Code Health: Respectful Reviews == Useful Reviews by potta_coffee on Thursday November 07, 2019 @07:00PM (#21478772)
In my management experience, I've spent much more time dealing with people's stupid, childish bullshit than doing "real" work.
Re:Code Health: Respectful Reviews == Useful Reviews by munchbunny on Thursday November 07, 2019 @07:12PM (#21478864)
That's in my management experience as well. You don't believe it's a real thing until it happens, and then you're still left wondering, "Seriously, am I really dealing with this shit?"
Re:Code Health: Respectful Reviews == Useful Reviews by munchbunny on Thursday November 07, 2019 @06:39PM (#21478599)
> So managers are supposed to be part time kindergarten nannies now?

If their employees act like children, then yes. And I'm pretty sure we can all come up with examples of adults acting like children.

Re:Code Health: Respectful Reviews == Useful Reviews by geofft on Thursday November 07, 2019 @07:47PM (#21479071)
Kindergarten nannies generally don't have the talent for teaching people how to not be jerks - they just put the jerks in timeout. Some eventually grow out of it. Some eventually get medication and/or therapy that addresses the issue. Some eventually respond to a lack of environmental stressors when they move out of their parents' house. And some simply stay that way.

If you've hired someone in the latter category, yes, delivering business value requires you to deal with it. Firing them is an option, if that's really net positive for business value; sometimes it isn't. Seeing if you have the knack for teaching them is another, and likely highly profitable if you can do it. Handing down rigid rules is yet another option - not great, but quick and usually effective.

Re:Code Health: Respectful Reviews == Useful Reviews by icelancer on Thursday November 07, 2019 @11:00PM (#21479865)
When the two adults are a man and a woman, yes, the company gets pretty scared pretty fast at the implications. Hence the rules.
Re:Code Health: Respectful Reviews == Useful Reviews by commandlinefan on Thursday November 07, 2019 @03:11PM (#21476834)
> I'm not sure how I'd respond

That might depend on whether or not you were worried about losing your job over it.

Re:Code Health: Respectful Reviews == Useful Reviews by esotericn on Thursday November 07, 2019 @03:44PM (#21477071)
Right, hence my comment. I wouldn't be worried at all. It feels like a different working culture (or country).

It seems like one of those cultural things, like how Europeans and Americans have inverse views on the severity of sex and violence.

I think you may have even misinterpreted my comment as me thinking I'm somehow "above the rules" or whatever, even. It's not that. It's that it would have literally never crossed my mind that my continued employment would be related to how I behave in relation to this document.

In my personal life I left behind that sort of 'rules lawyering' when I left school. No job I've ever held has actually functioned like that. The closest I've been is working at a large accounting firm, but even there most people had a mutual understanding that the 'book' (a lot more official than this post) was just a CYA fluff document invented to keep certain people busy and certain other people happy.

Re:Code Health: Respectful Reviews == Useful Reviews by bonoboTP on Thursday November 07, 2019 @04:25PM (#21477462)
I also wonder this when looking at the "Workplace" Stack Exchange site or at Reddit's /r/legaladvice. So much CYA stuff, "you must collect a paper trail", "email yourself your recollection of the situation, so it's time stamped", how quickly you can become a liability for HR and how much companies are scared of getting sued for, to me, frivolous reasons.

Sure this also exists in corporate Europe, but it seems America is more "robotic" in this respect. Well, they'd just call it being professional I guess.

Re:Code Health: Respectful Reviews == Useful Reviews by icebraining on Friday November 08, 2019 @03:53AM (#21480804)
Eh, many of the questions in Workplace are about FUBAR situations. It makes sense to take extreme measures in those cases.
Re:Code Health: Respectful Reviews == Useful Reviews by SpicyLemonZest on Thursday November 07, 2019 @07:55PM (#21479109)
Sure, but I think that is itself the cultural thing. I'll take your word for it that some people experience this, but the idea that anyone would fear being fired for missing fiddly details of a document like this is completely foreign to me. I've never seen a code review checklist that people followed even 75% of.
Re:Code Health: Respectful Reviews == Useful Reviews by reificator on Thursday November 07, 2019 @08:34PM (#21479287)
> I'll take your word for it that some people experience this, but the idea that anyone would fear being fired for missing fiddly details of a document like this is completely foreign to me.

There is currently a very public example of this going on at Stack Exchange over a code of conduct that was still in review status.

https://meta.stackexchange.com/questions/336526/stack-overfl...

Re:Code Health: Respectful Reviews == Useful Reviews by SpicyLemonZest on Thursday November 07, 2019 @08:43PM (#21479340)
Yes, that's a good example of what's completely foreign to me. I don't have time to trawl through all the details of the story you linked, but it's incomprehensible to me why Stack Exchange would do what's described here, and I've multiple times made negative comments about a proposed set of rules without facing or fearing punishment.
Re:Code Health: Respectful Reviews == Useful Reviews by reificator on Thursday November 07, 2019 @09:19PM (#21479486)
> I don't have time to trawl through all the details of the story you linked

Having done so myself out of morbid curiosity (and a sense of "there must be another side of the story that we're not getting"[0]) I would not suggest it. It's a rabbit hole that, as far as I can tell, leads back to the post I linked as the most accurate summary of the situation.

[0]: If there is, I have yet to find it after hours and hours of time wasted.

Re:Code Health: Respectful Reviews == Useful Reviews by michaelbuckbee on Thursday November 07, 2019 @04:01PM (#21477204)
CoC are a tool like any other - helpful if applied to the right situations and harmful if misused. I think you've made a really insightful point about keeping it small and maybe less a rule book and more a guideline for interaction.
Re:Code Health: Respectful Reviews == Useful Reviews by gowld on Thursday November 07, 2019 @01:49PM (#21476062)
#3 used to be called "professionalism"

A comic take on professionalism: https://www.youtube.com/watch?v=ZRzxJZrm3iU

https://arresteddevelopment.fandom.com/wiki/Wayne_Jarvis

Re:Code Health: Respectful Reviews == Useful Reviews by siruncledrew on Friday November 08, 2019 @02:02AM (#21480440)
The ever-expanding-CoC made me think a lot about the parallels to how laws are made.

I do agree the prolific laundry list of Do/Don’t criteria becomes more mentally hampering over time to circumnavigate.

Realistically speaking, If there was feedback/questions to bring up, I would just want to leave a comment putting my thoughts into words as efficiently as possible to then continue reviewing. Not a snarky, underhanded jerk comment like something an opponent would say in a multiplayer videogame - just a regular, normal person’s comment in a plain way.

For example, “What is the goal of this section?”, “Why use X method?”, “Please use ABC naming convention for the function here :)“.

Some of the “Do” ways are just about repackaging a concise statement into a more lengthy form for the sake of issue indirectness (or trying to avoid anything negative). This to me seems less efficient in a code review because it then takes longer to jump through all the mental gymnastics and mulling over phrasing of how to write a sentence referring to a piece of code.

I’m not at all saying be a ruthless hard-ass with the emotion of a robot. It’s just policies like a CoC that grows and grows and grows to retroactively counteract every single offense or misgiving feels like drudging through a bunch of HR bullshit. Coders already have enough mental exertion as it is.

The simpler and shorter the list for the CoC, the better (IMO). Will it encompass every possible instance or example? No. Will it please everyone? No. Will it get the job done so everyone can go home? Yes.

Look, every coder is going to make a mistake at some point and every reviewer is going to make a mistake, too. It’s ok to respectfully agree/disagree/debate perspectives about the code concisely. There is no need to turn an (unfun) diligence process into a pissing contest or a witch-hunt or a gatekeeping exercise. The people who do are wasting everyone’s time. Accept responsibility. Accept feedback. Reach a resolution and move on.

Re:Code Health: Respectful Reviews == Useful Reviews by Aeolun on Thursday November 07, 2019 @05:49PM (#21478117)
No emoji’s in code reviews? I have a hard time seeing how that helps instead of hurts things.

What was the reasoning behind it?

Re:Code Health: Respectful Reviews == Useful Reviews by bradknowles on Thursday November 07, 2019 @06:33PM (#21478533)
Your description here is what I would characterize as an accurate description of how most laws "just growed" in most communities.

That is, at least up until the time that the special interests got involved. Then they made a point of ensuring that the laws got written to only be applied to "others".

Re:Code Health: Respectful Reviews == Useful Reviews by vageli on Thursday November 07, 2019 @11:25PM (#21479958)
> Your description here is what I would characterize as an accurate description of how most laws "just growed" in most communities.

> That is, at least up until the time that the special interests got involved. Then they made a point of ensuring that the laws got written to only be applied to "others".

When was this time that special interests did not exist? One might argue (only partly in jest) that the entire purpose of government is to protect special interests.

Re:Code Health: Respectful Reviews == Useful Reviews by ma2rten on Thursday November 07, 2019 @09:21PM (#21479495)
This blog post originated at Google, but it is not some kind of Code of Conduct everyone at Google has to follow. This was an episode of Testing on the Toilet, as the name implies it is a newsletter, which is posted in the bathrooms.
Re:Code Health: Respectful Reviews == Useful Reviews by taurath on Thursday November 07, 2019 @06:59PM (#21478762)
> The CoC became a tool for power plays. For a few bad apples, the CoC became a list of gotchas that they could use as a power play against others

They should add that you shouldn’t do that to the code of conduct! ;)

Re:Code Health: Respectful Reviews == Useful Reviews by pacala on Thursday November 07, 2019 @07:58PM (#21479117)
First rule of the CoC: You do not talk about the CoC.
Re:Code Health: Respectful Reviews == Useful Reviews by droithomme on Thursday November 07, 2019 @09:52PM (#21479610)
Yes. CoCs are toxic and all workplaces with CoCs quickly become gamed toxic work environments. It's a nightmare. I never accept offers to join places with CoCs. In order to be effective and efficient I require the ability to speak plainly, clearly and directly about code quality and design issues.

Companies that use these tend to stop making good code and products and start using lobbyists to use regulations to anchor their dismally low quality products and squash any upcoming free-thinking rivals with good design.

Re:Code Health: Respectful Reviews == Useful Reviews by bluntfang on Thursday November 07, 2019 @01:25PM (#21475803)
Hmmm number 3 doesn't seem like a negative or counter-intuitive. I feel like software devs (in bay area startup world, or FAANG) are usually a certain demographic and they usually come from a place of privilege where they've never had to do the mental work that's involved in communicating effectively across diverse demographics.
Re:Code Health: Respectful Reviews == Useful Reviews by PragmaticPulp on Thursday November 07, 2019 @01:36PM (#21475938)
> Hmmm number 3 doesn't seem like a negative or counter-intuitive.

This is the core of the problem: Some people like the idea of robotic, semi-scripted conversations according to a well-defined set of rules. They think that if there's a rulebook, they can predict how people will respond to them. Or worse, they think they can control how people react and respond.

Yes, we should put some constraints around egregious communication issues as well as provide general guidelines, but the important thing is to let people interact naturally within those loose constraints.

> I feel like software devs (in bay area startup world, or FAANG) are usually a certain demographic and they usually come from a place of privilege where they've never had to do the mental work that's involved in communicating effectively across diverse demographics.

It's a fallacy, though. You can't create perfect rules for human conversation. Everyone needs to build those interpersonal and conversational skills, even if it's somewhat painful along the way. The basic skills can be guided with simple rules and guidelines, but the problem comes when you try to control too much of the conversation or set the constraints so tightly that it's a minefield to navigate.

Re:Code Health: Respectful Reviews == Useful Reviews by dwoozle on Thursday November 07, 2019 @03:09PM (#21476825)
I like robotic conversations at work because my work is not important to me, and I don’t want to bring my “full self” to work. I like to get in, do my shit, conduct communication in a formalized manner, and get out in 6 hours and go do stuff that matters to me.
Re:Code Health: Respectful Reviews == Useful Reviews by bluntfang on Thursday November 07, 2019 @01:46PM (#21476041)
>Some people like the idea of robotic, semi-scripted conversations according to a well-defined set of rules.

Thinking about the words you use in daily conversation with diverse peers doesn't have to be "robotic". You're just being exposed to how other people in less privileged positions have to think and act, and that's uncomfortable.

>You can't create perfect rules for human conversation.

Is anyone here claiming that their goal is perfection?

>Everyone needs to build those interpersonal and conversational skills

And there's nothing wrong with receiving help and guidance while you're on that journey.

Re:Code Health: Respectful Reviews == Useful Reviews by concordDance on Thursday November 07, 2019 @03:04PM (#21476789)
> Thinking about the words you use in daily conversation with diverse peers doesn't have to be "robotic".

I'd much rather save my mental energy for the coding.

If having to carefully think about how every turn of phrase could be seen and completely giving up on being able to make friends at work is the price of hiring less privileged people? I'd rather stay in my privileged monoculture thanks. The underprivileged can go join the company with the underprivileged monoculture and everyone can be happier, communicating in the style they prefer with people who are ok with that style.

Re:Code Health: Respectful Reviews == Useful Reviews by twothumbsup on Thursday November 07, 2019 @08:00PM (#21479121)
"i cant make friends if i cant make dumb jokes about minorities and women"
Re:Code Health: Respectful Reviews == Useful Reviews by bluntfang on Thursday November 07, 2019 @07:40PM (#21479035)
you're gross.
Re:Code Health: Respectful Reviews == Useful Reviews by kortilla on Thursday November 07, 2019 @02:41PM (#21476564)
> You're just being exposed to how other people in less privileged positions have to think and act, and that's uncomfortable.

No, it has nothing to do with that. As an unprivileged person, CoCs were harder for me to follow because I grew up using much harsher language and being more direct.

CoCs mainly seem to be about privileged people affirming to each other how “woke” they are.

Re:Code Health: Respectful Reviews == Useful Reviews by hrktb on Thursday November 07, 2019 @02:00PM (#21476196)
It’s easy to come to a point where we only talk in coded ways to follow the letter of the rules.

People start saying “thanks for your feedback, we’ll look into this issue when planning the next iteration” as code for “you could be pissing in the wind”, and most communication becomes non sensical where you need to feel if they actually mean what they’re saying in text form.

Then we lament that face to face time is needed to communicate efficiently with people.

[dead]
Re:Code Health: Respectful Reviews == Useful Reviews by threwawasy1228 on Thursday November 07, 2019 @04:15PM (#21477339)
This is the core problem with social justice, which I support. When you have a very real problem, eg that some groups live their lives in a situation where they must police their speech and actions to fit with the dominant white male cishet culture. This is a problem, and should be noted and acknowledged. Do you not see that having as your solution "force everyone to act fake and robotic, just like excluded groups/cultures do around the dominant culture" just expands the problem?

This robotic speech is incredibly socially isolating, you end up with communities isolating into their specific groups not out of racism or sexism but because it is the path of least resistance. People in general don't want to expend time or energy learning the rulesets that each subgroup needs followed to feel included and safe. This goes for non-privileged groups as well, isolating themselves from other non-privileged groups. When going into a situation unknowing can get you shamed and called out, the path of least resistance that does not result in a negative outcome is not engaging with other groups of people unlike yourself. AKA the opposite of what our stated goals are. People don't want to act robotic, and they don't want to isolate themselves.

Re:Code Health: Respectful Reviews == Useful Reviews by bluntfang on Thursday November 07, 2019 @07:42PM (#21479046)
So asking people not to use phrases that reference their penis or urine (like pissing in the wind) is forcing people to be robotic?
Re:Code Health: Respectful Reviews == Useful Reviews by kortilla on Thursday November 07, 2019 @08:31PM (#21479275)
Females emit urine and affected just as much by pissing into the wind.
Re:Code Health: Respectful Reviews == Useful Reviews by tick_tock_tick on Thursday November 07, 2019 @08:24PM (#21479235)
yes
Re:Code Health: Respectful Reviews == Useful Reviews by hrktb on Thursday November 07, 2019 @03:24PM (#21476923)
It’s interesting because I mentally don’t want people to be pissing outside of bathrooms whatever their gender.

Then when you specifically plan it, for camping in the wilderness for instance, there’s accessories that help to level the playing field (feel free to google it, it should come up with keywords like “woman camp urination portable”. It has an actual interesting story behind it and was developped by a camper that made it for her own needs at first)

Re:Code Health: Respectful Reviews == Useful Reviews by throwaway40324 on Thursday November 07, 2019 @05:49PM (#21478121)
5 gallon bucket, kitchen 33 gal trash bags, foam swimming pool 'noodle', paper towels (for absorbtion)

It's not environmentally friendly, but cheap for a temporary portable toilet.

Note: cut the pool noodle down and it sort snaps right on to the bucket.

Re:Code Health: Respectful Reviews == Useful Reviews by droithomme on Thursday November 07, 2019 @11:02PM (#21479875)
> I mentally don’t want people to be pissing outside of bathrooms

You definitely wouldn't enjoy staying at my place then!

Re:Code Health: Respectful Reviews == Useful Reviews by esotericn on Thursday November 07, 2019 @03:05PM (#21476792)
Pissing in the wind is likely going to cause a mess regardless of gender.
Re:Code Health: Respectful Reviews == Useful Reviews by kortilla on Thursday November 07, 2019 @02:42PM (#21476575)
> Pissing in the wind is a gendered statement.

I’ve seen videos that beg to differ.

Re:Code Health: Respectful Reviews == Useful Reviews by bradknowles on Thursday November 07, 2019 @06:30PM (#21478497)
One the one hand, that is technically true. I'm sure there do exist some videos that demonstrate that fact.

On the other, across my 53+ years of living on this planet, I don't think I have yet met a single female who would try to participate in that kind of activity. And I've met more than a few males who would actually be entertained by that outcome.

So, on the weight of my own personal experience, I would have to agree with the section you quoted and responded to.

Re:Code Health: Respectful Reviews == Useful Reviews by braindeath on Thursday November 07, 2019 @09:09PM (#21479448)
More murders are committed by males. Does that make the simple verb “murder” inherently gendered? Is that your claim? because that’s the only possible relevance your odd personal testimony seems to be implying.
Re:Code Health: Respectful Reviews == Useful Reviews by chapium on Thursday November 07, 2019 @06:07PM (#21478268)
no, it isn't
Re:Code Health: Respectful Reviews == Useful Reviews by matheusmoreira on Thursday November 07, 2019 @02:11PM (#21476308)
It is a negative. Nobody wants to navigate a social minefield where everything they say can and will be used against them in a court of public opinion. If social interaction becomes too difficult and risky, it's better to not participate at all.

This is why people get stonewalled. Why would anyone speak their mind when there are serious consequences?

[dead]
Re:Code Health: Respectful Reviews == Useful Reviews by dang on Friday November 08, 2019 @12:52AM (#21480233)
You repeatedly posted flamewar comments in this thread. We ban accounts that do that. Please stop.

https://news.ycombinator.com/newsguidelines.html

Re:Code Health: Respectful Reviews == Useful Reviews by concordDance on Thursday November 07, 2019 @03:08PM (#21476823)
> My point is that non-white non-cisgendered non-male people are already doing this in order to exist in the workplace!

I'm struggling to see how the "Don't"s in the article are associated with a particular orientation, race or sex... are you suggesting that non-white non-cisgendered non-male people can't cope with a more casual tone? Why? In my experience non-"white" people are just as casual or formal as "white" people ("white" is such a weirdly American concept, here in the UK we wouldn't want to group the Poles and the French together).

Re:Code Health: Respectful Reviews == Useful Reviews by threwawasy1228 on Thursday November 07, 2019 @04:47PM (#21477661)
The lack of granularity in America is honestly extremely annoying to me, different states or cities generally have wildly different "white" culture, traditions, commonality, and attitudes. It is often more hidden or subtle and less overt or surface level like it is in Europe.

Equally annoying is when people attempt to define 'African-American' as though it was one homogeneous entity of experience. The experiences and struggles of a young black man in NYC is vastly different from the struggles of a young black man in rural Alabama.

Re:Code Health: Respectful Reviews == Useful Reviews by potta_coffee on Thursday November 07, 2019 @07:08PM (#21478830)
This is the problem with categorization of people in general. All this "you're white", "you're black", "you're male", "you're female" is belittling because it's so surface level and ignores the depth of human experience. There's so much diversity within each of these broad categories.
Re:Code Health: Respectful Reviews == Useful Reviews by pnako on Thursday November 07, 2019 @03:52PM (#21477134)
In America, "white" is used instead of "European" because it's less ambiguous, since it distinguishes Americans of European ancestry from European citizens.

That being said, "white" is also ambiguous in other ways. It's generally not meant to be strictly speaking about skin color, since people with fair skin from certain parts of the middle east, for example, would not necessarily be considered to be white in this context.

Re:Code Health: Respectful Reviews == Useful Reviews by kortilla on Thursday November 07, 2019 @02:44PM (#21476598)
> My point is that non-white non-cisgendered non-male people are already doing this in order to exist in the workplace

No they aren’t. Non-white people aren’t avoiding the use of emojis in code review and they certainly aren’t against telling someone an idea is bad.

Re:Code Health: Respectful Reviews == Useful Reviews by bradknowles on Thursday November 07, 2019 @06:37PM (#21478572)
Speaking as an old white cisgendered male, my opinion is that if you're white, cisgendered, and male, then you're playing the game of life on easy mode.

You never get a chance to even see what it's like for everyone else who is forced to play on regular mode, or worse.

Re:Code Health: Respectful Reviews == Useful Reviews by kortilla on Thursday November 07, 2019 @08:29PM (#21479264)
Cool story. CoCs are invented by people “playing on easy mode” to signal to other easy mode players of their guilt. They do nothing to help the people on regular or hard.
Re:Code Health: Respectful Reviews == Useful Reviews by braindeath on Thursday November 07, 2019 @09:43PM (#21479574)
you better watch it.. this could very we’ll be....mansplaining
Re:Code Health: Respectful Reviews == Useful Reviews by commandlinefan on Thursday November 07, 2019 @03:27PM (#21476937)
> software devs are usually a certain demographic and they usually come from a place of privilege where they've never had to do the mental work that's involved in communicating effectively across diverse demographics.

This strikes me as a surprising assertion: most software devs (including in the Bay Area, FAANG) are recent immigrants (or temporary guest workers) who are, by definition, navigating a culture very different than the one they grew up in.

Re:Code Health: Respectful Reviews == Useful Reviews by dragonwriter on Thursday November 07, 2019 @03:33PM (#21476981)
> most software devs (including in the Bay Area, FAANG) are recent immigrants

The only data I can find that speaks to that (from 2015) has far less than half foreign-born (39.2% of "software engineers", 27.4% of "computer programmers", etc.), and obviously not all of those are going to be "recent immigrants".

https://www.americanimmigrationcouncil.org/research/foreign-...

Re:Code Health: Respectful Reviews == Useful Reviews by cameronbrown on Thursday November 07, 2019 @05:11PM (#21477870)
40% is a lot. Don't forget tech's exponential growth in jobs over the past few decades.
Re:Code Health: Respectful Reviews == Useful Reviews by ragona on Thursday November 07, 2019 @05:55PM (#21478161)
I’d be curious to see that from FAANG specifically, since they drive so much international hiring.
Re:Code Health: Respectful Reviews == Useful Reviews by geofft on Thursday November 07, 2019 @08:02PM (#21479133)
> most software devs (including in the Bay Area, FAANG) are recent immigrants (or temporary guest workers)

The only data I can find supporting this is that tech workers in Silicon Valley as a whole are majority foreign-born. But that includes everyone from Oracle to HP to Wipro, not just FAANG. (And I think the definition of Silicon Valley in this data is the traditional one, i.e., not including San Francisco.)

A subset of those are recent immigrants.