> In practice this means that we have issues coming in, but we never close them when they are fixed, causing them to pile up. So we decided that the best thing we could do is mark them as stale and close old issues that nobody has commented on in a while. If we mistakenly closed something that is still an issue, the community will let us know and we can reopen it.
The discussion I had with them was interesting, but it didn't leave me feeling like anything would really change. Seeing your comment reminded me of this and I guess the status quo has remained.
[1] https://ps.reddit.com/r/reactnative/comments/7wqxjy/why_are_...
This sounds totally backwards.
It is. It's the result of low level managers using issue counts as KPI: now it's a metric that must be gamed.
The explanation is more prosaic: https://news.ycombinator.com/item?id=17316150
And, the "whole idea" of logging issues is not to see how long they are open for... it's to, you know, log issues, because they can't be fixed instantaneously. Measuring how long they are open for is just a pointy-haired boss side effect, because those are the kind of idiots that would think that kind of metric means anything.
I don't think such cynicism is warranted. Open issue time is a useful metric, at the very least over time, of how quickly developers are fixing problems and how complex they are becoming.
Certainly not something for a pointy haired boss to optimize exclusively for, but a useful bit of data to be taken into consideration with other measurements of performance.
It's not the only factor, it's highly product dependent, but it is very relevant to most outward facing activity...
This is the problem. Why not close them when they are fixed?!?
Not saying this is an excuse, but it's unfortunate reality that "close most issues, see which ones come back" is one of the easier ways to focus on the most important bugs
In many cases, the fix comes from within Facebook or from a different contributor when we/they run into the issue themselves.
This makes me very sad (as an ex-FBer especially), I wish that FB would just add another 3 or 4 engineers to the team with the explicit goal of giving them the bandwidth to be good open source stewards. I'm sure the FB engineers don't like having to ignore the community, but they do as a matter of policy.
I am a distant outsider to that company, I haven't used the platform in years and remain quite critical of it and many business practices especially regarding recent exposures (though I am a fan of their engineering they've released or open-sourced for the web)— yet I can understand somewhat how staff associated with such projects are not necessarily actively and regularly allocated to addressing those issues. At times they're passion projects that still need to gain traction that entreats the company to something worthwhile to the company [re: endpoint-shareholders]—mindshare, general confidence, whatever. Big corps often do what big corps do...
That's not the case with React Native though.
The problem is that the surface area is vast, and the popularity is booming through the roof. If RN team looked at every issue, the (very active) development would stall completely. On the "web" React repo we can afford to do this because our surface area is much smaller, but on RN it's not practical.
So instead, the RN team tends to focus on the issues that are reported most often by the FB product teams. While this is not a great outside communication strategy, it ends up highlighting most pain points shared by folks outside the company too. Note this includes vast architectural improvements as highlighted in the post--something that goes way beyond a traditional GitHub issue report.
While admittedly this approach puts FB's needs first, it also serves as an important way to keep the team focused. It is very hard to deal with dozen new issues every day and still move the project forward so they chose this path.
I want to highlight that RN has maintainers outside of FB who help with different parts of the codebase (because again, the surface area is vast), sometimes with more expertise in those areas than people at FB. So the project isn't dependent on FB maintainers looking at issues alone. Folks outside can, and do help.
This doesn't mean issues don't end up being addressed in the end. But GH issue communication model just doesn't scale well for RN.
These issues are extremely costly to teams using React and they absolutely need much faster resolution.
Because the overall health of the open source ecosystem around React and React Native depends upon the cost of development being somewhat predictable.
Most of the bugs in this category are inefficient for most teams to tackle because they get below the surface of the APIs and tooling. Not only is there (by design) no contract for how these things should work, but the appeal of React and React Native is that the developers and teams using them can be selectively ignorant about these things.
In life one must choose which things to devote energy into becoming expert in. These kinds of bugs tend to be show stoppers for teams impacted by them. It's a coincidence that Facebook itself has not been impacted, but someone needs to adopt a higher level view to realize these are very important issues which the maintainer should be addressing as top priority.
Facebook is a many billion dollar company and can surely afford to put a few more top engineers on the team to do this stuff. These things create major credibility issues for React Native supporters in their own orgs.
If Facebook decides to upgrade to a newer Babel library (for instance) and it creates a major issue with an open source library that is used by 30% of React Native projects, this warrants direct attention by Facebook.
If a RN update causes thousands of teams using RN to get failed builds, there should be someone at Facebook trying hard to reproduce the problem even if there is no obvious theoretical reason why it should have occurred and it is not impacting Facebook's builds.
React Native is a great project, but this stuff causes a tremendous amount of thrash and wasted time for the teams impacted. It could be much more efficiently dealt with by Facebook directly (and should be).
It may be strategic for them to take that role and hire folks to work on React Native, either a MS fork, or as part of a conjoined effort with Facebook.
React Native is fantastic, but the ecosystem is thrashed around horribly by these kinds of bugs and the non response from Facebook for things that impact most of the non-Facebook open source ecosystem around React Native.
Love RN, and the daunting vastness of the surface area not lost on me, but would be totally ok with me if development stalled for 6 months of purely bug-fix releases. Maybe I'd sound differently if I cared about integration with native apps.
Pay $$$ or €€€ to get enterprise support, promissing to fix your issue with a Pull Request in the mainstream repository
edit: Just realized which Dan you are. Thanks for the insights. Your team does good work.
Ironically if you wrote this up as an issue in their tracker, I would surely have one more such experience when they closed it shortly after.
That said I complain out of love, because React Native is just awesome when it works.
To anyone whose issue I've closed prematurely, it's OK to feel upset about it. Please do let me know when that happens, as that is the signal I'm looking for. Out of thousands of issues that the bot has closed automatically, only a few dozen end up getting commented on after the fact. Some of these issues we won't reopen because there is no minimal repro (usually because they were opened before we started enforcing the issue template, in which case, please open a new issue!), but in many cases all it needs is for a maintainer to go in and re-open the issue.
If you're reading this and you are one of the people actively participating in the repo, and you'd like to get added to the team that manages issues, please reach out. We have a handful of non-Facebook maintainers with this type of access and we're always looking for more. Shoot an email to my first name @ fb.com.
At this time, we're only automatically closing issues that don't make use of the template. The requirements are actually quite lax: all we ask is for you to run `react-native info` so we can get more information about your setup, and a minimal reproducible example. Questions and requests for help do get sent to Stack Overflow, and this is with the community's best interest in mind as we want to focus on bugs and regressions that affect people's apps. For anything that is not a bug report or a request for help, we have an open-ended discussion template that can be used to file issues that used to get closed automatically in the past.
We used to close stale issues more aggressively in the past, which was needed to get us down from thousands of open issues down to a more manageable state. The bot now only closes issues after four months of inactivity. The bot does give a 30 day warning which should be enough for people to verify if the bug is still present in the latest release, in which case they can leave a comment and the bot won't bug you for another 90 days. This way, we can prune out any issues that got fixed in a release - as others have commented, sometimes the people fixing a bug are not aware that an issue was filed for the bug for various reasons.
But the true purpose of the stale bot is transparency: if there has been no activity in the issue in such a long time, it's not something people should expect to see fixed soon. Typically, issues where someone is able and willing to provide a fix for, or long-running issues describing a problem that does not have an easy fix but the core team wishes to fix at some point, will have some sort of ongoing discussion, in which case we protect the issue from being closed by adding the appropriate label ("Core Team" or "For Discussion").
Finally, I want to point out that the project is open source. If you are waiting for a fix to be merged and need to unblock yourself right now, you can always cut a release off your own fork. Please let us know when you do this, as this helps provide us with some signal about PRs that could be prioritized.
PS: If you would like to learn more about how we prepare each release, please visit https://github.com/react-native-community/react-native-relea...
Not that running a patched version is necessarily a huge deal, but it's nice to have that 'this random code is approved by someone that actively works on the codebase' stamp.
(well, still might be on 0.55.3 for the version if NetInfo we can work around, but I do appreciate the project, warts and all)
I'm not unsympathetic to your claim but context matters. This is an enthusiasm problem. Not a community one
As an aside, who's really the man child? Hacker News users, or the ~50 year old man insulting/trolling them with that image?
So then you start this goose chase of hunting down the current issue since it starts getting into this loop of closed, open a new issue, closed, open a new issue, closed, open a new issue, etc. And everytime this happens relevant information gets lots because its not transferred to the new issue.
And then you finally find the newest, currently active iteration of the issue and find out that its still not fixed and the workaround is to stop using the React Native version and re-implement the feature yourself natively on both ios and android.