News for hackers. Stuff that matters.
Re:State of React Native 2018 by plopz on Thursday June 14, 2018 @05:26PM (#17315528)
The biggest problem I've run into with React Native has been their handling of issues. Far too frequently I'll google an issue I'm having and click a link to a bug report that matches the exact problem I'm having and provides a repro only to see that the issue was closed for inactivity. Never mind the issue is still valid, and the comments on the issue will ask for it to be re-opened and the response is to open a new issue.

So then you start this goose chase of hunting down the current issue since it starts getting into this loop of closed, open a new issue, closed, open a new issue, closed, open a new issue, etc. And everytime this happens relevant information gets lots because its not transferred to the new issue.

And then you finally find the newest, currently active iteration of the issue and find out that its still not fixed and the workaround is to stop using the React Native version and re-implement the feature yourself natively on both ios and android.

Re:State of React Native 2018 by hysan on Thursday June 14, 2018 @06:50PM (#17316092)
I remember asking about this on Reddit and got a response from someone on the RN team.[1]

> In practice this means that we have issues coming in, but we never close them when they are fixed, causing them to pile up. So we decided that the best thing we could do is mark them as stale and close old issues that nobody has commented on in a while. If we mistakenly closed something that is still an issue, the community will let us know and we can reopen it.

The discussion I had with them was interesting, but it didn't leave me feeling like anything would really change. Seeing your comment reminded me of this and I guess the status quo has remained.

[1] https://ps.reddit.com/r/reactnative/comments/7wqxjy/why_are_...

Re:State of React Native 2018 by ak39 on Friday June 15, 2018 @04:39AM (#17318354)
I can't seem to understand what the problem with "pile up" is? The whole idea of logging issues is to see how long they're open for! In fact good projects take the painstaking exercise to coalesce tickets that are in fact the same with an original item IN ORDER TO track the correct age of the ticket.

This sounds totally backwards.

Re:State of React Native 2018 by _pmf_ on Friday June 15, 2018 @09:46AM (#17319711)
> This sounds totally backwards.

It is. It's the result of low level managers using issue counts as KPI: now it's a metric that must be gamed.

Re:State of React Native 2018 by danabramov on Friday June 15, 2018 @10:08AM (#17319859)
We don't use GitHub issue counts as "KPI" at Facebook.

The explanation is more prosaic: https://news.ycombinator.com/item?id=17316150

Re:State of React Native 2018 by workinthehead on Friday June 15, 2018 @11:02AM (#17320225)
Nope, wrong on all counts. You need to delete stale issues, it's no good having an endless backlog of someone's nice-to-haves that they no longer even care about.

And, the "whole idea" of logging issues is not to see how long they are open for... it's to, you know, log issues, because they can't be fixed instantaneously. Measuring how long they are open for is just a pointy-haired boss side effect, because those are the kind of idiots that would think that kind of metric means anything.

Re:State of React Native 2018 by valuearb on Friday June 15, 2018 @04:50PM (#17323443)
I agree that how long they are open is meaningless, but closing them before they are fixed throws the baby out with it's dirty bathwater.
Re:State of React Native 2018 by allthenews on Friday June 15, 2018 @03:22PM (#17322711)
>Measuring how long they are open for is just a pointy-haired boss side effect...kind of metric means anything.

I don't think such cynicism is warranted. Open issue time is a useful metric, at the very least over time, of how quickly developers are fixing problems and how complex they are becoming.

Certainly not something for a pointy haired boss to optimize exclusively for, but a useful bit of data to be taken into consideration with other measurements of performance.

Re:State of React Native 2018 by bonesss on Monday June 18, 2018 @02:27AM (#17336306)
Of all the KPIs for development teams, how-f-ing-long-will-it-take is a pretty 'key' one, IMO.

It's not the only factor, it's highly product dependent, but it is very relevant to most outward facing activity...

Re:State of React Native 2018 by je42 on Thursday June 14, 2018 @11:11PM (#17317258)
most of the time the issues are also not fixed (a cross multiple releases) some of the issues are really basic ones, one can wonder why they made a release with them in the first place.
Re:State of React Native 2018 by e40 on Friday June 15, 2018 @10:21AM (#17319952)
but we never close them when they are fixed, causing them to pile up

This is the problem. Why not close them when they are fixed?!?

Re:State of React Native 2018 by dgoldstein0 on Friday June 15, 2018 @10:32AM (#17320035)
If you have enough issues, just deduping and knowing when a commit fixes an issue to remember to close it becomes a problem.

Not saying this is an excuse, but it's unfortunate reality that "close most issues, see which ones come back" is one of the easier ways to focus on the most important bugs

Re:State of React Native 2018 by kbsletten on Friday June 15, 2018 @10:29AM (#17320013)
Well, unless they have a triage team, you're counting on developers having a Spidey-sense that there's an open issue related to what they're working on. I assume the issue list is something they never asked for but feel obligated to doing a minimal amount to clean up.
Re:State of React Native 2018 by valuearb on Friday June 15, 2018 @04:54PM (#17323482)
Huh? You don't need a spidey sense to close a bug you just fixed, you just close it.
Re:State of React Native 2018 by HectorRamos on Friday June 15, 2018 @05:13PM (#17323610)
This assumes that the person fixing the bug is either the same one who filed the bug, or they were motivated to fix the bug after finding the GitHub issue.

In many cases, the fix comes from within Facebook or from a different contributor when we/they run into the issue themselves.

Re:State of React Native 2018 by valuearb on Monday June 18, 2018 @04:11PM (#17341302)
And this is exactly why React Native is such an unprofessional pile of crap. Random code changes from random people with no prioritization, documentation or coherent history.
Re:State of React Native 2018 by _Tev on Tuesday June 19, 2018 @01:56PM (#17348862)
So they cannot do even the basic issue tracking? Wow, what a mess.
Re:State of React Native 2018 by shaneos on Friday June 15, 2018 @01:51AM (#17317776)
The response that I've gotten, after complaining repeatedly, is that the team simply has no time to look at any externally reported issues, and that it's essentially a waste of time opening an issue.

This makes me very sad (as an ex-FBer especially), I wish that FB would just add another 3 or 4 engineers to the team with the explicit goal of giving them the bandwidth to be good open source stewards. I'm sure the FB engineers don't like having to ignore the community, but they do as a matter of policy.

Re:State of React Native 2018 by ascorbic on Friday June 15, 2018 @03:34PM (#17322810)
They could learn a lot from Microsoft. VS Code, Typescript and related projects are a shining example of how to handle issues on open source projects. In fact, considering what heavy users they are of React Native, maybe Microsoft could be taking a more active role in the core project.
Re:State of React Native 2018 by olfactory on Friday June 15, 2018 @11:39AM (#17320544)
This is a great point. There have been a few issues that I've followed only to find that eventually the entire thread on Github with tons of example cases of the bug gets "closed for inactivity" because nobody from Facebook would respond to it.
Re:State of React Native 2018 by ricardobeat on Friday June 15, 2018 @02:40PM (#17322351)
They don't need to add more engineers - as an open-source project, all they should have to do is put one person to manage the community, encourage and vet new contributors. But that would mean losing some control.
Re:State of React Native 2018 by 52-6F-62 on Thursday June 14, 2018 @06:45PM (#17316067)
I've found that to be relevant for a few issues (including one of my own) with Facebook Open Source projects—that or they just go unheeded by staff, but confirmed by a stream of others.

I am a distant outsider to that company, I haven't used the platform in years and remain quite critical of it and many business practices especially regarding recent exposures (though I am a fan of their engineering they've released or open-sourced for the web)— yet I can understand somewhat how staff associated with such projects are not necessarily actively and regularly allocated to addressing those issues. At times they're passion projects that still need to gain traction that entreats the company to something worthwhile to the company [re: endpoint-shareholders]—mindshare, general confidence, whatever. Big corps often do what big corps do...

Re:State of React Native 2018 by danabramov on Thursday June 14, 2018 @07:03PM (#17316150)
>At times they're passion projects that still need to gain traction that entreats the company to something worthwhile to the company

That's not the case with React Native though.

The problem is that the surface area is vast, and the popularity is booming through the roof. If RN team looked at every issue, the (very active) development would stall completely. On the "web" React repo we can afford to do this because our surface area is much smaller, but on RN it's not practical.

So instead, the RN team tends to focus on the issues that are reported most often by the FB product teams. While this is not a great outside communication strategy, it ends up highlighting most pain points shared by folks outside the company too. Note this includes vast architectural improvements as highlighted in the post--something that goes way beyond a traditional GitHub issue report.

While admittedly this approach puts FB's needs first, it also serves as an important way to keep the team focused. It is very hard to deal with dozen new issues every day and still move the project forward so they chose this path.

I want to highlight that RN has maintainers outside of FB who help with different parts of the codebase (because again, the surface area is vast), sometimes with more expertise in those areas than people at FB. So the project isn't dependent on FB maintainers looking at issues alone. Folks outside can, and do help.

This doesn't mean issues don't end up being addressed in the end. But GH issue communication model just doesn't scale well for RN.

Re:State of React Native 2018 by olfactory on Thursday June 14, 2018 @11:24PM (#17317319)
I think you should just hire a few smart people who can be dedicated to supporting these issues which are high priority outside Facebook.

These issues are extremely costly to teams using React and they absolutely need much faster resolution.

Re:State of React Native 2018 by vosper on Friday June 15, 2018 @01:04AM (#17317635)
Why should Facebook pay for that? If there are issues that are extremely costly to a bunch of outside teams maybe they should be the ones hiring people to fix their problems.
Re:State of React Native 2018 by olfactory on Friday June 15, 2018 @11:31AM (#17320448)
> Why should Facebook pay for that?

Because the overall health of the open source ecosystem around React and React Native depends upon the cost of development being somewhat predictable.

Most of the bugs in this category are inefficient for most teams to tackle because they get below the surface of the APIs and tooling. Not only is there (by design) no contract for how these things should work, but the appeal of React and React Native is that the developers and teams using them can be selectively ignorant about these things.

In life one must choose which things to devote energy into becoming expert in. These kinds of bugs tend to be show stoppers for teams impacted by them. It's a coincidence that Facebook itself has not been impacted, but someone needs to adopt a higher level view to realize these are very important issues which the maintainer should be addressing as top priority.

Facebook is a many billion dollar company and can surely afford to put a few more top engineers on the team to do this stuff. These things create major credibility issues for React Native supporters in their own orgs.

If Facebook decides to upgrade to a newer Babel library (for instance) and it creates a major issue with an open source library that is used by 30% of React Native projects, this warrants direct attention by Facebook.

If a RN update causes thousands of teams using RN to get failed builds, there should be someone at Facebook trying hard to reproduce the problem even if there is no obvious theoretical reason why it should have occurred and it is not impacting Facebook's builds.

React Native is a great project, but this stuff causes a tremendous amount of thrash and wasted time for the teams impacted. It could be much more efficiently dealt with by Facebook directly (and should be).

Re:State of React Native 2018 by pygy_ on Friday June 15, 2018 @06:38AM (#17318762)
It looks like Microsoft is pursuing React Native as an alternative to Google's Flutter.

It may be strategic for them to take that role and hire folks to work on React Native, either a MS fork, or as part of a conjoined effort with Facebook.

Re:State of React Native 2018 by danabramov on Friday June 15, 2018 @10:10AM (#17319875)
That's exactly what ends up happening: companies that invest heavily in RN also contribute back (and even help us managing issues and releases).
Re:State of React Native 2018 by olfactory on Friday June 15, 2018 @11:41AM (#17320557)
FWIW I think you guys should put out a major call for help to other companies and add more non-FB people to the core committers.

React Native is fantastic, but the ecosystem is thrashed around horribly by these kinds of bugs and the non response from Facebook for things that impact most of the non-Facebook open source ecosystem around React Native.

Re:State of React Native 2018 by nol13 on Friday June 15, 2018 @07:52AM (#17319058)
Been actively wondering if there would be enough interest/momentum for a community LTS fork.

Love RN, and the daunting vastness of the surface area not lost on me, but would be totally ok with me if development stalled for 6 months of purely bug-fix releases. Maybe I'd sound differently if I cared about integration with native apps.

Re:State of React Native 2018 by antris on Friday June 15, 2018 @05:58AM (#17318627)
Better developer relations.
Re:State of React Native 2018 by tmaier on Friday June 15, 2018 @01:00AM (#17317629)
This could even be a business model.

Pay $$$ or €€€ to get enterprise support, promissing to fix your issue with a Pull Request in the mainstream repository

Re:State of React Native 2018 by valuearb on Friday June 15, 2018 @04:57PM (#17323493)
Can't understand how any internal team at Facebook tolerates the sloppy coding practices of the RN team. Is everything just technical debt to be ignored and left behind so the team can work on the latest shiniest feature?
Re:State of React Native 2018 by s73v3r_ on Friday June 15, 2018 @05:07PM (#17323563)
From descriptions, that's the way all teams at Facebook work.
Re:State of React Native 2018 by 52-6F-62 on Thursday June 14, 2018 @07:08PM (#17316164)
All good points, thanks. I guess I was remarking on other experiences more to do with other FB Open Source projects versus giants like RN.

edit: Just realized which Dan you are. Thanks for the insights. Your team does good work.

Re:State of React Native 2018 by arcticfox on Thursday June 14, 2018 @05:44PM (#17315681)
I've had this exact experience multiple times.

Ironically if you wrote this up as an issue in their tracker, I would surely have one more such experience when they closed it shortly after.

That said I complain out of love, because React Native is just awesome when it works.

Re:State of React Native 2018 by HectorRamos on Friday June 15, 2018 @04:16PM (#17323179)
I'm one of the open source React Native maintainers here at Facebook, and I'm the one who has set the direction for how issues are treated on our React Native repository.

To anyone whose issue I've closed prematurely, it's OK to feel upset about it. Please do let me know when that happens, as that is the signal I'm looking for. Out of thousands of issues that the bot has closed automatically, only a few dozen end up getting commented on after the fact. Some of these issues we won't reopen because there is no minimal repro (usually because they were opened before we started enforcing the issue template, in which case, please open a new issue!), but in many cases all it needs is for a maintainer to go in and re-open the issue.

If you're reading this and you are one of the people actively participating in the repo, and you'd like to get added to the team that manages issues, please reach out. We have a handful of non-Facebook maintainers with this type of access and we're always looking for more. Shoot an email to my first name @ fb.com.

At this time, we're only automatically closing issues that don't make use of the template. The requirements are actually quite lax: all we ask is for you to run `react-native info` so we can get more information about your setup, and a minimal reproducible example. Questions and requests for help do get sent to Stack Overflow, and this is with the community's best interest in mind as we want to focus on bugs and regressions that affect people's apps. For anything that is not a bug report or a request for help, we have an open-ended discussion template that can be used to file issues that used to get closed automatically in the past.

We used to close stale issues more aggressively in the past, which was needed to get us down from thousands of open issues down to a more manageable state. The bot now only closes issues after four months of inactivity. The bot does give a 30 day warning which should be enough for people to verify if the bug is still present in the latest release, in which case they can leave a comment and the bot won't bug you for another 90 days. This way, we can prune out any issues that got fixed in a release - as others have commented, sometimes the people fixing a bug are not aware that an issue was filed for the bug for various reasons.

But the true purpose of the stale bot is transparency: if there has been no activity in the issue in such a long time, it's not something people should expect to see fixed soon. Typically, issues where someone is able and willing to provide a fix for, or long-running issues describing a problem that does not have an easy fix but the core team wishes to fix at some point, will have some sort of ongoing discussion, in which case we protect the issue from being closed by adding the appropriate label ("Core Team" or "For Discussion").

Finally, I want to point out that the project is open source. If you are waiting for a fix to be merged and need to unblock yourself right now, you can always cut a release off your own fork. Please let us know when you do this, as this helps provide us with some signal about PRs that could be prioritized.

PS: If you would like to learn more about how we prepare each release, please visit https://github.com/react-native-community/react-native-relea...

Re:State of React Native 2018 by nol13 on Friday June 15, 2018 @08:46PM (#17325032)
Well, I see there's at least been some action on the TextInput regressions that were keeping us on fork! <3

Not that running a patched version is necessarily a huge deal, but it's nice to have that 'this random code is approved by someone that actively works on the codebase' stamp.

(well, still might be on 0.55.3 for the version if NetInfo we can work around, but I do appreciate the project, warts and all)

Re:State of React Native 2018 by sercand on Friday June 15, 2018 @12:32PM (#17321099)
Another similar issue is they never accept Pull Requests from github.
Re:State of React Native 2018 by HectorRamos on Friday June 15, 2018 @04:41PM (#17323365)
There's a long tail of PRs to go through and review, and the ones we review may take a while to get to a point where they are accepted, but saying PRs are never accepted isn't quite accurate: https://github.com/facebook/react-native/pulls?utf8=%E2%9C%9...
Re:State of React Native 2018 by golergka on Friday June 15, 2018 @04:47AM (#17318379)
I've had the same experience in multiple open source projects. Seems like not spending though resources on unsexy things, like QA, is typical for open source – although I'd rather expect it from volunteers than FB's engineering team.
Re:State of React Native 2018 by whistlerbrk on Thursday June 14, 2018 @11:25PM (#17317326)
I mean... It's a fast moving ecosystem and a coalition of the willing. You have to submit PRs too.

I'm not unsympathetic to your claim but context matters. This is an enthusiasm problem. Not a community one

Re:State of React Native 2018 by jbarham on Thursday June 14, 2018 @08:59PM (#17316684)
It's the CADT model of software development: https://www.jwz.org/doc/cadt.html
Re:State of React Native 2018 by tlrobinson on Thursday June 14, 2018 @09:03PM (#17316702)
FYI links to jwz.org from Hacker News redirect to an... interesting... image. Copy and paste into your browser instead.

As an aside, who's really the man child? Hacker News users, or the ~50 year old man insulting/trolling them with that image?

Re:State of React Native 2018 by paulddraper on Thursday June 14, 2018 @10:01PM (#17316973)
Strip your referrer https://fkref.com/?8XB37z8i
Re:State of React Native 2018 by maddyboo on Thursday June 14, 2018 @09:05PM (#17316711)
NSFW Warning
Re:State of React Native 2018 by jocoda on Friday June 15, 2018 @03:08AM (#17318010)
works ok for me now
Re:State of React Native 2018 by maddyboo on Friday June 15, 2018 @03:13AM (#17318037)
Previously it redirected to a photoshopped picture of a testicle in a cup.
Re:State of React Native 2018 by elbear on Friday June 15, 2018 @09:02AM (#17319433)
It still does for me.