News for hackers. Stuff that matters.
Re:Git log in JSON format by jaseemabid on Sunday July 12, 2015 @04:41AM (#9872929)
Every time I see this pattern, a part of me dies inside.

    collection = []
    for i in data:
        collection.append(fn(i))
Why not just

    [fn(i) for i in data] ?
Re:Git log in JSON format by m1el on Sunday July 12, 2015 @10:55AM (#9873657)
You are right, list comprehension are cool and I often use them.

However, in this particular case, IMO, it would make things worse because I would have to write a multi-line list comprehension. Multi-line list comprehensions have bad readability. The object literal is too big to be included in list comprehension.

I could move commit->object conversion to a function, but then I would have used map. And it would have created one more indirection.

The current state is my deliberate choice.

Re:Git log in JSON format by zokier on Sunday July 12, 2015 @05:10AM (#9872981)
If we are nitpicking then why not

    map(fn, data)

?
Re:Git log in JSON format by bpicolo on Sunday July 12, 2015 @09:52AM (#9873489)
List comprehensions are more direct, support more than just a function call, and in py3 map returns an iterable instead of a list (granted, easily solvable by list(map()) but it's an extra concern)

List comprehensions are the very recommended strategy for constructing python lists, not to mention they're simply a fantastic language feature. Very direct, readable, and hard to get wrong.

Python loses out a lot on it's functional sorts of functions (filter, map) because you can't use method chaining on a list for them, imo

Re:Git log in JSON format by wingerlang on Sunday July 12, 2015 @05:08AM (#9872977)
First example is way, WAY, more readable. Honestly, if I didn't read the first one I would probably not have figured out what the other one does without research.
[dead]
Re:Git log in JSON format by wingerlang on Sunday July 12, 2015 @08:04AM (#9873213)
> Which is really easy to read if you understand english

Maybe I missed something, but how does this

> [fn(i) for i in data]

read easier if you know english? You need to know the syntax of "[...]" to know what it does.

The top/first example, however, actually reads like english.

Re:Git log in JSON format by tschuy on Sunday July 12, 2015 @09:24AM (#9873409)
List comprehension are a very common thing in Python.

If you knew Python you'd know exactly what that means. But zokier is right, a map is probably a better choice here.

Re:Git log in JSON format by merb on Sunday July 12, 2015 @01:51PM (#9874262)
I never talked about fn(i) for i in data. That's pythonic as somebody explain but the map one is the most readable and appears in more and more languages, even Java.
Re:Git log in JSON format by s_kilk on Sunday July 12, 2015 @10:52AM (#9873643)
>> You need to know the syntax of "[...]" to know what it does.

Anyone with even a basic understanding of python (the language of the examples we've been discussing here) should know this syntax. If they didn't I'd be worried.