News for hackers. Stuff that matters.
Re:Git log in JSON format by m1el on Sunday July 12, 2015 @10:55AM (#9873657)
You are right, list comprehension are cool and I often use them.

However, in this particular case, IMO, it would make things worse because I would have to write a multi-line list comprehension. Multi-line list comprehensions have bad readability. The object literal is too big to be included in list comprehension.

I could move commit->object conversion to a function, but then I would have used map. And it would have created one more indirection.

The current state is my deliberate choice.

There are no comments on this comment yet.