News for hackers. Stuff that matters.
Re:A Million Lines of Bad Code by cperciva on Friday April 17, 2015 @04:11PM (#9396908)
"Hey pretty cool program! Its a great start. I bet we can make it run faster if we changed the way files are imported to something like this... nice work"

I usually hear this referred to as a "criticism sandwich": Criticism surrounded on either side with compliments.

Re:A Million Lines of Bad Code by switch007 on Friday April 17, 2015 @04:30PM (#9397030)
We Brits are the masters of allusive and indirect speech, and I would automatically automatically strip of both pieces of bread translate that to "you're reading in files wrong".
Re:A Million Lines of Bad Code by cperciva on Friday April 17, 2015 @04:44PM (#9397108)
Yes, I would automatically parse the "bread" as being boilerplate politeness -- but as with most forms of politeness, I would probably feel differently about the speaker if it wasn't there.
Re:A Million Lines of Bad Code by thothamon on Friday April 17, 2015 @04:59PM (#9397175)
I think you have to take each individual differently. Most folks react well to the criticism sandwich. Someone like you might prefer a more direct approach, as long as it is not phrased in a mean way.

At some point in my career, I stopped taking criticism personally. I just realized I was wrong so often that upholding the pretense that I knew it all was too hard. For that reason, I prefer direct suggestions.

If I was teaching a child or a new beginner, I would start with a lot of praise that they're even trying. I want to get them some early wins to help boost their confidence.

Re:A Million Lines of Bad Code by r00fus on Friday April 17, 2015 @04:59PM (#9397174)
Not everyone auto-parses. Unless you really know who you're talking to, it makes sense to add the "bread/condiments" to the sandwich.
Re:A Million Lines of Bad Code by bstamour on Friday April 17, 2015 @04:15PM (#9396929)
In the martial arts community we call this "praise, correct, praise."
Re:A Million Lines of Bad Code by gagege on Friday April 17, 2015 @04:27PM (#9397001)
What's weird is that even though I know this is a "trick" I still want people to talk to me that way unless I specifically ask them for the hard truth.
Re:A Million Lines of Bad Code by artursapek on Friday April 17, 2015 @04:28PM (#9397011)
Programmers tend to incline towards efficiency. I think that's why we often skip the bread and deliver only the filling. IMO there's a big difference between a criticism sandwich and tactful criticism.
Re:A Million Lines of Bad Code by npizzolato on Friday April 17, 2015 @05:29PM (#9397298)
"Inclining towards efficiency" might be their justification, but I think the truth is closer to many programmers simply lacking tact.
Re:A Million Lines of Bad Code by sullyj3 on Saturday April 18, 2015 @10:21AM (#9399530)
S/he said, bluntly.
Re:A Million Lines of Bad Code by pharke on Friday April 17, 2015 @06:48PM (#9397619)
Delivering constructive criticism in a polite and non-abrasive way is more efficient. If abruptly telling someone their wrong causes them to take offense to the help you're trying to provide, they'll likely disregard what you've just told them out of pride or spite and you'll reduce their willingness to work with you on future problems.

By being polite you're ensuring that the message you're sending gets incorporated into their strategy for tackling that problem and making them feel comfortable discussing other issues with you.

As programmers, we have to learn that 'programming' people is very different from programming computers.

Re:A Million Lines of Bad Code by iagooar on Saturday April 18, 2015 @01:44AM (#9398431)
Efficiency is one thing, being a douche is another. Programmers are still human beings and while they might tolerate some harsher comments, they still affect them. Efficiency yes, but not above all.
Re:A Million Lines of Bad Code by LoSboccacc on Friday April 17, 2015 @05:11PM (#9397216)
on the other hand, would you like to work with someone that doesn't take criticism well and whom jumps on the defensive about random pieces of code, of all things?
Re:A Million Lines of Bad Code by grecy on Friday April 17, 2015 @10:26PM (#9398108)
Canadian Snowboard Instructors call that "Positive, to and try" i.e.

That's great! To make it read files faster, next time let's try xyz.

Re:A Million Lines of Bad Code by shanemhansen on Friday April 17, 2015 @06:37PM (#9397580)
I think the key is to give an honest compliment on not a bullshit one. So instead of "great job on the thing! but ..." maybe "great job finding and diagnosing the root cause of that problem, that was pretty hairy, but I think there's a better way to fix the root cause".