Re:A Million Lines of Bad Code
by bstamour on Friday April 17, 2015 @04:15PM
(#9396929)
In the martial arts community we call this "praise, correct, praise."
[ Parent
| on HN ]
What's weird is that even though I know this is a "trick" I still want people to talk to me that way unless I specifically ask them for the hard truth.
Re:A Million Lines of Bad Code
by artursapek on Friday April 17, 2015 @04:28PM
(#9397011)
Programmers tend to incline towards efficiency. I think that's why we often skip the bread and deliver only the filling. IMO there's a big difference between a criticism sandwich and tactful criticism.
Re:A Million Lines of Bad Code
by npizzolato on Friday April 17, 2015 @05:29PM
(#9397298)
"Inclining towards efficiency" might be their justification, but I think the truth is closer to many programmers simply lacking tact.
S/he said, bluntly.
Delivering constructive criticism in a polite and non-abrasive way is more efficient. If abruptly telling someone their wrong causes them to take offense to the help you're trying to provide, they'll likely disregard what you've just told them out of pride or spite and you'll reduce their willingness to work with you on future problems.
By being polite you're ensuring that the message you're sending gets incorporated into their strategy for tackling that problem and making them feel comfortable discussing other issues with you.
As programmers, we have to learn that 'programming' people is very different from programming computers.
Efficiency is one thing, being a douche is another. Programmers are still human beings and while they might tolerate some harsher comments, they still affect them. Efficiency yes, but not above all.
Re:A Million Lines of Bad Code
by LoSboccacc on Friday April 17, 2015 @05:11PM
(#9397216)
on the other hand, would you like to work with someone that doesn't take criticism well and whom jumps on the defensive about random pieces of code, of all things?