News for hackers. Stuff that matters.
Re:A Million Lines of Bad Code by swalsh on Friday April 17, 2015 @04:06PM (#9396881)
I recently read the book "How to Win Friends & Influence People", bad title great book. My main take away from this is I've been talking to people really badly for the last 27 years. I wish I had read this book in middle school.

But this blog reminded me of some of the concepts from the book, its far more productive to give positive encouragement than to give negative feedback, and just adding a complement isn't enough if you follow it with a "but".

"Hey pretty cool program! Its a great start. I bet we can make it run faster if we changed the way files are imported to something like this... nice work"

will get better results then this

"Hey pretty cool program, but you're reading in files wrong"

which even that is better than this

"You're reading in files completely wrong, try googling for a better solution" which unfortunately among engineers seems to be the most common reply.

Re:A Million Lines of Bad Code by AceJohnny2 on Friday April 17, 2015 @04:16PM (#9396935)
I like teaching. I don't think I'm amazing at it, but I like sharing knowledge and experience with my friends and co-workers and see them improve, or just sometimes for the abstract sense of helping. Of course, sometimes I fall flat and come across as arrogant or condescending, but I hope that's rare. I read "How to make friends" a long time ago, and I apply those rules diligently to my interactions with people.

Recently though, I've been assigned a guy to help me with one of my tasks, managing the build pipeline. This requires a wide range of knowledge about unix and scripting (Bash, Perl AND Python. Yup. On top of Makefiles, of course).

The guy doesn't know how to use a command-line.

I'm surprised to find myself to be very unhelpful and curt with this guy. He's the unlucky recipient of my resentment at the amount of effort I will have to put in before he can actually become remotely helpful. Of course, it doesn't help that he's in far off timezone where I'd have to stay up late to help him, and that I have trouble getting direct answers from him about his knowledge level. The communication and experience gap is too large.

Anyhow, this is just my two cents relating an experience to show how a seemingly normal and friendly human being can revert to angry "RTFM"s.

Re:A Million Lines of Bad Code by irremediable on Friday April 17, 2015 @04:32PM (#9397042)
Very well said. It's wrong to be a dick, but it's also the natural response to a lot of stressful situations. Think of trying to give tech support to relatives, for example. It's too easy to get annoyed with other people, and this is especially true when you're under pressure and they're MEANT TO BE HELPING, DAMNIT!

FWIW, I suspect that you're much more experienced in this stuff than me, so it's a bit arrogant for me to offer a suggestion. But still, I'm going to offer one. Is the guy quite self-motivated? If so, one thing that might help you is to spend some time curating good learning resources for him, and then linking him to them. It's essentially the ethical version of RTFM. You help him figure out what the useful "M" actually is, and he'll get himself up to scratch from there.

Just a suggestion, anyway. :)

Re:A Million Lines of Bad Code by AceJohnny2 on Friday April 17, 2015 @05:11PM (#9397220)
That's actually the route I've been trying to follow, but that's where the experience gap becomes a problem. I can give him some ressources on how to use Git or learn Python, but it's been so long that I don't even know where to start for the CLI :|
Re:A Million Lines of Bad Code by johnmaguire2013 on Friday April 17, 2015 @06:12PM (#9397473)
I found this pretty good for sharing to people, if you're targeting Linux: http://linuxsurvival.com/

Parts of it are a bit dated (no longer typically used features), but it's a pretty good overview of how Linux works for end users.

Re:A Million Lines of Bad Code by tthrowaway on Friday April 17, 2015 @05:31PM (#9397303)
I like this:

http://www.amazon.com/Practical-Guide-Commands-Editors-Progr...

I've also found "Unix for the Impatient" very helpful but the 1995 copyright is a little scary.

Re:A Million Lines of Bad Code by vehementi on Saturday April 18, 2015 @03:22AM (#9398605)
I had the same problem with a past coworker, a "how is this person being paid to work with technology in any capacity" person doing development and having never learned how to read graphs ("the CPU is at the top of the graph, so that is the cause of the performance problem" was common). Or knowing that Excel could do visualizations of data. And I found myself doing the "Blatantly type their question into google right in front of them and click on the first link" thing and being super short and RTFM-y which made me feel bad afterward. But so resentful.
Re:A Million Lines of Bad Code by fallinghawks on Saturday April 18, 2015 @12:00PM (#9399873)
I had an IT job where I was the only person taking care of all office technology for 22 locations. This got bigger over time and I pushed management to get me some help. I got some halftime assistants, one of which was great, but he was a young guy and decided to move on after about 2 years (I was rather pleased this was the longest he had ever held a job!)

Then the powers that be decided I needed a manager, and hired some old wreck retired from IBM. I have no idea why. Old? Male? Wore a suit and would be more presentable to the board than me (not hard)? It was certainly not for his knowledge. He couldn't fix a PC, diagnose Windows problems, or use a Unix command line, and actually added to my workload because he would break his computer and need me to fix it. A co-worker quietly told me he spent his day playing Solitaire and taking messages because he was unable to solve problems.

He didn't seem to want to learn, either. That was the kicker. I would usually spend an hour a day teaching my previous assistant about networks or software, but this guy, his ignorance was just too big and he just didn't express any curiosity. I'm pretty sure his job was to collect a paycheck.

I quit. There wasn't really much choice. I was overworked and insulted. And within 2 weeks he resigned as well.

Re:A Million Lines of Bad Code by cxseven on Sunday April 19, 2015 @09:54AM (#9403125)
You made the right choice.
Re:A Million Lines of Bad Code by conistonwater on Friday April 17, 2015 @05:06PM (#9397200)
> Anyhow, this is just my two cents relating an experience to show how a seemingly normal and friendly human being can revert to angry "RTFM"s.

The guy is not just a human being, he's also a professional whose job it is to know what he's doing. Shouldn't there be some sense of "duty to do a job well", not just "duty to care about someone's feelings"? If he's not pulling his weight and is failing at his job, then the poor responses are his fault also.

Re:A Million Lines of Bad Code by AceJohnny2 on Friday April 17, 2015 @05:15PM (#9397234)
Sound like you haven't been working with outsourced talent and a boss that says "this is all we've got, deal with it." ;)

The "interesting" thing here is the cultural gap, where these folks have had all initiative beaten out of them throughout their education, where the cost of failure is higher than that of not trying. It's really disheartening.

My point is, it's heard to blame the person when you know how flawed is the system they come from.

Re:A Million Lines of Bad Code by capisce on Sunday April 19, 2015 @07:02AM (#9402735)
Your boss should pay you handsomely for the extra overtime and responsibility involved.
Re:A Million Lines of Bad Code by GFK_of_xmaspast on Friday April 17, 2015 @06:48PM (#9397615)
"And forgive us our sins; for we ourselves also forgive every one that is indebted to us."
Re:A Million Lines of Bad Code by magicalist on Friday April 17, 2015 @04:59PM (#9397171)
> Anyhow, this is just my two cents relating an experience to show how a seemingly normal and friendly human being can revert to angry "RTFM"s.

Sure. We're all human, and I know I've been there many times. Just also remember how the seemingly normal and ready to learn human will react to a lesson put that way.

Re:A Million Lines of Bad Code by AceJohnny2 on Friday April 17, 2015 @05:06PM (#9397198)
I know, and that's the part I feel worse about.
Re:A Million Lines of Bad Code by keithpeter on Saturday April 18, 2015 @03:40AM (#9398633)
How was the gentleman 'assigned' to help you?

Did the assigner spend enough time with the remote worker to understand the skill level?

In your organisation, is it OK to report a skill mismatch like this up the chain?

Summary: this is a management issue I think

Re:A Million Lines of Bad Code by cperciva on Friday April 17, 2015 @04:11PM (#9396908)
"Hey pretty cool program! Its a great start. I bet we can make it run faster if we changed the way files are imported to something like this... nice work"

I usually hear this referred to as a "criticism sandwich": Criticism surrounded on either side with compliments.

Re:A Million Lines of Bad Code by switch007 on Friday April 17, 2015 @04:30PM (#9397030)
We Brits are the masters of allusive and indirect speech, and I would automatically automatically strip of both pieces of bread translate that to "you're reading in files wrong".
Re:A Million Lines of Bad Code by cperciva on Friday April 17, 2015 @04:44PM (#9397108)
Yes, I would automatically parse the "bread" as being boilerplate politeness -- but as with most forms of politeness, I would probably feel differently about the speaker if it wasn't there.
Re:A Million Lines of Bad Code by thothamon on Friday April 17, 2015 @04:59PM (#9397175)
I think you have to take each individual differently. Most folks react well to the criticism sandwich. Someone like you might prefer a more direct approach, as long as it is not phrased in a mean way.

At some point in my career, I stopped taking criticism personally. I just realized I was wrong so often that upholding the pretense that I knew it all was too hard. For that reason, I prefer direct suggestions.

If I was teaching a child or a new beginner, I would start with a lot of praise that they're even trying. I want to get them some early wins to help boost their confidence.

Re:A Million Lines of Bad Code by r00fus on Friday April 17, 2015 @04:59PM (#9397174)
Not everyone auto-parses. Unless you really know who you're talking to, it makes sense to add the "bread/condiments" to the sandwich.
Re:A Million Lines of Bad Code by bstamour on Friday April 17, 2015 @04:15PM (#9396929)
In the martial arts community we call this "praise, correct, praise."
Re:A Million Lines of Bad Code by gagege on Friday April 17, 2015 @04:27PM (#9397001)
What's weird is that even though I know this is a "trick" I still want people to talk to me that way unless I specifically ask them for the hard truth.
Re:A Million Lines of Bad Code by artursapek on Friday April 17, 2015 @04:28PM (#9397011)
Programmers tend to incline towards efficiency. I think that's why we often skip the bread and deliver only the filling. IMO there's a big difference between a criticism sandwich and tactful criticism.
Re:A Million Lines of Bad Code by npizzolato on Friday April 17, 2015 @05:29PM (#9397298)
"Inclining towards efficiency" might be their justification, but I think the truth is closer to many programmers simply lacking tact.
Re:A Million Lines of Bad Code by sullyj3 on Saturday April 18, 2015 @10:21AM (#9399530)
S/he said, bluntly.
Re:A Million Lines of Bad Code by pharke on Friday April 17, 2015 @06:48PM (#9397619)
Delivering constructive criticism in a polite and non-abrasive way is more efficient. If abruptly telling someone their wrong causes them to take offense to the help you're trying to provide, they'll likely disregard what you've just told them out of pride or spite and you'll reduce their willingness to work with you on future problems.

By being polite you're ensuring that the message you're sending gets incorporated into their strategy for tackling that problem and making them feel comfortable discussing other issues with you.

As programmers, we have to learn that 'programming' people is very different from programming computers.

Re:A Million Lines of Bad Code by iagooar on Saturday April 18, 2015 @01:44AM (#9398431)
Efficiency is one thing, being a douche is another. Programmers are still human beings and while they might tolerate some harsher comments, they still affect them. Efficiency yes, but not above all.
Re:A Million Lines of Bad Code by LoSboccacc on Friday April 17, 2015 @05:11PM (#9397216)
on the other hand, would you like to work with someone that doesn't take criticism well and whom jumps on the defensive about random pieces of code, of all things?
Re:A Million Lines of Bad Code by grecy on Friday April 17, 2015 @10:26PM (#9398108)
Canadian Snowboard Instructors call that "Positive, to and try" i.e.

That's great! To make it read files faster, next time let's try xyz.

Re:A Million Lines of Bad Code by shanemhansen on Friday April 17, 2015 @06:37PM (#9397580)
I think the key is to give an honest compliment on not a bullshit one. So instead of "great job on the thing! but ..." maybe "great job finding and diagnosing the root cause of that problem, that was pretty hairy, but I think there's a better way to fix the root cause".
Re:A Million Lines of Bad Code by MichaelGG on Friday April 17, 2015 @04:28PM (#9397009)
Don't you feel patronized when people do that though? Be as rude as you want to me, as long as you're correct.

As for myself, I tend to not call out the positive parts of something, because that's sort of implicit. I would not bother to point out that the file reading code is wrong if the whole thing was broken.

I admit I'm probably incorrect here, but I notice people try this "say something positive" and it really comes off wrong. Or maybe I don't notice when they do it well.

Re:A Million Lines of Bad Code by dropit_sphere on Friday April 17, 2015 @04:52PM (#9397138)
I strongly agree. Sentence formulas are a hack. The actual advice should be, believe something positive. Specifically, believe that the person is basically smart but just didn't know X. That leads to natural utterances like:

"Sweet! Uh...that run time is pretty terrible though. Don't worry, let's see what's up with that. (Twenty seconds later:) Ohhhhhhhhh, ha, ok, check this out."

The novice coder knows they suck. They're not really worried about that because, well, they're still here. What they are worried about is that you'll write them off. So don't.

Re:A Million Lines of Bad Code by zminjie on Friday April 17, 2015 @05:00PM (#9397177)
I think it just comes down to different personalities. I'm just like you. I tend to get agitated when people try to sandwich their criticisms or compliment me for irrelevant things when I just want them to get to the point. I'd very much prefer someone just telling me "your code is shitty and here is how you'd fix it and why." Unfortunately, people that take criticisms like us seem to be in the minority.
Re:A Million Lines of Bad Code by TeMPOraL on Friday April 17, 2015 @09:57PM (#9398075)
That's why I personally declare Crocker's rules[0] - if you want to tell me something, I allow you to skip pleasantries and "social hacks", and just get straight to the point.

[0] - http://wiki.lesswrong.com/wiki/Crocker%27s_rules

Re:A Million Lines of Bad Code by davidgerard on Saturday April 18, 2015 @07:04AM (#9399001)
The trouble is: that's not how humans work. Including ones who push Crocker's rule. Personalising negative comments is how human brains work.

Remember: knowing a bias exists doesn't make it go away, at all.

In my experience, the sort of person who professes a love of unvarnished communication is someone heavily into sending it - the same people reliably hit the roof whenever they receive it.

Public relations is 50% of the job, even if you're bad at public relations. There are no quick hacks to make that go away, 'cos if there were then everyone would already be using them.

Re:A Million Lines of Bad Code by jonex on Friday April 17, 2015 @05:13PM (#9397225)
I gotta wonder, do you actually have such confidence yourself that you assume that everything other people _does not_ comment was good? If so congratulations! A suggestion though, on how you could improve the confidence in people like me - who aren't sure everything not mentioned is good - would be to actually point out the positive parts even if you don't feel that it is necessary.

I have to admit though, it took many years and a few courses in psychology until I finally could admit to myself and my surroundings that I actually need positive reinforcement, that negative reinforcement, even if true and relevant, could even be detrimental to my performance.

I do agree on the importance of not just "say something positive", it has to be real, most people have probably filled their quota of obviously false/exaggerated complements in preschool. I myself struggle with finding the right balance between sounding patronizing and being overly critical.

Re:A Million Lines of Bad Code by MichaelGG on Friday April 17, 2015 @06:06PM (#9397454)
I suppose there's a difference between when you're working with someone versus showing off to other people. If I'm doing a Show HN or I email a friend to check something out, sure I love flattery and compliments as anyone. It's within the technical scope of working together that I find it obnoxious.

And it's not really self confidence[1]. It's more of an extension of principles of coding. Anyone can write a system that does X. But doing X when things go well, and doing it in the face of errors, edge cases, and other faults - that's what it's all about. For me, anyways, when I'm writing code "as an engineer". So I don't find it particularly notable that something works. Of course it " works ", or you wouldn't be telling or showing me in the first place! Likewise if I ask for a review and your only comment is " file buffer is too small " I'm gonna guess the rest is alright else you wouldn't bother pointing out smaller things. If I'm unsure about something, I'll ask about it explicitly.

Outside of a feedback system like a code review, it is important to let people know you appreciate their work. And it's to my detriment that I don't let people know, honestly, when I appreciate them. But that's separate from mixing it in with criticism.

1: I've low confidence in my self confidence. On one hand I know I have a fairly good error rate and I'm objectively better than a lot of other developers. Yet, especially here on HN, I can plainly see I'm nothing special. But this doesn't really assure me that any particular piece of my work is good.

Re:A Million Lines of Bad Code by thaumasiotes on Saturday April 18, 2015 @03:10AM (#9398584)
tangential comment:

> I gotta wonder, do you actually have such confidence yourself that you assume that everything other people _does not_ comment was good? If so congratulations! A suggestion though, on how you could improve the confidence in people like me - who aren't sure everything not mentioned is good - would be to actually point out the positive parts even if you don't feel that it is necessary.

If you learn another language (a human language), and try to practice it with native speakers, you'll quickly notice that they never comment on your correct grammar. (It's not exactly common for people to comment on incorrect grammar either, but it can happen.) The only way to learn that your phrasing was correct is to ask outright, or observe someone producing an exact analogue of your sentence. This is a source of great aggravation to me, but things couldn't reasonably be any other way -- most of the correct stuff people say is stuff that they already knew was correct.

Re:A Million Lines of Bad Code by e12e on Saturday April 18, 2015 @09:21AM (#9399359)
I agree... to a point. It reminds me a bit about this quote by Ricky Grevais:

"The other thing about it is: Comedy comes from a good or a bad place. And I think that the funniest people always comes from a good place. Two people can say the same thing, and one person can be so nasty and vitriolic -- and therefore not funny. And the other can be, you know, a celebration. You know, you can be in on the joke."

--Ricky Gervais

http://www.howardschatz.com/film.php?ID=3814

Corny as it might sound -- I think brutal honesty is more constructive when it comes from a place of love. I'm not sure what the practical take-away from that is. Maybe build trust first, and then be direct? Or be honest, but avoid being mean?

OTOH I think everyone deserves/needs a good bit of BOFH bootcamp to slap them into reality before they are let lose writing code that talks to the Internet... ;-)

Re:A Million Lines of Bad Code by oldmanjay on Friday April 17, 2015 @04:31PM (#9397036)
This is helpful for sure, but it's also very useful to work on having a thick enough skin to take insulting feedback in a positive fashion. After all, the only way someone can offend you is if you let them.
Re:A Million Lines of Bad Code by 4gotpassword123 on Friday April 17, 2015 @04:36PM (#9397065)
I kind of get a kick out of your response.

You've offered a compliment, then suggestion, then a platitude, while telling someone that being rude is acceptable if it's technically correct and seemingly disagreeing with the previous poster.

It's sound advice, to have thick skin, but you've just shown how easy it is to give corrective feedback in a tactful way. Still good advice to not let people offend you though.

Re:A Million Lines of Bad Code by Lawtonfogle on Friday April 17, 2015 @04:52PM (#9397134)
>This is helpful for sure, but...

You did this on purpose, didn't you. ;)

Re:A Million Lines of Bad Code by tthrowaway on Friday April 17, 2015 @05:11PM (#9397217)
I'm a junior dev, I have a ton to learn and I don't for a moment think I know more than our senior dev. But working with this guy, and trying to learn from him, is a nightmare.

When I ask "why should I do this rather than that?", I either get a muddy explanation, or none at all.

Worse still is inconsistency. Just recently I was working on a project, went through several reviews without comment on the approach, was told "almost done just fix these tests". After waiting a week for review of those last tweaks, the review was "this is fundamentally flawed and shouldn't be done this way at all."

Now I'm not saying that's wrong, but it would have been better to hear that three weeks ago. Nor is the explanation of _why_ it's flawed the slightest bit clear.

Further, the new approach does _not_ support the business need motivating these changes in the first place. I am figuring out how to support that need within the directed approach, but it is harder than the first design would have been. Again, that doesn't mean I was right -- sometimes there are choices where you put the ugly stuff. These changes are pretty deep in our architecture, and so touch a lot of code. If being clean there means that some top-level stuff is more complicated, that is probably the right trade-off. But it would be nice to have a "sorry, I didn't think this through soon enough." And no, I am not the idiot I'm made out to be because I didn't, as a junior dev, immediately and fully understand how all the pieces should fit together.

Nor is this a two-way street. I've had moments where I've pointed out what seems like problems, been told I'm wrong, or ignored . . . and then find that the issue is quietly fixed a few days later. We do some stuff that is just flat wrong because that's how he likes it.

I'm not the only one, the others with more experience than I have similar problems.

I'm learning. The guy has good instincts, so his critiques usually lead in the right direction, so I roll with it and figure out the principles for myself. But it is absolutely zero fun working with this guy. I've become averse to submitting code for review, because I never know when the process will take 180 and stuff that was fine becomes crap. And while I think I'm getting better, I have to figure out how to build confidence in those skills, because I'm not going to get it from this feedback loop. Probably that will be working on my own projects, taking what I'm learning and using that to make them better. And at some point I'll move on.

Tough feedback, even insulting feedback, is ok with me. I'll work with it. But if you're going to be tough, then you have to be fair, you have to be clear, and you have to be right.

Re:A Million Lines of Bad Code by thothamon on Friday April 17, 2015 @05:31PM (#9397310)
I usually ask more senior people why they say that, and keep asking why until I get it. If this process seems to be going on too long, I ask if there's a book or reference I should be reading to understand the subject better. Honestly, most senior people will be very pleased that you care enough to find out why, including following up with external resources.

If a senior person won't explain something if you ask politely, usually either they don't understand it themselves, or they are simply not very good at explaining things. Not all senior people are good teachers. It sounds like your team lead is one of the latter.

Re:A Million Lines of Bad Code by grey-area on Saturday April 18, 2015 @03:09AM (#9398580)
The problem here, and you'll encounter it with clients and seniors throughout your career, is that your senior/boss doesn't have enough time, or thinks they don't have enough time, to supervise your work correctly and thus comes in at the last minute and drops hidden requirements/fundamental changes on you. It's very common.

If you want to avoid this, you're going to have to make it your job to point out potential flaws and hurdles in your work as you come across them, to ask only for essential and broad-strokes guidance up front, and to find/fix smaller issues yourself as you go along without bothering the higher ups. Your senior probably genuinely wasn't aware of the deeper issues with your work because they just didn't have time to do anything but scan your code and hope for the best, because their senior is hassling them about a,b,c, which are far more important.

Now that was flawed on their part, and they're doing their job wrong, but you can help them fix that process, if you want to, and it is a good skill to learn. You absolutely should not be avoiding code review, you should be guiding that process in a direction that is in everyone's interest. The world of work is not remotely fair, clear or right - it is very rarely even one of those, but you can make it better yourself by managing upwards and making your requirements and concerns clear at a very early stage.

In my opinion the dichotomy of tough but fair/nice but inaccurate feedback is a false one. Most feedback is rushed, muddled, partly correct, partly irrelevant, partly insightful and still useful if you know how to mine it.

Re:A Million Lines of Bad Code by shanemhansen on Friday April 17, 2015 @06:30PM (#9397554)
I'm an engineer, and I've gotten so much benefit out of that book. I read it cover to cover several times a year. It's very corny, but it reminds me of several things I often don't conciously think about when interacting with people. Sometimes reading that book is the only way I can get through the day and interact pleasantly with people.

One reason engineers can be unintentionally critical is that their job is often "find what's wrong with this thing and make it better". It's rarely "find what's right with this thing and congratulate someone". It takes me quite a bit of mental effort to switch from nitpick mode to encouragement mode. I've tried to consciously balance my criticisms by leaving a few honest encouraging comments in code reviews like: "thanks for improving test coverage here", or "glad you handled timeouts and retrys, this api has given us grief before".

Re:A Million Lines of Bad Code by bentcorner on Friday April 17, 2015 @04:30PM (#9397025)
> "You're reading in files completely wrong, try googling for a better solution" which unfortunately among engineers seems to be the most common reply.

I can empathize with this because I feel like saying this all too often. I guess it's a mentality of "teach a man how to fish". I guess I could use a reading of "How to Win Friends & Influence People".

Re:A Million Lines of Bad Code by jqm on Saturday April 18, 2015 @01:25PM (#9400198)
The problem with the "win friends and influence people" method is that some people just listen to the positive parts and go right on their way never improving.

We aren't selling cars nor running for office where "win friends" is particularly useful. I'm also not saying we should be deliberately nasty or personally demeaning. But we shouldn't let shit pass just to be nice either. There is far too much of that nonsense in the world, and the net effect of it is a theft from everyone.

We should try to be our best. We should ask others to be their best. We should always be positive and helpful and teach others what we can. But we should also be direct when something is wrong and we know better. This in the best interest of the person, the project and the organization. The ability to give and to accept honest criticism with the goal of improvement is unfortunately strikingly rare.

When we don't know better we should keep our mouths shut rather than bluffing and blustering our way along. If I had 10 bucks for every loudmouth know-nothing trying to impress everyone or score political points I have met in life I'd be rich. The tech scene is particularly full of these kind of blowhards in my experience. Some people have a hard time telling the difference between positive honest criticism and ego driving showing off. And some people just plain don't know what they are talking about but talk anyway. This kind particularly needs to be called out in the most direct manner possible for the best interest of everyone involved.

Re:A Million Lines of Bad Code by laacz on Friday April 17, 2015 @04:49PM (#9397125)
When I read that book by Dale Carnegie one think struck me. Aside from being well with words and advice he never succeeded in his own life. Two divorces and almost no friends at the end of his life.

General advice is easy to give. There are millions of tiny details which tend to guide you away.

Re:A Million Lines of Bad Code by thothamon on Friday April 17, 2015 @05:39PM (#9397345)
Sources for that? Wikipedia doesn't mention a divorce with his second wife, Dorothy Vanderpool.
Re:A Million Lines of Bad Code by zachalexander on Friday April 17, 2015 @04:31PM (#9397033)
In short, "yes and" instead of "no" or "but".
Re:A Million Lines of Bad Code by eranation on Friday April 17, 2015 @04:28PM (#9397013)
Yes! this book changed my life. It is amazing how many are not aware of the amount of criticism that they output, willingly or unconsciously.
Re:A Million Lines of Bad Code by Swizec on Friday April 17, 2015 @04:30PM (#9397031)
I too recently read that book and loved it.

But (yes, I buted), I think a lot of people go overboard. I've seen people get so bent up around coming off as nice and encouraging, that it becomes difficult to even understand what they want from you. Or worse, it comes off passive aggressive.

I'm not sure there's a better fix for that than practice.

Re:A Million Lines of Bad Code by zura on Friday April 17, 2015 @04:46PM (#9397110)
Hah, nice to hear that famous book (which I've never read so far) coincides with my understanding and behavior. The only motivation for me is that I value people and their feelings much more than any other thing. To be honest, it is not planned or contrived... It is just a natural feedback.
Re:A Million Lines of Bad Code by davidgerard on Saturday April 18, 2015 @07:01AM (#9398987)
Michael Meeks has a good example of how this is supposed to work in LibreOffice:

https://people.gnome.org/~michael/data/2011-10-13-new-develo... (5 page presentation)

Compare pages 3 and 4.

Re:A Million Lines of Bad Code by var_explained on Friday April 17, 2015 @04:17PM (#9396939)
What's interesting is that XKCD shows replies that are even worse than your last reply- even suggesting Googling provides a course of action. XKCD's more like "My grandmother could read files faster than that."
Re:A Million Lines of Bad Code by staunch on Friday April 17, 2015 @04:30PM (#9397028)
The main difference in your example is talking about the code instead of talking about the person.