News for hackers. Stuff that matters.
Re:Software Engineering at Google by sa46 on Monday August 14, 2023 @04:22PM (#37126322)
Of all the Google dev tools, I miss Critique the most. GitHub is terrible at giving enough context to efficiently review a PR on a second or third pass.

I think coupling commits with review progress was a mistake.

Re:Software Engineering at Google by codeapprove on Monday August 14, 2023 @04:26PM (#37126358)
Shameless plug but if you're missing Critique and working on GitHub, try CodeApprove (https://codeapprove.com) which brings as much of the Critique magic to GitHub as possible.
Re:Software Engineering at Google by limonkufu on Monday August 14, 2023 @05:23PM (#37126987)
This seems very simiilar to Gitlab's MR. Does anyone know all of them to highlight their strengths and drawbacks?
Re:Software Engineering at Google by darkwater on Monday August 14, 2023 @05:25PM (#37127016)
Offtopic but, aren't you scared by "GitHub improves its PR workflow" and put your product out of business?
Re:Software Engineering at Google by codeapprove on Monday August 14, 2023 @05:29PM (#37127064)
Yes that's a real risk! CodeApprove is not (yet) anyone's full time job so it's also an acceptable risk.

However I think the biggest issue with the landscape for code review tools is that 99% of developers use the default system that ships with their VCS. So on most teams, that's GitHub. People should be actively choosing their code review tools just like they choose their VCS, IDE, CI/CD platform, Issue Trackers, etc. It's one of many tools that makes up your SDLC "Stack".

Re:Software Engineering at Google by underdeserver on Tuesday August 15, 2023 @01:51AM (#37130663)
They haven't done it yet. What's been stopping them?

As long as CodeApprove and Reviewable remain niche they've got nothing to worry about.

Re:Software Engineering at Google by nh2 on Monday August 14, 2023 @08:01PM (#37128417)
https://reviewable.io is the earliest full-powered Critique alternative for GitHub.

It supports some cool things Critique doesn't/didn't, such as reviewing multi-commit branches (also across history-rewriting force-push cleanups), and indicating exactly the nature of your comment (just FYI, or you want this to be changed before you'll give your approval).

(I was an intern in the initial making of Critique, and subsequently got interested in finding an out-of-Google alternative. I contributed a bit to other review tools such as ReviewBoard, and actively used Gerrit, Crucible, Phabricator, and GitLab reviews.)

When looking for a Critique alternative for my startup, reviewable.io had just appeared and ticked all the boxes, and we use it successfully for many years. The drawbacks are that it's GitHub-only and isn't free software.