News for hackers. Stuff that matters.
Re:Don’t Teach During Code Reviews by rerdavies on Sunday February 05, 2023 @06:31PM (#34671016)
I most recently worked on a 100% code-review team. Fabulous!

In my personal experience, the hump from wide-eyed novice junior to productive contributing member really doesn't take that long when every line that everyone writes is code-reviewed. The first couple of code reviews might take longer than usual. But it definitely much less time than it used to take to bring a junior up to speed. No net productivity in the first year used to be a rule, when bringing juniors onboard in the dark ages of computing. With 100% code reviews, that process seems to take no more than a couple of months -- maybe even as little as one month. The difference is dramatic.

It's a fabulous way to transmit not only good culture, but also love of our craft.

Re:Don’t Teach During Code Reviews by mplanchard on Sunday February 05, 2023 @07:34PM (#34671619)
What do you mean by 100% code review?
Re:Don’t Teach During Code Reviews by bdangubic on Sunday February 05, 2023 @07:41PM (#34671680)
Every line of code must be code reviewed before it goes to stage/prod
Re:Don’t Teach During Code Reviews by xxpor on Sunday February 05, 2023 @08:00PM (#34671838)
… how else do people operate? Complete yolo?
Re:Don’t Teach During Code Reviews by Aeolun on Sunday February 05, 2023 @08:06PM (#34671896)
Maybe rubber stamp PR? We can say we review everything 100%, but practically this sometimes just means clicking the approve button.
Re:Don’t Teach During Code Reviews by rerdavies on Sunday February 05, 2023 @09:13PM (#34672394)
lol. I've been doing this for a long time. It wasn't always done that way.
Re:Don’t Teach During Code Reviews by ornornor on Monday February 06, 2023 @02:21AM (#34674345)
You’d be surprised how many places operate that way. Or better, commit to master via the web ui because “it’s a quick small fix”