Re:Don’t Teach During Code Reviews
by mplanchard on Sunday February 05, 2023 @07:34PM
(#34671619)
What do you mean by 100% code review?
Every line of code must be code reviewed before it goes to stage/prod
… how else do people operate? Complete yolo?
Maybe rubber stamp PR? We can say we review everything 100%, but practically this sometimes just means clicking the approve button.
lol. I've been doing this for a long time. It wasn't always done that way.
In my personal experience, the hump from wide-eyed novice junior to productive contributing member really doesn't take that long when every line that everyone writes is code-reviewed. The first couple of code reviews might take longer than usual. But it definitely much less time than it used to take to bring a junior up to speed. No net productivity in the first year used to be a rule, when bringing juniors onboard in the dark ages of computing. With 100% code reviews, that process seems to take no more than a couple of months -- maybe even as little as one month. The difference is dramatic.
It's a fabulous way to transmit not only good culture, but also love of our craft.