News for hackers. Stuff that matters.

A comment on Don’t Teach During Code Reviews. Parent comment

Re:Don’t Teach During Code Reviews by bdangubic on Sunday February 05, 2023 @07:41PM (#34671680)
Every line of code must be code reviewed before it goes to stage/prod
[ Parent | on HN ]
Re:Don’t Teach During Code Reviews by xxpor on Sunday February 05, 2023 @08:00PM (#34671838)
… how else do people operate? Complete yolo?
[ Parent | on HN ]
Re:Don’t Teach During Code Reviews by Aeolun on Sunday February 05, 2023 @08:06PM (#34671896)
Maybe rubber stamp PR? We can say we review everything 100%, but practically this sometimes just means clicking the approve button.
[ Parent | on HN ]
Re:Don’t Teach During Code Reviews by rerdavies on Sunday February 05, 2023 @09:13PM (#34672394)
lol. I've been doing this for a long time. It wasn't always done that way.
[ Parent | on HN ]
Re:Don’t Teach During Code Reviews by ornornor on Monday February 06, 2023 @02:21AM (#34674345)
You’d be surprised how many places operate that way. Or better, commit to master via the web ui because “it’s a quick small fix”
[ Parent | on HN ]