News for hackers. Stuff that matters.
Re:Rewriting TypeScript in Rust? You'D have to be by madeofpalk on Wednesday December 14, 2022 @07:37PM (#33993204)
Weird - using constant string discriminators feel very natural and normal to me in Typescript. What do other languages do without them?
Re:Rewriting TypeScript in Rust? You'D have to be by refulgentis on Wednesday December 14, 2022 @08:00PM (#33993461)
Most model it as an actual enum, if backed by strings. Typescript, by comparison, requires being able to indicate a type just from a string argument
Re:Rewriting TypeScript in Rust? You'D have to be by esprehn on Wednesday December 14, 2022 @09:18PM (#33994231)
Allowing literal strings and type aliases of unions of strings to represent enums doesn't seem unreasonable. It's the same concept as many other languages with some extra quotes, ex. https://ocaml.org/docs/data-types#a-simple-custom-type
Re:Rewriting TypeScript in Rust? You'D have to be by goto11 on Thursday December 15, 2022 @11:33AM (#34001967)
"Some extra quotes" make a big difference though. The type of

   Red
in OCaml is pretty unambiguous, but the type of

   "Red"
in Typescript is not. The typesystem has to do a lot of work to support strings as both enum values, type descriptors and characters-strings.
Re:Rewriting TypeScript in Rust? You'D have to be by wruza on Thursday December 15, 2022 @04:37AM (#33997211)
This doesn’t change anything:

  foo(get_some_myenum_value(), …)
  {type:get_another(), …}
These are as unguessable as if myenum was a string.
Re:Rewriting TypeScript in Rust? You'D have to be by madeofpalk on Thursday December 15, 2022 @06:08AM (#33997798)
Hmm. That doesn't feel like much of a difference to me?
Re:Rewriting TypeScript in Rust? You'D have to be by refulgentis on Thursday December 15, 2022 @10:30AM (#34001037)
It's huge? I'm really confused lol. I write in Dart/Java/C++/ObjC/TS regularly to maintain a cross-platform library and this is a massive difference from every typechecker in any other language, much less the narrower thing of if the idea of reifying random strings into an enum is a novel feature. I get a very strong sense from the thread that people are talking past eachother, somehow.
Re:Rewriting TypeScript in Rust? You'D have to be by goto11 on Thursday December 15, 2022 @02:17AM (#33996290)
The event type could just be exposed as a regular property so you could write `element.onclick.add((ev => ...)` so you would get static typing without any need for magic strings.

Magic string are use all over JavaScript for different purposes. For example createElement('P') could just be new PHtmlElement() ...

In other cases magic strings could be replaced with enums.

Re:Rewriting TypeScript in Rust? You'D have to be by madeofpalk on Thursday December 15, 2022 @06:09AM (#33997805)
Changing Javascript is explicitly out of scope for Typescript.

I was curious how other languages did discriminators in a way that makes Typescript's feel alien. Just having different functions doesn't really tackle that.

Re:Rewriting TypeScript in Rust? You'D have to be by 411111111111111 on Thursday December 15, 2022 @10:23AM (#34000891)
Agreed and I think the reason for this confusion is because string types generally aren't considered a complicated feature of typescript.

Nor is it unique to it. I.e. elexir does the same through pattern matching and it works even better as far as I'm concerned.

It's more about the features that enable extended type inference and modifying these inferred types on-the-fly.

Easy to understand type modifiers like Omit<>, Partial<> etc are fine, but if you lean into that you can create pretty hard to understand typing logic. Especially if you're diving into annotations for code generation

Re:Rewriting TypeScript in Rust? You'D have to be by goto11 on Thursday December 15, 2022 @11:10AM (#34001644)
The pattern I'm most familiar with is using type constructors:

   type Shape = Square Int | Circle Int
and then pattern matching:

   print (Square size) = ..
   print (Circle radius) = ...
In Typescript this would be something like:

   type Shape = { type: 'square', size: number } | { type: 'circle', radius: number }
And string matching for type narrowing:

   function print(shape: Shape) {
     if (shape.type === 'square) {
       ...
     } else if (shape.type === 'square) {
      ...
     }
   }
The TypeScript approach is comparatively weird and verbose but also pretty clever since it doesn't require any change to the core language.

It also have some pitfalls, e.g. you can write:

  print({type: 'square', size: 10});
But you cant write:

  const x = {type: 'square', size: 10};
  print(x); <-- type error
You have to write:

  const x = {type: 'square' as const, size: 10};
  print(x);
Things like this just complicates the type system and type inference.