News for hackers. Stuff that matters.
Re:Twitter engineers told to print out their code by londons_explore on Saturday October 29, 2022 @01:01AM (#33381126)
Elements of this plan sound good.

Obviously musk doesn't have time to review it all... But saying 'print out a couple of pages of your recent code you are proud of and bring it to a review with your tech lead' is a good way to discuss coding style.

The 'you are proud of' is key to this working though - all your code is visible in the VCS anyway, but asking you to pick a good bit to discuss seems valuable.

Re:Twitter engineers told to print out their code by minraws on Saturday October 29, 2022 @01:12AM (#33381181)
From this perspective this seems very reasonable, if I picked some code which I like it will be very hard but I believe it will force me to consider what I don't consider in the day to day. Am I really proud of what I do? And what do I do really?

Maybe with a bit of back and forth with team mates it might help people like me as well who struggle with imposter syndrome on a daily basis feel like they can be proud of things they do.

Re:Twitter engineers told to print out their code by fzeroracer on Saturday October 29, 2022 @01:13AM (#33381185)
If a tech lead told me to print out some code and bring it to a review, I'd strongly reconsider the team I'm on. Not only is it among the worst ways to review code, but it also includes a lot of irrelevant information.
Re:Twitter engineers told to print out their code by systemvoltage on Saturday October 29, 2022 @01:57AM (#33381381)
Why? Printed code is code, NASA/Military does it for formal review. I've worked on avionics systems that are developed in similar fashion. You ought to be able to explain what it does. Most of it is going to be plumbing. Call this, fetch that, join foo, collate bar.

Strong arming Elon's intentions, may be he is used to perhaps how code reviews work in Space industry? Sometimes old school ways are fine, under the hood it is just code.

Re:Twitter engineers told to print out their code by fzeroracer on Saturday October 29, 2022 @02:35AM (#33381574)
No, no they do not. I've worked for the government and in that sector. We did not print code to review it. That might've been a thing a decade or two ago, but it is not a thing now and for good reason. And I would strongly question the technical capabilities of a team that was not able to adapt to modern tools even for older codebases. What exactly is your citation that they still do that?

It is simply much quicker and much more efficient to do something like a proper code share in an office with one person driving the code and being able to jump between areas of the code.

To say it bluntly: Anyone that uses printed code for code reviews is wrong. It assumes all functionality is colocated and nearby. It wastes time by forcing people to index through multiple pages of paper. Anyone that demands it should see prompt pushback.

Re:Twitter engineers told to print out their code by systemvoltage on Saturday October 29, 2022 @02:54AM (#33381676)
I worked in 2010, so yea it might have moved on. It's probably in powerpoints now ;-) I worked in military (not space) though. I still know people there and I'd guess it is not that modern. We'd also make bluebooks in 2010 with code printed and neatly bound in them.
Re:Twitter engineers told to print out their code by throwawayx130 on Friday November 11, 2022 @11:43PM (#33570025)
I worked both in the military and the military industry in the early 2000 and we never printed out any code for review.

We did have very thorough design documents and manuals and all of them have been printed (including documented function headers) as the contract dictated, but we only used the original word documents and the version control system to review our code.

Re:Twitter engineers told to print out their code by ergocoder on Sunday October 30, 2022 @03:47PM (#33397918)
People keep saying printing code is bad for twitter engs.

If I'm forced to print code, I would probably do it. It is essentially a few clicks taking a few minutes of my time.

On the other hand, your tech lead reviewing code on paper is going to be extremely painful. The tech lead who is forced to review code on paper would probably quit first.

Re:Twitter engineers told to print out their code by kotlin2 on Saturday October 29, 2022 @01:55AM (#33381375)
Judging the sizes of the stacked pages from the last 60 days of code would probably be a pretty good indication of productivity. Perfect? No. Good enough? Maybe.
Re:Twitter engineers told to print out their code by code_duck on Saturday October 29, 2022 @02:00AM (#33381404)
As in, the fewer pages, the more concise they are? What about clarity, and which languages are we talking about? Bonus points for Java? I think it’s been fairly well determined that LoC isn’t a good metric for judging productivity.
Re:Twitter engineers told to print out their code by kotlin2 on Saturday October 29, 2022 @01:05PM (#33385924)
I think LoC has been determined to be a bad productivity metric because it’s gameable and incentivizes bad behavior. However, that doesn’t apply here as the engineers didn’t know they were going to be evaluated by LoC a priori. I struggle to think of cases were lines-changed wouldn’t be correlated with the productivity of engineers working in a consistent environment if they weren’t trying to game the system.
Re:Twitter engineers told to print out their code by code_duck on Sunday October 30, 2022 @02:12AM (#33391658)
The problem is some languages are more verbose than others. Considering boilerplate (which is often automated these days) it extra has nothing to do with productivity. More lines doesn't mean more action - I mean, we're on a Lisp-derivative forum.

And sure, if I was getting judged by LoC I'd just paste in a library versus including it, which would generally be worse.

Re:Twitter engineers told to print out their code by whimsicalism on Saturday October 29, 2022 @02:10AM (#33381441)
Yeah, no.
Re:Twitter engineers told to print out their code by esoterica on Saturday October 29, 2022 @03:28AM (#33381844)
I never thought I would see someone on HN unironically advocate for counting LoC to measure productivity. Unbelievable how this guy's cult of personality poisons brains.
Re:Twitter engineers told to print out their code by scrubs on Saturday October 29, 2022 @03:44AM (#33381921)
100% right. I just watched an OJ Simpson trial documentary. From that making the small point being famous brings perception then perception management... Which goes fast to nowhere. Fixing Twitter can't start with loc and the new owner reading code. I can guarantee Gerstner never did that at ibm.
Re:Twitter engineers told to print out their code by sebastialonso on Saturday October 29, 2022 @08:11AM (#33383359)
I agree. They probably don't have any experience in Big Tech if that's really the case.
Re:Twitter engineers told to print out their code by kotlin2 on Sunday October 30, 2022 @09:14PM (#33400892)
People, even those at other big tech companies, unironically refer to working at Google as "retiring." Not sure 'big tech' is a great example to use when talking about productivity.
Re:Twitter engineers told to print out their code by kotlin2 on Saturday October 29, 2022 @09:12AM (#33383755)
I’ve worked in big companies and I’ve worked in small companies. The one constant has been that writing code is required to make product changes. No code likely means no changes. Maybe LOC != productivity makes sense when algorithms are of great importance, like in situations where a genius algorithm can unlock tons of value. Machine learning would be one example. However, most work is feature work, which typically has a straightforward path from start to finish. In product feature work, it’s unclear to me what activity would use time productively that didn’t result in lines of code.
Re:Twitter engineers told to print out their code by dekhn on Saturday October 29, 2022 @11:27AM (#33384860)
All my best programming work involved reducing lines in the codebase, not adding them.

Do I bring shredded paper to demonstrate that?

Re:Twitter engineers told to print out their code by whimsicalism on Saturday October 29, 2022 @11:30AM (#33384888)
Or just printing out diffs, not that I advocate for this position
Re:Twitter engineers told to print out their code by vkou on Saturday October 29, 2022 @02:35AM (#33381579)
> is a good way to discuss coding style.

Is scheduling every single person in the company to have a discussion about... coding style solve any particular problem Twitter has?

This reeks of 'I am the new owner, I need to do something, this is something, everyone will now be doing it.'

Re:Twitter engineers told to print out their code by yetihehe on Saturday October 29, 2022 @03:16AM (#33381784)
It helps to weed out total slackers, of which there could be non-negligible percent. If you have any shred of decent code - you are ok. If you can't produce a page of decent code after working a year - why would anyone keep such programmer.
Re:Twitter engineers told to print out their code by scrubs on Saturday October 29, 2022 @03:37AM (#33381892)
And why weren't they already canned? Slacker tls and managers. Next thing you know Elon is looking at himself.

Yeah bring code so we can talk about it is fine at the bottom level. Dumb for owner in first week. The good programmers know nothing will ultimately come of this codiscovery process thus making a bad impression on the good employees

Re:Twitter engineers told to print out their code by aniforprez on Saturday October 29, 2022 @09:09AM (#33383722)
Why in the Sam Hell would you need printouts. Literally look at git histories and contributions per user. This is bending over backwards to explain what is most likely a simple power play that most probably backfired
Re:Twitter engineers told to print out their code by yetihehe on Sunday October 30, 2022 @09:48AM (#33394485)
So that they can show code they are proud of, not just average code or code written under pressure or when they had to do quick fixes.
Re:Twitter engineers told to print out their code by Polygator on Saturday November 05, 2022 @01:29AM (#33478264)
If you read the thread, he appears to have asked for the last 30 to 60 days of code, printed. So not code they're proud of, literally everything. And why printed?
Re:Twitter engineers told to print out their code by ratg13 on Saturday October 29, 2022 @05:04AM (#33382300)
Not a musk fan, but if you purchased any company would you not want to get to know the people that make it work, what they are up to, and what excites them?

Not saying his intentions are noble, but the act of these mettings, in and of themselves, does not signal anything in either direction.

Re:Twitter engineers told to print out their code by kitsune_ on Saturday October 29, 2022 @07:46AM (#33383186)
What you say is of dubious value (or even negative value). I imagine Twitter has code reviews like most other places anyways.

And even if were not of zero value, it's not what they were told to do anyways. Printing out your code of the past 30 days is a demeaning power play to test your loyalty. They could just look at your pull requests or commits themselves.

Re:Twitter engineers told to print out their code by sebastialonso on Saturday October 29, 2022 @08:09AM (#33383344)
What possible value to the company can come from the CEO doing this stunt for coding style? Don't you think there are already company-wide guides for this? It sounds like something that someone from outside the software engineer world would think it's valuable.
Re:Twitter engineers told to print out their code by 8n4vidtmkvmk on Saturday October 29, 2022 @12:26PM (#33385523)
what even coding style. we have so many lints in place that almost all code is homogeneous.