Also personally the ideal situation for me is for someone who is getting paid to fix the issue to go fix it without me having to get my hands dirty.
It's not an exaggeration, but I don't know how it could be better done.
We are entirely free to fork the project, embed the change and compile our own binaries. You don't have to strongarm a change into upstream for that.
Personally, I'm ok with doing the work myself if I didn't pay for the product. It gives me a feeling we're all working together on a better software ecosystem, because Turing knows we need it to be better sometimes.
edit: sorry for moving the goal posts, it's definitely cool that you got MR's into Roslyn, it's an awesome project.
The Contributor License Agreement used on all MSFT open source projects doesn't ask you to transfer your copyright, though it does require submitters to agree to grant a permissive copyright and patent license. IANAL, but the copyright and patent clauses in Microsoft's CLA[0] do not look substantially different from the equivalent clauses in the Apache 2.0 license[1].
[0]: https://opensource.microsoft.com/pdf/microsoft-contribution-...
[1]: https://github.com/rust-lang/rust/blob/master/LICENSE-APACHE...
The purpose of open-source software is to be able to fix problems for your use case and continue using the improved software. OP could have just chosen not to upstream their changes (I'm assuming you'd be okay with that since Microsoft doesn't get their hand on the fix) but then they wouldn't be able to easily update their compiler.
I guess the only real option here is to use a community-developed language with no for-profit company behind it. Then write all the libraries that Microsoft wrote for C# and published for _free_. Hmm.
I wonder what percentage of popular languages / libraries out there have the level of reliability & support that C# and other open-source software with big corps behind them has.
If Microsoft was honest about equality and open source, they would have donated the whole platform to a non-profit foundation and removed its name from it.
.NET isn't your average hobby project - it's used everywhere. It's imperative that changes go through the proper due process here. It takes time to prepare design documents and review them, discuss the changes and different alternatives, review the code, implement the changes and test them properly.
If that's somehow a problem to you, I think your expectations need to be readjusted. This is not the kind of project that should hastily accept code.
All of this about dotnet not accepting PRs is unadulterated "Micro$uck FUD". The other critiques are valid, but not this one, not by a mile, it is complete bullshit.
So there's also not much designing and reviewing needed. The merge requests were assigned to very senior reviewers each time. The automated test suites made sure I didn't waste much of anyone's time with trivial errors. Of course the requirement is that you're actually at least proficient with the languages (C for Ruby and Rust for rustc) but beyond that I think anyone can do it with a couple of sunday afternoons spent diligently digging through the codebase.
And? The vast majority of the .NET ecosystem operates this way, and discounting that because MS still has proprietary closed-source projects is disingenuous.
You want to know what's better than having actual MS developers interact with your issue on GH? Being able to submit a MR yourself and actually have that MR be merged in within days of it being good to go.
That's not just a dream, that's the standard way of operating for most large open source ecosystems. If you solve a known issue with a clear well considered merge request, and you've gone through all the prescribed steps your MR will get merged.
From personal experience I've landed MR's in the Ruby interpreter, in the Rust compiler and in the Rails framework. All as a complete outsider with no prior introductions to the team. Just be polite, follow the rules, solve something that's real with no architectural impact and it'll get merged (just mentioning these because they're ecosystems, I've had MR's merged in for dozens of smaller projects in the same manner).