News for hackers. Stuff that matters.
Re:GitHub incident 2022-03-23 by blueplanet200 on Wednesday March 23, 2022 @11:13AM (#30779291)
I hope they figure out what’s going on every morning. Heard from inside they don’t know why the db dies everyday but restarting it fixes it.
Re:GitHub incident 2022-03-23 by exikyut on Wednesday March 23, 2022 @11:37AM (#30779575)
What's "the db"? It sounds like something of small to medium scale if you can just restart it like that.

In any case, why not just relocate some vendor engineers on site for a bit? Or, better, why does the vendor not have a small presence in the corner?

Sounds like whatever "the db" is it's probably some (objectively) small but very scary thing that's currently on fire and people are trying to figure out how to put it out without crashing the plane and also making too many waves internally, which is probably even harder. So asking about making vendor noises is (as useful as it may be) probably going down the wrong path - in much the same way this is probably not related to the outages (it may well be, but from the outside it's all coincidence anyway).

Re:GitHub incident 2022-03-23 by fundmondawyaya on Wednesday March 23, 2022 @11:19PM (#30786073)
Cock crows. DB crashed.

Systemctl restart

mysqld

(Or mariadb, if you pronounce "SQL" as "sequel")

Re:GitHub incident 2022-03-23 by yebyen on Wednesday March 23, 2022 @07:21PM (#30784815)
Re:GitHub incident 2022-03-23 by shepardrtc on Wednesday March 23, 2022 @12:14PM (#30780008)
IIS Server had/has a memory leak in worker threads that many years ago always forced us to restart the server every few days. Starting in 6.0, they added worker thread recycling and made it a mandatory to choose a time period for every thread to be recycled. Why fix the error when you can just restart the service?
Re:GitHub incident 2022-03-23 by djbusby on Wednesday March 23, 2022 @12:34PM (#30780281)
Apache prefork had that since forever. Seems just a garbage collect type pattern.
Re:GitHub incident 2022-03-23 by mst on Wednesday March 23, 2022 @10:18PM (#30785790)
For old-school mod_perl apps setting MaxRequestsPerChild was often a much better ROI than actually finding and fixing the leaks.

Speaking as somebody who's done over a decade of large scale OO applications perl and is actually really good at finding and fixing the leaks, this has often been intellectually aggravating but every time I've set that option instead I rewarded myself with a glass of bourbon for picking the pragmatic choice and then went back to adding (non-leaky) features that were far more useful to the company in question than cleaning up the older code would've been.

Re:GitHub incident 2022-03-23 by shepardrtc on Wednesday March 23, 2022 @01:30PM (#30781012)
It's not a bug, it's a pattern.

Seriously though, IIS 5.0 had no worker recycling. There was no method to fix the issue. Threads would eat up GB's of memory until you killed them.

Re:GitHub incident 2022-03-23 by whimsicalism on Wednesday March 23, 2022 @12:46PM (#30780435)
I doubt they use IIS
Re:GitHub incident 2022-03-23 by throwra620 on Wednesday March 23, 2022 @01:12PM (#30780772)
MSer here, yes we do… for some things
Re:GitHub incident 2022-03-23 by prepend on Wednesday March 23, 2022 @03:32PM (#30782331)
For GitHub? It seems unbelievable that they would use IIS pre-purchase and why in the world would you mix in a second web server for post-purchase enhancements.
Re:GitHub incident 2022-03-23 by Yuioup on Saturday March 26, 2022 @01:13PM (#30813531)
Why trade an open source solution with third rate garbage that is called IIS which runs on a sub-par desktop OS called Windows. I thought that Github was supposed to be independant.
Re:GitHub incident 2022-03-23 by whimsicalism on Wednesday March 23, 2022 @04:46PM (#30783125)
If GH is around the same level of integration with Microsoft as my employer, which is another Microsoft acquisition, I don't really believe you have a ton of insight into GH processes.
Re:GitHub incident 2022-03-23 by edgyquant on Wednesday March 23, 2022 @05:40PM (#30783809)
I dated a girl at GitHub for awhile last year who said they weren’t even completely off of AWS yet and she liked how they didn’t seem like working for Microsoft. Maybe this has changed though.
Re:GitHub incident 2022-03-23 by cube00 on Wednesday March 23, 2022 @11:26AM (#30779439)
Break out the early morning restart cron job.
Re:GitHub incident 2022-03-23 by gaoshan on Wednesday March 23, 2022 @11:54AM (#30779784)
Here you go, Github:

0 4 * * * /etc/init.d/postgresql restart

I'll take an architect position as compensation, but only if there is equity.

Re:GitHub incident 2022-03-23 by rish on Wednesday March 23, 2022 @12:30PM (#30780216)
GitHub uses MySQL primarily though.
Re:GitHub incident 2022-03-23 by grumple on Wednesday March 23, 2022 @02:41PM (#30781765)
MySQL also has a restart command! I'll take my rsus now ty.
Re:GitHub incident 2022-03-23 by Kostic on Wednesday March 23, 2022 @11:29AM (#30779478)
Early morning in which timezone?
Re:GitHub incident 2022-03-23 by afterburner on Wednesday March 23, 2022 @11:33AM (#30779520)
GaryOldman.gif
Re:GitHub incident 2022-03-23 by glenneroo on Wednesday March 23, 2022 @12:29PM (#30780200)
When the least amount of users are online?
Re:GitHub incident 2022-03-23 by MuffinFlavored on Wednesday March 23, 2022 @07:33PM (#30784911)
How long does restarting it take?
Re:GitHub incident 2022-03-23 by raffraffraff on Wednesday March 23, 2022 @03:10PM (#30782093)
Yuck. Honestly, restarting a database to fix a major outage sounds like "we have no idea what we're doing"
Re:GitHub incident 2022-03-23 by blueplanet200 on Wednesday March 23, 2022 @07:45PM (#30785004)
It sounds like "they don't know why it's going down." I've worked with plenty super competent people that have taken time to root cause incidents.

Guide to incidents: Step 1: Stop the bleeding Step 2: Prevent it in the future

Doing Step 1 doesn't make you incompetent.

Re:GitHub incident 2022-03-23 by raffraffraff on Thursday March 24, 2022 @01:05PM (#30792602)
I'm not a DBA, and maybe you're not a DBA either, so this question goes to DBAs who may be reading: aren't you always better off killing the bad queries instead of rebooting the whole box, if that's an option? (ie: aside from times when the entire host is screwed, load per core is >50, metrics aren't getting out, you can't ssh in etc)
Re:GitHub incident 2022-03-23 by bpicolo on Wednesday March 23, 2022 @04:10PM (#30782724)
Sporadic database performance issues can certainly make you feel that way. They are definitely not trivially debugged at scale
Re:GitHub incident 2022-03-23 by vimda on Wednesday March 23, 2022 @04:57PM (#30783263)
Would you rather it stay down while they spend a day debugging it?
Re:GitHub incident 2022-03-23 by paulryanrogers on Wednesday March 23, 2022 @05:47PM (#30783886)
If that means it won't be down every morning in my time zone then yes.
Re:GitHub incident 2022-03-23 by seanw444 on Wednesday March 23, 2022 @07:31PM (#30784898)
As long as it's announced in advance so that users/customers can plan ahead, I don't see why not.
Re:GitHub incident 2022-03-23 by karmakaze on Wednesday March 23, 2022 @07:04PM (#30784696)
They could use multiple writer hosts and rollover the restarts. MySQL has had GTIDs since 5.6 and replication groups rather than writer-replicas since some 5.7.x version.