Apple's products are demonstrably supported in software far longer than other manufacturers. People rate the physical build quality of their products very high as well.
It seems that people like the benefits and features of Apple hardware enough to overlook the problems with self-repairability.
And regarding the app store, maybe because you're in the industry you think it's a generally big problem, because you're affected. But it's a 1% privilege issue to most of the world.
It seems Apple is doing enough right that its value is climbing.
I have seen that headline every year since 1984. Every single year.
Though with the size and cash reserves, it's more likely they get "doomed" the way Microsoft was in the last 10 years (still is, perhaps).
Remember when TV and radio repair shops were a thing? RadioShack in the US or Tandy in Europe? Kids these days don’t...