News for hackers. Stuff that matters.
Re:Netgpu and the hazards of proprietary kernel modules by microcow on Friday August 14, 2020 @01:05PM (#24160422)
It seems reasonable to reject the patch for technical and legal reasons, but it's pretty disappointing to see toxic comments from prominent kernel developers like:

> "Seriously? If you only even considered this is something reasonable to do you should not be anywhere near Linux kernel development. Just go away!"

https://lwn.net/ml/netdev/[email protected]/ https://lwn.net/ml/netdev/[email protected]/

Re:Netgpu and the hazards of proprietary kernel modules by Corazoor on Friday August 14, 2020 @05:07PM (#24163274)
While I agree that these responses are rude, patches like this are the lkml equivalent of taking a dump in someones backyard... It might very well be that the submitter didn't know that, the documentation on what will be flat out rejected is not very explicit.

But a compile-time dependency on a non-gpl module should be very self-evident, and the documentation explicitly asks people to go and learn about how the GPL works...

Revealing that as Patch 21 of 21 just adds insult to injury. Wasted a lot of peoples time with that one.

The fact that the module in question is from nvidia further shows that the submitter just had no idea of the histoy and culture of the linux developer community. And that is the charitable Interpretation...

The kernel developers have to fend off stuff like that constantly, some are probably pretty jaded by now, which leads to responses like that.

It's normal human nature, most service workers who have to deal with customers have similar problems, and some develop the same kind of behaviour.

If you don't outsource thinking to other people you actually won't get reponses like this.

Re:Netgpu and the hazards of proprietary kernel modules by microcow on Friday August 14, 2020 @08:37PM (#24164892)
No! A flawed patch is not the equivalent of "taking a dump" in someone's yard. Proposing a flawed patch is not a contemptuous act, it's not insulting, and it is not injurious. Treating it as such is the problem.

Telling someone they "should not be anywhere near Linux kernel development" and to "just go away" is degrading and contemptuous.

Re:Netgpu and the hazards of proprietary kernel modules by pritambaral on Saturday August 15, 2020 @04:55PM (#24172325)
I feel like the difference of opinion you and us are having here are ultimately over the difference in perspective here. You label it as merely a "flawed patch". The original comment by the kernel dev that incited this whole debate isn't even directed at the flaw in the patch, so it kinda feels like you're arguing at cross purposes here.
Re:Netgpu and the hazards of proprietary kernel modules by rini17 on Saturday August 15, 2020 @03:54AM (#24166912)
...and right thing to do in these circumstances.
Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Saturday August 15, 2020 @04:40AM (#24167149)
No! Talking or writing about another person like that (in public) is shameful for that Guy and for that Hellwig Clown (the guy who lost against VMware) too. If you say something like that in private..ok, not nice but acceptable but NOT in Public that should be absolute clear for any decent human being.
[dead]
Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Saturday August 15, 2020 @04:46AM (#24167177)
>review these turds

Are you talking about the Kernel-maintainers or the Patches?

Re:Netgpu and the hazards of proprietary kernel modules by q3k on Friday August 14, 2020 @01:44PM (#24160889)
Yeah, this sort of tone on LKML has repeatedly driven me away from trying to upstream my patches. I don't need handholding and hugs, but if I'm going to get unconstructive toxicity like this then I'd rather just keep carrying my local patchset around.
Re:Netgpu and the hazards of proprietary kernel modules by boomboomsubban on Friday August 14, 2020 @03:59PM (#24162545)
I would describe posting your code in 21 patches, the last of which makes it fairly obvious there will be legal issues as "unconstructive toxicity" as well. Particularly when submitting something for a kernel team in a company like Facebook.
Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Friday August 14, 2020 @01:33PM (#24160750)
All in all Linux (the kernel) has a really toxic environment. If you like a more friendly community and still want to work on a Kernel go to Net/Freebsd, Haiku or OmniosCE. With Linux (the kernel) you are not allowed to make mistakes or ask (stupid?) questions.
Re:Netgpu and the hazards of proprietary kernel modules by zokula on Saturday August 15, 2020 @03:45AM (#24166858)
Oh stop the bullshit and hyperbolic hand waving. The Linux kernel community is way more friendly place to work than any of the BSD kernel communities.
Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Saturday August 15, 2020 @03:59AM (#24166933)
Yeah linux, its a lovely place ;)

Just curios...why are you so against BSD's (looking at you comments) is it a Fanboy thing? Are you fighting also so hard witch distribution is the best? :)

Re:Netgpu and the hazards of proprietary kernel modules by non-entity on Friday August 14, 2020 @01:39PM (#24160833)
Can confirm: Haiku, FreedBSD, NetBSD, and DrangonflyBSD kernel communities have been quite friendly and helpful.
Re:Netgpu and the hazards of proprietary kernel modules by zokula on Saturday August 15, 2020 @03:46AM (#24166866)
FreeBSD and NetBSd are quite toxic places.
Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Saturday August 15, 2020 @03:50AM (#24166891)
Proof...because it's bullshit.

EDIT: Ahh looking at you comment's you are a anti-bsd troll, so dont waste time searching for proof.

Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Friday August 14, 2020 @01:52PM (#24160994)
>DrangonflyBSD

I knew i forgot someone THANKS!

Re:Netgpu and the hazards of proprietary kernel modules by qubex on Saturday August 15, 2020 @02:39AM (#24166562)
All half-dozen of us thank you for thinking of us. ;)
Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Saturday August 15, 2020 @03:44AM (#24166851)
Yes yes, in the 90' everyone said that too...but about Linux ;)
Re:Netgpu and the hazards of proprietary kernel modules by kabdib on Friday August 14, 2020 @02:53PM (#24161796)
> "Seriously? If you only even considered this is something reasonable to do > you should not be anywhere near Linux kernel development. Just go away!"

A response like this would get you a serious talkin' to at just about any place I've worked. Possibly fired, if it was consistent behavior.

I don't care if you're Donald Knuth, Dennis Ritchie and Edgar Djikstra all rolled into one, act like a jerk and you're off of my Christmas list.

Re:Netgpu and the hazards of proprietary kernel modules by stefan_ on Friday August 14, 2020 @03:52PM (#24162467)
So what do you get for trying to upstream an entirely useless patchset that exists purely as a GPL workaround to enable the ever-proprietary NVIDIA driver? Do you realize that's spitting into the face of the very people trying to drive open-source software across the entire stack?

Greg KH called this trolling, and he isn't one to mindlessly throw around insults.

Re:Netgpu and the hazards of proprietary kernel modules by microtherion on Saturday August 15, 2020 @03:01PM (#24171347)
Besides, I'm confident that Knuth would never say something like that, and Ritchie was not known for such antics, either, to my knowledge.

Dijkstra would probably have said something like that, though he'd have crafted a pithier way of saying it.

Re:Netgpu and the hazards of proprietary kernel modules by spoopyskelly on Saturday August 15, 2020 @06:45AM (#24167889)
They should put participation awards in the Code of Conduct.
Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Saturday August 15, 2020 @04:44AM (#24167168)
That is on point, Thanks.
Re:Netgpu and the hazards of proprietary kernel modules by beefee on Friday August 14, 2020 @02:16PM (#24161339)
As a user and downstream developer, I'm glad that the Linux maintainers are committed to maintaining a sound architecture.

The idea that they need to be more polite about rejecting low quality work is puzzling to me.

Re:Netgpu and the hazards of proprietary kernel modules by ska on Friday August 14, 2020 @03:43PM (#24162374)
What is puzzling to me is the idea that being rude contributes anything to the cause of maintaining a sound architecture.

As far as I can see, if you have to say "no" doing so politely has no downside, whereas behaving like this clearly has some.

Re:Netgpu and the hazards of proprietary kernel modules by R0b0t1 on Monday August 17, 2020 @12:31PM (#24188805)
Some people don't "get it" unless you at least try to appear rude. It's possible to waste a lot of time by not properly telling people off.
Re:Netgpu and the hazards of proprietary kernel modules by ska on Monday August 17, 2020 @07:14PM (#24193414)
In my experience being clear is always enough here, being rude is not needed.
Re:Netgpu and the hazards of proprietary kernel modules by qubex on Saturday August 15, 2020 @02:44AM (#24166589)
An “impolite no” is not just a ‘no’, and it’s the latter that was required and not the former. He could have ‘recommended’ that the whole patch-set be re-architected to avoid depending on the proprietary module. There was really no need (or any excuse really) for being so coarse.
Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Friday August 14, 2020 @03:01PM (#24161895)
>need to be more polite about rejecting low quality work is puzzling to me.

First, it's not low quality

Second, for sure you have to be polite if you don't pay him (but even when you do, you should)

Third, imagine a 16yo get smashed like that (not that i say he is) and what a devastating and demotivating thing that could be...welcome to the linux world

Overall, those Superstar Linux dev's are mostly ignorant borderline autistic assholes who can't develop a good Filesystem like XFS or ZFS from scratch, then moan about Nvidia, but work on a computer with around ~100 proprietary systems called firmware. One accusing the OpenBSD peoples for being masturbating security Monkeys just to say (4-6 years later) that they where right (a super rare occasion for a linux super star). You know what i like to say? FUCK YOU LINUX, FUCK YOU GNU (but not grep...gnu grep is nice)

Re:Netgpu and the hazards of proprietary kernel modules by rini17 on Saturday August 15, 2020 @03:49AM (#24166884)
You are right, it's not low quality, it's high quality attack on whole culture.

But please come up with real examples, did linux devs ever like "smashed 16yo"?

Also, why don't you set an example and express yourself politely too?

Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Saturday August 15, 2020 @04:13AM (#24167009)
>Also, why don't you set an example and express yourself politely too

Because i can:

https://www.youtube.com/watch?v=caOq2rDe_C0

EDIT: Oh yeah a attack on a culture...what culture? The Fuck you NVIDIA but we send you firmware because otherwise nothing will work? That Culture?

Re:Netgpu and the hazards of proprietary kernel modules by jeffbee on Friday August 14, 2020 @04:55PM (#24163159)
Imagine believing that Linux has a "sound architecture".
Re:Netgpu and the hazards of proprietary kernel modules by nix23 on Saturday August 15, 2020 @04:52AM (#24167211)
Hehe...Cheers buddy.
Re:Netgpu and the hazards of proprietary kernel modules by zokula on Saturday August 15, 2020 @03:50AM (#24166886)
Imagine believing in it's not.
Re:Netgpu and the hazards of proprietary kernel modules by spoopyskelly on Saturday August 15, 2020 @06:57AM (#24167953)
Imagine being a fanboy.
Re:Netgpu and the hazards of proprietary kernel modules by hvis on Sunday August 16, 2020 @06:50AM (#24176763)
There is one subtle fact that kernel contributors (as well as members of other "serious" free software project) have to make a point to avoid knowing the internals of proprietary software, in order to avoid any suspicion of copying the code, design, or willful patent infringement.

As such, submitting a patch that relies on such internals in third-party proprietary code and thus imparts a certain amount of knowledge about those internals to the reader might make the work life of the reviewers more difficult. So it is considered distinctly impolite.

I'm not 100% sure about the exact legal reasons/mechanisms involved, but this has come up previously during the review of Microsoft's DX12 patches for WSL.

Re:Netgpu and the hazards of proprietary kernel modules by deft on Friday August 14, 2020 @02:51PM (#24161781)
How is that comment toxic? The code this guy was trying to get merged in was toxic, and the kernel developer rightly told them to stop trying to push this harmful code.
Re:Netgpu and the hazards of proprietary kernel modules by microcow on Friday August 14, 2020 @03:30PM (#24162252)
It's degrading ("toxic") to tell a contributor they don't belong in kernel development with comments like the above and the follow-up:

"...you really disqualify yourself from kernel work. Please really just go away and stop this crap."

Re:Netgpu and the hazards of proprietary kernel modules by pritambaral on Friday August 14, 2020 @05:31PM (#24163545)
1. They're not a contributor. Not yet, anyway.

2. How degrading do you consider the submission?

As can be seen from the patchset, there's no conceivable way it could be built into the kernel without having the kernel build depend on proprietary headers, effectively disqualifying it entirely. This all-important fact is revealed in the very last patch of a 21-patch patchset, wasting everyone's time, and a lot of it. It's either utter carelessness, stupidity, or outright malice to ask for something like this to be included into a loudly-and-clearly GPL-licensed kernel.

Re:Netgpu and the hazards of proprietary kernel modules by solidasparagus on Friday August 14, 2020 @10:01PM (#24165266)
It's ridiculous that the Linux community thinks it's normal to insult people and tell them to go away and never come back because they are "careless" or "stupid". Reject it (and maybe educate if you're feeling generous) but there's no reason to be a dick.
Re:Netgpu and the hazards of proprietary kernel modules by q3k on Friday August 14, 2020 @06:38PM (#24164130)
> As can be seen from the patchset, there's no conceivable way it could be built into the kernel without having the kernel build depend on proprietary headers, effectively disqualifying it entirely.

Then just disqualify it, cite the reasons for why, and move on. No need for attacks, no need to tell the other person to fuck off. There's enough badness in the patch that you don't need to resort to criticizing the submitter.

Re:Netgpu and the hazards of proprietary kernel modules by pritambaral on Saturday August 15, 2020 @02:37PM (#24171164)
As I have said already, which you seem to be ignoring:

"This all-important fact is revealed in the very last patch of a 21-patch patchset, wasting everyone's time, and a lot of it. It's either utter carelessness, stupidity, or outright malice to ask for something like this to be included into a loudly-and-clearly GPL-licensed kernel.

----

In the end, all I have to say to you is:

If I walk up to you in the street and slap you in the face, unprovoked, surely the noble thing for you to do is to politely tell me off; but I will not hold it against you if you were to lose your cool and retaliate.

Re:Netgpu and the hazards of proprietary kernel modules by q3k on Saturday August 15, 2020 @04:05PM (#24171924)
Neither carelessness, stupidity, or malice (over a patch!) warrants personal attacks. I wouldn't ever compare these to being slapped in the face, unprovoked, on the street.

A code maintainer's job is to curate, coordinate, help, and sometimes (in this case, notably) also gatekeep. If you can't stand the occasional terrible code and have to resort to personal attacks in order to vent off, or to feel better (or because you feel personally insulted) - then that seems to me that you're bad at your job.

If we're going with parallels - seeing this sort of behavior and excuses reminds me of people excusing police abuse. If you can't be cool and deescalate the occasional problem - maybe this job's not for you.

Re:Netgpu and the hazards of proprietary kernel modules by pritambaral on Saturday August 15, 2020 @05:15PM (#24172458)
> Neither carelessness, stupidity, or malice (over a patch!) warrants personal attacks.

1. We both know it wasn't just "a patch". Downplaying what happened doesn't serve the discussion.

2. I do not see "If you only even considered this is something reasonable to do you should not be anywhere near Linux kernel development. Just go away!" as a personal attack, but as an attack against _the behaviour_ that _deliberately_ wastes a lot of one's time. Note the _"if you ... considered this ..."_.

----

> I wouldn't ever compare these to being slapped in the face, unprovoked, on the street.

This is not the comparison I made. I compared the reactions of the offended and your comments on said reactions. Let me try again, in clear terms: I find it understandable when someone doesn't react calmly and politely to having a lot of their time _deliberately_ wasted and their principles attacked.

> ... the occasional terrible code ...

See, again, I think you're severely downplaying what happened. The LKML regularly sees "the occasional terrible code". This is not one of them. Not even close.

> ... this sort of behavior and excuses reminds me of people excusing police abuse.

That is a ridiculous comparison to make. The LKML does not exist to "protect and serve" the public, is not funded by the public, or even remotely responsible for law & order & safety & peace of the public.

It is a private group of like-minded people that happen to be open to public participation. If you go and take a dump on their lawn, don't be surprised at some harsh words thrown back at you.

And definitely don't compare a handful of harsh words that are easily brushed aside for gruesome physical brutality and blatant wilful murder.

> ... the occasional problem ...

Again, you are severely downplaying what happened. What was posted is not an example of "the occasional problem" — there's plenty of those in the lists. What was returned wasn't nearly as toxic.

Re:Netgpu and the hazards of proprietary kernel modules by userbinator on Friday August 14, 2020 @08:09PM (#24164722)
I wonder what Linus would say. "nVidia, fuck you!"? Maybe not this time.
Re:Netgpu and the hazards of proprietary kernel modules by temp43t453 on Saturday August 15, 2020 @03:55AM (#24166914)
ok, what you do when someone modifies the product you're using so you cant continue to use it the way you did before, and you cant fix it or alter it due to legal or community reasons? you move away to different product.

what the people who use/develop kernel would do when they become unable to modify large part of kernel code that is highly needed for their work?

business doesnt work like typical consumer, there is no "products" that they pick from the big market