News for hackers. Stuff that matters.
Re:Ask HN: How to improve code quality while maintaining dec... by fouc on Tuesday December 10, 2019 @02:26AM (#21750418)
You might be over-estimating how much attention people are paying to your speed, especially if you recently joined.

For the first 3-6 months, companies probably care more about having newcomers get up to speed on matching the style & convention of the existing codebase.

It helps to do an architecture review of the codebase and understand the overall code design focus, and pay attention to how the code is typically structured. you could also look at other people's code reviews to see what the common areas of design thinking are.

Re:Ask HN: How to improve code quality while maintaining dec... by mavsman on Tuesday December 10, 2019 @09:33AM (#21752748)
Glad to see that most people agree with you. I've had a recent experience where I assumed this would be the case but it turns out I was underestimating how much attention my manager was paying to my speed, even just a couple months after being on the team.

In either case, make sure you understand what is expected of you so you can be on the same page as those whose expectations matter (often a manager and your teammates).

Re:Ask HN: How to improve code quality while maintaining dec... by commandlinefan on Tuesday December 10, 2019 @01:26PM (#21755241)
> I was underestimating how much attention my manager was paying to my speed

If "velocity" is a buzzword that comes up in natural conversation, there's a pretty good chance that's the _only_ thing they're paying attention to. If you're put in the position of managing software developers, but don't know anything about software development, all you can pay attention to is how much time they're spending on "tickets".

Re:Ask HN: How to improve code quality while maintaining dec... by nickserv on Tuesday December 10, 2019 @02:58AM (#21750560)
This has been my experience as well, viewed from both sides.

Additionally, sometimes code reviews for newcomers is more involved because we want to see how the person reasons about the problem. It's also helpful to get astonishment reports from newcomers during code reviews.

Re:Ask HN: How to improve code quality while maintaining dec... by benignslime on Tuesday December 10, 2019 @08:51AM (#21752380)
One thing I always beg for at the beginning of a tenure is for scathing code reviews. Tell me everything your heart desires, if you have the time. The more we get of the way early, the less we need to worry when our minds are in sync.
Re:Ask HN: How to improve code quality while maintaining dec... by ykevinator on Tuesday December 10, 2019 @06:56AM (#21751642)
I second this. If I had to rank in order of preference it's good and fast then good then fast. Don't assume speed is an issue unless you're being told so. Focus on good, speed will follow once you learn. It's a practicable skill.
Re:Ask HN: How to improve code quality while maintaining dec... by OliverJones on Tuesday December 10, 2019 @08:27AM (#21752206)
Agreed. It takes time to come up to speed on a new codebase and with new co-workers. Be patient.