News for hackers. Stuff that matters.
Re:What’s New in Python 3.8 by drdaeman on Monday October 14, 2019 @08:11PM (#21254277)
Coming from Perl, I used to want this badly, but then I thought that there's absolutely nothing wrong with

    m = re.match(...)
    if m is not None:
        pass
Now, I wonder what you meant saying that single-line version is less error-prone, because I don't think so. I believe they're exactly the same in this regard, except for a bizarre case when someone would bastardize the code by putting some irrelevant lines between the assignment and the comparison, obfuscating the logic.

Also, as I tend to use `if m is not None:` rather than just `if m:` (because I typically don't want to run all that subtle `__nonzero__` magic), it would - subjectively - look less pretty in the one-line version: `if (m := re.match(...)) is not None:`.

Use in the generator expressions to create aliases/shortcuts and avoid repetition is great, though. I love this use case.

Re:What’s New in Python 3.8 by 3PS on Monday October 14, 2019 @08:31PM (#21254396)
The issue, in my opinion, is when you want something like this:

    while m := f(many, args):
        # do stuff with m
Now, if you're writing this in Python 3.7, you often end up with some code duplication:

    m = f(many, args)
    while m:
        # do stuff with m
        m = f(many, args) # duplicate
Or something like this:

    while True:
        m = f(many, args)
        if not m:
            break
        # do stuff with m
Personally, I consider the last version to be the most elegant, but still something of an anti-pattern. So I welcome this new operator.
Re:What’s New in Python 3.8 by hermitdev on Monday October 14, 2019 @09:41PM (#21254814)
I literally wrote your last example twice last week to hash files in 4k chunks. Those 4 lines would be reduced to 1 with the walrus operator. I welcome it, as well.

Edit: 1 line, not 2 (excluding the "do stuff")

Re:What’s New in Python 3.8 by cellularmitosis on Tuesday October 15, 2019 @12:07PM (#21260013)
This comes up in recursive descent implementations as well https://gist.github.com/cellularmitosis/53913ad229bad5d0a3bb...
Re:What’s New in Python 3.8 by ygrechuk on Monday October 14, 2019 @10:22PM (#21255033)
Why not something like this:

  def f_iter(many, args):
      while True:
          m = f(many, args)
          if m:
              yield m
          else:
              raise StopIteration
  ...
  for m in f_iter(many, args):
      # do stuff with m
This way you’re isolating all the initialization logic, error handling, etc. And you can focus on your domain logic in your client code.
Re:What’s New in Python 3.8 by bvrmn on Tuesday October 15, 2019 @10:54AM (#21259059)
Python has built-in facilities for that, there is no need to write wrapper by yourself.

   from functools import partial
   with open('mydata.db', 'rb') as f:
       for block in iter(partial(f.read, 64), b''):
           process_block(block)
Re:What’s New in Python 3.8 by ciupicri on Tuesday October 15, 2019 @10:03AM (#21258420)
Instead of raising StopIteration you could also just return from the function. You could also make it a bit shorter if you swap the if branches.

  def f_iter(many, args):
      while True:
          m = f(many, args)
          if not m:
              return
          yield m
Re:What’s New in Python 3.8 by zb on Tuesday October 15, 2019 @10:12AM (#21258523)
Instead of raising StopIteration you have to return from the function, otherwise you'll just get a RuntimeError starting with Python 3.7.
Re:What’s New in Python 3.8 by ciupicri on Tuesday October 15, 2019 @11:20AM (#21259375)
You're right. The [changelog] for Python 3.7 states:

> [bpo-32670]: Enforce [PEP 479] for all code. This means that manually raising a StopIteration exception from a generator is prohibited for all code, regardless of whether ‘from __future__ import generator_stop’ was used or not.

[changelog]: https://docs.python.org/3.7/whatsnew/changelog.html#id115

[bpo-32670]: https://bugs.python.org/issue32670

[PEP 479]: https://www.python.org/dev/peps/pep-0479/

Re:What’s New in Python 3.8 by repsilat on Monday October 14, 2019 @10:37PM (#21255107)
And less reasonably, something similar for regular expressions:

    for m in filter([re.match(...)], bool):
        ...
;-)
Re:What’s New in Python 3.8 by mlevental on Tuesday October 15, 2019 @12:03AM (#21255459)
so i should write a whole other function that iterates over a list instead of being happy that := exists?
Re:What’s New in Python 3.8 by throwaway744678 on Tuesday October 15, 2019 @03:47AM (#21256368)
Yes! No pain, no gain!
Re:What’s New in Python 3.8 by pyrale on Tuesday October 15, 2019 @03:51AM (#21256383)
The last version clearly exposes that you have an infinite loop. This is something hidden by the `while(evaluate)` expression.

Also if it comes to pure form I would have preferred `while (evaluate) as x:` out of establishing a parallel with existing syntax, but that's not very important.

Re:What’s New in Python 3.8 by pdpi on Tuesday October 15, 2019 @04:34AM (#21256590)
On the contrary: the loop isn’t fundamentally infinite, it’s just an artefact of the language that you have to write it that way. The walrus lets you put the termination where it belongs.
Re:What’s New in Python 3.8 by pyrale on Tuesday October 15, 2019 @07:44AM (#21257489)
I don't understand that the walrus has any significance with regards to the `while` loop termination. it's the nature of the evaluated expression that makes a difference, more precisely, whether it will return something that is cast to False.

In that sense, while loops over expressions always require knowledge of the expression to understand the semantic. On the other hand, something like:

    while True:
       with x as y:
           print(y)
would not require understanding of x to understand the intent. Therefore it is not semantically equivalent to:

    while x as y:
        print(y)
Note that in both cases, `:=` is strictly equivalent to `as` as it is defined for `with`. That is a matter of personal preference.
Re:What’s New in Python 3.8 by xapata on Tuesday October 15, 2019 @01:43AM (#21255840)
That last one isn't an anti-pattern. That's the pattern concluded best for do-while in the discussion of PEP-315.

https://www.python.org/dev/peps/pep-0315/#notice

Re:What’s New in Python 3.8 by eesmith on Tuesday October 15, 2019 @06:22AM (#21257119)
Think about if you match multiple patterns:

    for line in f:
      if (m:= pat1.search(line)) is not None:
        ... do stuff ..
      elif (m:= pat2.search(line)) is not None:
        ... do other stuff ..
      elif (m:= pat3.search(line)) is not None:
         ... do something else ..
In older Python that's:

    for line in f:
      m = pat1.search(line)
      if m is not None:
        ... do stuff ..
      else:
        m = pat2.search(line)
        if m is not None:
          ... do other stuff ..
        else:
           m = pat3.search(line)
           if m is not None:
             ... do something else ..
I think the newer makes it clear that it's supposed to be a simple elif chain, where all branches following the same structure.

There are other ways to structure it, but the alternatives I can think of also have their own cumbersome complexities.

Re:What’s New in Python 3.8 by drdaeman on Wednesday October 16, 2019 @12:33AM (#21267061)
If actions are different, I tend to put them in functions (independent testable pieces, yay!) and iterate over a mapping:

    LINE_ACTIONS = (
        (re.compile("pattern 1"), do_stuff),
        (re.compile("pattern 2"), do_other_stuff),
        (re.compile("pattern 3"), do_something_else),
    )
    ...
    for pattern, action in LINE_ACTIONS:
        m = pattern.search(line)
        if m is not None:
            action(m)
            break
Or even use a method registry pattern that would auto-populate LINE_ACTIONS by just declaring the fuctions:

    @action("pattern 1")
    def do_stuff(m):
       ...
Alternatively, I might just break the processing into a function:

    def _process(line):
        m = pat1.search(line)
        if m is not None:
            ... do stuff ...
            return

        m = pat2.search(line)
        if m is not None:
            ... do stuff ...
            return

        m = pat3.search(line)
        if m is not None:
            ... do stuff ...
            return

    _process(line)
Of course, this depends on the purpose. Could be completely inadequate in some situations.
Re:What’s New in Python 3.8 by eesmith on Wednesday October 16, 2019 @05:50AM (#21268664)
Indeed, I've also used this pattern.

I've found that I don't like using it. As you write, it's "inadequate in some situations", which I consider as part of the cumbersome complexities I mentioned.

For examples, do_stuff() and do_other_stuff() may need to share variables, and do_something_else() might need the line number to report an error while the others don't.

This can be handled with shared state/nonlocal, and by passing in more parameters to the generic handler API, but these add complexity.

Or, different parts of the file may have different line dispatch processing (eg, a header block followed by a data block followed by a footer block) where one of the handlers must indicate the transition to a different processor.

Also, function dispatch in CPython is slow. While the regex tests are also slow, it can also be important to consider the (using a hypothetical number) 5% overhead for dispatching over inline code.

Re:What’s New in Python 3.8 by kstrauser on Tuesday October 15, 2019 @12:22PM (#21260223)
That's... lovely. I propose making this the standard example of why you might want to use the walrus operator.
Re:What’s New in Python 3.8 by Alex3917 on Monday October 14, 2019 @11:46PM (#21255377)
If you only have one or two regex like that then there is no difference in readability. If you have ten in a row though then suddenly your function no longer fits on the screen and it’s more difficult to understand what’s going on.
Re:What’s New in Python 3.8 by bandrami on Tuesday October 15, 2019 @02:26AM (#21256014)
I mean, what you really want in this case is Perl's =~ operator, as well as the implicit $_ variable.