News for hackers. Stuff that matters.
Re:GitLab 11.1 released with security dashboards and enhance... by aw3c2 on Sunday July 22, 2018 @12:38PM (#17587584)
A month of nothing but performance tweaks and bugfixes would be great though.
Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @03:18PM (#17588352)
We have to balance shipping new features https://about.gitlab.com/handbook/ceo/#how-do-we-keep-shippi... with performance tweaks and bugfixes.

If we would not have shipped new features and still did just just version control GitLab the company would not be viable. We're committed to shipping a single application for the whole DevOps lifecycle this year https://about.gitlab.com/2017/10/11/from-dev-to-devops/

But there are multiple performance tweaks en bugfixes going out every month, including this one.

The big performance tweak in this release is the merge request view refactor https://about.gitlab.com/2018/07/22/gitlab-11-1-released/#me... which makes loading merge requests much faster but there are 35 other performance improvements https://gitlab.com/groups/gitlab-org/-/merge_requests?scope=...

There were 141 bugs closed in this release https://gitlab.com/groups/gitlab-org/-/issues?scope=all&utf8...

Re:GitLab 11.1 released with security dashboards and enhance... by heroprotagonist on Sunday July 22, 2018 @09:15PM (#17589827)
Well, there's definitely a difference between periodically slowing down the new features for a month of additional focus on stability/performance improvements and 'just doing version control forever'.

Keep your fingers on the pulse of your customers. If the top comments in posts about your releases say "I wish they'd focus on quality more" even in a place where 'move fast and break things' is considered sage advice, then think of this as an indicator. If the performance improvements that have been going out every month are sufficient, the discussion would not focus on them as much.

Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @09:34PM (#17589911)
I hope you see that I actively engage with our users and customers. We want to get the balance right. I think currently GitLab.com should be much more reliable and the RAM usage with should be lower. I'm happy with the improvements we are making in UX, polish, navigation, and loading times. They should all improve from today but we're making the right amount of progress.

Maybe a bit off-topic but some of our reliability improvements like Gitaly cause GitLab to use more memory. So improving non-functional requirements is not a single dimension.

Re:GitLab 11.1 released with security dashboards and enhance... by yAnonymous on Monday July 23, 2018 @04:08AM (#17591263)
Yes, do everything this anonymous person says, because their post has 3 upvotes.

Seriously though, listening to everything the community says is a certain recipe for failure. User feedback is an indicator, not more. Implementation details and the general direction of the software have to be based on sane decisions by the development team, not the community.

Re:GitLab 11.1 released with security dashboards and enhance... by mbesto on Sunday July 22, 2018 @09:18PM (#17589835)
Please take my comment as playing devil's advocate, and not a negative "what do you think you're doing" question.

> If we would not have shipped new features and still did just just version control GitLab the company would not be viable.

Says who? I can name hundreds of enterprise software companies that don't ship new features on a regular basis and are still commercially very viable. In other words, what evidence do you have that if you spent 3 months just shipping performance improvements that it would slow your growth?

Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @09:27PM (#17589879)
Thanks for asking. If you get back on the same pace after 3 months it would be acceptable. However I think this unlikely. From the linked page https://about.gitlab.com/handbook/ceo/#how-do-we-keep-shippi... "Don't ever slow down because it is very hard to recover from that. As soon as you stop shipping (for a big refactor, a security initiative, etc.) it is very hard to get back op to the old speed. The organization has accepted a slower rate and there are always enough reasons to go slower. You have to do the refactors and other things during the course of business, never slow down."
Re:GitLab 11.1 released with security dashboards and enhance... by boundlessdreamz on Monday July 23, 2018 @12:11AM (#17590521)
I think this is probably wrong. You need customers to love the product. Polish matters. Which is why github/slack is still used and loved more than bitbucket/hipchat.

Velocity for sake of velocity is not going to result in customer delight

Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Monday July 23, 2018 @12:57AM (#17590681)
I agree polish (user experience) is very important in winning people over. We think the worst user experience is between product categories in the DevOps lifecycle. Having to switch between JIRA, GitHub, circleCI, Artifactory, Ansible, and New Relic. We want to create a better flow. Therefore we have to balance polishing what we have with completing out vision of a single application for the DevOps lifecycle.
Re:GitLab 11.1 released with security dashboards and enhance... by apple4ever on Monday July 23, 2018 @02:09PM (#17594561)
I'd love to use GitLab Issues over JIRA, but Issues is just so feature poor. I don't even need a complex bug tracker, but Issues doesn't solve any problem I can see, except very simple lists.
Re:GitLab 11.1 released with security dashboards and enhance... by aw3c2 on Sunday July 22, 2018 @04:36PM (#17588794)
Thank you for this nice reply (and all the great work of course)!
Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @04:41PM (#17588820)
You're welcome! :) Thanks for caring about GitLab. New features vs. bugfixes is a hard balance and feedback helps us to find it.
Re:GitLab 11.1 released with security dashboards and enhance... by mcny on Sunday July 22, 2018 @08:08PM (#17589591)
Congrats on shipping!

Sometimes new features appear straightforward but the implementation details can be complicated. For example,

https://gitlab.com/gitlab-org/gitlab-ce/issues/18157

Just off the top of my head: How do you feel about CI/CD for gitlab? I mean in the sense of a publicly available unstable.gitlab.com where we warn users that everything will can get deleted at any time without notice? Maybe it is already possible?

Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @08:17PM (#17589620)
We are working on doing incremental rollout of new features on GitLab.com and on having an artificial load on our staging site.

There is a cookie setting you can use to get some features early on GitLab.com but I can't find a link right now.

We also test new features on dev.gitlab.org that runs a nightly build and is used by some of our team members.

Re:GitLab 11.1 released with security dashboards and enhance... by suprememoocow on Monday July 23, 2018 @04:57AM (#17591439)
> There is a cookie setting you can use to get some features early on GitLab.com but I can't find a link right now.

Andrew from the Infrastructure team at GitLab here: non-team members are welcome to use our canary service, provided they understand that service may at times we downgraded (they can always switch back to production when this happens).

Details of how to toggle the canary environment can be found in our handbook: https://about.gitlab.com/handbook/engineering/#canary-testin...

Re:GitLab 11.1 released with security dashboards and enhance... by mrmondo on Monday July 23, 2018 @02:49AM (#17590973)
Shout out to you Sid for remaining so engaged in the community in a constructive, science backed and transparent manor as the company has grown.
Re:GitLab 11.1 released with security dashboards and enhance... by ComputerGuru on Sunday July 22, 2018 @09:41PM (#17589936)
Are you not accruing technical debt to ship these features, then? That’s not sustainable.
Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @09:45PM (#17589951)
We are not accruing technical debt to ship these features. Quite the opposite, because we ship the minimum viable change we keep things as simple as possible, preventing un-needed complexity that can slow us down later.
Re:GitLab 11.1 released with security dashboards and enhance... by ComputerGuru on Sunday July 22, 2018 @10:02PM (#17590045)
I mean by putting off refactoring and bug fixes that are being constantly eschewed in favor of adding features.
Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @10:41PM (#17590215)
We care a lot about having an optimal level of technical debt and write about this on our blog and in our handbook https://www.dropbox.com/s/kdctzn1ha8z666l/Screenshot%202018-...

I like the perspective I recently read here that you should avoid the debt with a high interest rate. If you got a fundamental concept wrong and that mistake spreads throughout your codebase that is much worse than an isolated piece of code that could be better.

Re:GitLab 11.1 released with security dashboards and enhance... by DanielDent on Sunday July 22, 2018 @06:42PM (#17589295)
It really really would.

And it's a very good thing that their product allows you to self-host, because I have zero-confidence in their ability to properly operate infrastructure.

But the attention to detail/quality on the product itself is lacking too. Don't get me wrong, I love gitlab as a product, but they really don't seem to care about working on anything that doesn't let them check another box on a marketing feature sheet.

A selection of some issue I've filed...

Only took around a year to fix: https://gitlab.com/gitlab-org/gitlab-ce/issues/25388

Then this issue lingered for about a year before being closed because a customer filed a similar issue a couple months after I did... that other issue is still open though, so maybe they'll get around to it eventually: https://gitlab.com/gitlab-org/gitlab-ce/issues/25535

Here's one from two years ago that's still open: https://gitlab.com/gitlab-org/gitlab-ce/issues/19846

It's possible that issue is actually fixed now. I don't know and I don't care anymore.

Here another issue from 2 years ago: https://gitlab.com/gitlab-org/gitlab-ce/issues/19656

I filed that issue after a Gitlab person here on hacker news specifically invited feedback on UX/UI issues, and I had just spent a frustrating time trying to track down a runner.

At some point I just stopped filing issues & started ignoring the issues I'd already filed. The times they decided to close issues because they'd been open a long time certainly didn't inspire me to waste any more time trying to help them improve the product.

Closing & re-opening and re-tagging and doing everything but actually fixing the issue is not confidence inspiring.

Gitlab is still a great product, but now when I run into things that might warrant opening an issue, I just find ways of dealing with them on my own.

Re:GitLab 11.1 released with security dashboards and enhance... by apple4ever on Monday July 23, 2018 @02:12PM (#17594587)
Ugh I hear you. I have been following this issue for nearly a year: https://gitlab.com/gitlab-org/gitlab-ce/issues/39056

I cannot believe its not fixed it. They made the MR file view completely useless for us. It was a new "feature" that actually made things worse.

Re:GitLab 11.1 released with security dashboards and enhance... by jramsay on Monday July 23, 2018 @05:57PM (#17596363)
James (Product Manager at GitLab) here. I've just picked up merge requests and have seen lots of feedback across multiple issues related to navigating between diffs/files when reviewing a merge request, and I want to make it better too.

There have been a few different solutions proposed including adding a file tree to the merge request interface, so you can quickly see a full list of the files and how they relate to each other. There is a design discovery issue for adding a file tree to the merge request interface https://gitlab.com/gitlab-org/gitlab-ce/issues/49189 scheduled for the next release to work out the UX in more detail.

Would a file tree make reviewing a merge request easier for you? Thanks for the feedback, and would love to hear more here, or on the issue.

Re:GitLab 11.1 released with security dashboards and enhance... by detaro on Monday July 23, 2018 @02:18PM (#17594627)
Also sad to see how reports about regressions appear to turn into "feature requests", that then are nice to have instead of important.
Re:GitLab 11.1 released with security dashboards and enhance... by jramsay on Monday July 23, 2018 @10:24AM (#17592965)
Thanks Daniel. I'm a Product Manger at GitLab. The relative submodule fix is scheduled as a Deliverable for 11.3 https://gitlab.com/gitlab-org/gitlab-ce/issues/25535 – sorry it's taken so long.

Normally new duplicate issues are consolidated into the oldest issue, but since both issues had been open a while ago I kept the issue that had the most participants and discussion open.

Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @07:36PM (#17589476)
I wanted to give some context issue by issue.

1. We consider stopping an environment https://gitlab.com/gitlab-org/gitlab-ce/issues/25388 a new feature, not a bug.

2. Relative submodule links are planned for 11.3 https://gitlab.com/gitlab-org/gitlab-ce/issues/37356

3. Not showing a retry option to logged out users https://gitlab.com/gitlab-org/gitlab-ce/issues/19846 is a good improvement but since very few logged out users will see this message we don't consider it a bug.

4. Showing the original project next to the runner IDs makes a lot of sense. As you can see in the issue we are no longer closing feature proposals due to inactivity.

If you find ways of dealing with above things on your own that involve modifying GitLab please consider contributing them back.

Re:GitLab 11.1 released with security dashboards and enhance... by DanielDent on Sunday July 22, 2018 @08:01PM (#17589563)
Your response only furthers my point: if it doesn't show up on a marketing feature sheet, Gitlab doesn't seem to care to devote any resources to it.

Adding new features is great, but making sure that the user experience around existing features is smooth/sensible/not frustrating is pretty important too.

The approach of shipping 80% solutions which take 20% of the effort probably got Gitlab to where it is today. But at some point the company is large enough and has enough resources that it's reasonable to expect that the difficult parts of the problem and the "polish" get addressed too.

Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @08:42PM (#17589701)
We care about making sure GitLab is polished end to end. We hired a UX team and now have two UX researchers on staff to find the biggest problems and fix them. An example of the outcome of that research is the SSH key experience https://gitlab.com/gitlab-org/ux-research/issues/53 of which the improvements shipped in this release.

We balance new major features, performance improvements and bug fixes https://news.ycombinator.com/item?id=17588352 and polish.

The vision of GitLab of a single application for the whole DevOps lifecycle is large and even though we have 160 engineers (including support) we can't do it all.

So if there are people who are proficient in Ruby we would love for them to submit improvements and join the 2000 people who already contributed code to GitLab.

Re:GitLab 11.1 released with security dashboards and enhance... by matejlatin on Monday July 23, 2018 @05:22AM (#17591531)
Hey, Matej here, I'm part of the UX team at GitLab. I understand that it can look like we don't spend much time polishing the user interfaces and experiences that much but I can assure that we do. We don't have a split in % on how much time we should spend polishing existing things but maybe it's something we should consider doing.

Just to give an example of a recent redesign of an existing feature that I was involved in, it can be found here: https://gitlab.com/gitlab-org/gitlab-ee/issues/6089

Our application covers the whole DevOps lifecycle which means it takes a lot of effort to upkeep existing and constantly ship new features, but we always strive to do our best.

Thanks for the feedback, I think it will trigger internal discussions on how much time we should spend polishing existing features and experiences.

Re:GitLab 11.1 released with security dashboards and enhance... by detaro on Wednesday July 25, 2018 @06:42PM (#17613585)
Re "polishing", part of that might be treating complaints about experience getting worse differently than requests for improvements. E.g. from a different subthread here: https://gitlab.com/gitlab-org/gitlab-ce/issues/39056 The report clearly is "this has been broken", but nothing in the issue suggests it being noticed as a regression and not just another potential for improvement, whereas the customer will remember "this worked, and they broke it".
Re:GitLab 11.1 released with security dashboards and enhance... by ggregoire on Sunday July 22, 2018 @01:43PM (#17587867)
They introduced "squash" and "modify commit message" on the last release. It worked 1 time on the 4 times I tried.
Re:GitLab 11.1 released with security dashboards and enhance... by victorwu on Sunday July 22, 2018 @02:01PM (#17587942)
If you could log a bug here with any details that would be great! https://gitlab.com/gitlab-org/gitlab-ce

Thanks!

Edit: I wanted to clarify that if you’ve observed any undesirable behavior, we welcome you to log it and we will address it as soon as we can. I see how my original comment made it seem like we ship untested code. That’s not the case as Sid mentioned below. That being said, there might be specific edge cases or scenarios we have not captured in our tests. So problems do appear from time to time. So I wanted to invite anybody to log any problem so that we can reproduce it as soon as we can and get it fixed.

Also as Sid mentioned, this feature was recently brought to Core so that more users now have access to it.

Re:GitLab 11.1 released with security dashboards and enhance... by hitekker on Sunday July 22, 2018 @02:49PM (#17588168)
Please stop using your customers as your Quality Control.

I get Gitlab is going for "breadth over depth", but your company must ensure the features being promoted actually work.

Shipping untested code does not build confidence.

Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @03:03PM (#17588259)
We're not using our customers as quality control.

Changes can be minimal but they have to meet our definition of done https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBU... that includes tests.

I assume the relevant product manager (Victor) hasn't heard this complain before but that doesn't show from his answer.

This feature was open sourced in 11.0 https://about.gitlab.com/2018/06/22/gitlab-11-0-released/#sq... after many people requested it https://gitlab.com/gitlab-org/gitlab-ce/issues/34591 but the code has been in use by users since GitLab 8.17 (Feb 22, 2017) https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1024 so I think that is why Victor assumed this was a user specific problem.

Re:GitLab 11.1 released with security dashboards and enhance... by victorwu on Sunday July 22, 2018 @03:48PM (#17588553)
hitekker: See my edited comment above. We do not ship untested code. But any problems that users do find we definitely want them captured as soon as possible so that we can triage and fix.
Re:GitLab 11.1 released with security dashboards and enhance... by apple4ever on Monday July 23, 2018 @02:17PM (#17594624)
Fixing merge conflicts is completely broken for me ever since they introduced it.
Re:GitLab 11.1 released with security dashboards and enhance... by Promarged on Sunday July 22, 2018 @04:24PM (#17588742)
Or cleaning up their work-in-progress, currently there are around 11307 issues open: https://gitlab.com/gitlab-org/gitlab-ce/issues
Re:GitLab 11.1 released with security dashboards and enhance... by sytse on Sunday July 22, 2018 @04:27PM (#17588761)
Among other things we use the issue tracker for feature proposals. So it is not a good proxy of work in progress.