News for hackers. Stuff that matters.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by ajross on Sunday April 01, 2018 @08:37AM (#16727942)
This is the Cloudflare resolver, right? What's the "privacy-first" part about? It's just another third party DNS host. They haven't changed the protocol to be uninspectable and AFAIK haven't made any guarantees about logging or whatnot that would enhance privacy vs. using whatever you are now. This just means you're trusting Cloudflare instead of Comcast or Google or whoever.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by tialaramex on Sunday April 01, 2018 @08:41AM (#16727975)
"We will never log your IP address (the way other companies identify you). And we’re not just saying that. We’ve retained KPMG to audit our systems annually to ensure that we're doing what we say."

Now, audits are generally not worth very much (even, perhaps even especially, from a Big Four group like KPMG), but for this type of thing (verifying that a company isn't doing something they promised they would not do) they're about the best we have.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by aquis on Sunday April 01, 2018 @11:24AM (#16728729)
Worth noting they have already edited the article (less than 2hours later) and taken out the "We will never log your IP" bit...

"We committed to never writing the querying IP addresses to disk and wiping all logs within 24 hours."

"While we need some logging to prevent abuse and debug issues, we couldn't imagine any situation where we'd need that information longer than 24 hours. And we wanted to put our money where our mouth was, so we committed to retaining KPMG, the well-respected auditing firm, to audit our code and practices annually and publish a public report confirming we're doing what we said we would."

Re:1.1.1.1: Fast, privacy-first consumer DNS service by iwalsh on Sunday April 01, 2018 @03:56PM (#16730094)
Not sure if they edited anything. Your quote is from the blog post[1] but the aforementioned quote by tialaramex is from the 1.1.1.1 site itself[2].

[1] https://blog.cloudflare.com/announcing-1111/ [2] https://1.1.1.1

Re:1.1.1.1: Fast, privacy-first consumer DNS service by forapurpose on Sunday April 01, 2018 @03:00PM (#16729840)
> Worth noting they have already edited the article (less than 2hours later) and taken out the "We will never log your IP" bit...

> "We committed to never writing the querying IP addresses to disk ..."

A DNS resolver does need to record the querying IP for at least a few moments because, you know, they have to respond to your query.

However, I don't know why they changed that sentence; it could be for other reasons too.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by staticassertion on Sunday April 01, 2018 @03:30PM (#16729982)
Seems like they're just trying to be clear.

It's not uncommon to retain logs like that for debugging purposes, abuse prevention purposes, etc, but then to go back later and wipe them or anonymize them.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by bogomipz on Sunday April 01, 2018 @09:51AM (#16728245)
>"Now, audits are generally not worth very much (even, perhaps even especially, from a Big Four group like KPMG)"

Indeed, see the recent KPMG scandal:

https://www.marketwatch.com/story/kpmg-indictment-suggests-m...

Re:1.1.1.1: Fast, privacy-first consumer DNS service by anonnyj on Sunday April 01, 2018 @10:18AM (#16728397)
Seems we need an auditor auditor.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by ritinkar on Sunday April 01, 2018 @11:21AM (#16728712)
Quis custodiet ipsos custodes?
Re:1.1.1.1: Fast, privacy-first consumer DNS service by auxym on Sunday April 01, 2018 @11:56AM (#16728905)
They were also implicated in tax evasion schemes in Canada.

http://www.cbc.ca/news/business/canada-revenue-kpmg-secret-a...

Re:1.1.1.1: Fast, privacy-first consumer DNS service by runningmike on Sunday April 01, 2018 @09:26AM (#16728151)
Where is the technical audit report published? Open access url please.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by bostik on Sunday April 01, 2018 @12:57PM (#16729235)
Having dealt with KPMG recently (which I do at least once a year...), I would not expect to see the report.

KPMG's risk department - the lawyers' lawyers - appears to be violently allergic to their customers disclosing any report to outside parties. Based on my experience you can get a copy, but first you and the primary customer need to submit some paperwork. And among the conditions you need to agree with is that you don't redistribute the report or its contents.

Disclosure: I deal with security audits and technical aspects of compliance.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by jlgaddis on Sunday April 01, 2018 @03:34PM (#16730000)
> KPMG's risk department - the lawyers' lawyers - appears to be violently allergic to their customers disclosing any report to outside parties.

Isn't that the entire point of such an audit? To be able to present it to outside third-parties?

For examples, Mozilla (CA/B) requires audits for root CAs. The CA must provide a link to the audit on the auditor's public web site -- forwarding a copy or hosting it on their own isn't sufficient.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by tialaramex on Sunday April 01, 2018 @05:42PM (#16730626)
You'd think, but it's surprisingly difficult to get the real full audit report. Mozilla's root policy _does_ require that they be shown the report, and has a bunch of extra requirements in there to ensure they're more detail, rather than some summary or overview document the auditors were persuaded to produce for this purpose. But the CA/B rules would allow just an audit letter which basically almost always says "Yes, we did an audit, and everything is fine" unless the auditors weren't comfortable writing "everything is fine". And almost always they feel that a footnote on a sub-paragraph buried in a detailed report is enough to leave "everything is fine" as the headline in the letter...

If you've ever been audited for some other reason, you'll know they find lots of things, and then you fix them, and that's "fine". But well, is it fine? Or, should we acknowledge that they found lots of things and what those things were, even if you subsequently fixed them? The CA/B says you have several months to hand over your letter after the audit period. Guess what those months are spent doing...

Re:1.1.1.1: Fast, privacy-first consumer DNS service by dx034 on Tuesday April 03, 2018 @03:03AM (#16742460)
Auditors will confirm the result of the audit but usually not disclose the content of the audit report.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by Bromskloss on Sunday April 01, 2018 @11:39AM (#16728817)
Does KPMG employ technology people? I thought they did only financial audits.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by tialaramex on Sunday April 01, 2018 @12:08PM (#16728980)
First of all, KPMG is the name of a group. All the Big Four are arranged as group companies, a single financial entity owns the name (e.g "KPMG", "EY") from some friendly place, (London in all but one case) and licenses out the right to operate a member company to professional services companies in various jurisdictions around the world. The group has the famous name, and sets some rules about training and compliance, but the employees will (almost all) work for the local member companies even though reporting for lay people will say the group name, as they do here.

Secondly, the idea in audit is not really about digging into the engineering. So although they will need people who have some idea what DNS is, they don't need experts - this isn't code review. The auditors tend to spend most of their time looking at paperwork and at policy - so e.g. we don't expect auditors to discover a Raspberry Pi configured for packet logging hidden in a patchbay, but we do expect them to find if "Delete logs every morning" is an ambition and it's not anybody's job to actually do that, nor is it anybody's job to check it got done.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by thinkloop on Sunday April 01, 2018 @01:11PM (#16729314)
I think it's somewhere in between, the article itself states:

"to audit our code and practices annually and publish a public report confirming we're doing what we said we would."

I run an investment fund (hedge fund) and we are completing our required annual audit (not by KPMG). It is quite thorough, they manually check balances in our bank accounts directly with the bank, they verify balances directly off blockchain (it's a crypto fund) and have us prove ownership of keys by signing messages, etc. And they do do a due diligence (lots of doodoo there) that we are not doing scammy things like the equivalent of having a raspberry pi attached to the network. Now this is extremely tough of course, and they are limited in what they can accomplish there, but the thought does cross their mind. All firms are different, but from what we've seen most auditors do decent good jobs most of the time. Their reputation can only be hit so many times before their name is no longer valuable to be an auditor.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by badsectoracula on Monday April 02, 2018 @01:37AM (#16732561)
How do we know they are not lying (or forced to lie, they are a US company after all)?
Re:1.1.1.1: Fast, privacy-first consumer DNS service by otoburb on Sunday April 01, 2018 @08:40AM (#16727969)
Cloudflare is making a public pronouncement that they're not going to sell your DNS data nor track your IP address, with the implication that they will also not use the usage data to upsell you services. That's about the only additional "privacy" edge they offer.

In the same breath, they insinuate that Google both sells and uses DNS usage from their 8.8.8.8 and 8.8.4.4 resolvers.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by heisenbit on Sunday April 01, 2018 @08:54AM (#16728030)
They are NOT saying Google is lying and collecting the data. They are saying the business model of Google inherently provides such incentive.

Cloudflare is somewhat right: Means, Motive and Opportunity - but for a conviction you have to prove someone acted on the Opportunity. The Motive of Google is tampered with severe risk for loosing trust.

Cloudflare can make an argument they are fundamentally better positioned and that is all they do. As with all US based operations the NSA may cook up some convincing counterarguments and we may never know.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by bogomipz on Sunday April 01, 2018 @10:22AM (#16728416)
>"They are NOT saying Google is lying and collecting the data."

The OP did not say that cloudflare is "saying" that. The OP very clearly said they are "insinuating" it. And yes under the heading "DNS's Privacy Problem" the post mentions:

"With all the concern over the data that companies like Facebook and Google are collecting on you,..."

I think that juxtaposition of this statement under a bolded heading of "DNS's Privacy Problem" is very much insinuating that.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by ocdtrekkie on Sunday April 01, 2018 @11:18AM (#16728696)
Bear in mind, Google's changed its mind before and can again at any time. For instance, when they bought DoubleClick they promised not to connect it with the Google account data they had. Then they changed that policy later.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by bogomipz on Sunday April 01, 2018 @01:00PM (#16729257)
That does not change the the fact that Cloudflare is insinuating something something about Google's DNS.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by ocdtrekkie on Sunday April 01, 2018 @01:26PM (#16729390)
Is the suggestion that a company whose main business is targeting ads based on collecting data about you might be collecting data about you an unfair insinuation?
Re:1.1.1.1: Fast, privacy-first consumer DNS service by bogomipz on Sunday April 01, 2018 @02:40PM (#16729761)
Please follow the thread - the question of whether an insinuation if "fair" is not what's being discussed. What's being discussed is whether or not Cloudflare said or insinuated that there were privacy concerns with using 8.8.8.8.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by Twisol on Sunday April 01, 2018 @08:58AM (#16728041)
It's clear what you meant, but for whatever it's worth, I think the word you wanted was "tempered", not "tampered".
Re:1.1.1.1: Fast, privacy-first consumer DNS service by wtmt on Sunday April 01, 2018 @10:13AM (#16728362)
For what it’s worth, you missed to point out “loosing” vs. “losing” in that comment (where it talks about “loosing trust”). :)
Re:1.1.1.1: Fast, privacy-first consumer DNS service by Twisol on Sunday April 01, 2018 @06:13PM (#16730812)
That looked more like a garden-variety typo than a bona fide eggcorn, so I gave it a pass ;)

https://en.wikipedia.org/wiki/Eggcorn

Re:1.1.1.1: Fast, privacy-first consumer DNS service by kentonv on Sunday April 01, 2018 @12:26PM (#16729060)
> they insinuate that Google both sells and uses DNS

I don't think it's intended to say anything about Google specifically. Keep in mind that there are many other DNS services out there, and some of them are known for being pretty scummy, e.g. replacing NXDOMAIN results with "smart search" / ad pages.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by bogomipz on Sunday April 01, 2018 @01:11PM (#16729313)
>"I don't think it's intended to say anything about Google specifically"

Google is mentioned 13 times in this post and their resolvers 3. That's 16 total mentions of Google in their post.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by kentonv on Sunday April 01, 2018 @06:44PM (#16730955)
I was specifically referring to the statement that Cloudflare won't sell your DNS history.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by shimms on Sunday April 01, 2018 @08:39AM (#16727957)
Yes they have:

"Privacy First: Guaranteed. We will never sell your data or use it to target ads. Period. We will never log your IP address (the way other companies identify you). And we’re not just saying that. We’ve retained KPMG to audit our systems annually to ensure that we're doing what we say.

Frankly, we don’t want to know what you do on the Internet—it’s none of our business—and we’ve taken the technical steps to ensure we can’t."

Re:1.1.1.1: Fast, privacy-first consumer DNS service by dictum on Sunday April 01, 2018 @08:59AM (#16728044)
> Frankly, we don’t want to know what you do on the Internet—it’s none of our business

In the DNS resolver space, what is their business?

Re:1.1.1.1: Fast, privacy-first consumer DNS service by hrunt on Sunday April 01, 2018 @09:14AM (#16728103)
They want fast resolution of names that point to websites hosted by Cloudflare. Cloudflare makes their money selling their network to businesses that use it, and anything that makes that service better for the end-user increases customer stickiness.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by jhanschoo on Sunday April 01, 2018 @12:51PM (#16729210)
Traffic from heavily censored regimes to its big customers, which often end up being censored due to user contributions, I suppose.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by distantsounds on Sunday April 01, 2018 @09:42AM (#16728205)
Making the internet fast and reliable, and arguably DNS resolution plays into that.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by tbyehl on Sunday April 01, 2018 @09:44AM (#16728209)
Could be a precursor to launching an OpenDNS competitor.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by wtmt on Sunday April 01, 2018 @10:17AM (#16728386)
Is OpenDNS even as relevant as it was earlier, before Google DNS appeared (and then OpenDNS was bought by Cisco)?
Re:1.1.1.1: Fast, privacy-first consumer DNS service by tialaramex on Sunday April 01, 2018 @10:54AM (#16728574)
Maybe not _as_ relevant, but still a considerable number of clients are configured to trust OpenDNS, and their far more ambiguous stance on what exactly this is for is appealing to some people. For example, OpenDNS says yes, absolutely it is their business what you're looking up, and maybe you are a Concerned Parent™ who wants to ensure their children don't access RedTube, so that feels like a good idea.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by tbyehl on Sunday April 01, 2018 @12:38PM (#16729128)
I was thinking more along the lines of their SME offering. DNS filtering is an important layer in network security and CloudFlare’s position of being in the middle of a large portion of Internet traffic, alongside now trying to attract a chunk of general DNS queries, potentially gives them a great deal of insight into who the bad actors are.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by ajross on Sunday April 01, 2018 @10:31AM (#16728461)
Serious question: where is that quote from? The link above is just to the resolver address.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by brantonb on Sunday April 01, 2018 @10:54AM (#16728577)
Quote is at: https://1.1.1.1
Re:1.1.1.1: Fast, privacy-first consumer DNS service by dingo_bat on Sunday April 01, 2018 @11:04PM (#16732001)
Not opening for me.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by lugg on Monday April 02, 2018 @01:38AM (#16732564)
Re:1.1.1.1: Fast, privacy-first consumer DNS service by cornholio on Sunday April 01, 2018 @08:42AM (#16727978)
I think the whole point for such free services is to log that data and extract statistical meaning out of it - in this case, they pledge to use an anonymized format. On the other hand CloudFlare's mission (ensure secure, solid end to end connectivity) is much better aligned with the user's needs than Google's mission (sell more ads).
Re:1.1.1.1: Fast, privacy-first consumer DNS service by yjftsjthsd-h on Sunday April 01, 2018 @08:40AM (#16727968)
On the contrary, they've taken 2 big steps that are better than ISPs (not sure about Google):

* no logging

* DNS over HTTPS

Re:1.1.1.1: Fast, privacy-first consumer DNS service by therealmarv on Sunday April 01, 2018 @08:51AM (#16728011)
Google is one of the first ones using DNS over HTTPS.

BTW if you want to use DNS over HTTPS on Linux/Mac I strongly recommend dnscrypt proxy V2 (golang rewrite) https://github.com/jedisct1/dnscrypt-proxy and put e.g. cloudflare in their config toml file to make use of it.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by cptskippy on Sunday April 01, 2018 @09:22AM (#16728137)
The whole point of encrypting DNS traffic is to hide it from the likes of Google.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by akquise on Sunday April 01, 2018 @10:01AM (#16728286)
For me personally it is much more important to hide my DNS traffic from my ISP instead of Google, etc., even though I don't live in the US.

I pay them to access the internet, every further information they gather about my internet activity does not mean any benefit for me.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by opencl on Sunday April 01, 2018 @10:49AM (#16728551)
Hiding DNS traffic from your ISP is pointless when you have to give them the IP that gets resolved anyway for them to route your traffic.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by markonen on Sunday April 01, 2018 @11:14AM (#16728671)
Not really. Typically the query includes much more information (the site you want to visit) than the response (an IP potentially shared by thousands or millions of sites).
Re:1.1.1.1: Fast, privacy-first consumer DNS service by xioxox on Sunday April 01, 2018 @11:30AM (#16728762)
Even with https, the name of the site is sent in clear when the connection to the site is established (this is SNI).
Re:1.1.1.1: Fast, privacy-first consumer DNS service by markonen on Sunday April 01, 2018 @11:54AM (#16728892)
Back when they chose this design for SNI, I’m sure someone argued that it was fine because DNS had already leaked the hostname anyway :)
Re:1.1.1.1: Fast, privacy-first consumer DNS service by tialaramex on Sunday April 01, 2018 @12:23PM (#16729048)
It's really hard to fix this. https://datatracker.ietf.org/doc/draft-ietf-tls-sni-encrypti... is the state of the art -- note that's a Draft, and really, really not finished, help is doubtless welcome.

If it was easy, it would have been done during the TLS 1.3 process, but after a lot of discussion we're down to basically "Here is what people expect 'SNI encryption' would do for them, here's why all the obvious stuff can't achieve that, and here are some ugly, slow things that could work, now what?"

Re:1.1.1.1: Fast, privacy-first consumer DNS service by dfox on Sunday April 01, 2018 @07:23PM (#16731123)
It is hard because of the TLS's pre-PFS legacy and to some extent also because of (very meaningful) intention to reduce roundtrips. The way to do SNI-like stuff is obvious: negotiate unauthenticated encrypted channel (by means of some EDH variant, you need one roundtrip for that) and perform any endpoint authentication steps inside that channel. This is what SSH2 does and AFAIK Microsoft's implementation of encrypted ISO-on-TCP (eg. rdesktop) does something similar.

Edit: in SSH2 the server authentication happens in the first cryptographic message from server (for the obvious efficiency reasons), and thus for doing SNI-style certificate selection there would have to be some plaintext server-ID in first clients message, but the security of the protocol does not require that as long as the in-tunnel authentication is mutual (it is for things like kerberos).

Re:1.1.1.1: Fast, privacy-first consumer DNS service by tialaramex on Monday April 02, 2018 @06:57AM (#16733572)
So, it feels like you're saying this is how SSH2 and rdesktop work, and then you caveat that by saying well, no, they actually don't offer this capability at all it turns out.

You are correct that you can do this if you spend one round trip first to set up the channel, and both the proposals for how we might encrypt SNI in that Draft do pay a round trip. Which is why I said they're slow and ugly. And as you noticed, SSH2 and rdesktop do not, in fact, spend an extra round trip to buy this capability they just go without.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by gsich on Sunday April 01, 2018 @10:39PM (#16731895)
A load balancer can chose the correct backend by using the SNI. So there is a use for being unencrypted.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by pfg on Sunday April 01, 2018 @11:28AM (#16728750)
You're still leaking that information due to SNI.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by throw2016 on Sunday April 01, 2018 @11:09AM (#16728649)
This does not make sense. Either people are not concerned about hiding their traffic or if they are it follows they would be equally if not much more concerned about Google that can track them across devices and build far more indepth invasive profiles than the ISP.

Aside it's strange https everywhere has been pushed aggressively by many here under the bogeyman of ISP adware and spying while completely ignoring the much larger adware and privacy threats posed by the stalking of Google, Facebook and others. It is disingenuous and insincere.

Re:1.1.1.1: Fast, privacy-first consumer DNS service by ocdtrekkie on Sunday April 01, 2018 @11:20AM (#16728705)
Most fears of ISPs have been stoked primarily by tech companies, who invest a lot more money into marketing than the ISPs do.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by tialaramex on Sunday April 01, 2018 @05:54PM (#16730700)
I can only really discuss the UK, since that's the only place where I've bought home ISP service.

Only a handful of small specialist firms actually just move bits in the UK. Every single UK ISP big enough to advertise on television is signed up to filter traffic and block things for being "illegal" or maybe if Hollywood doesn't like them, or if they have "naughty" words mentioned, or just because somebody slipped. If you're thinking "Not mine" and it runs TV adverts then, oops, nope, you're wrong about that and have had your Internet censored without realising it. I wonder how ISPs got their bad reputation...

Re:1.1.1.1: Fast, privacy-first consumer DNS service by pnutjam on Sunday April 01, 2018 @09:51AM (#16728249)
I've switched to cloudflare and none of the dns leak tests are showing my DNS, which I find interesting. They always showed google.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by vimda on Sunday April 01, 2018 @08:40AM (#16727965)
Did you read the page? They're supporting DNS over TLS and DNS over HTTPS - both changes to the protocol to make in uninspectable. They've also said they're not logging IP info and they're getting independent auditors in to confirm what they're saying. Sounds trustworthy to me
Re:1.1.1.1: Fast, privacy-first consumer DNS service by dingaling on Sunday April 01, 2018 @08:52AM (#16728018)
Both encrypted extensions are of course inspectable at the end-point, which is the privacy model being discussed.

What is intriguing to me is why Cloudflare are offering this. Perhaps it is to provide data on traffic that is 'invisible' to them, as in it doesn't currently touch their networks. Possibly as a sales-lead generator.

Or is the plan to become dominant and then use DNS blackholing to shutdown malware that is a threat to their systems?

Re:1.1.1.1: Fast, privacy-first consumer DNS service by zackbloom on Sunday April 01, 2018 @10:10AM (#16728336)
The goal is to make the sites that use Cloudflare ridiculously fast by putting the authoritative and recursive DNS on the same machine (for clients who use 1.1.1.1).
Re:1.1.1.1: Fast, privacy-first consumer DNS service by vimda on Sunday April 01, 2018 @08:57AM (#16728038)
Im probably being naive, but maybe altruism? At least if you buy into their making the internet better rhetoric
Re:1.1.1.1: Fast, privacy-first consumer DNS service by wtmt on Sunday April 01, 2018 @10:22AM (#16728412)
Cloudflare is already a significant enough player in handling Internet traffic. Maybe the company does want to do good for the sake of doing good, but I’m wary of companies taking over in this manner and making the Internet more like a monolith than a distributed system.
Re:1.1.1.1: Fast, privacy-first consumer DNS service by kzrdude on Sunday April 01, 2018 @12:43PM (#16729162)
It seems like bait-and-switch though? They tell about DNS over https and dns without logging, and then direct to an installation instruction where you can learn to start to use, "DNS without logging", but nothing that's encrypted? What am I missing?