amagne
Re:Ask HN: Which best practices to follow and when to adapt or modify ...
on Wednesday April 19, 2023 @05:19AM (#35626076)
my2c: 2 main scenarios should lead to best practice creation: (1) A bug has been identified that stems from a poor design or code error; (2) An improvement has been made to the source code.
Re:Speed up the pull request process. Advice?
on Wednesday April 19, 2023 @05:13AM (#35626037)
at Promyze, we started exploring the model Ship Show Ask. [1]
In this approach, PR authors are considered free of trust to evaluate themselves if:
- The code doesn’t require a code review since the changes are trivial (Ship)
- They’d like to show the code changes to colleagues and get their feedback (Show); This mode can sound totally counternatural as the feedback can be provided after the merge. This is part of the paradigm shift.
- The code requires a review (Ask)
So, instead of adding more people to review the code, we reconsider the necessity for each PR to be approved. This is how we positively impacted the lead time for change.