Don't even get into unexpected behavior in classes:
In [1]: class A(object):
...: l = []
...:
In [2]: a, b = A(), A()
In [3]: a.l.append("Something")
In [4]: a.l
Out[4]: ['Something']
In [5]: b.l
Out[5]: ['Something']
In [6]: class B(object0:
...:
KeyboardInterrupt
In [6]: class B(object):
...: l = None
...: def __init__(self):
...: self.l = []
...:
In [7]: c, d = B(), B()
In [8]: c.l.append("Something")
In [9]: c.l, d.l
Out[9]: (['Something'], []) >>> for item in [1]:
... print item
1
>>> item
1
>>> for i in []:
... print i
>>> i
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
NameError: name 'i' is not defined
I would expect i == None. That oddity makes it dangerous to use the feature unless you're really careful (e.g. using a for - else construct). In [1]: for i in []:
...: pass
...: else:
...: print 'Else!'
...:
Else!
In [2]: for i in []:
...: break
...: else:
...: print 'Else!'
...:
Else!
In [3]: for i in range(2):
...: break
...: else:
...: print 'Else!'
...:
In [4]: for i in range(2):
...: pass
...: else:
...: print 'Else!'
...:
Else!
The syntax could be interpreted as: if len(l) == 0:
print "Else!"
else:
for i in l:
pass
The "catch cases where a `break` is triggered" case isn't common enough for this syntax feature to be encountered very often, leading to confusion when people come across it (though at least it's not a bug where a common use-case has weird behavior to new-comers).if you conceptualize how a for-loop has to work as a while-loop using Python's iterator protocol (which is the only way the iterator protocol itself makes sense), it seems pretty intuitive.
That is, this:
for item in items:
...1
else:
...2
becomes, approximately: try:
while True:
__hidden_iter = items.iter()
try:
item = __hidden_iter.next()
except StopIteration:
raise __NormalLoopExit
...1
except __NormalLoopExit:
...2
If you have an empty loop, the first assignment doesn't complete (instead raising StopIteration in evaluating the right side, which raises the notional exception __NormalLoopExit, which invokes the else: clause, if any) so the variable never gets around to being created.If the object was immutable then append wouldn't work. That's hardly matching expectations.
I guess the clarification to what I was saying is that, in the simple case (integers, strings, None) the objects are immutable. It's only getting into cases where the value of the object itself is mutable, that you run into issues. If all objects (or all objects 'allowed' as default values) were immutable, then this behavior would not trigger.
So saying that mutability has nothing to do with it isn't entirely true. It's the immutability of the types of values used in most simple cases that hides this issue from developers until they run into a more complex case.
if val is None: val = []
or the more idiomatic python way:
val = val or []You want to explicitly check against `None` so that you're not overwriting all falsey values of `val` - even though you should generally try to enforce argument types, your second example would cause unexpected behavior in some cases, particularly those that have non-falsey 'default' assignments
>>> [1,2,3] + [4,5]
[1, 2, 3, 4, 5]
Thus appending should do something different than addition. >>> x = [1,2,3]
>>> x.append([4,5])
>>> x
[1, 2, 3, [4, 5]]In most of the languages I'm familiar with, there are very clear syntax differences when working with class attributes. For example, in many languages class attributes have to be accessed via the class name instead of from an instance of the class making it clear to the programmer they are working with a class attribute, e.g. MyClass.myClassVariable not myInstance.myClassVariable. Additionally, the way you define class attributes in python is the way you define instance attributes in many languages, which just adds to the confusion. e.g. in Java or C# you can define class variables directly in the class body, but an explicit 'static' keyword is needed, undecorated definitions are assumed to be instance variables.
Finally, I think the definition of class B above is a little more nuanced, class B has both a class attribute named l AND an instance attribute named l.
B.l == None and B().l == []
It's been a while since I've done major OOP coding in any language other than Python, so I'm a little rusty. The issues you raise are perfectly legitimate and would be understandably confusing to newcomers to the language. :)
I wonder if people who weren't exposed to languages which work differently ala C++ would be as surprised?
I don't think the question has much to do with mutability, it isn't surprising to me nor would I imagine most programmers that a list is mutable, that's very common.
The surprising part of this question is that the default value of 'l' continues to exist outside the lexical scope of the function, the expected behavior is that the value of 'l' is initialized at function call time and is garbage collected after each call. As it sits, using default values in python is sort of like defining a global that only has a named reference inside the function block, which is very strange.