It seems downright obvious that p^2 - 1 would have to be divisible by 24 for any prime other than 2 or 3, and in fact completely unremarkable, after you point out the factorization.
After factoring p^2 -1 into (p+1)(p-1) you could have given the rest of the proof as an exercise to the reader.
x^2 - y^2 = (x - y) * (x + y)
In this case y is 1 and y^2 is 1, so this gives us aforementioned:
x^2 - 1 = (x - 1) * (x + 1)
Here is wikipedia page with the proof: http://en.wikipedia.org/wiki/Difference_of_two_squares
(Of course, the OP doesn't deserve this level of criticism--he was just writing a quick sketch up on the internet.)
AFAIK there is no sequence that lists all primes, because of the property of prime numbers themselves (not divisible by anything except 1 and themselves). This essentially means that you can't use multiplication to generate primes.
Moreover checking if number is prime is hard in itself, because you need to check for divisibility by all previous prime numbers up until square root of prime candidate you are trying to check. Thus you can think of prime numbers as recursive series.
That is not true - since 2002 a deterministic polynomial time primality test is known [1]. And even before that primality test faster than trial division were known [2].
Besides that it is true that there is currently no known algorithm to easily enumerate all primes but it is not impossible that such an algorithm exists.
p^2 - 1 = (p+1)(p-1)
And p+1 and p-1 must both be multiples of 2 because p is odd. Furthermore, one of p+1 or p-1 is also a multiple of 4 (because they are both multiples of 2 and only 2 apart). So, we can see where the 2^3 factor comes from in the magic number 24. The remaining factor, 3, comes from the fact that p is prime and not a multiple of 3, so either p+1 or p-1 must be a multiple of 3 (otherwise p-1, p, and p+1 would be three consecutive numbers, none of which are divisible by 3, which is impossible).
As a result, for any prime p > 3, (p+1)(p-1) is divisible by 24, so p^2 - 1 is also divisible by 24.