Re:When a bad day gets worse – getting hacked twice in one day
by moot on Tuesday May 06, 2014 @01:17PM
(#7705792)
Good point -- frankly I'd suggest doing both (clean repo and revoke/replace the secrets). The developer in question simply overlooked the issue, and since we were busy spinning down the company, nobody else caught it.
Re:When a bad day gets worse – getting hacked twice in one day
by stouset on Tuesday May 06, 2014 @07:59PM
(#7707895)
Also, just swear of ever committing secrets to a repo to begin with. It's a bad idea, period.
Re:When a bad day gets worse – getting hacked twice in one day
by StavrosK on Wednesday May 07, 2014 @08:41AM
(#7709785)
There are many times when that isn't doable. Fortunately, you can swear off ever committing plaintext secrets to a repo. I use git-crypt:
Re:When a bad day gets worse – getting hacked twice in one day
by BoppreH on Tuesday May 06, 2014 @03:28PM
(#7706576)
I would scrub the repo anyways because revoked secrets can still be used for social engineering. "Hey $HOST, I got hacked. My old password was $PASSWD and you can be sure it's me because $PUBLIC_INFORMATION. Can you send a password reset to $ATTACKER_EMAIL?"
Re:When a bad day gets worse – getting hacked twice in one day
by johnnymonster on Tuesday May 06, 2014 @03:23PM
(#7706542)
Its a very good point that if you are not able to easily revert and change all your secrets and key's then you are in more trouble than just removing them from the commit log.
Moot left out the most sensible response to Mistake #5:
I went through a rushed 8hr rebase to remove all of our keys, certificates, cookie secrets and the like before DocumentCloud's platform was opened. Two days after, a friend asked me why I hadn't simply revoked and replaced all of our secrets to the sound of me facepalming repeatedly.
It is always much easier just to revoke and replace your secrets. Doing so should always be relatively easy for you to execute, and having a chance to practice that is also always good.