The actual bad smell of infected people was believed to be unhealthy, so afaik most plague masks were built to provide a "good" smell through herbs or incent, but it seems plausible that some of them helped nonetheless.