Since they are the one doing the prompting, they quickly got lazy of actually reviewing the output from the LLM which means that nobody is reviewing anything.
It hasn't happened yet but I guess that is how you end up with major outages.
I find the engineers currently thriving are the ones who never gave a fuck about anything but their own advancement and are happy to drop weeks of work on others and take the credit.
You are doing it right. But the people who are giving you the money; They are doing it WRONG.
Well, you’re not until you realise that your AI has done something stupid and then you’re part of an exploit. Or exfiltrates used data to an unsecured cloud, or something equally smart.
Everyone's doing code reviews--well, not even code reviews; just PR reviews--so how are they supposed to gain an understanding of the system.
I review a PR, I see that one new endpoint was added to the API. It looks correct. I say "LGTM" in a GitHub comment.
The sprint's almost over, everyone's in a rush to do code reviews.
I look at another PR. Somebody added a button to the UI. The button looks correct, it's connect to some callbacks that look correct. They get a thumbs-up emoji from me. I bet they feel satisfied.
I look at another PR. Somebody changed a timeout in the settings because some people complained about dropped connections. It's a really small change, so, approved.
At what point am I supposed to understand the system? I looked at a single API endpoint, in isolation, and then a button, and then a harmless looking settings change.
I was pressured to hurry.
Am I supposed to somehow get an understanding of the big picture through this?
Imagine if instead there was time to review large logical sections of the code together. Imagine if we focused our reviews on the overall code instead of on the lines in one random PR at a time.
You need to understand the architecture of the system. The broad flows of data and domains. And then you need to understand the features of the system, aka the rules and contracts. First learn it for your team’s domain, then for adjacent domains.
Learning the minutiae of the code specifically is no longer (was it ever?) your primary job. You are an engineer of a system. You need to have a mental model of the system, start high and build up low over time.
You can use AI to build your understanding by Q&A and by drafting diagrams etc.
Yes. if you have this attitude, great things will come to you. if you care or try to make sense of things, you'll be in misery
1. Pride in the code we are developing and 2. How the dang things holds together and why this function is important and 3. Some coding guidelines that we can try to follow later (or not)
Thats how companies worked - they argued and talked about and fought over the code and that created the engineering culture that if you were lucky and had a product that made it carried you to your series C
Claude always comes up with more things to add to the code that are pure bloat and become inbred bombs over several iterations, and some people can't distinguish what suggestions to reject and go along with everything Claude suggests to the detriment of the program #garrytangate
Yes, if we stop doing quality controls, we don't have the problem of being hung up on quality controls. You do of course have SOC-2 compliance which is a legally auditable attestation, so if you claim you do code review but don't you're committing fraud unless you drop that.
It is a job you know... doing what is necessary to keep yourself qualified is an implicit requirement, and "being interested" is irrelevant. It's work.
The trade has a low bottom, a high ceiling and not a lot of reward for the latter.
Fear of consequences does not get you good engineering.
I am not advocating for the lack of interest, mind you. Just saying that you really want a system where the ideal behavior is rewarded and we seem to be moving backwards on that front. From that point on statistics do its thing.
I unironically agree. At least, the current form of code reviews needs to go.
Currently we spend all effort reviewing individual changes and no effort reviewing the entire system, or the underlying dependencies.
If you sat down to learn a legacy codebase, you would not review it in the order of commits. Reviewing individual commits is inefficient.
It would be better to have an entire team of reviewers systematically reviewing ALL the code, over and over, including the code of dependencies.
We need better tooling and heuristics to help focus review efforts on the code that is most risky.
It seems that the human involvement is the new "unit testing". There was a period of time when management that it was superfluous.
I can't wait for the pendulum to swing back in full force.
I review on a high level, but on a line-by-line level, it’s pointless to try to trace everything. It either works or it doesn’t. Have good tests.